Skip to contentSkip to conversation

drm/i915: Fix NPD in PMU during driver teardown

PATCH In review Stuart Summers 4 participants 10 messages Aug 3, 2022 – Aug 5, 2022

Subsystems (2)
lore
Share & tools
lore
#1 lore raw

PATCH 2/2 drm/i915: Only disable PMU on stop if not already closed

In reply to Stuart Summers

There can be a race in the PMU process teardown vs the time when the driver is unbound in which the user attempts to stop the PMU process, but the actual data structure in the kernel is no longer available. Avoid this use-after-free by skipping the PMU disable in i915_pmu_event_stop() when the PMU has already been closed/unregistered by the driver.

Fixes b00bccb3f0bb ("drm/i915/pmu: Handle PCI unbind")
---
 drivers/gpu/drm/i915/i915_pmu.c | 8 ++++++++
 1 file changed, 8 insertions(+)
drivers/gpu/drm/i915/i915_pmu.c +8 -0
index 958b37123bf12..0d02f338118e4 100644
@@ -760,9 +760,17 @@ static void i915_pmu_event_start(struct perf_event *event, int flags)
 
 static void i915_pmu_event_stop(struct perf_event *event, int flags)
 {
+	struct drm_i915_private *i915 =
+		container_of(event->pmu, typeof(*i915), pmu.base);
+	struct i915_pmu *pmu = &i915->pmu;
+
+	if (pmu->closed)
+		goto out;
+
 	if (flags & PERF_EF_UPDATE)
 		i915_pmu_event_read(event);
 	i915_pmu_disable(event);
+out:
 	event->hw.state = PERF_HES_STOPPED;
 }
 
Signature · 1 line
2.25.1
#0 lore raw

PATCH 1/2 drm/i915: Fix NPD in PMU during driver teardown

In the driver teardown, we are unregistering the gt prior to unregistering the PMU. This means there is a small window of time in which the application can request metrics from the PMU, some of which are calling into the uapi engines list, while the engines are not available. In this case we can see null pointer dereferences.

Fix this ordering in both the driver load and unload sequences.

v1: Actually address the driver load/unload ordering issue
v2: Remove the NULL checks since they shouldn't be necessary
now with the proper ordering

Fixes 42014f69bb235 ("drm/i915: Hook up GT power management")
---
 drivers/gpu/drm/i915/i915_driver.c | 11 ++++++-----
 1 file changed, 6 insertions(+), 5 deletions(-)
drivers/gpu/drm/i915/i915_driver.c +6 -5
index deb8a8b76965a..ee4dcb85d2060 100644
@@ -717,7 +717,6 @@ static void i915_driver_register(struct drm_i915_private *dev_priv)
 	struct drm_device *dev = &dev_priv->drm;
 
 	i915_gem_driver_register(dev_priv);
-	i915_pmu_register(dev_priv);
 
 	intel_vgpu_register(dev_priv);
 
@@ -731,11 +730,12 @@ static void i915_driver_register(struct drm_i915_private *dev_priv)
 	i915_debugfs_register(dev_priv);
 	i915_setup_sysfs(dev_priv);
 
+	intel_gt_driver_register(to_gt(dev_priv));
+
 	/* Depends on sysfs having been initialized */
+	i915_pmu_register(dev_priv);
 	i915_perf_register(dev_priv);
 
-	intel_gt_driver_register(to_gt(dev_priv));
-
 	intel_display_driver_register(dev_priv);
 
 	intel_power_domains_enable(dev_priv);
@@ -762,11 +762,12 @@ static void i915_driver_unregister(struct drm_i915_private *dev_priv)
 
 	intel_display_driver_unregister(dev_priv);
 
-	intel_gt_driver_unregister(to_gt(dev_priv));
-
 	i915_perf_unregister(dev_priv);
+	/* GT should be available until PMU is gone */
 	i915_pmu_unregister(dev_priv);
 
+	intel_gt_driver_unregister(to_gt(dev_priv));
+
 	i915_teardown_sysfs(dev_priv);
 	drm_dev_unplug(&dev_priv->drm);
 
Signature · 1 line
2.25.1
#5 lore raw

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/2] drm/i915: Fix NPD in PMU during driver teardown

== Series Details ==

== Series Details ==

Series: series starting with [1/2] drm/i915: Fix NPD in PMU during driver teardown
URL : https://patchwork.freedesktop.org/series/106948/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_11966 -> Patchwork_106948v1
====================================================

Summary
-------

**SUCCESS**

No regressions found.

External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106948v1/index.html

Participating hosts (41 -> 39)
------------------------------

Additional (2): bat-rpls-1 bat-jsl-3
Missing (4): fi-kbl-soraka fi-rkl-11600 fi-pnv-d510 bat-dg1-5

Known issues
------------

Here are the changes found in Patchwork_106948v1 that come from known issues:

### CI changes ###

#### Possible fixes ####

* boot:
- fi-kbl-8809g: [FAIL][1] -> [PASS][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11966/fi-kbl-8809g/boot.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106948v1/fi-kbl-8809g/boot.html

### IGT changes ###

#### Issues hit ####

* igt@gem_huc_copy@huc-copy:
- fi-kbl-8809g: NOTRUN -> [SKIP][3] ([fdo#109271] / [i915#2190])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106948v1/fi-kbl-8809g/igt@[email protected]

* igt@gem_lmem_swapping@parallel-random-engines:
- fi-kbl-8809g: NOTRUN -> [SKIP][4] ([fdo#109271] / [i915#4613]) +3 similar issues
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106948v1/fi-kbl-8809g/igt@[email protected]

* igt@i915_pm_backlight@basic-brightness:
- fi-kbl-8809g: NOTRUN -> [SKIP][5] ([fdo#109271]) +26 similar issues
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106948v1/fi-kbl-8809g/igt@[email protected]

* igt@i915_selftest@live@hangcheck:
- bat-dg1-6: [PASS][6] -> [DMESG-FAIL][7] ([i915#4494] / [i915#4957])
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11966/bat-dg1-6/igt@i915_selftest@[email protected]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106948v1/bat-dg1-6/igt@i915_selftest@[email protected]

* igt@i915_selftest@live@requests:
- fi-blb-e6850: [PASS][8] -> [DMESG-FAIL][9] ([i915#4528])
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11966/fi-blb-e6850/igt@i915_selftest@[email protected]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106948v1/fi-blb-e6850/igt@i915_selftest@[email protected]

* igt@i915_suspend@basic-s3-without-i915:
- fi-bdw-5557u: [PASS][10] -> [INCOMPLETE][11] ([i915#146])
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11966/fi-bdw-5557u/igt@[email protected]
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106948v1/fi-bdw-5557u/igt@[email protected]

* igt@kms_chamelium@dp-hpd-fast:
- fi-kbl-8809g: NOTRUN -> [SKIP][12] ([fdo#109271] / [fdo#111827]) +8 similar issues
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106948v1/fi-kbl-8809g/igt@[email protected]

#### Possible fixes ####

* igt@fbdev@read:
- {bat-rpls-2}: [SKIP][13] ([i915#2582]) -> [PASS][14] +4 similar issues
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11966/bat-rpls-2/igt@[email protected]
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106948v1/bat-rpls-2/igt@[email protected]

* igt@gem_exec_suspend@basic-s0@smem:
- {bat-rplp-1}: [DMESG-WARN][15] ([i915#2867]) -> [PASS][16]
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11966/bat-rplp-1/igt@gem_exec_suspend@[email protected]
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106948v1/bat-rplp-1/igt@gem_exec_suspend@[email protected]

* igt@kms_cursor_legacy@basic-busy-flip-before-cursor@atomic-transitions-varying-size:
- fi-bsw-kefka: [FAIL][17] ([i915#6298]) -> [PASS][18]
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11966/fi-bsw-kefka/igt@kms_cursor_legacy@basic-busy-flip-before-cursor@atomic-transitions-varying-size.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106948v1/fi-bsw-kefka/igt@kms_cursor_legacy@basic-busy-flip-before-cursor@atomic-transitions-varying-size.html

* igt@kms_frontbuffer_tracking@basic:
- {bat-rpls-2}: [SKIP][19] ([i915#1849]) -> [PASS][20]
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11966/bat-rpls-2/igt@[email protected]
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106948v1/bat-rpls-2/igt@[email protected]

* igt@prime_vgem@basic-fence-flip:
- {bat-rpls-2}: [SKIP][21] ([fdo#109295] / [i915#1845] / [i915#3708]) -> [PASS][22]
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11966/bat-rpls-2/igt@[email protected]
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106948v1/bat-rpls-2/igt@[email protected]

{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).

[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285
[fdo#109295]: https://bugs.freedesktop.org/show_bug.cgi?id=109295
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
[i915#1155]: https://gitlab.freedesktop.org/drm/intel/issues/1155
[i915#146]: https://gitlab.freedesktop.org/drm/intel/issues/146
[i915#1845]: https://gitlab.freedesktop.org/drm/intel/issues/1845
[i915#1849]: https://gitlab.freedesktop.org/drm/intel/issues/1849
[i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190
[i915#2582]: https://gitlab.freedesktop.org/drm/intel/issues/2582
[i915#2867]: https://gitlab.freedesktop.org/drm/intel/issues/2867
[i915#3003]: https://gitlab.freedesktop.org/drm/intel/issues/3003
[i915#3282]: https://gitlab.freedesktop.org/drm/intel/issues/3282
[i915#3301]: https://gitlab.freedesktop.org/drm/intel/issues/3301
[i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
[i915#3637]: https://gitlab.freedesktop.org/drm/intel/issues/3637
[i915#3708]: https://gitlab.freedesktop.org/drm/intel/issues/3708
[i915#4103]: https://gitlab.freedesktop.org/drm/intel/issues/4103
[i915#4312]: https://gitlab.freedesktop.org/drm/intel/issues/4312
[i915#4494]: https://gitlab.freedesktop.org/drm/intel/issues/4494
[i915#4528]: https://gitlab.freedesktop.org/drm/intel/issues/4528
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#4957]: https://gitlab.freedesktop.org/drm/intel/issues/4957
[i915#4983]: https://gitlab.freedesktop.org/drm/intel/issues/4983
[i915#5828]: https://gitlab.freedesktop.org/drm/intel/issues/5828
[i915#5950]: https://gitlab.freedesktop.org/drm/intel/issues/5950
[i915#6298]: https://gitlab.freedesktop.org/drm/intel/issues/6298

Build changes
-------------

* Linux: CI_DRM_11966 -> Patchwork_106948v1

CI-20190529: 20190529
CI_DRM_11966: f3c1d1b53388aaa69e20a1b72f8307ad57116565 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_6613: 209230467200f2fa63a6f71fe6299996470dd813 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_106948v1: f3c1d1b53388aaa69e20a1b72f8307ad57116565 @ git://anongit.freedesktop.org/gfx-ci/linux

### Linux commits

6247b5cb4654 drm/i915: Only disable PMU on stop if not already closed 2a3a41783fc2 drm/i915: Fix NPD in PMU during driver teardown

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106948v1/index.html

#6 lore raw

[Intel-gfx] ✗ Fi.CI.IGT: failure for series starting with [1/2] drm/i915: Fix NPD in PMU during driver teardown

In reply to Stuart Summers
== Series Details ==

== Series Details ==

Series: series starting with [1/2] drm/i915: Fix NPD in PMU during driver teardown
URL : https://patchwork.freedesktop.org/series/106948/
State : failure

== Summary ==

CI Bug Log - changes from CI_DRM_11966_full -> Patchwork_106948v1_full
====================================================

Summary
-------

**FAILURE**

Serious unknown changes coming with Patchwork_106948v1_full absolutely need to be verified manually.

If you think the reported changes have nothing to do with the changes introduced in Patchwork_106948v1_full, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.

Participating hosts (10 -> 13)
------------------------------

Additional (3): shard-rkl shard-dg1 shard-tglu

Possible new issues
-------------------

Here are the unknown changes that may have been introduced in Patchwork_106948v1_full:

### IGT changes ###

#### Possible regressions ####

* igt@kms_cursor_crc@cursor-sliding@pipe-c-dp-1-64x64:
- shard-kbl: [PASS][1] -> [FAIL][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11966/shard-kbl4/igt@kms_cursor_crc@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106948v1/shard-kbl1/igt@kms_cursor_crc@[email protected]

* igt@kms_cursor_legacy@flip-vs-cursor@atomic-transitions:
- shard-skl: NOTRUN -> [INCOMPLETE][3]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106948v1/shard-skl4/igt@kms_cursor_legacy@[email protected]

Known issues
------------

Here are the changes found in Patchwork_106948v1_full that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@gem_exec_balancer@parallel-contexts:
- shard-iclb: [PASS][4] -> [SKIP][5] ([i915#4525]) +1 similar issue
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11966/shard-iclb2/igt@[email protected]
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106948v1/shard-iclb6/igt@[email protected]

* igt@gem_exec_fair@basic-deadline:
- shard-glk: NOTRUN -> [FAIL][6] ([i915#2846])
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106948v1/shard-glk7/igt@[email protected]

* igt@gem_exec_fair@basic-none-share@rcs0:
- shard-glk: [PASS][7] -> [FAIL][8] ([i915#2842]) +1 similar issue
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11966/shard-glk8/igt@gem_exec_fair@[email protected]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106948v1/shard-glk8/igt@gem_exec_fair@[email protected]

* igt@gem_exec_fair@basic-none@vcs1:
- shard-kbl: [PASS][9] -> [FAIL][10] ([i915#2842]) +1 similar issue
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11966/shard-kbl1/igt@gem_exec_fair@[email protected]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106948v1/shard-kbl4/igt@gem_exec_fair@[email protected]

* igt@gem_exec_fair@basic-pace@vcs1:
- shard-iclb: NOTRUN -> [FAIL][11] ([i915#2842])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106948v1/shard-iclb4/igt@gem_exec_fair@[email protected]

* igt@gem_lmem_swapping@heavy-verify-multi-ccs:
- shard-glk: NOTRUN -> [SKIP][12] ([fdo#109271] / [i915#4613])
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106948v1/shard-glk7/igt@[email protected]

* igt@gem_lmem_swapping@heavy-verify-random-ccs:
- shard-skl: NOTRUN -> [SKIP][13] ([fdo#109271] / [i915#4613])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106948v1/shard-skl9/igt@[email protected]

* igt@gem_lmem_swapping@smem-oom:
- shard-apl: NOTRUN -> [SKIP][14] ([fdo#109271] / [i915#4613]) +1 similar issue
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106948v1/shard-apl2/igt@[email protected]

* igt@gem_softpin@evict-single-offset:
- shard-tglb: [PASS][15] -> [FAIL][16] ([i915#4171])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11966/shard-tglb7/igt@[email protected]
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106948v1/shard-tglb5/igt@[email protected]

* igt@gem_userptr_blits@dmabuf-sync:
- shard-apl: NOTRUN -> [SKIP][17] ([fdo#109271] / [i915#3323])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106948v1/shard-apl6/igt@[email protected]

* igt@i915_module_load@reload-with-fault-injection:
- shard-snb: [PASS][18] -> [DMESG-WARN][19] ([i915#6201])
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11966/shard-snb6/igt@[email protected]
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106948v1/shard-snb2/igt@[email protected]

* igt@i915_pm_dc@dc6-dpms:
- shard-iclb: [PASS][20] -> [FAIL][21] ([i915#454]) +1 similar issue
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11966/shard-iclb1/igt@[email protected]
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106948v1/shard-iclb3/igt@[email protected]

* igt@kms_async_flips@alternate-sync-async-flip@pipe-a-edp-1:
- shard-skl: [PASS][22] -> [FAIL][23] ([i915#2521])
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11966/shard-skl7/igt@kms_async_flips@[email protected]
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106948v1/shard-skl2/igt@kms_async_flips@[email protected]

* igt@kms_ccs@pipe-a-crc-sprite-planes-basic-y_tiled_gen12_rc_ccs_cc:
- shard-skl: NOTRUN -> [SKIP][24] ([fdo#109271] / [i915#3886]) +3 similar issues
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106948v1/shard-skl7/igt@kms_ccs@pipe-a-crc-sprite-planes-basic-y_tiled_gen12_rc_ccs_cc.html

* igt@kms_ccs@pipe-a-missing-ccs-buffer-y_tiled_gen12_rc_ccs_cc:
- shard-apl: NOTRUN -> [SKIP][25] ([fdo#109271] / [i915#3886]) +3 similar issues
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106948v1/shard-apl2/igt@kms_ccs@pipe-a-missing-ccs-buffer-y_tiled_gen12_rc_ccs_cc.html

* igt@kms_ccs@pipe-b-bad-pixel-format-4_tiled_dg2_rc_ccs:
- shard-kbl: NOTRUN -> [SKIP][26] ([fdo#109271]) +16 similar issues
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106948v1/shard-kbl4/igt@kms_ccs@pipe-b-bad-pixel-format-4_tiled_dg2_rc_ccs.html

* igt@kms_ccs@pipe-c-crc-sprite-planes-basic-y_tiled_gen12_rc_ccs_cc:
- shard-glk: NOTRUN -> [SKIP][27] ([fdo#109271] / [i915#3886]) +4 similar issues
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106948v1/shard-glk7/igt@kms_ccs@pipe-c-crc-sprite-planes-basic-y_tiled_gen12_rc_ccs_cc.html

* igt@kms_ccs@pipe-d-crc-primary-rotation-180-yf_tiled_ccs:
- shard-skl: NOTRUN -> [SKIP][28] ([fdo#109271]) +72 similar issues
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106948v1/shard-skl9/igt@kms_ccs@pipe-d-crc-primary-rotation-180-yf_tiled_ccs.html

* igt@kms_chamelium@dp-crc-single:
- shard-apl: NOTRUN -> [SKIP][29] ([fdo#109271] / [fdo#111827]) +11 similar issues
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106948v1/shard-apl2/igt@[email protected]

* igt@kms_chamelium@hdmi-aspect-ratio:
- shard-glk: NOTRUN -> [SKIP][30] ([fdo#109271] / [fdo#111827]) +1 similar issue
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106948v1/shard-glk7/igt@[email protected]

* igt@kms_chamelium@hdmi-crc-multiple:
- shard-skl: NOTRUN -> [SKIP][31] ([fdo#109271] / [fdo#111827]) +5 similar issues
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106948v1/shard-skl9/igt@[email protected]

* igt@kms_color_chamelium@pipe-d-ctm-negative:
- shard-kbl: NOTRUN -> [SKIP][32] ([fdo#109271] / [fdo#111827])
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106948v1/shard-kbl4/igt@[email protected]

* igt@kms_content_protection@uevent:
- shard-apl: NOTRUN -> [FAIL][33] ([i915#2105])
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106948v1/shard-apl2/igt@[email protected]

* igt@kms_cursor_crc@cursor-suspend@pipe-b-dp-1:
- shard-apl: [PASS][34] -> [DMESG-WARN][35] ([i915#180]) +2 similar issues
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11966/shard-apl6/igt@kms_cursor_crc@[email protected]
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106948v1/shard-apl8/igt@kms_cursor_crc@[email protected]

* igt@kms_cursor_crc@cursor-suspend@pipe-b-edp-1:
- shard-skl: [PASS][36] -> [INCOMPLETE][37] ([i915#4939])
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11966/shard-skl6/igt@kms_cursor_crc@[email protected]
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106948v1/shard-skl1/igt@kms_cursor_crc@[email protected]

* igt@kms_dither@fb-8bpc-vs-panel-8bpc@pipe-a-dp-1:
- shard-apl: NOTRUN -> [DMESG-WARN][38] ([i915#180])
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106948v1/shard-apl2/igt@kms_dither@[email protected]

* igt@kms_flip@2x-plain-flip-fb-recreate-interruptible@ac-hdmi-a1-hdmi-a2:
- shard-glk: [PASS][39] -> [FAIL][40] ([i915#2122])
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11966/shard-glk5/igt@kms_flip@[email protected]
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106948v1/shard-glk1/igt@kms_flip@[email protected]

* igt@kms_flip@flip-vs-expired-vblank-interruptible@a-edp1:
- shard-skl: [PASS][41] -> [FAIL][42] ([i915#79])
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11966/shard-skl4/igt@kms_flip@[email protected]
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106948v1/shard-skl9/igt@kms_flip@[email protected]

* igt@kms_flip@flip-vs-expired-vblank-interruptible@b-hdmi-a2:
- shard-glk: [PASS][43] -> [FAIL][44] ([i915#79]) +1 similar issue
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11966/shard-glk7/igt@kms_flip@[email protected]
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106948v1/shard-glk9/igt@kms_flip@[email protected]

* igt@kms_flip@plain-flip-fb-recreate-interruptible@b-edp1:
- shard-skl: [PASS][45] -> [FAIL][46] ([i915#2122])
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11966/shard-skl6/igt@kms_flip@[email protected]
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106948v1/shard-skl7/igt@kms_flip@[email protected]

* igt@kms_flip_scaled_crc@flip-32bpp-linear-to-64bpp-linear-downscaling@pipe-a-default-mode:
- shard-iclb: NOTRUN -> [SKIP][47] ([i915#3555]) +1 similar issue
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106948v1/shard-iclb2/igt@kms_flip_scaled_crc@flip-32bpp-linear-to-64bpp-linear-downscaling@pipe-a-default-mode.html

* igt@kms_flip_scaled_crc@flip-64bpp-4tile-to-16bpp-4tile-downscaling@pipe-a-valid-mode:
- shard-iclb: NOTRUN -> [SKIP][48] ([i915#2672]) +7 similar issues
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106948v1/shard-iclb7/igt@kms_flip_scaled_crc@flip-64bpp-4tile-to-16bpp-4tile-downscaling@pipe-a-valid-mode.html

* igt@kms_flip_scaled_crc@flip-64bpp-ytile-to-32bpp-ytilegen12rcccs-upscaling@pipe-a-default-mode:
- shard-iclb: NOTRUN -> [SKIP][49] ([i915#2672] / [i915#3555])
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106948v1/shard-iclb2/igt@kms_flip_scaled_crc@flip-64bpp-ytile-to-32bpp-ytilegen12rcccs-upscaling@pipe-a-default-mode.html

* igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-shrfb-draw-pwrite:
- shard-glk: NOTRUN -> [SKIP][50] ([fdo#109271]) +42 similar issues
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106948v1/shard-glk7/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-shrfb-draw-pwrite.html

* igt@kms_frontbuffer_tracking@psr-2p-scndscrn-pri-indfb-draw-render:
- shard-skl: NOTRUN -> [SKIP][51] ([fdo#109271] / [i915#1888]) +1 similar issue
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106948v1/shard-skl9/igt@kms_frontbuffer_tracking@psr-2p-scndscrn-pri-indfb-draw-render.html

* igt@kms_hdr@bpc-switch@pipe-a-dp-1:
- shard-kbl: [PASS][52] -> [FAIL][53] ([i915#1188])
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11966/shard-kbl4/igt@kms_hdr@[email protected]
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106948v1/shard-kbl1/igt@kms_hdr@[email protected]

* igt@kms_plane_alpha_blend@pipe-b-alpha-basic:
- shard-apl: NOTRUN -> [FAIL][54] ([fdo#108145] / [i915#265])
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106948v1/shard-apl2/igt@[email protected]

* igt@kms_plane_alpha_blend@pipe-b-alpha-transparent-fb:
- shard-apl: NOTRUN -> [FAIL][55] ([i915#265])
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106948v1/shard-apl2/igt@[email protected]

* igt@kms_plane_alpha_blend@pipe-c-alpha-transparent-fb:
- shard-glk: NOTRUN -> [FAIL][56] ([i915#265])
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106948v1/shard-glk7/igt@[email protected]

* igt@kms_plane_alpha_blend@pipe-c-constant-alpha-min:
- shard-skl: NOTRUN -> [FAIL][57] ([fdo#108145] / [i915#265])
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106948v1/shard-skl9/igt@[email protected]

* igt@kms_plane_alpha_blend@pipe-d-alpha-transparent-fb:
- shard-apl: NOTRUN -> [SKIP][58] ([fdo#109271]) +135 similar issues
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106948v1/shard-apl7/igt@[email protected]

* igt@kms_plane_scaling@planes-unity-scaling-downscale-factor-0-5@pipe-a-edp-1:
- shard-iclb: [PASS][59] -> [SKIP][60] ([i915#5235]) +2 similar issues
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11966/shard-iclb8/igt@kms_plane_scaling@[email protected]
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106948v1/shard-iclb2/igt@kms_plane_scaling@[email protected]

* igt@kms_psr2_sf@overlay-plane-move-continuous-exceed-fully-sf:
- shard-skl: NOTRUN -> [SKIP][61] ([fdo#109271] / [i915#658])
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106948v1/shard-skl1/igt@[email protected]
- shard-apl: NOTRUN -> [SKIP][62] ([fdo#109271] / [i915#658])
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106948v1/shard-apl7/igt@[email protected]

* igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-big-fb:
- shard-kbl: NOTRUN -> [SKIP][63] ([fdo#109271] / [i915#658])
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106948v1/shard-kbl4/igt@[email protected]

* igt@kms_psr@psr2_cursor_render:
- shard-iclb: [PASS][64] -> [SKIP][65] ([fdo#109441])
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11966/shard-iclb2/igt@kms_psr@psr2_cursor_render.html
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106948v1/shard-iclb6/igt@kms_psr@psr2_cursor_render.html

* igt@kms_vblank@pipe-b-ts-continuation-suspend:
- shard-kbl: [PASS][66] -> [DMESG-WARN][67] ([i915#180]) +7 similar issues
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11966/shard-kbl7/igt@[email protected]
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106948v1/shard-kbl7/igt@[email protected]

* igt@kms_vblank@pipe-d-wait-idle:
- shard-apl: NOTRUN -> [SKIP][68] ([fdo#109271] / [i915#533])
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106948v1/shard-apl6/igt@[email protected]

* igt@kms_writeback@writeback-check-output:
- shard-apl: NOTRUN -> [SKIP][69] ([fdo#109271] / [i915#2437])
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106948v1/shard-apl2/igt@[email protected]

* igt@perf@blocking:
- shard-skl: [PASS][70] -> [FAIL][71] ([i915#1542])
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11966/shard-skl2/igt@[email protected]
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106948v1/shard-skl7/igt@[email protected]

* igt@perf@polling-parameterized:
- shard-iclb: [PASS][72] -> [FAIL][73] ([i915#5639])
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11966/shard-iclb7/igt@[email protected]
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106948v1/shard-iclb5/igt@[email protected]
- shard-skl: [PASS][74] -> [FAIL][75] ([i915#5639])
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11966/shard-skl9/igt@[email protected]
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106948v1/shard-skl2/igt@[email protected]

* igt@perf@short-reads:
- shard-skl: [PASS][76] -> [FAIL][77] ([i915#51])
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11966/shard-skl1/igt@[email protected]
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106948v1/shard-skl6/igt@[email protected]

* igt@sysfs_clients@fair-3:
- shard-apl: NOTRUN -> [SKIP][78] ([fdo#109271] / [i915#2994])
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106948v1/shard-apl2/igt@[email protected]

* igt@sysfs_clients@sema-10:
- shard-glk: NOTRUN -> [SKIP][79] ([fdo#109271] / [i915#2994])
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106948v1/shard-glk7/igt@[email protected]

* igt@sysfs_clients@sema-50:
- shard-skl: NOTRUN -> [SKIP][80] ([fdo#109271] / [i915#2994])
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106948v1/shard-skl7/igt@[email protected]

#### Possible fixes ####

* igt@gem_eio@in-flight-contexts-10ms:
- shard-tglb: [TIMEOUT][81] ([i915#3063]) -> [PASS][82]
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11966/shard-tglb3/igt@[email protected]
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106948v1/shard-tglb3/igt@[email protected]

* igt@gem_exec_balancer@parallel-keep-submit-fence:
- shard-iclb: [SKIP][83] ([i915#4525]) -> [PASS][84] +1 similar issue
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11966/shard-iclb5/igt@[email protected]
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106948v1/shard-iclb4/igt@[email protected]

* igt@gem_exec_fair@basic-none@vcs0:
- shard-glk: [FAIL][85] ([i915#2842]) -> [PASS][86]
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11966/shard-glk2/igt@gem_exec_fair@[email protected]
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106948v1/shard-glk2/igt@gem_exec_fair@[email protected]

* igt@gem_exec_fair@basic-pace-solo@rcs0:
- shard-kbl: [FAIL][87] ([i915#2842]) -> [PASS][88]
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11966/shard-kbl4/igt@gem_exec_fair@[email protected]
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106948v1/shard-kbl1/igt@gem_exec_fair@[email protected]

* igt@gem_spin_batch@spin-each:
- shard-skl: [FAIL][89] ([i915#2898]) -> [PASS][90]
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11966/shard-skl3/igt@[email protected]
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106948v1/shard-skl7/igt@[email protected]

* igt@i915_pm_rpm@modeset-lpsp-stress:
- shard-iclb: [DMESG-WARN][91] ([i915#6316]) -> [PASS][92]
[91]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11966/shard-iclb2/igt@[email protected]
[92]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106948v1/shard-iclb6/igt@[email protected]

* igt@kms_cursor_legacy@flip-vs-cursor@atomic-transitions-varying-size:
- shard-glk: [FAIL][93] ([i915#2346]) -> [PASS][94]
[93]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11966/shard-glk2/igt@kms_cursor_legacy@[email protected]
[94]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106948v1/shard-glk2/igt@kms_cursor_legacy@[email protected]

* igt@kms_cursor_legacy@flip-vs-cursor@toggle:
- shard-skl: [FAIL][95] ([i915#2346]) -> [PASS][96]
[95]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11966/shard-skl1/igt@kms_cursor_legacy@[email protected]
[96]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106948v1/shard-skl4/igt@kms_cursor_legacy@[email protected]

* igt@kms_flip@flip-vs-expired-vblank@a-edp1:
- shard-skl: [FAIL][97] ([i915#79]) -> [PASS][98] +1 similar issue
[97]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11966/shard-skl2/igt@kms_flip@[email protected]
[98]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106948v1/shard-skl10/igt@kms_flip@[email protected]

* igt@kms_flip@plain-flip-ts-check-interruptible@b-edp1:
- shard-skl: [FAIL][99] ([i915#2122]) -> [PASS][100] +2 similar issues
[99]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11966/shard-skl1/igt@kms_flip@[email protected]
[100]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106948v1/shard-skl6/igt@kms_flip@[email protected]

* igt@kms_invalid_mode@int-max-clock@dp-1-pipe-c:
- shard-apl: [DMESG-WARN][101] ([i915#62]) -> [PASS][102] +12 similar issues
[101]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11966/shard-apl7/igt@kms_invalid_mode@[email protected]
[102]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106948v1/shard-apl3/igt@kms_invalid_mode@[email protected]

* igt@kms_psr@psr2_basic:
- shard-iclb: [SKIP][103] ([fdo#109441]) -> [PASS][104]
[103]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11966/shard-iclb6/igt@kms_psr@psr2_basic.html
[104]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106948v1/shard-iclb2/igt@kms_psr@psr2_basic.html

* igt@kms_psr_stress_test@flip-primary-invalidate-overlay:
- shard-tglb: [SKIP][105] ([i915#5519]) -> [PASS][106]
[105]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11966/shard-tglb3/igt@[email protected]
[106]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106948v1/shard-tglb2/igt@[email protected]

* igt@kms_vblank@pipe-a-ts-continuation-suspend:
- shard-apl: [DMESG-WARN][107] ([i915#180]) -> [PASS][108] +4 similar issues
[107]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11966/shard-apl4/igt@[email protected]
[108]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106948v1/shard-apl2/igt@[email protected]

#### Warnings ####

* igt@gem_eio@kms:
- shard-tglb: [TIMEOUT][109] ([i915#3063]) -> [FAIL][110] ([i915#5784])
[109]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11966/shard-tglb5/igt@[email protected]
[110]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106948v1/shard-tglb3/igt@[email protected]

* igt@gem_exec_balancer@parallel-ordering:
- shard-iclb: [FAIL][111] ([i915#6117]) -> [SKIP][112] ([i915#4525])
[111]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11966/shard-iclb4/igt@[email protected]
[112]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106948v1/shard-iclb8/igt@[email protected]

* igt@i915_selftest@mock@vma:
- shard-skl: [INCOMPLETE][113] ([i915#6473] / [i915#6509]) -> [INCOMPLETE][114] ([i915#6473])
[113]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11966/shard-skl1/igt@i915_selftest@[email protected]
[114]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106948v1/shard-skl6/igt@i915_selftest@[email protected]

* igt@kms_ccs@pipe-a-crc-primary-rotation-180-y_tiled_gen12_mc_ccs:
- shard-skl: [SKIP][115] ([fdo#109271] / [i915#1888] / [i915#3886]) -> [SKIP][116] ([fdo#109271] / [i915#3886])
[115]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11966/shard-skl1/igt@kms_ccs@pipe-a-crc-primary-rotation-180-y_tiled_gen12_mc_ccs.html
[116]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106948v1/shard-skl6/igt@kms_ccs@pipe-a-crc-primary-rotation-180-y_tiled_gen12_mc_ccs.html

* igt@kms_cursor_legacy@flip-vs-cursor@atomic:
- shard-skl: [INCOMPLETE][117] -> [FAIL][118] ([i915#2346])
[117]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11966/shard-skl1/igt@kms_cursor_legacy@[email protected]
[118]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106948v1/shard-skl4/igt@kms_cursor_legacy@[email protected]

* igt@kms_fbcon_fbt@fbc-suspend:
- shard-kbl: [INCOMPLETE][119] ([i915#180] / [i915#4939]) -> [FAIL][120] ([i915#4767])
[119]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11966/shard-kbl7/igt@[email protected]
[120]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106948v1/shard-kbl4/igt@[email protected]

* igt@kms_psr2_sf@overlay-plane-move-continuous-sf:
- shard-iclb: [SKIP][121] ([i915#2920]) -> [SKIP][122] ([i915#658])
[121]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11966/shard-iclb2/igt@[email protected]
[122]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106948v1/shard-iclb3/igt@[email protected]

* igt@kms_psr2_sf@primary-plane-update-sf-dmg-area:
- shard-iclb: [SKIP][123] ([i915#2920]) -> [SKIP][124] ([fdo#111068] / [i915#658])
[123]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11966/shard-iclb2/igt@[email protected]
[124]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106948v1/shard-iclb6/igt@[email protected]

* igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-big-fb:
- shard-iclb: [SKIP][125] ([i915#658]) -> [SKIP][126] ([i915#2920]) +1 similar issue
[125]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11966/shard-iclb8/igt@[email protected]
[126]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106948v1/shard-iclb2/igt@[email protected]

* igt@kms_psr2_su@page_flip-nv12:
- shard-iclb: [SKIP][127] ([fdo#109642] / [fdo#111068] / [i915#658]) -> [FAIL][128] ([i915#5939])
[127]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11966/shard-iclb5/igt@kms_psr2_su@page_flip-nv12.html
[128]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106948v1/shard-iclb2/igt@kms_psr2_su@page_flip-nv12.html

* igt@kms_psr@psr2_sprite_blt:
- shard-skl: [SKIP][129] ([fdo#109271] / [i915#1888]) -> [SKIP][130] ([fdo#109271])
[129]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11966/shard-skl7/igt@kms_psr@psr2_sprite_blt.html
[130]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106948v1/shard-skl1/igt@kms_psr@psr2_sprite_blt.html

* igt@runner@aborted:
- shard-kbl: ([FAIL][131], [FAIL][132], [FAIL][133], [FAIL][134], [FAIL][135]) ([i915#180] / [i915#3002] / [i915#4312] / [i915#5257] / [i915#92]) -> ([FAIL][136], [FAIL][137], [FAIL][138], [FAIL][139], [FAIL][140], [FAIL][141], [FAIL][142], [FAIL][143]) ([i915#180] / [i915#3002] / [i915#4312] / [i915#5257])
[131]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11966/shard-kbl1/igt@[email protected]
[132]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11966/shard-kbl1/igt@[email protected]
[133]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11966/shard-kbl7/igt@[email protected]
[134]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11966/shard-kbl7/igt@[email protected]
[135]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11966/shard-kbl7/igt@[email protected]
[136]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106948v1/shard-kbl1/igt@[email protected]
[137]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106948v1/shard-kbl7/igt@[email protected]
[138]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106948v1/shard-kbl7/igt@[email protected]
[139]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106948v1/shard-kbl7/igt@[email protected]
[140]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106948v1/shard-kbl7/igt@[email protected]
[141]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106948v1/shard-kbl7/igt@[email protected]
[142]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106948v1/shard-kbl7/igt@[email protected]
[143]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106948v1/shard-kbl4/igt@[email protected]

{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).

[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109274]: https://bugs.freedesktop.org/show_bug.cgi?id=109274
[fdo#109280]: https://bugs.freedesktop.org/show_bug.cgi?id=109280
[fdo#109283]: https://bugs.freedesktop.org/show_bug.cgi?id=109283
[fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285
[fdo#109289]: https://bugs.freedesktop.org/show_bug.cgi?id=109289
[fdo#109291]: https://bugs.freedesktop.org/show_bug.cgi?id=109291
[fdo#109295]: https://bugs.freedesktop.org/show_bug.cgi?id=109295
[fdo#109300]: https://bugs.freedesktop.org/show_bug.cgi?id=109300
[fdo#109302]: https://bugs.freedesktop.org/show_bug.cgi?id=109302
[fdo#109303]: https://bugs.freedesktop.org/show_bug.cgi?id=109303
[fdo#109308]: https://bugs.freedesktop.org/show_bug.cgi?id=109308
[fdo#109309]: https://bugs.freedesktop.org/show_bug.cgi?id=109309
[fdo#109312]: https://bugs.freedesktop.org/show_bug.cgi?id=109312
[fdo#109313]: https://bugs.freedesktop.org/show_bug.cgi?id=109313
[fdo#109314]: https://bugs.freedesktop.org/show_bug.cgi?id=109314
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[fdo#109506]: https://bugs.freedesktop.org/show_bug.cgi?id=109506
[fdo#109642]: https://bugs.freedesktop.org/show_bug.cgi?id=109642
[fdo#110189]: https://bugs.freedesktop.org/show_bug.cgi?id=110189
[fdo#110542]: https://bugs.freedesktop.org/show_bug.cgi?id=110542
[fdo#110723]: https://bugs.freedesktop.org/show_bug.cgi?id=110723
[fdo#111068]: https://bugs.freedesktop.org/show_bug.cgi?id=111068
[fdo#111314]: https://bugs.freedesktop.org/show_bug.cgi?id=111314
[fdo#111614]: https://bugs.freedesktop.org/show_bug.cgi?id=111614
[fdo#111615]: https://bugs.freedesktop.org/show_bug.cgi?id=111615
[fdo#111644]: https://bugs.freedesktop.org/show_bug.cgi?id=111644
[fdo#111656]: https://bugs.freedesktop.org/show_bug.cgi?id=111656
[fdo#111825]: https://bugs.freedesktop.org/show_bug.cgi?id=111825
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[fdo#112054]: https://bugs.freedesktop.org/show_bug.cgi?id=112054
[fdo#112283]: https://bugs.freedesktop.org/show_bug.cgi?id=112283
[i915#1063]: https://gitlab.freedesktop.org/drm/intel/issues/1063
[i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
[i915#1155]: https://gitlab.freedesktop.org/drm/intel/issues/1155
[i915#1188]: https://gitlab.freedesktop.org/drm/intel/issues/1188
[i915#1257]: https://gitlab.freedesktop.org/drm/intel/issues/1257
[i915#132]: https://gitlab.freedesktop.org/drm/intel/issues/132
[i915#1397]: https://gitlab.freedesktop.org/drm/intel/issues/1397
[i915#1542]: https://gitlab.freedesktop.org/drm/intel/issues/1542
[i915#1722]: https://gitlab.freedesktop.org/drm/intel/issues/1722
[i915#1755]: https://gitlab.freedesktop.org/drm/intel/issues/1755
[i915#1769]: https://gitlab.freedesktop.org/drm/intel/issues/1769
[i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180
[i915#1825]: https://gitlab.freedesktop.org/drm/intel/issues/1825
[i915#1839]: https://gitlab.freedesktop.org/drm/intel/issues/1839
[i915#1845]: https://gitlab.freedesktop.org/drm/intel/issues/1845
[i915#1849]: https://gitlab.freedesktop.org/drm/intel/issues/1849
[i915#1850]: https://gitlab.freedesktop.org/drm/intel/issues/1850
[i915#1888]: https://gitlab.freedesktop.org/drm/intel/issues/1888
[i915#1902]: https://gitlab.freedesktop.org/drm/intel/issues/1902
[i915#1911]: https://gitlab.freedesktop.org/drm/intel/issues/1911
[i915#2105]: https://gitlab.freedesktop.org/drm/intel/issues/2105
[i915#2122]: https://gitlab.freedesktop.org/drm/intel/issues/2122
[i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190
[i915#2232]: https://gitlab.freedesktop.org/drm/intel/issues/2232
[i915#2346]: https://gitlab.freedesktop.org/drm/intel/issues/2346
[i915#2410]: https://gitlab.freedesktop.org/drm/intel/issues/2410
[i915#2433]: https://gitlab.freedesktop.org/drm/intel/issues/2433
[i915#2434]: https://gitlab.freedesktop.org/drm/intel/issues/2434
[i915#2435]: https://gitlab.freedesktop.org/drm/intel/issues/2435
[i915#2436]: https://gitlab.freedesktop.org/drm/intel/issues/2436
[i915#2437]: https://gitlab.freedesktop.org/drm/intel/issues/2437
[i915#2521]: https://gitlab.freedesktop.org/drm/intel/issues/2521
[i915#2527]: https://gitlab.freedesktop.org/drm/intel/issues/2527
[i915#2530]: https://gitlab.freedesktop.org/drm/intel/issues/2530
[i915#2582]: https://gitlab.freedesktop.org/drm/intel/issues/2582
[i915#265]: https://gitlab.freedesktop.org/drm/intel/issues/265
[i915#2658]: https://gitlab.freedesktop.org/drm/intel/issues/2658
[i915#2672]: https://gitlab.freedesktop.org/drm/intel/issues/2672
[i915#2705]: https://gitlab.freedesktop.org/drm/intel/issues/2705
[i915#280]: https://gitlab.freedesktop.org/drm/intel/issues/280
[i915#284]: https://gitlab.freedesktop.org/drm/intel/issues/284
[i915#2842]: https://gitlab.freedesktop.org/drm/intel/issues/2842
[i915#2846]: https://gitlab.freedesktop.org/drm/intel/issues/2846
[i915#2852]: https://gitlab.freedesktop.org/drm/intel/issues/2852
[i915#2856]: https://gitlab.freedesktop.org/drm/intel/issues/2856
[i915#2898]: https://gitlab.freedesktop.org/drm/intel/issues/2898
[i915#2920]: https://gitlab.freedesktop.org/drm/intel/issues/2920
[i915#2994]: https://gitlab.freedesktop.org/drm/intel/issues/2994
[i915#3002]: https://gitlab.freedesktop.org/drm/intel/issues/3002
[i915#3012]: https://gitlab.freedesktop.org/drm/intel/issues/3012
[i915#3063]: https://gitlab.freedesktop.org/drm/intel/issues/3063
[i915#3116]: https://gitlab.freedesktop.org/drm/intel/issues/3116
[i915#3281]: https://gitlab.freedesktop.org/drm/intel/issues/3281
[i915#3282]: https://gitlab.freedesktop.org/drm/intel/issues/3282
[i915#3291]: https://gitlab.freedesktop.org/drm/intel/issues/3291
[i915#3297]: https://gitlab.freedesktop.org/drm/intel/issues/3297
[i915#3299]: https://gitlab.freedesktop.org/drm/intel/issues/3299
[i915#3301]: https://gitlab.freedesktop.org/drm/intel/issues/3301
[i915#3318]: https://gitlab.freedesktop.org/drm/intel/issues/3318
[i915#3323]: https://gitlab.freedesktop.org/drm/intel/issues/3323
[i915#3361]: https://gitlab.freedesktop.org/drm/intel/issues/3361
[i915#3376]: https://gitlab.freedesktop.org/drm/intel/issues/3376
[i915#3458]: https://gitlab.freedesktop.org/drm/intel/issues/3458
[i915#3469]: https://gitlab.freedesktop.org/drm/intel/issues/3469
[i915#3528]: https://gitlab.freedesktop.org/drm/intel/issues/3528
[i915#3539]: https://gitlab.freedesktop.org/drm/intel/issues/3539
[i915#3546]: https://gitlab.freedesktop.org/drm/intel/issues/3546
[i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
[i915#3558]: https://gitlab.freedesktop.org/drm/intel/issues/3558
[i915#3637]: https://gitlab.freedesktop.org/drm/intel/issues/3637
[i915#3638]: https://gitlab.freedesktop.org/drm/intel/issues/3638
[i915#3689]: https://gitlab.freedesktop.org/drm/intel/issues/3689
[i915#3708]: https://gitlab.freedesktop.org/drm/intel/issues/3708
[i915#3734]: https://gitlab.freedesktop.org/drm/intel/issues/3734
[i915#3742]: https://gitlab.freedesktop.org/drm/intel/issues/3742
[i915#3778]: https://gitlab.freedesktop.org/drm/intel/issues/3778
[i915#3804]: https://gitlab.freedesktop.org/drm/intel/issues/3804
[i915#3825]: https://gitlab.freedesktop.org/drm/intel/issues/3825
[i915#3826]: https://gitlab.freedesktop.org/drm/intel/issues/3826
[i915#3828]: https://gitlab.freedesktop.org/drm/intel/issues/3828
[i915#3886]: https://gitlab.freedesktop.org/drm/intel/issues/3886
[i915#3936]: https://gitlab.freedesktop.org/drm/intel/issues/3936
[i915#3938]: https://gitlab.freedesktop.org/drm/intel/issues/3938
[i915#3952]: https://gitlab.freedesktop.org/drm/intel/issues/3952
[i915#3955]: https://gitlab.freedesktop.org/drm/intel/issues/3955
[i915#3966]: https://gitlab.freedesktop.org/drm/intel/issues/3966
[i915#3989]: https://gitlab.freedesktop.org/drm/intel/issues/3989
[i915#4016]: https://gitlab.freedesktop.org/drm/intel/issues/4016
[i915#4032]: https://gitlab.freedesktop.org/drm/intel/issues/4032
[i915#4070]: https://gitlab.freedesktop.org/drm/intel/issues/4070
[i915#4077]: https://gitlab.freedesktop.org/drm/intel/issues/4077
[i915#4078]: https://gitlab.freedesktop.org/drm/intel/issues/4078
[i915#4079]: https://gitlab.freedesktop.org/drm/intel/issues/4079
[i915#4083]: https://gitlab.freedesktop.org/drm/intel/issues/4083
[i915#4098]: https://gitlab.freedesktop.org/drm/intel/issues/4098
[i915#4103]: https://gitlab.freedesktop.org/drm/intel/issues/4103
[i915#4171]: https://gitlab.freedesktop.org/drm/intel/issues/4171
[i915#4212]: https://gitlab.freedesktop.org/drm/intel/issues/4212
[i915#4213]: https://gitlab.freedesktop.org/drm/intel/issues/4213
[i915#4215]: https://gitlab.freedesktop.org/drm/intel/issues/4215
[i915#426]: https://gitlab.freedesktop.org/drm/intel/issues/426
[i915#4270]: https://gitlab.freedesktop.org/drm/intel/issues/4270
[i915#4312]: https://gitlab.freedesktop.org/drm/intel/issues/4312
[i915#433]: https://gitlab.freedesktop.org/drm/intel/issues/433
[i915#4349]: https://gitlab.freedesktop.org/drm/intel/issues/4349
[i915#4369]: https://gitlab.freedesktop.org/drm/intel/issues/4369
[i915#4387]: https://gitlab.freedesktop.org/drm/intel/issues/4387
[i915#4391]: https://gitlab.freedesktop.org/drm/intel/issues/4391
[i915#4494]: https://gitlab.freedesktop.org/drm/intel/issues/4494
[i915#4525]: https://gitlab.freedesktop.org/drm/intel/issues/4525
[i915#4538]: https://gitlab.freedesktop.org/drm/intel/issues/4538
[i915#454]: https://gitlab.freedesktop.org/drm/intel/issues/454
[i915#4565]: https://gitlab.freedesktop.org/drm/intel/issues/4565
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#4767]: https://gitlab.freedesktop.org/drm/intel/issues/4767
[i915#4771]: https://gitlab.freedesktop.org/drm/intel/issues/4771
[i915#4812]: https://gitlab.freedesktop.org/drm/intel/issues/4812
[i915#4833]: https://gitlab.freedesktop.org/drm/intel/issues/4833
[i915#4852]: https://gitlab.freedesktop.org/drm/intel/issues/4852
[i915#4853]: https://gitlab.freedesktop.org/drm/intel/issues/4853
[i915#4855]: https://gitlab.freedesktop.org/drm/intel/issues/4855
[i915#4859]: https://gitlab.freedesktop.org/drm/intel/issues/4859
[i915#4860]: https://gitlab.freedesktop.org/drm/intel/issues/4860
[i915#4873]: https://gitlab.freedesktop.org/drm/intel/issues/4873
[i915#4874]: https://gitlab.freedesktop.org/drm/intel/issues/4874
[i915#4880]: https://gitlab.freedesktop.org/drm/intel/issues/4880
[i915#4881]: https://gitlab.freedesktop.org/drm/intel/issues/4881
[i915#4883]: https://gitlab.freedesktop.org/drm/intel/issues/4883
[i915#4884]: https://gitlab.freedesktop.org/drm/intel/issues/4884
[i915#4885]: https://gitlab.freedesktop.org/drm/intel/issues/4885
[i915#4893]: https://gitlab.freedesktop.org/drm/intel/issues/4893
[i915#4939]: https://gitlab.freedesktop.org/drm/intel/issues/4939
[i915#4941]: https://gitlab.freedesktop.org/drm/intel/issues/4941
[i915#4957]: https://gitlab.freedesktop.org/drm/intel/issues/4957
[i915#4958]: https://gitlab.freedesktop.org/drm/intel/issues/4958
[i915#4991]: https://gitlab.freedesktop.org/drm/intel/issues/4991
[i915#51]: https://gitlab.freedesktop.org/drm/intel/issues/51
[i915#5176]: https://gitlab.freedesktop.org/drm/intel/issues/5176
[i915#5182]: https://gitlab.freedesktop.org/drm/intel/issues/5182
[i915#5235]: https://gitlab.freedesktop.org/drm/intel/issues/5235
[i915#5257]: https://gitlab.freedesktop.org/drm/intel/issues/5257
[i915#5286]: https://gitlab.freedesktop.org/drm/intel/issues/5286
[i915#5287]: https://gitlab.freedesktop.org/drm/intel/issues/5287
[i915#5288]: https://gitlab.freedesktop.org/drm/intel/issues/5288
[i915#5289]: https://gitlab.freedesktop.org/drm/intel/issues/5289
[i915#5325]: https://gitlab.freedesktop.org/drm/intel/issues/5325
[i915#5327]: https://gitlab.freedesktop.org/drm/intel/issues/5327
[i915#533]: https://gitlab.freedesktop.org/drm/intel/issues/533
[i915#5439]: https://gitlab.freedesktop.org/drm/intel/issues/5439
[i915#5461]: https://gitlab.freedesktop.org/drm/intel/issues/5461
[i915#5519]: https://gitlab.freedesktop.org/drm/intel/issues/5519
[i915#5563]: https://gitlab.freedesktop.org/drm/intel/issues/5563
[i915#5639]: https://gitlab.freedesktop.org/drm/intel/issues/5639
[i915#5723]: https://gitlab.freedesktop.org/drm/intel/issues/5723
[i915#5784]: https://gitlab.freedesktop.org/drm/intel/issues/5784
[i915#5939]: https://gitlab.freedesktop.org/drm/intel/issues/5939
[i915#6011]: https://gitlab.freedesktop.org/drm/intel/issues/6011
[i915#6095]: https://gitlab.freedesktop.org/drm/intel/issues/6095
[i915#6117]: https://gitlab.freedesktop.org/drm/intel/issues/6117
[i915#62]: https://gitlab.freedesktop.org/drm/intel/issues/62
[i915#6201]: https://gitlab.freedesktop.org/drm/intel/issues/6201
[i915#6227]: https://gitlab.freedesktop.org/drm/intel/issues/6227
[i915#6230]: https://gitlab.freedesktop.org/drm/intel/issues/6230
[i915#6245]: https://gitlab.freedesktop.org/drm/intel/issues/6245
[i915#6248]: https://gitlab.freedesktop.org/drm/intel/issues/6248
[i915#6252]: https://gitlab.freedesktop.org/drm/intel/issues/6252
[i915#6268]: https://gitlab.freedesktop.org/drm/intel/issues/6268
[i915#6301]: https://gitlab.freedesktop.org/drm/intel/issues/6301
[i915#6316]: https://gitlab.freedesktop.org/drm/intel/issues/6316
[i915#6331]: https://gitlab.freedesktop.org/drm/intel/issues/6331
[i915#6335]: https://gitlab.freedesktop.org/drm/intel/issues/6335
[i915#6344]: https://gitlab.freedesktop.org/drm/intel/issues/6344
[i915#6412]: https://gitlab.freedesktop.org/drm/intel/issues/6412
[i915#6433]: https://gitlab.freedesktop.org/drm/intel/issues/6433
[i915#6458]: https://gitlab.freedesktop.org/drm/intel/issues/6458
[i915#6463]: https://gitlab.freedesktop.org/drm/intel/issues/6463
[i915#6473]: https://gitlab.freedesktop.org/drm/intel/issues/6473
[i915#6493]: https://gitlab.freedesktop.org/drm/intel/issues/6493
[i915#6497]: https://gitlab.freedesktop.org/drm/intel/issues/6497
[i915#6509]: https://gitlab.freedesktop.org/drm/intel/issues/6509
[i915#6524]: https://gitlab.freedesktop.org/drm/intel/issues/6524
[i915#6527]: https://gitlab.freedesktop.org/drm/intel/issues/6527
[i915#658]: https://gitlab.freedesktop.org/drm/intel/issues/658
[i915#79]: https://gitlab.freedesktop.org/drm/intel/issues/79
[i915#92]: https://gitlab.freedesktop.org/drm/intel/issues/92

Build changes
-------------

* Linux: CI_DRM_11966 -> Patchwork_106948v1

CI-20190529: 20190529
CI_DRM_11966: f3c1d1b53388aaa69e20a1b72f8307ad57116565 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_6613: 209230467200f2fa63a6f71fe6299996470dd813 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_106948v1: f3c1d1b53388aaa69e20a1b72f8307ad57116565 @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106948v1/index.html

#7 lore raw
In reply to Stuart Summers
Quoted 7 lines · Stuart Summers

In the driver teardown, we are unregistering the gt prior to unregistering the PMU. This means there is a small window of time in which the application can request metrics from the PMU, some of which are calling into the uapi engines list, while the engines are not available. In this case we can see null pointer dereferences.

Quoted 7 lines

Fix this ordering in both the driver load and unload sequences.

v1: Actually address the driver load/unload ordering issue
v2: Remove the NULL checks since they shouldn't be necessary
now with the proper ordering

Fixes 42014f69bb235 ("drm/i915: Hook up GT power management")

What happened in this commit to break it?

Quoted 19 lines
---
  drivers/gpu/drm/i915/i915_driver.c | 11 ++++++-----
  1 file changed, 6 insertions(+), 5 deletions(-)
drivers/gpu/drm/i915/i915_driver.c +0 -1
index deb8a8b76965a..ee4dcb85d2060 100644
@@ -717,7 +717,6 @@ static void i915_driver_register(struct drm_i915_private *dev_priv)
  	struct drm_device *dev = &dev_priv->drm;
 
  	i915_gem_driver_register(dev_priv);
-	i915_pmu_register(dev_priv);
 
  	intel_vgpu_register(dev_priv);
 
@@ -731,11 +730,12 @@ static void i915_driver_register(struct drm_i915_private *dev_priv)
  	i915_debugfs_register(dev_priv);

drivers/gpu/drm/i915/i915_driver.c static void i915_driver_register(struct drm_i915_private *dev_priv) · line 738

Quoted 10 lines
drivers/gpu/drm/i915/i915_driver.c +3 -2
  	i915_setup_sysfs(dev_priv);
 
+	intel_gt_driver_register(to_gt(dev_priv));
+
  	/* Depends on sysfs having been initialized */
+	i915_pmu_register(dev_priv);
  	i915_perf_register(dev_priv);
 
-	intel_gt_driver_register(to_gt(dev_priv));
-

There was a bit of a time distance since we originally discussed this so things kind of evaporated from my head. Or at least it feels like that.
Today when I look at the code I don't understand why is this shuffle
relevant.

The sysfs comment does not really apply to pmu, but also if I look into intel_gt_driver_(un)register I did not spot what is the relevant part which interacts with the PMU.

On register it is engine list first then PMU.

On unregister it is PMU first, then engine list:

i915_driver_remove

    i915_driver_unregister
      i915_pmu_unregister
    i915_gem_driver_remove
      clears uabi engines list

Help please? :)

Regards,

Tvrtko

Quoted 18 lines
drivers/gpu/drm/i915/i915_driver.c +3 -2
  	intel_display_driver_register(dev_priv);
 
  	intel_power_domains_enable(dev_priv);
@@ -762,11 +762,12 @@ static void i915_driver_unregister(struct drm_i915_private *dev_priv)
 
  	intel_display_driver_unregister(dev_priv);
 
-	intel_gt_driver_unregister(to_gt(dev_priv));
-
  	i915_perf_unregister(dev_priv);
+	/* GT should be available until PMU is gone */
  	i915_pmu_unregister(dev_priv);
 
+	intel_gt_driver_unregister(to_gt(dev_priv));
+
  	i915_teardown_sysfs(dev_priv);
  	drm_dev_unplug(&dev_priv->drm);
 
Reviewed-by on v1 2/2
#2 lore raw

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Only disable PMU on stop if not already closed

In reply to Stuart Summers
Quoted 26 lines · Stuart Summers

There can be a race in the PMU process teardown vs the time when the driver is unbound in which the user attempts to stop the PMU process, but the actual data structure in the kernel is no longer available. Avoid this use-after-free by skipping the PMU disable in i915_pmu_event_stop() when the PMU has already been closed/unregistered by the driver.

Fixes b00bccb3f0bb ("drm/i915/pmu: Handle PCI unbind")
---
  drivers/gpu/drm/i915/i915_pmu.c | 8 ++++++++
  1 file changed, 8 insertions(+)
drivers/gpu/drm/i915/i915_pmu.c +4 -0
index 958b37123bf12..0d02f338118e4 100644
@@ -760,9 +760,17 @@ static void i915_pmu_event_start(struct perf_event *event, int flags)
 
  static void i915_pmu_event_stop(struct perf_event *event, int flags)
  {
+	struct drm_i915_private *i915 =
+		container_of(event->pmu, typeof(*i915), pmu.base);
+	struct i915_pmu *pmu = &i915->pmu;
+

drivers/gpu/drm/i915/i915_pmu.c static void i915_pmu_event_start(struct perf_event *event, int flags) · line 776

Quoted 10 lines
drivers/gpu/drm/i915/i915_pmu.c +4 -0
+	if (pmu->closed)
+		goto out;
+
  	if (flags & PERF_EF_UPDATE)
  		i915_pmu_event_read(event);
  	i915_pmu_disable(event);
+out:
  	event->hw.state = PERF_HES_STOPPED;
  }
 

LGTM, although I am not sure who feels comfortable to r-b since we all kind of suggested the same fix. :)

FWIW:

Regards,

Tvrtko

#8 lore raw
In reply to Tvrtko Ursulin
Quoted 10 lines · Tvrtko Ursulin
Quoted 9 lines · Stuart Summers

In the driver teardown, we are unregistering the gt prior to unregistering the PMU. This means there is a small window of time in which the application can request metrics from the PMU, some of which are calling into the uapi engines list, while the engines are not available. In this case we can see null pointer dereferences.

Fix this ordering in both the driver load and unload sequences.

Quoted 7 lines
Quoted 5 lines

v1: Actually address the driver load/unload ordering issue
v2: Remove the NULL checks since they shouldn't be necessary
now with the proper ordering

Fixes 42014f69bb235 ("drm/i915: Hook up GT power management")

What happened in this commit to break it?

Hm.. well this was the patch that added the abstraction ordering issue, i.e. gt_register/unregister. There isn't anything specifically broken here since we don't actually access the gt structure underneath. My assertion is that this patch should have taken the expansion of the gt structure into consideration and added the correct ordering with respect to the pmu.

Are you asking for the specific patch where things stopped working functionally?

Thanks,
Stuart

Quoted 83 lines
Quoted 23 lines
---
  drivers/gpu/drm/i915/i915_driver.c | 11 ++++++-----
  1 file changed, 6 insertions(+), 5 deletions(-)
drivers/gpu/drm/i915/i915_driver.c +0 -1
index deb8a8b76965a..ee4dcb85d2060 100644
@@ -717,7 +717,6 @@ static void i915_driver_register(struct
 drm_i915_private *dev_priv)
  	struct drm_device *dev = &dev_priv->drm;
 
  	i915_gem_driver_register(dev_priv);
-	i915_pmu_register(dev_priv);
 
  	intel_vgpu_register(dev_priv);
@@ -731,11 +730,12 @@ static void i915_driver_register(struct
 drm_i915_private *dev_priv)
  	i915_debugfs_register(dev_priv);

drivers/gpu/drm/i915/i915_driver.c static void i915_driver_register(struct · line 739

Quoted 10 lines
drivers/gpu/drm/i915/i915_driver.c +3 -2
  	i915_setup_sysfs(dev_priv);
 
+	intel_gt_driver_register(to_gt(dev_priv));
+
  	/* Depends on sysfs having been initialized */
+	i915_pmu_register(dev_priv);
  	i915_perf_register(dev_priv);
 
-	intel_gt_driver_register(to_gt(dev_priv));
-

There was a bit of a time distance since we originally discussed this so
things kind of evaporated from my head. Or at least it feels like that.
Today when I look at the code I don't understand why is this
shuffle
relevant.

The sysfs comment does not really apply to pmu, but also if I look into
intel_gt_driver_(un)register I did not spot what is the relevant part
which interacts with the PMU.

On register it is engine list first then PMU.

On unregister it is PMU first, then engine list:

   i915_driver_remove
     i915_driver_unregister
       i915_pmu_unregister
     i915_gem_driver_remove
       clears uabi engines list

Help please? :)

Regards,

Tvrtko

Quoted 19 lines
drivers/gpu/drm/i915/i915_driver.c +0 -0
  	intel_display_driver_register(dev_priv);
 
  	intel_power_domains_enable(dev_priv);
drivers/gpu/drm/i915/i915_driver.c +3 -2
@@ -762,11 +762,12 @@ static void i915_driver_unregister(struct
 drm_i915_private *dev_priv)
 
  	intel_display_driver_unregister(dev_priv);
 
-	intel_gt_driver_unregister(to_gt(dev_priv));
-
  	i915_perf_unregister(dev_priv);
+	/* GT should be available until PMU is gone */
  	i915_pmu_unregister(dev_priv);
 
+	intel_gt_driver_unregister(to_gt(dev_priv));
+
  	i915_teardown_sysfs(dev_priv);
  	drm_dev_unplug(&dev_priv->drm);
#3 lore raw

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Only disable PMU on stop if not already closed

In reply to Tvrtko Ursulin
Quoted 45 lines · Tvrtko Ursulin
Quoted 37 lines · Stuart Summers

There can be a race in the PMU process teardown vs the time when the driver is unbound in which the user attempts to stop the PMU process, but the actual data structure in the kernel is no longer available. Avoid this use-after-free by skipping the PMU disable in i915_pmu_event_stop() when the PMU has already been closed/unregistered by the driver.

Fixes b00bccb3f0bb ("drm/i915/pmu: Handle PCI unbind")
---
  drivers/gpu/drm/i915/i915_pmu.c | 8 ++++++++
  1 file changed, 8 insertions(+)
drivers/gpu/drm/i915/i915_pmu.c +8 -0
index 958b37123bf12..0d02f338118e4 100644
@@ -760,9 +760,17 @@ static void i915_pmu_event_start(struct
 perf_event *event, int flags)
 
  static void i915_pmu_event_stop(struct perf_event *event, int
 flags)
  {
+	struct drm_i915_private *i915 =
+		container_of(event->pmu, typeof(*i915), pmu.base);
+	struct i915_pmu *pmu = &i915->pmu;
+
+	if (pmu->closed)
+		goto out;
+
  	if (flags & PERF_EF_UPDATE)
  		i915_pmu_event_read(event);
  	i915_pmu_disable(event);
+out:
  	event->hw.state = PERF_HES_STOPPED;
Quoted 2 lines
  }

LGTM, although I am not sure who feels comfortable to r-b since we all
kind of suggested the same fix. :)

Quoted 3 lines

FWIW:

Thanks Tvrtko! I'll track down another reviewer here as well to close that out before merging.

Thanks,
Stuart

Quoted 4 lines

Regards,

Tvrtko

Reviewed-by on v1 2/2
#4 lore raw

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Only disable PMU on stop if not already closed

In reply to Stuart Summers
Quoted 25 lines · Stuart Summers

There can be a race in the PMU process teardown vs the time when the driver is unbound in which the user attempts to stop the PMU process, but the actual data structure in the kernel is no longer available. Avoid this use-after-free by skipping the PMU disable in i915_pmu_event_stop() when the PMU has already been closed/unregistered by the driver.

Fixes b00bccb3f0bb ("drm/i915/pmu: Handle PCI unbind")

---
drivers/gpu/drm/i915/i915_pmu.c | 8 ++++++++

1 file changed, 8 insertions(+)
drivers/gpu/drm/i915/i915_pmu.c +3 -0
index 958b37123bf12..0d02f338118e4 100644
@@ -760,9 +760,17 @@ static void i915_pmu_event_start(struct perf_event *event, int flags)
 
 static void i915_pmu_event_stop(struct perf_event *event, int flags)
 {
+	struct drm_i915_private *i915 =
+		container_of(event->pmu, typeof(*i915), pmu.base);
+	struct i915_pmu *pmu = &i915->pmu;

drivers/gpu/drm/i915/i915_pmu.c static void i915_pmu_event_start(struct perf_event *event, int flags) · line 775

Quoted 10 lines
drivers/gpu/drm/i915/i915_pmu.c +5 -0
+
+	if (pmu->closed)
+		goto out;
+
 	if (flags & PERF_EF_UPDATE)
 		i915_pmu_event_read(event);
 	i915_pmu_disable(event);
+out:
 	event->hw.state = PERF_HES_STOPPED;
 }

lgtm

Thanks,
Umesh

Quoted 4 lines
Signature · 2 lines
-- 
2.25.1
#9 lore raw
In reply to Summers, Stuart
Quoted 26 lines · Stuart
Quoted 10 lines · Tvrtko Ursulin
Quoted 9 lines · Stuart Summers

In the driver teardown, we are unregistering the gt prior to unregistering the PMU. This means there is a small window of time in which the application can request metrics from the PMU, some of which are calling into the uapi engines list, while the engines are not available. In this case we can see null pointer dereferences.

Fix this ordering in both the driver load and unload sequences.

Quoted 7 lines
Quoted 5 lines

v1: Actually address the driver load/unload ordering issue
v2: Remove the NULL checks since they shouldn't be necessary
now with the proper ordering

Fixes 42014f69bb235 ("drm/i915: Hook up GT power management")

What happened in this commit to break it?

Hm.. well this was the patch that added the abstraction ordering issue, i.e. gt_register/unregister. There isn't anything specifically broken here since we don't actually access the gt structure underneath. My assertion is that this patch should have taken the expansion of the gt structure into consideration and added the correct ordering with respect to the pmu.

Quoted 2 lines

Are you asking for the specific patch where things stopped working functionally?

No, I was looking for the info on what is actually broken with the ordering, as is since I couldn't spot it myself yesterday. In other words, with patch 2/2 applied - does 1/2 fix anything further for the PMU use cases?

Regards,

Tvrtko

Quoted 82 lines
Quoted 82 lines
Quoted 22 lines
---
   drivers/gpu/drm/i915/i915_driver.c | 11 ++++++-----
   1 file changed, 6 insertions(+), 5 deletions(-)
drivers/gpu/drm/i915/i915_driver.c +0 -1
index deb8a8b76965a..ee4dcb85d2060 100644
@@ -717,7 +717,6 @@ static void i915_driver_register(struct
 drm_i915_private *dev_priv)
   	struct drm_device *dev = &dev_priv->drm;
 
   	i915_gem_driver_register(dev_priv);
-	i915_pmu_register(dev_priv);
 
   	intel_vgpu_register(dev_priv);
@@ -731,11 +730,12 @@ static void i915_driver_register(struct
 drm_i915_private *dev_priv)
   	i915_debugfs_register(dev_priv);

drivers/gpu/drm/i915/i915_driver.c static void i915_driver_register(struct · line 739

Quoted 10 lines
drivers/gpu/drm/i915/i915_driver.c +3 -2
   	i915_setup_sysfs(dev_priv);
 
+	intel_gt_driver_register(to_gt(dev_priv));
+
   	/* Depends on sysfs having been initialized */
+	i915_pmu_register(dev_priv);
   	i915_perf_register(dev_priv);
 
-	intel_gt_driver_register(to_gt(dev_priv));
-

There was a bit of a time distance since we originally discussed this so
things kind of evaporated from my head. Or at least it feels like that.
Today when I look at the code I don't understand why is this
shuffle
relevant.

The sysfs comment does not really apply to pmu, but also if I look into
intel_gt_driver_(un)register I did not spot what is the relevant part
which interacts with the PMU.

On register it is engine list first then PMU.

On unregister it is PMU first, then engine list:

    i915_driver_remove
      i915_driver_unregister
        i915_pmu_unregister
      i915_gem_driver_remove
        clears uabi engines list

Help please? :)

Regards,

Tvrtko

Quoted 19 lines
drivers/gpu/drm/i915/i915_driver.c +0 -0
   	intel_display_driver_register(dev_priv);
 
   	intel_power_domains_enable(dev_priv);
drivers/gpu/drm/i915/i915_driver.c +3 -2
@@ -762,11 +762,12 @@ static void i915_driver_unregister(struct
 drm_i915_private *dev_priv)
 
   	intel_display_driver_unregister(dev_priv);
 
-	intel_gt_driver_unregister(to_gt(dev_priv));
-
   	i915_perf_unregister(dev_priv);
+	/* GT should be available until PMU is gone */
   	i915_pmu_unregister(dev_priv);
 
+	intel_gt_driver_unregister(to_gt(dev_priv));
+
   	i915_teardown_sysfs(dev_priv);
   	drm_dev_unplug(&dev_priv->drm);