drm/amd/display: restore plane with no modifiers code.
Subsystems (3)
PATCH 1/1 drm/amd/display: restore plane with no modifiers code.
When this file was split in
5d945cbcd4b16a29d6470a80dfb19738f9a4319f
Author: Rodrigo Siqueira <[email protected]> Date: Wed Jul 20 15:31:42 2022 -0400
drm/amd/display: Create a file dedicated to planes
This chunk seemed to get dropped. Linus noticed on this rx580 and I've reproduced on FIJI which makes sense as these are pre-modifier GPUs.
With this applied, I get gdm back.
--- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_plane.c | 3 +++ 1 file changed, 3 insertions(+)
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_plane.c +3 -0
@@ -1591,6 +1591,9 @@ int amdgpu_dm_plane_init(struct amdgpu_display_manager *dm,if (res)return res; +if (modifiers ==NULL ) +adev_to_drm (dm->adev)->mode_config.fb_modifiers_not_supported = true; + res =drm_universal_plane_init (adev_to_drm (dm->adev), plane, possible_crtcs, &dm_plane_funcs, formats, num_formats, modifiers, plane->type,NULL );
Signature · 1 line
2.37.1
Quoted 8 lines · Dave Airlie
When this file was split in
5d945cbcd4b16a29d6470a80dfb19738f9a4319fAuthor: Rodrigo Siqueira <[email protected]> Date: Wed Jul 20 15:31:42 2022 -0400drm/amd/display: Create a file dedicated to planes
Quoted 8 lines
This chunk seemed to get dropped. Linus noticed on this rx580 and I've reproduced on FIJI which makes sense as these are pre-modifier GPUs.
With this applied, I get gdm back.
Fixes 5d945cbcd4b1 ("drm/amd/display: Create a file dedicated to planes")Signed-off-by Dave Airlie <[email protected]>
Harry
Quoted 18 lines
--- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_plane.c | 3 +++ 1 file changed, 3 insertions(+)drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_plane.c +3
-0@@ -1591,6 +1591,9 @@ int amdgpu_dm_plane_init(struct amdgpu_display_manager *dm,if (res)return res; +if (modifiers ==NULL ) +adev_to_drm (dm->adev)->mode_config.fb_modifiers_not_supported = true; + res =drm_universal_plane_init (adev_to_drm (dm->adev), plane, possible_crtcs, &dm_plane_funcs, formats, num_formats, modifiers, plane->type,NULL );
Quoted 2 lines · Dave Airlie
With this applied, I get gdm back.
I can confirm that it makes thing work again for me too. Applied.
Linus