alfred: add missing alfred_event_notify_v0 struct documentation
PATCH 1/3 alfred: add missing alfred_event_notify_v0 struct documentation
Signed-off-by Marek Lindner <[email protected]>
--- packet.h | 1 + 1 file changed, 1 insertion(+)
packet.h +1 -0
@@ -247,6 +247,7 @@ struct alfred_event_register_v0 {* struct alfred_event_notify_v0 - event notification message * @header: TLV header describing the complete packet * @type: Type of the data triggering the event +* @source: Mac address of the original source of the data * * Sent by the daemon to client on data record update */
Signature · 1 line
2.36.1
PATCH 2/3 alfred: fix erroneous documentation of '-r' argument
Signed-off-by Marek Lindner <[email protected]>
--- main.c | 2 +- man/alfred.8 | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)
main.c +1 -1
@@ -31,7 +31,7 @@ static void alfred_usage(void)printf (" -s, --set-data [data type] sets new data to distribute from stdin\n" );printf (" for the supplied data type (0-255)\n" );printf (" -r, --request [data type] collect data from the network and prints\n" ); -printf (" it on the network\n" ); +printf (" it on stdout\n" );printf (" -d, --verbose Show extra information in the data output\n" );printf (" -V, --req-version specify the data version set for -s\n" );printf (" -M, --modeswitch primary switch daemon to mode primary\n" );
man/alfred.8 +1 -1
@@ -67,7 +67,7 @@ must be periodically written again to alfred, otherwise it will timeout and alfred will forget about it (after 10 minutes). .TP \fB\-r\fP, \fB\-\-request\fP \fIdata\-type\fP -Collect data from the network and prints it on the network +Collect data from the network and prints it on stdout .TP \fB\-d\fP, \fB\-\-verbose\fP Show extra information in the data output
Signature · 1 line
2.36.1
PATCH 3/3 alfred: mismaching declarations of is_valid_ether_addr()
In reply to Marek Lindnerutil.c:57:34: warning: argument 1 of type ‘uint8_t[6]’
{aka ‘unsigned char[6]’} with mismatched bound [-Warray-parameter=] 57 | bool is_valid_ether_addr(uint8_t addr[ETH_ALEN])
| ~~~~~~~~^~~~~~~~~~~~~~
In file included from util.c:20:
alfred.h:231:35: note: previously declared as ‘uint8_t *’
{aka ‘unsigned char *’}
231 | bool is_valid_ether_addr(uint8_t *addr);
| ~~~~~~~~~^~~~Signed-off-by Marek Lindner <[email protected]>
--- alfred.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
alfred.h +1 -1
@@ -228,7 +228,7 @@ int time_diff(struct timespec *tv1, struct timespec *tv2, struct timespec *tvdiff);void time_random_seed (void );uint16_t get_random_id (void ); -bool is_valid_ether_addr (uint8_t *addr); +bool is_valid_ether_addr (uint8_t addr[ETH_ALEN ]);bool is_iface_disabled (char *iface);int ipv4_arp_request (struct interface *interface,const alfred_addr *addr,struct ether_addr *mac);
Signature · 1 line
2.36.1