Skip to contentSkip to conversation

ksmbd: return STATUS_BAD_NETWORK_NAME error status if share is not configured

PATCH In review Namjae Jeon 2 participants 2 messages Aug 8, 2022 – Aug 9, 2022

Subsystems (2)
lore
Share & tools
lore

Namjae Jeon

author maintainer
#0 lore raw

PATCH 1/1 ksmbd: return STATUS_BAD_NETWORK_NAME error status if share is not configured

If share is not configured in smb.conf, smb2 tree connect should return STATUS_BAD_NETWORK_NAME instead of STATUS_BAD_NETWORK_PATH.

---
 fs/ksmbd/mgmt/tree_connect.c | 2 +-
 fs/ksmbd/smb2pdu.c           | 3 ++-
 2 files changed, 3 insertions(+), 2 deletions(-)
fs/ksmbd/mgmt/tree_connect.c +1 -1
index b35ea6a6abc5..dd262daa2c4a 100644
@@ -19,7 +19,7 @@ struct ksmbd_tree_conn_status
 ksmbd_tree_conn_connect(struct ksmbd_conn *conn, struct ksmbd_session *sess,
 			char *share_name)
 {
-	struct ksmbd_tree_conn_status status = {-EINVAL, NULL};
+	struct ksmbd_tree_conn_status status = {-ENOENT, NULL};
 	struct ksmbd_tree_connect_response *resp = NULL;
 	struct ksmbd_share_config *sc;
 	struct ksmbd_tree_connect *tree_conn = NULL;
fs/ksmbd/smb2pdu.c +2 -1
index 4c3c840df455..d478c3ea4215 100644
@@ -1944,8 +1944,9 @@ int smb2_tree_connect(struct ksmbd_work *work)
 		rsp->hdr.Status = STATUS_SUCCESS;
 		rc = 0;
 		break;
+	case -ENOENT:
 	case KSMBD_TREE_CONN_STATUS_NO_SHARE:
-		rsp->hdr.Status = STATUS_BAD_NETWORK_PATH;
+		rsp->hdr.Status = STATUS_BAD_NETWORK_NAME;
 		break;
 	case -ENOMEM:
 	case KSMBD_TREE_CONN_STATUS_NOMEM:
Signature · 1 line
2.25.1
Reviewed-by on v1 1/1
#1 lore raw

2022년 8월 8일 (월) 오후 9:57, Namjae Jeon <[email protected]>님이 작성:

Quoted 5 lines

If share is not configured in smb.conf, smb2 tree connect should return STATUS_BAD_NETWORK_NAME instead of STATUS_BAD_NETWORK_PATH.

Quoted 36 lines
---
 fs/ksmbd/mgmt/tree_connect.c | 2 +-
 fs/ksmbd/smb2pdu.c           | 3 ++-
 2 files changed, 3 insertions(+), 2 deletions(-)
fs/ksmbd/mgmt/tree_connect.c +1 -1
index b35ea6a6abc5..dd262daa2c4a 100644
@@ -19,7 +19,7 @@ struct ksmbd_tree_conn_status
 ksmbd_tree_conn_connect(struct ksmbd_conn *conn, struct ksmbd_session *sess,
                        char *share_name)
 {
-       struct ksmbd_tree_conn_status status = {-EINVAL, NULL};
+       struct ksmbd_tree_conn_status status = {-ENOENT, NULL};
        struct ksmbd_tree_connect_response *resp = NULL;
        struct ksmbd_share_config *sc;
        struct ksmbd_tree_connect *tree_conn = NULL;
fs/ksmbd/smb2pdu.c +2 -2
index 4c3c840df455..d478c3ea4215 100644
@@ -1944,8 +1944,9 @@ int smb2_tree_connect(struct ksmbd_work *work)
                rsp->hdr.Status = STATUS_SUCCESS;
                rc = 0;
                break;
+       case -ENOENT:
        case KSMBD_TREE_CONN_STATUS_NO_SHARE:
-               rsp->hdr.Status = STATUS_BAD_NETWORK_PATH;
+               rsp->hdr.Status = STATUS_BAD_NETWORK_NAME;
                break;
        case -ENOMEM:
        case KSMBD_TREE_CONN_STATUS_NOMEM:
--

2.25.1

Signature · 2 lines
Thanks,
Hyunchul