Skip to contentSkip to conversation

documentation-mm-prefer-kmap_local_page-and-avoid-kmap.patch removed from -mm tree

merged mm-stable Andrew Morton 1 participant 1 message Aug 9, 2022

lore
Share & tools
lore

Andrew Morton

author tree notice Applied
#0 lore raw

The quilt patch titled
Subject: Documentation/mm: rrefer kmap_local_page() and avoid kmap()
has been removed from the -mm tree. Its filename was
documentation-mm-prefer-kmap_local_page-and-avoid-kmap.patch

This patch was dropped because it was merged into the mm-stable branch of git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm

------------------------------------------------------
From: "Fabio M. De Francesco" <[email protected]>
Subject: Documentation/mm: rrefer kmap_local_page() and avoid kmap()
Date: Thu, 28 Jul 2022 17:48:42 +0200

The reasoning for converting kmap() to kmap_local_page() was questioned recently.[1]

There are two main problems with kmap(): (1) It comes with an overhead as mapping space is restricted and protected by a global lock for synchronization and (2) kmap() also requires global TLB invalidation when its pool wraps and it might block when the mapping space is fully utilized until a slot becomes available.

Warn users to avoid the use of kmap() and instead use kmap_local_page(), by designing their code to map pages in the same context the mapping will be used.

[1] https://lore.kernel.org/lkml/1891319.taCxCBeP46@opensuse/

Cc Matthew Wilcox (Oracle) <[email protected]>
Cc Mike Rapoport <[email protected]>
Cc Sebastian Andrzej Siewior <[email protected]>
Cc Thomas Gleixner <[email protected]>
Cc Catalin Marinas <[email protected]>
Cc Jonathan Corbet <[email protected]>
Cc Peter Collingbourne <[email protected]>
Cc Vlastimil Babka <[email protected]>
Cc Will Deacon <[email protected]>

---

 Documentation/mm/highmem.rst |    5 +++++
 1 file changed, 5 insertions(+)
Documentation/mm/highmem.rst renamed from Documentation/mm/highmem.rst~documentation-mm-prefer-kmap_local_page-and-avoid-kmap +5 -0
@@ -84,6 +84,11 @@ list shows them in order of preference o
   be absolutely sure to keep the use of the return address local to the
   thread which mapped it.
 
+  Most code can be designed to use thread local mappings. User should
+  therefore try to design their code to avoid the use of kmap() by mapping
+  pages in the same thread the address will be used and prefer
+  kmap_local_page().
+
   Nesting kmap_local_page() and kmap_atomic() mappings is allowed to a certain
   extent (up to KMAP_TYPE_NR) but their invocations have to be strictly ordered
   because the map implementation is stack based. See kmap_local_page() kdocs

_

Patches currently in -mm which might be from [email protected] are