Convert Aspeed SCU to DT schema
Subsystems (7)
Rob Herring
maintainercover Convert Aspeed SCU to DT schema
This short series converts the aspeed,ast2x00-scu binding to DT schema. The binding is already in use in examples which unsurprisingly need fixes with the schema added.
If someone wants to convert the remaining child node bindings, that would be nice.
This is part of getting rid of the remaining ~40 cases of compatibles without a schema in the examples.
Rob
Rob Herring (2):
dt-bindings: pinctrl: aspeed: Add missing properties to examples
dt-bindings: mfd: aspeed,ast2x00-scu: Convert to DT schema format
.../bindings/mfd/aspeed,ast2x00-scu.yaml | 110 ++++++++++++++++++ .../devicetree/bindings/mfd/aspeed-scu.txt | 48 -------- .../pinctrl/aspeed,ast2400-pinctrl.yaml | 6 + .../pinctrl/aspeed,ast2500-pinctrl.yaml | 4 + .../pinctrl/aspeed,ast2600-pinctrl.yaml | 6 + 5 files changed, 126 insertions(+), 48 deletions(-) create mode 100644 Documentation/devicetree/bindings/mfd/aspeed,ast2x00-scu.yaml delete mode 100644 Documentation/devicetree/bindings/mfd/aspeed-scu.txt
--
2.34.1
Rob Herring
maintainerPATCH 1/2 dt-bindings: pinctrl: aspeed: Add missing properties to examples
The aspeed pinctrl parent node (SCU) in the examples is missing various properties. Add the properties in preparation for the SCU schema.
--- .../devicetree/bindings/pinctrl/aspeed,ast2400-pinctrl.yaml | 6 ++++++ .../devicetree/bindings/pinctrl/aspeed,ast2500-pinctrl.yaml | 4 ++++ .../devicetree/bindings/pinctrl/aspeed,ast2600-pinctrl.yaml | 6 ++++++ 3 files changed, 16 insertions(+)
Documentation/devicetree/bindings/pinctrl/aspeed,ast2400-pinctrl.yaml +6 -0
@@ -63,6 +63,12 @@ examples: syscon: scu at 1e6e2000 { compatible = "aspeed,ast2400-scu", "syscon", "simple-mfd"; reg = <0x1e6e2000 0x1a8>; + #clock-cells = <1>; + #reset-cells = <1>; + + #address-cells = <1>; + #size-cells = <1>; + ranges = <0x0 0x1e6e2000 0x1000>; pinctrl: pinctrl { compatible = "aspeed,ast2400-pinctrl";
Documentation/devicetree/bindings/pinctrl/aspeed,ast2500-pinctrl.yaml +4 -0
@@ -82,6 +82,10 @@ examples: #clock-cells = <1>; #reset-cells = <1>; + #address-cells = <1>; + #size-cells = <1>; + ranges = <0x0 0x1e6e2000 0x1000>; + pinctrl: pinctrl { compatible = "aspeed,ast2500-pinctrl"; aspeed,external-nodes = <&gfx>, <&lhc>;
Documentation/devicetree/bindings/pinctrl/aspeed,ast2600-pinctrl.yaml +6 -0
@@ -96,6 +96,12 @@ examples: syscon: scu at 1e6e2000 { compatible = "aspeed,ast2600-scu", "syscon", "simple-mfd"; reg = <0x1e6e2000 0xf6c>; + #clock-cells = <1>; + #reset-cells = <1>; + + #address-cells = <1>; + #size-cells = <1>; + ranges = <0x0 0x1e6e2000 0x1000>; pinctrl: pinctrl { compatible = "aspeed,ast2600-pinctrl";
Signature · 1 line
2.34.1
Rob Herring
maintainerPATCH 2/2 dt-bindings: mfd: aspeed,ast2x00-scu: Convert to DT schema format
In reply to Rob HerringConvert the aspeed,ast2[456]00-scu binding to DT schema format.
The original binding was missing '#address-cells', '#size-cells', 'ranges', and child nodes, so add them.
--- .../bindings/mfd/aspeed,ast2x00-scu.yaml | 110 ++++++++++++++++++ .../devicetree/bindings/mfd/aspeed-scu.txt | 48 -------- 2 files changed, 110 insertions(+), 48 deletions(-) create mode 100644 Documentation/devicetree/bindings/mfd/aspeed,ast2x00-scu.yaml delete mode 100644 Documentation/devicetree/bindings/mfd/aspeed-scu.txt
Documentation/devicetree/bindings/mfd/aspeed,ast2x00-scu.yaml new file +110 -0
@@ -0,0 +1,110 @@ +# SPDX-License-Identifier: GPL-2.0 +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/mfd/aspeed,ast2x00-scu.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Aspeed System Control Unit + +description: + The Aspeed System Control Unit manages the global behaviour of the SoC, + configuring elements such as clocks, pinmux, and reset. + +maintainers: + - Joel Stanley <[email protected]> + - Andrew Jeffery <[email protected]> + +properties: + compatible: + items: + - enum: + - aspeed,ast2400-scu + - aspeed,ast2500-scu + - aspeed,ast2600-scu + - const: syscon + - const: simple-mfd + + reg: + maxItems: 1 + + ranges: true + + '#address-cells': + const: 1 + + '#size-cells': + const: 1 + + '#clock-cells': + const: 1 + + '#reset-cells': + const: 1 + +patternProperties: + '^p2a-control@[0-9a-f]+$': + description: See Documentation/devicetree/bindings/misc/aspeed-p2a-ctrl.txt + type: object + + '^pinctrl(@[0-9a-f]+)?$': + oneOf: + - $ref: /schemas/pinctrl/aspeed,ast2400-pinctrl.yaml + - $ref: /schemas/pinctrl/aspeed,ast2500-pinctrl.yaml + - $ref: /schemas/pinctrl/aspeed,ast2600-pinctrl.yaml + + '^interrupt-controller@[0-9a-f]+$': + description: See Documentation/devicetree/bindings/interrupt-controller/aspeed,ast2xxx-scu-ic.txt + type: object + + '^silicon-id@[0-9a-f]+$': + description: Unique hardware silicon identifiers within the SoC + type: object + additionalProperties: false + + properties: + compatible: + items: + - enum: + - aspeed,ast2400-silicon-id + - aspeed,ast2500-silicon-id + - aspeed,ast2600-silicon-id + - const: aspeed,silicon-id + + reg: + description: + The reg should be the unique silicon id register, and not backwards + compatible one in eg. the 2600. + minItems: 1 + items: + - description: silicon id information registers + - description: unique chip id registers + +required: + - compatible + - reg + - ranges + - '#address-cells' + - '#size-cells' + - '#clock-cells' + - '#reset-cells' + +additionalProperties: false + +examples: + - | + syscon at 1e6e2000 { + compatible = "aspeed,ast2400-scu", "syscon", "simple-mfd"; + reg = <0x1e6e2000 0x1a8>; + #clock-cells = <1>; + #reset-cells = <1>; + + #address-cells = <1>; + #size-cells = <1>; + ranges = <0x0 0x1e6e2000 0x1000>; + + silicon-id at 7c { + compatible = "aspeed,ast2500-silicon-id", "aspeed,silicon-id"; + reg = <0x7c 0x4>, <0x150 0x8>; + }; + }; +...
Documentation/devicetree/bindings/mfd/aspeed-scu.txt deleted +0 -48
48 lines not on this page · raw message
Signature · 1 line
2.34.1
Re: [PATCH 2/2] dt-bindings: mfd: aspeed,ast2x00-scu: Convert to DT schema format
Quoted 6 lines · Rob Herring
Convert the aspeed,ast2[456]00-scu binding to DT schema format.
The original binding was missing '#address-cells', '#size-cells', 'ranges', and child nodes, so add them.
Signed-off-by Rob Herring <[email protected]>
Best regards,
Krzysztof
Re: [PATCH 2/2] dt-bindings: mfd: aspeed,ast2x00-scu: Convert to DT schema format
In reply to Rob HerringQuoted 5 lines · Rob Herring
Convert the aspeed,ast2[456]00-scu binding to DT schema format.
The original binding was missing '#address-cells', '#size-cells', 'ranges', and child nodes, so add them.
Quoted 7 lines
Signed-off-by Rob Herring <[email protected]>--- .../bindings/mfd/aspeed,ast2x00-scu.yaml | 110 ++++++++++++++++++ .../devicetree/bindings/mfd/aspeed-scu.txt | 48 -------- 2 files changed, 110 insertions(+), 48 deletions(-) create mode 100644 Documentation/devicetree/bindings/mfd/aspeed,ast2x00-scu.yaml delete mode 100644 Documentation/devicetree/bindings/mfd/aspeed-scu.txt
Applied, thanks.
Signature · 1 line
Lee Jones [???]
Re: [PATCH 1/2] dt-bindings: pinctrl: aspeed: Add missing properties to examples
In reply to Rob HerringQuoted 4 lines · Rob Herring
The aspeed pinctrl parent node (SCU) in the examples is missing various properties. Add the properties in preparation for the SCU schema.
Signed-off-by Rob Herring <[email protected]>
I see Lee applied 2/2 to the MFD tree so I applied this to the pinctrl tree.
Yours,
Linus Walleij