ALSA: hda: cs35l41: Clarify support for CSC3551 without _DSD Properties
PATCH 1/1 ALSA: hda: cs35l41: Clarify support for CSC3551 without _DSD Properties
For devices which use HID CSC3551, correct ACPI _DSD properties are required to be able support those systems.
Add error message to clarify this.
Signed-off-by Stefan Binding <[email protected]>
--- sound/pci/hda/cs35l41_hda.c | 5 +++++ 1 file changed, 5 insertions(+)
sound/pci/hda/cs35l41_hda.c +5 -0
@@ -1163,6 +1163,11 @@ static int cs35l41_no_acpi_dsd(struct cs35l41_hda *cs35l41, struct device *physd hw_cfg->gpio1.func = CS35l41_VSPK_SWITCH; hw_cfg->gpio1.valid = true; }else { +/* +* Note: CLSA010(0/1) are special cases which use a slightly different design. +* All other HIDs e.g. CSC3551 require valid ACPI _DSD properties to be supported. +*/ +dev_err (cs35l41->dev,"Error: ACPI _DSD Properties are missing for HID %s." , hid); hw_cfg->valid = false; hw_cfg->gpio1.valid = false; hw_cfg->gpio2.valid = false;
Signature · 1 line
2.34.1
Quoted 15 lines · Stefan Binding
For devices which use HID CSC3551, correct ACPI
_DSDproperties are required to be able support those systems.
Add error message to clarify this.Signed-off-by Stefan Binding <[email protected]>--- sound/pci/hda/cs35l41_hda.c | 5 +++++ 1 file changed, 5 insertions(+)sound/pci/hda/cs35l41_hda.c +0
-0
sound/pci/hda/cs35l41_hda.c static int cs35l41_no_acpi_dsd(struct cs35l41_hda *cs35l41, struct device *physd · line 1170
Quoted 8 lines
sound/pci/hda/cs35l41_hda.c +5
-0@@ -1163,6 +1163,11 @@ static int cs35l41_no_acpi_dsd(struct cs35l41_hda *cs35l41, struct device *physd hw_cfg->gpio1.func = CS35l41_VSPK_SWITCH; hw_cfg->gpio1.valid = true; }else { +/* +* Note: CLSA010(0/1) are special cases which use a slightly different design. +* All other HIDs e.g. CSC3551 require valid ACPI _DSD properties to be supported. +*/ +dev_err (cs35l41->dev,"Error: ACPI _DSD Properties are missing for HID %s." , hid);
A newline is missing at the end of the string?
Takashi