Remove Unnecessary TODO
PATCH v2 1/1 Remove Unnecessary TODO
The capabilities enabled for multi-link are required as part of the programming sequences, even when a stream uses a single link we still use the syncArm/syncGo sequences. Therefore the TODO is no longer necessary.
---
Previous discussions:
- v1 Link: https://lore.kernel.org/lkml/[email protected]/
Changes since v1:
- Remove the todo, leave rest of the code as is
- Update commit message
drivers/soundwire/bus.c | 1 - 1 file changed, 1 deletion(-)
drivers/soundwire/bus.c +0 -1
@@ -75,7 +75,6 @@ int sdw_bus_master_add(struct sdw_bus *bus, struct device *parent,/* * Initialize multi_link flag -* TODO: populate this flag by reading property from FW node */ bus->multi_link = false;if (bus->ops->read_prop) {
Signature · 1 line
2.37.1
Quoted 7 lines · Khalid Masum
The capabilities enabled for multi-link are required as part of the programming sequences, even when a stream uses a single link we still use the syncArm/syncGo sequences. Therefore the TODO is no longer necessary.
Suggested-by Pierre-Louis Bossart <[email protected]>Signed-off-by Khalid Masum <[email protected]>
the title of your patch should be something like
soundwire: intel: remove unnecessary TODO
so that the patch scope and context is clearly identified.
Quoted 23 lines
---
Previous discussions:
- v1 Link: https://lore.kernel.org/lkml/[email protected]/Changes since v1:
- Remove the todo, leave rest of the code as is
- Update commit messagedrivers/soundwire/bus.c | 1 - 1 file changed, 1 deletion(-)drivers/soundwire/bus.c +0
-1@@ -75,7 +75,6 @@ int sdw_bus_master_add(struct sdw_bus *bus, struct device *parent,/* * Initialize multi_link flag -* TODO: populate this flag by reading property from FW node */ bus->multi_link = false;if (bus->ops->read_prop) {
Quoted 8 lines · Pierre-Louis Bossart
Quoted 5 lines · Khalid Masum
The capabilities enabled for multi-link are required as part of the programming sequences, even when a stream uses a single link we still use the syncArm/syncGo sequences. Therefore the TODO is no longer necessary.
Quoted 7 lines
Quoted 2 lines
Suggested-by Pierre-Louis Bossart <[email protected]>Signed-off-by Khalid Masum <[email protected]>the title of your patch should be something like
soundwire: intel: remove unnecessary TODO
You are right. I shall send the patch with the title fixed soon.
-- Khalid Masum