Skip to contentSkip to conversation

.gitlab-ci.d/buildtest.yml: Increase the check-gprof-gcov job timeout

PATCH In review Bin Meng 3 participants 5 messages Aug 17, 2022 – Aug 19, 2022

lore
Share & tools
lore

Bin Meng

author
#0 lore raw

PATCH 1/1 .gitlab-ci.d/buildtest.yml: Increase the check-gprof-gcov job timeout

Current project timeout is 1 hour, but the check-gprof-gcov job never completes within 1 hour. Increase the job timeout to 90 minutes.

---

 .gitlab-ci.d/buildtest.yml | 1 +
 1 file changed, 1 insertion(+)
.gitlab-ci.d/buildtest.yml +1 -0
index 1931b77b49..52d45508fb 100644
@@ -495,6 +495,7 @@ check-gprof-gcov:
   variables:
     IMAGE: ubuntu2004
     MAKE_CHECK_ARGS: check
+  timeout: 90m
   after_script:
     - ${CI_PROJECT_DIR}/scripts/ci/coverage-summary.sh
 
Signature · 1 line
2.34.1
#1 lore raw
Quoted 14 lines · Bin Meng

Current project timeout is 1 hour, but the check-gprof-gcov job never completes within 1 hour. Increase the job timeout to 90 minutes.

---

  .gitlab-ci.d/buildtest.yml | 1 +
  1 file changed, 1 insertion(+)
.gitlab-ci.d/buildtest.yml +0 -0
index 1931b77b49..52d45508fb 100644

.gitlab-ci.d/buildtest.yml check-gprof-gcov: · line 500

Quoted 6 lines
.gitlab-ci.d/buildtest.yml +1 -0
@@ -495,6 +495,7 @@ check-gprof-gcov:
    variables:
      IMAGE: ubuntu2004
      MAKE_CHECK_ARGS: check
+  timeout: 90m
    after_script:
      - ${CI_PROJECT_DIR}/scripts/ci/coverage-summary.sh

Thanks, I think we could use this as a workaround ... for tackling the real problem, we have to figure out a way to speed up the migration tests in the CI, see:

https://lists.gnu.org/archive/html/qemu-devel/2022-08/msg01219.html

Thomas

#2 lore raw
In reply to Bin Meng
Quoted 2 lines · Bin Meng

Current project timeout is 1 hour, but the check-gprof-gcov job never completes within 1 hour. Increase the job timeout to 90 minutes.

I've tried to do some data mining on this test which seems to indicate that the average successful completion time for gprof-gcov is 27 mins. So it seems the sometimes *something* causes it to run a lot more slowly. I wonder if increasing the timeout just masks the problem?

Quoted 18 lines

---

 .gitlab-ci.d/buildtest.yml | 1 +
 1 file changed, 1 insertion(+)
.gitlab-ci.d/buildtest.yml +1 -0
index 1931b77b49..52d45508fb 100644
@@ -495,6 +495,7 @@ check-gprof-gcov:
   variables:
     IMAGE: ubuntu2004
     MAKE_CHECK_ARGS: check
+  timeout: 90m
   after_script:
     - ${CI_PROJECT_DIR}/scripts/ci/coverage-summary.sh
Signature · 1 line
Alex Bennée
#3 lore raw
Quoted 10 lines · Alex Bennée
Quoted 2 lines · Bin Meng

Current project timeout is 1 hour, but the check-gprof-gcov job never completes within 1 hour. Increase the job timeout to 90 minutes.

I've tried to do some data mining on this test which seems to indicate that the average successful completion time for gprof-gcov is 27 mins. So it seems the sometimes *something* causes it to run a lot more slowly. I wonder if increasing the timeout just masks the problem?

I think it's very certainly the migration test that is causing the timeout now. In former times, the test was skipped, see e.g.:

https://gitlab.com/qemu-project/qemu/-/jobs/2795092179#L48

Since commit 2649a72555e the tests are run and take ca. 2 * 20 minutes:

https://gitlab.com/qemu-project/qemu/-/jobs/2798625330#L48

That's why I started a discussion here for how to reduce the amount of time of the migration tests in the CI:

https://lists.gnu.org/archive/html/qemu-devel/2022-08/msg01219.html

Thomas

#4 lore raw
Quoted 16 lines · Thomas Huth
Quoted 9 lines · Alex Bennée
Quoted 2 lines · Bin Meng

Current project timeout is 1 hour, but the check-gprof-gcov job never completes within 1 hour. Increase the job timeout to 90 minutes.

I've tried to do some data mining on this test which seems to indicate
that the average successful completion time for gprof-gcov is 27 mins. So it seems the sometimes *something* causes it to run a lot more slowly. I wonder if increasing the timeout just masks the problem?

I think it's very certainly the migration test that is causing the timeout now. In former times, the test was skipped, see e.g.:

https://gitlab.com/qemu-project/qemu/-/jobs/2795092179#L48

Quoted 8 lines

Since commit 2649a72555e the tests are run and take ca. 2 * 20 minutes:

https://gitlab.com/qemu-project/qemu/-/jobs/2798625330#L48

That's why I started a discussion here for how to reduce the amount of time of the migration tests in the CI:

https://lists.gnu.org/archive/html/qemu-devel/2022-08/msg01219.html

OK I have queued to this patch to testing/next while the discussion is had. I'll update the commit message.

Signature · 1 line
Alex Bennée