powerpc/boot: Fix compilation of uImage for e500 platforms
PATCH 1/1 powerpc/boot: Fix compilation of uImage for e500 platforms
Commit 40a75584e526 ("powerpc/boot: Build wrapper for an appropriate CPU") broke compilation of uImage target for mpc85xx platforms by powerpc e500 SPE capable cross compilers. After that commit build process throws error:
BOOTAS arch/powerpc/boot/crt0.o
powerpc-linux-gnuspe-gcc: error: unrecognized argument in option ‘-mcpu=powerpc’
powerpc-linux-gnuspe-gcc: note: valid arguments to ‘-mcpu=’ are: 8540 8548 native make[1]: *** [arch/powerpc/boot/Makefile:231: arch/powerpc/boot/crt0.o] Error 1
Fix this issue by checking for CONFIG_PPC_E500MC / CONFIG_E500 options and applying appropriate -mcpu options for building uImage boot code.
--- arch/powerpc/boot/Makefile | 6 ++++++ 1 file changed, 6 insertions(+)
arch/powerpc/boot/Makefile +6 -0
@@ -44,8 +44,14 @@ else BOOTCFLAGS += -m64 -mcpu=powerpc64 endif else +ifdef CONFIG_PPC_E500MC +BOOTCFLAGS += -m32 $(call cc-option,-mcpu=e500mc,-mcpu=powerpc) +else ifdef CONFIG_E500 +BOOTCFLAGS += -m32 $(call cc-option,-mcpu=8540 -msoft-float,-mcpu=powerpc) +else BOOTCFLAGS += -m32 -mcpu=powerpc endif +endif BOOTCFLAGS += -isystem $(shell $(BOOTCC) -print-file-name=include)
Signature · 1 line
2.20.1
Le 20/08/2022 à 12:52, Pali Rohár a écrit :
Quoted 11 lines
Commit
40a75584e526("powerpc/boot: Build wrapper for an appropriate CPU") broke compilation of uImage target for mpc85xx platforms by powerpc e500 SPE capable cross compilers. After that commit build process throws error:BOOTAS
arch/powerpc/boot/crt0.o
powerpc-linux-gnuspe-gcc: error: unrecognized argument in option ‘-mcpu=powerpc’
powerpc-linux-gnuspe-gcc: note: valid arguments to ‘-mcpu=’ are: 8540 8548 native make[1]: *** [arch/powerpc/boot/Makefile:231:arch/powerpc/boot/crt0.o] Error 1Fix this issue by checking for
CONFIG_PPC_E500MC/CONFIG_E500options and applying appropriate -mcpu options for building uImage boot code.
This is very specific to e500, could you instead do something using CONFIG_TARGET_CPU, just like commit 446cda1b21d9 ("powerpc/32: Don't always pass -mcpu=powerpc to the compiler")
Thanks
Christophe
Quoted 27 lines
Fixes 40a75584e526 ("powerpc/boot: Build wrapper for an appropriate CPU")Signed-off-by Pali Rohár <[email protected]>--- arch/powerpc/boot/Makefile | 6 ++++++ 1 file changed, 6 insertions(+)arch/powerpc/boot/Makefile +6
-0@@ -44,8 +44,14 @@ else BOOTCFLAGS += -m64 -mcpu=powerpc64 endif else +ifdef CONFIG_PPC_E500MC +BOOTCFLAGS += -m32 $(call cc-option,-mcpu=e500mc,-mcpu=powerpc) +else ifdef CONFIG_E500 +BOOTCFLAGS += -m32 $(call cc-option,-mcpu=8540 -msoft-float,-mcpu=powerpc) +else BOOTCFLAGS += -m32 -mcpu=powerpc endif +endif BOOTCFLAGS += -isystem $(shell $(BOOTCC) -print-file-name=include)
Quoted 10 lines · On Tuesday 23 August 2022 16:57:34 Christophe Leroy wrote:
Le 20/08/2022 à 12:52, Pali Rohár a écrit :
Quoted 9 lines
Commit
40a75584e526("powerpc/boot: Build wrapper for an appropriate CPU") broke compilation of uImage target for mpc85xx platforms by powerpc e500 SPE capable cross compilers. After that commit build process throws error:BOOTAS
arch/powerpc/boot/crt0.o
powerpc-linux-gnuspe-gcc: error: unrecognized argument in option ‘-mcpu=powerpc’
powerpc-linux-gnuspe-gcc: note: valid arguments to ‘-mcpu=’ are: 8540 8548 native make[1]: *** [arch/powerpc/boot/Makefile:231:arch/powerpc/boot/crt0.o] Error 1
Quoted 6 lines
Quoted 2 lines
Fix this issue by checking for
CONFIG_PPC_E500MC/CONFIG_E500options and applying appropriate -mcpu options for building uImage boot code.This is very specific to e500, could you instead do something using
CONFIG_TARGET_CPU, just like commit446cda1b21d9("powerpc/32: Don't always pass -mcpu=powerpc to the compiler")
Ok, What about this change?
arch/powerpc/boot/Makefile +9 -0
@@ -34,6 +34,7 @@ endif BOOTCFLAGS := -Wall -Wundef -Wstrict-prototypes -Wno-trigraphs \ -fno-strict-aliasing -O2 -msoft-float -mno-altivec -mno-vsx \ + $(call cc-option,-mno-spe) $(call cc-option,-mspe=no) \ -pipe -fomit-frame-pointer -fno-builtin -fPIC -nostdinc \ $(LINUXINCLUDE)
@@ -44,8 +45,16 @@ else BOOTCFLAGS += -m64 -mcpu=powerpc64 endif else +ifdef CONFIG_PPC32 +ifdef CONFIG_TARGET_CPU_BOOL +BOOTCFLAGS += -m32 -mcpu=$(CONFIG_TARGET_CPU) +else +BOOTCFLAGS += -m32 -mcpu=powerpc +endif +else BOOTCFLAGS += -m32 -mcpu=powerpc endif +endif BOOTCFLAGS += -isystem $(shell $(BOOTCC) -print-file-name=include)
Quoted 31 lines
Thanks
ChristopheQuoted 27 lines
Fixes 40a75584e526 ("powerpc/boot: Build wrapper for an appropriate CPU")Signed-off-by Pali Rohár <[email protected]>--- arch/powerpc/boot/Makefile | 6 ++++++ 1 file changed, 6 insertions(+)arch/powerpc/boot/Makefile +6
-0@@ -44,8 +44,14 @@ else BOOTCFLAGS += -m64 -mcpu=powerpc64 endif else +ifdef CONFIG_PPC_E500MC +BOOTCFLAGS += -m32 $(call cc-option,-mcpu=e500mc,-mcpu=powerpc) +else ifdef CONFIG_E500 +BOOTCFLAGS += -m32 $(call cc-option,-mcpu=8540 -msoft-float,-mcpu=powerpc) +else BOOTCFLAGS += -m32 -mcpu=powerpc endif +endif BOOTCFLAGS += -isystem $(shell $(BOOTCC) -print-file-name=include)
PATCH v2 1/1 powerpc/boot: Don't always pass -mcpu=powerpc when building 32-bit uImage
In reply to Pali RohárFor 32-bit uImage try to use CONFIG_TARGET_CPU option for -mcpu. This fixes following compiler error when building kernel with powerpc e500 SPE capable cross compilers:
BOOTAS arch/powerpc/boot/crt0.o
powerpc-linux-gnuspe-gcc: error: unrecognized argument in option ‘-mcpu=powerpc’
powerpc-linux-gnuspe-gcc: note: valid arguments to ‘-mcpu=’ are: 8540 8548 native make[1]: *** [arch/powerpc/boot/Makefile:231: arch/powerpc/boot/crt0.o] Error 1
For 64-bit uImage and 64-bit kernels with 32-bit uImage wrapper there is no change.
Similar change was already introduced for the main powerpc Makefile in commit 446cda1b21d9 ("powerpc/32: Don't always pass -mcpu=powerpc to the compiler").
--- arch/powerpc/boot/Makefile | 8 ++++++++ 1 file changed, 8 insertions(+)
arch/powerpc/boot/Makefile +8 -0
@@ -44,8 +44,16 @@ else BOOTCFLAGS += -m64 -mcpu=powerpc64 endif else +ifdef CONFIG_PPC32 +ifdef CONFIG_TARGET_CPU_BOOL +BOOTCFLAGS += -m32 -mcpu=$(CONFIG_TARGET_CPU) +else +BOOTCFLAGS += -m32 -mcpu=powerpc +endif +else BOOTCFLAGS += -m32 -mcpu=powerpc endif +endif BOOTCFLAGS += -isystem $(shell $(BOOTCC) -print-file-name=include)
Signature · 1 line
2.20.1
Re: [PATCH v2] powerpc/boot: Don't always pass -mcpu=powerpc when building 32-bit uImage
Le 27/08/2022 à 15:39, Pali Rohár a écrit :
Quoted 28 lines
For 32-bit uImage try to use
CONFIG_TARGET_CPUoption for -mcpu. This fixes following compiler error when building kernel with powerpc e500 SPE capable cross compilers:BOOTAS
arch/powerpc/boot/crt0.o
powerpc-linux-gnuspe-gcc: error: unrecognized argument in option ‘-mcpu=powerpc’
powerpc-linux-gnuspe-gcc: note: valid arguments to ‘-mcpu=’ are: 8540 8548 native make[1]: *** [arch/powerpc/boot/Makefile:231:arch/powerpc/boot/crt0.o] Error 1For 64-bit uImage and 64-bit kernels with 32-bit uImage wrapper there is no change.
Similar change was already introduced for the main powerpc
Makefilein commit446cda1b21d9("powerpc/32: Don't always pass -mcpu=powerpc to the compiler").Fixes 40a75584e526 ("powerpc/boot: Build wrapper for an appropriate CPU")Signed-off-by Pali Rohár <[email protected]>--- arch/powerpc/boot/Makefile | 8 ++++++++ 1 file changed, 8 insertions(+)arch/powerpc/boot/Makefile +0
-0
arch/powerpc/boot/Makefile else · line 51
Quoted 8 lines
arch/powerpc/boot/Makefile +5
-0@@ -44,8 +44,16 @@ else BOOTCFLAGS += -m64 -mcpu=powerpc64 endif else +ifdef CONFIG_PPC32 +ifdef CONFIG_TARGET_CPU_BOOL +BOOTCFLAGS += -m32 -mcpu=$(CONFIG_TARGET_CPU) +else +BOOTCFLAGS += -m32 -mcpu=powerpc
You can't do that. You get here only if user has selected TOOLCHAIN_DEFAULT_CPU, in which case you don't want to for -mcpu=powerpc.
-mcpu=powerpc is set when user selects CONFIG_POWERPC_CPU, in which case CONFIG_TARGET_CPU_BOOL is set as well.
arch/powerpc/boot/Makefile else · line 54
Quoted 3 lines
arch/powerpc/boot/Makefile +2
-0+endif +else BOOTCFLAGS += -m32 -mcpu=powerpc
Same, for PPC64 I think you don't want that either, unless the CONFIG_GENERIC_CPU has been selected in which case CONFIG_TARGET_CPU_BOOL is not set.
When CONFIG_TARGET_CPU_BOOL is set for PPC64 you also want -mcpu=$(CONFIG_TARGET_CPU)
Quoted 5 lines
arch/powerpc/boot/Makefile +1
-0endif +endif BOOTCFLAGS += -isystem $(shell $(BOOTCC) -print-file-name=include)
Re: [PATCH v2] powerpc/boot: Don't always pass -mcpu=powerpc when building 32-bit uImage
Quoted 24 lines · On Saturday 27 August 2022 17:31:10 Christophe Leroy wrote:
Le 27/08/2022 à 15:39, Pali Rohár a écrit :
Quoted 23 lines
For 32-bit uImage try to use
CONFIG_TARGET_CPUoption for -mcpu. This fixes following compiler error when building kernel with powerpc e500 SPE capable cross compilers:BOOTAS
arch/powerpc/boot/crt0.o
powerpc-linux-gnuspe-gcc: error: unrecognized argument in option ‘-mcpu=powerpc’
powerpc-linux-gnuspe-gcc: note: valid arguments to ‘-mcpu=’ are: 8540 8548 native make[1]: *** [arch/powerpc/boot/Makefile:231:arch/powerpc/boot/crt0.o] Error 1For 64-bit uImage and 64-bit kernels with 32-bit uImage wrapper there is no change.
Similar change was already introduced for the main powerpc
Makefilein commit446cda1b21d9("powerpc/32: Don't always pass -mcpu=powerpc to the compiler").Fixes 40a75584e526 ("powerpc/boot: Build wrapper for an appropriate CPU")Signed-off-by Pali Rohár <[email protected]>--- arch/powerpc/boot/Makefile | 8 ++++++++ 1 file changed, 8 insertions(+)
Quoted 16 lines
arch/powerpc/boot/Makefile else · line 51
Quoted 13 lines
arch/powerpc/boot/Makefile +5
-0@@ -44,8 +44,16 @@ else BOOTCFLAGS += -m64 -mcpu=powerpc64 endif else +ifdef CONFIG_PPC32 +ifdef CONFIG_TARGET_CPU_BOOL +BOOTCFLAGS += -m32 -mcpu=$(CONFIG_TARGET_CPU) +else +BOOTCFLAGS += -m32 -mcpu=powerpcYou can't do that. You get here only if user has selected
TOOLCHAIN_DEFAULT_CPU, in which case you don't want to for -mcpu=powerpc.
So do I understand it correctly that in this branch I should omit -mcpu=powerpc?
Quoted 11 lines
-mcpu=powerpc is set when user selects
CONFIG_POWERPC_CPU, in which caseCONFIG_TARGET_CPU_BOOLis set as well.arch/powerpc/boot/Makefile else · line 54
Quoted 3 lines
arch/powerpc/boot/Makefile +2
-0+endif +else BOOTCFLAGS += -m32 -mcpu=powerpcSame, for PPC64 I think you don't want that either, unless the
CONFIG_GENERIC_CPUhas been selected in which caseCONFIG_TARGET_CPU_BOOLis not set.
Quoted 2 lines
When
CONFIG_TARGET_CPU_BOOLis set for PPC64 you also want -mcpu=$(CONFIG_TARGET_CPU)
I understand that this branch is called for PPC64 build with 32-bit uImage wrapper. So in this case should not be used TARGET_CPU as it would be 64-bit and not 32-bit as requited for 32-bit uImage wrapper.
Anyway, in this change I'm touching only PPC32 build, so all PPC64 stay as it was before.
Quoted 5 lines
Quoted 5 lines
arch/powerpc/boot/Makefile +1
-0endif +endif BOOTCFLAGS += -isystem $(shell $(BOOTCC) -print-file-name=include)
Re: [PATCH v2] powerpc/boot: Don't always pass -mcpu=powerpc when building 32-bit uImage
Le 27/08/2022 à 19:36, Pali Rohár a écrit :
Quoted 42 lines · On Saturday 27 August 2022 17:31:10 Christophe Leroy wrote:
Quoted 24 lines
Le 27/08/2022 à 15:39, Pali Rohár a écrit :
Quoted 23 lines
For 32-bit uImage try to use
CONFIG_TARGET_CPUoption for -mcpu. This fixes following compiler error when building kernel with powerpc e500 SPE capable cross compilers:BOOTAS
arch/powerpc/boot/crt0.o
powerpc-linux-gnuspe-gcc: error: unrecognized argument in option ‘-mcpu=powerpc’
powerpc-linux-gnuspe-gcc: note: valid arguments to ‘-mcpu=’ are: 8540 8548 native make[1]: *** [arch/powerpc/boot/Makefile:231:arch/powerpc/boot/crt0.o] Error 1For 64-bit uImage and 64-bit kernels with 32-bit uImage wrapper there is no change.
Similar change was already introduced for the main powerpc
Makefilein commit446cda1b21d9("powerpc/32: Don't always pass -mcpu=powerpc to the compiler").Fixes 40a75584e526 ("powerpc/boot: Build wrapper for an appropriate CPU")Signed-off-by Pali Rohár <[email protected]>--- arch/powerpc/boot/Makefile | 8 ++++++++ 1 file changed, 8 insertions(+)Quoted 16 lines
arch/powerpc/boot/Makefile else · line 51
Quoted 13 lines
arch/powerpc/boot/Makefile +5
-0@@ -44,8 +44,16 @@ else BOOTCFLAGS += -m64 -mcpu=powerpc64 endif else +ifdef CONFIG_PPC32 +ifdef CONFIG_TARGET_CPU_BOOL +BOOTCFLAGS += -m32 -mcpu=$(CONFIG_TARGET_CPU) +else +BOOTCFLAGS += -m32 -mcpu=powerpcYou can't do that. You get here only if user has selected
TOOLCHAIN_DEFAULT_CPU, in which case you don't want to for -mcpu=powerpc.
Quoted 1 line
So do I understand it correctly that in this branch I should omit -mcpu=powerpc?
Correct.
Quoted 12 lines
Quoted 12 lines
-mcpu=powerpc is set when user selects
CONFIG_POWERPC_CPU, in which caseCONFIG_TARGET_CPU_BOOLis set as well.arch/powerpc/boot/Makefile else · line 54
Quoted 3 lines
arch/powerpc/boot/Makefile +2
-0+endif +else BOOTCFLAGS += -m32 -mcpu=powerpcSame, for PPC64 I think you don't want that either, unless the
CONFIG_GENERIC_CPUhas been selected in which caseCONFIG_TARGET_CPU_BOOLis not set.
Quoted 6 lines
Quoted 2 lines
When
CONFIG_TARGET_CPU_BOOLis set for PPC64 you also want -mcpu=$(CONFIG_TARGET_CPU)I understand that this branch is called for PPC64 build with 32-bit uImage wrapper. So in this case should not be used
TARGET_CPUas it would be 64-bit and not 32-bit as requited for 32-bit uImage wrapper.
Why ?
-mcpu=e6500 -m32 works as far as I can see.
Quoted 9 lines
Anyway, in this change I'm touching only PPC32 build, so all PPC64 stay as it was before.
Quoted 5 lines
Quoted 5 lines
arch/powerpc/boot/Makefile +1
-0endif +endif BOOTCFLAGS += -isystem $(shell $(BOOTCC) -print-file-name=include)
Re: [PATCH v2] powerpc/boot: Don't always pass -mcpu=powerpc when building 32-bit uImage
Quoted 43 lines · On Saturday 27 August 2022 18:32:42 Christophe Leroy wrote:
Le 27/08/2022 à 19:36, Pali Rohár a écrit :
Quoted 42 lines · On Saturday 27 August 2022 17:31:10 Christophe Leroy wrote:
Quoted 40 lines
Le 27/08/2022 à 15:39, Pali Rohár a écrit :
Quoted 28 lines
For 32-bit uImage try to use
CONFIG_TARGET_CPUoption for -mcpu. This fixes following compiler error when building kernel with powerpc e500 SPE capable cross compilers:BOOTAS
arch/powerpc/boot/crt0.o
powerpc-linux-gnuspe-gcc: error: unrecognized argument in option ‘-mcpu=powerpc’
powerpc-linux-gnuspe-gcc: note: valid arguments to ‘-mcpu=’ are: 8540 8548 native make[1]: *** [arch/powerpc/boot/Makefile:231:arch/powerpc/boot/crt0.o] Error 1For 64-bit uImage and 64-bit kernels with 32-bit uImage wrapper there is no change.
Similar change was already introduced for the main powerpc
Makefilein commit446cda1b21d9("powerpc/32: Don't always pass -mcpu=powerpc to the compiler").Fixes 40a75584e526 ("powerpc/boot: Build wrapper for an appropriate CPU")Signed-off-by Pali Rohár <[email protected]>--- arch/powerpc/boot/Makefile | 8 ++++++++ 1 file changed, 8 insertions(+)arch/powerpc/boot/Makefile +0
-0arch/powerpc/boot/Makefile else · line 51
Quoted 8 lines
arch/powerpc/boot/Makefile +5
-0@@ -44,8 +44,16 @@ else BOOTCFLAGS += -m64 -mcpu=powerpc64 endif else +ifdef CONFIG_PPC32 +ifdef CONFIG_TARGET_CPU_BOOL +BOOTCFLAGS += -m32 -mcpu=$(CONFIG_TARGET_CPU) +else +BOOTCFLAGS += -m32 -mcpu=powerpcYou can't do that. You get here only if user has selected
TOOLCHAIN_DEFAULT_CPU, in which case you don't want to for -mcpu=powerpc.
Quoted 3 lines
Quoted 1 line
So do I understand it correctly that in this branch I should omit -mcpu=powerpc?
Correct.
Ok, I will fix it in v3.
Quoted 15 lines
Quoted 15 lines
Quoted 14 lines
-mcpu=powerpc is set when user selects
CONFIG_POWERPC_CPU, in which caseCONFIG_TARGET_CPU_BOOLis set as well.arch/powerpc/boot/Makefile else · line 54
Quoted 3 lines
arch/powerpc/boot/Makefile +2
-0+endif +else BOOTCFLAGS += -m32 -mcpu=powerpcSame, for PPC64 I think you don't want that either, unless the
CONFIG_GENERIC_CPUhas been selected in which caseCONFIG_TARGET_CPU_BOOLis not set.When
CONFIG_TARGET_CPU_BOOLis set for PPC64 you also want -mcpu=$(CONFIG_TARGET_CPU)
Quoted 7 lines
Quoted 3 lines
I understand that this branch is called for PPC64 build with 32-bit uImage wrapper. So in this case should not be used
TARGET_CPUas it would be 64-bit and not 32-bit as requited for 32-bit uImage wrapper.Why ?
-mcpu=e6500 -m32 works as far as I can see.
Hm... I did not know that. Ok, if you want I will put it into -m32 -mcpu=$(CONFIG_TARGET_CPU) branch too.
Quoted 9 lines
Quoted 9 lines
Anyway, in this change I'm touching only PPC32 build, so all PPC64 stay as it was before.
Quoted 5 lines
Quoted 5 lines
arch/powerpc/boot/Makefile +1
-0endif +endif BOOTCFLAGS += -isystem $(shell $(BOOTCC) -print-file-name=include)
Re: [PATCH v2] powerpc/boot: Don't always pass -mcpu=powerpc when building 32-bit uImage
Quoted 69 lines · On Saturday 27 August 2022 20:36:08 Pali Rohár wrote:
Quoted 43 lines · On Saturday 27 August 2022 18:32:42 Christophe Leroy wrote:
Le 27/08/2022 à 19:36, Pali Rohár a écrit :
Quoted 42 lines · On Saturday 27 August 2022 17:31:10 Christophe Leroy wrote:
Quoted 40 lines
Le 27/08/2022 à 15:39, Pali Rohár a écrit :
Quoted 28 lines
For 32-bit uImage try to use
CONFIG_TARGET_CPUoption for -mcpu. This fixes following compiler error when building kernel with powerpc e500 SPE capable cross compilers:BOOTAS
arch/powerpc/boot/crt0.o
powerpc-linux-gnuspe-gcc: error: unrecognized argument in option ‘-mcpu=powerpc’
powerpc-linux-gnuspe-gcc: note: valid arguments to ‘-mcpu=’ are: 8540 8548 native make[1]: *** [arch/powerpc/boot/Makefile:231:arch/powerpc/boot/crt0.o] Error 1For 64-bit uImage and 64-bit kernels with 32-bit uImage wrapper there is no change.
Similar change was already introduced for the main powerpc
Makefilein commit446cda1b21d9("powerpc/32: Don't always pass -mcpu=powerpc to the compiler").Fixes 40a75584e526 ("powerpc/boot: Build wrapper for an appropriate CPU")Signed-off-by Pali Rohár <[email protected]>--- arch/powerpc/boot/Makefile | 8 ++++++++ 1 file changed, 8 insertions(+)arch/powerpc/boot/Makefile +0
-0arch/powerpc/boot/Makefile else · line 51
Quoted 8 lines
arch/powerpc/boot/Makefile +5
-0@@ -44,8 +44,16 @@ else BOOTCFLAGS += -m64 -mcpu=powerpc64 endif else +ifdef CONFIG_PPC32 +ifdef CONFIG_TARGET_CPU_BOOL +BOOTCFLAGS += -m32 -mcpu=$(CONFIG_TARGET_CPU) +else +BOOTCFLAGS += -m32 -mcpu=powerpcYou can't do that. You get here only if user has selected
TOOLCHAIN_DEFAULT_CPU, in which case you don't want to for -mcpu=powerpc.Quoted 3 lines
Quoted 1 line
So do I understand it correctly that in this branch I should omit -mcpu=powerpc?
Correct.
Ok, I will fix it in v3.
Quoted 19 lines
Quoted 18 lines
Quoted 12 lines
-mcpu=powerpc is set when user selects
CONFIG_POWERPC_CPU, in which caseCONFIG_TARGET_CPU_BOOLis set as well.arch/powerpc/boot/Makefile else · line 54
Quoted 3 lines
arch/powerpc/boot/Makefile +2
-0+endif +else BOOTCFLAGS += -m32 -mcpu=powerpcSame, for PPC64 I think you don't want that either, unless the
CONFIG_GENERIC_CPUhas been selected in which caseCONFIG_TARGET_CPU_BOOLis not set.Quoted 2 lines
When
CONFIG_TARGET_CPU_BOOLis set for PPC64 you also want -mcpu=$(CONFIG_TARGET_CPU)I understand that this branch is called for PPC64 build with 32-bit uImage wrapper. So in this case should not be used
TARGET_CPUas it would be 64-bit and not 32-bit as requited for 32-bit uImage wrapper.
Quoted 6 lines
Quoted 3 lines
Why ?
-mcpu=e6500 -m32 works as far as I can see.
Hm... I did not know that. Ok, if you want I will put it into -m32 -mcpu=$(CONFIG_TARGET_CPU) branch too.
And when CONFIG_TARGET_CPU_BOOL is not set but CONFIG_PPC64_BOOT_WRAPPER is, should be -mcpu=powerpc64le or -mcpu=powerpc64 still passed?
Quoted 9 lines
Quoted 9 lines
Quoted 9 lines
Anyway, in this change I'm touching only PPC32 build, so all PPC64 stay as it was before.
Quoted 5 lines
Quoted 5 lines
arch/powerpc/boot/Makefile +1
-0endif +endif BOOTCFLAGS += -isystem $(shell $(BOOTCC) -print-file-name=include)
Re: [PATCH v2] powerpc/boot: Don't always pass -mcpu=powerpc when building 32-bit uImage
Le 27/08/2022 à 21:00, Pali Rohár a écrit :
Quoted 72 lines · On Saturday 27 August 2022 20:36:08 Pali Rohár wrote:
Quoted 71 lines · On Saturday 27 August 2022 18:32:42 Christophe Leroy wrote:
Quoted 43 lines
Le 27/08/2022 à 19:36, Pali Rohár a écrit :
Quoted 42 lines · On Saturday 27 August 2022 17:31:10 Christophe Leroy wrote:
Quoted 40 lines
Le 27/08/2022 à 15:39, Pali Rohár a écrit :
Quoted 28 lines
For 32-bit uImage try to use
CONFIG_TARGET_CPUoption for -mcpu. This fixes following compiler error when building kernel with powerpc e500 SPE capable cross compilers:BOOTAS
arch/powerpc/boot/crt0.o
powerpc-linux-gnuspe-gcc: error: unrecognized argument in option ‘-mcpu=powerpc’
powerpc-linux-gnuspe-gcc: note: valid arguments to ‘-mcpu=’ are: 8540 8548 native make[1]: *** [arch/powerpc/boot/Makefile:231:arch/powerpc/boot/crt0.o] Error 1For 64-bit uImage and 64-bit kernels with 32-bit uImage wrapper there is no change.
Similar change was already introduced for the main powerpc
Makefilein commit446cda1b21d9("powerpc/32: Don't always pass -mcpu=powerpc to the compiler").Fixes 40a75584e526 ("powerpc/boot: Build wrapper for an appropriate CPU")Signed-off-by Pali Rohár <[email protected]>--- arch/powerpc/boot/Makefile | 8 ++++++++ 1 file changed, 8 insertions(+)arch/powerpc/boot/Makefile +0
-0arch/powerpc/boot/Makefile else · line 51
Quoted 8 lines
arch/powerpc/boot/Makefile +5
-0@@ -44,8 +44,16 @@ else BOOTCFLAGS += -m64 -mcpu=powerpc64 endif else +ifdef CONFIG_PPC32 +ifdef CONFIG_TARGET_CPU_BOOL +BOOTCFLAGS += -m32 -mcpu=$(CONFIG_TARGET_CPU) +else +BOOTCFLAGS += -m32 -mcpu=powerpcYou can't do that. You get here only if user has selected
TOOLCHAIN_DEFAULT_CPU, in which case you don't want to for -mcpu=powerpc.Quoted 3 lines
Quoted 1 line
So do I understand it correctly that in this branch I should omit -mcpu=powerpc?
Correct.
Ok, I will fix it in v3.
Quoted 21 lines
Quoted 12 lines
Quoted 12 lines
-mcpu=powerpc is set when user selects
CONFIG_POWERPC_CPU, in which caseCONFIG_TARGET_CPU_BOOLis set as well.arch/powerpc/boot/Makefile else · line 54
Quoted 3 lines
arch/powerpc/boot/Makefile +2
-0+endif +else BOOTCFLAGS += -m32 -mcpu=powerpcSame, for PPC64 I think you don't want that either, unless the
CONFIG_GENERIC_CPUhas been selected in which caseCONFIG_TARGET_CPU_BOOLis not set.Quoted 6 lines
Quoted 2 lines
When
CONFIG_TARGET_CPU_BOOLis set for PPC64 you also want -mcpu=$(CONFIG_TARGET_CPU)I understand that this branch is called for PPC64 build with 32-bit uImage wrapper. So in this case should not be used
TARGET_CPUas it would be 64-bit and not 32-bit as requited for 32-bit uImage wrapper.Why ?
Quoted 7 lines
Quoted 4 lines
Quoted 1 line
-mcpu=e6500 -m32 works as far as I can see.
Hm... I did not know that. Ok, if you want I will put it into -m32 -mcpu=$(CONFIG_TARGET_CPU) branch too.
And when
CONFIG_TARGET_CPU_BOOLis not set butCONFIG_PPC64_BOOT_WRAPPERis, should be -mcpu=powerpc64le or -mcpu=powerpc64 still passed?
Not sure, so keep it like that, will change later if needed.
Quoted 10 lines
Quoted 10 lines
Quoted 10 lines
Quoted 10 lines
Anyway, in this change I'm touching only PPC32 build, so all PPC64 stay as it was before.
Quoted 5 lines
Quoted 5 lines
arch/powerpc/boot/Makefile +1
-0endif +endif BOOTCFLAGS += -isystem $(shell $(BOOTCC) -print-file-name=include)
Re: [PATCH v2] powerpc/boot: Don't always pass -mcpu=powerpc when building 32-bit uImage
Quoted 75 lines · On Sunday 28 August 2022 07:23:39 Christophe Leroy wrote:
Le 27/08/2022 à 21:00, Pali Rohár a écrit :
Quoted 74 lines · On Saturday 27 August 2022 20:36:08 Pali Rohár wrote:
Quoted 73 lines · On Saturday 27 August 2022 18:32:42 Christophe Leroy wrote:
Quoted 43 lines
Le 27/08/2022 à 19:36, Pali Rohár a écrit :
Quoted 42 lines · On Saturday 27 August 2022 17:31:10 Christophe Leroy wrote:
Quoted 40 lines
Le 27/08/2022 à 15:39, Pali Rohár a écrit :
Quoted 28 lines
For 32-bit uImage try to use
CONFIG_TARGET_CPUoption for -mcpu. This fixes following compiler error when building kernel with powerpc e500 SPE capable cross compilers:BOOTAS
arch/powerpc/boot/crt0.o
powerpc-linux-gnuspe-gcc: error: unrecognized argument in option ‘-mcpu=powerpc’
powerpc-linux-gnuspe-gcc: note: valid arguments to ‘-mcpu=’ are: 8540 8548 native make[1]: *** [arch/powerpc/boot/Makefile:231:arch/powerpc/boot/crt0.o] Error 1For 64-bit uImage and 64-bit kernels with 32-bit uImage wrapper there is no change.
Similar change was already introduced for the main powerpc
Makefilein commit446cda1b21d9("powerpc/32: Don't always pass -mcpu=powerpc to the compiler").Fixes 40a75584e526 ("powerpc/boot: Build wrapper for an appropriate CPU")Signed-off-by Pali Rohár <[email protected]>--- arch/powerpc/boot/Makefile | 8 ++++++++ 1 file changed, 8 insertions(+)arch/powerpc/boot/Makefile +0
-0arch/powerpc/boot/Makefile else · line 51
Quoted 8 lines
arch/powerpc/boot/Makefile +5
-0@@ -44,8 +44,16 @@ else BOOTCFLAGS += -m64 -mcpu=powerpc64 endif else +ifdef CONFIG_PPC32 +ifdef CONFIG_TARGET_CPU_BOOL +BOOTCFLAGS += -m32 -mcpu=$(CONFIG_TARGET_CPU) +else +BOOTCFLAGS += -m32 -mcpu=powerpcYou can't do that. You get here only if user has selected
TOOLCHAIN_DEFAULT_CPU, in which case you don't want to for -mcpu=powerpc.Quoted 3 lines
Quoted 1 line
So do I understand it correctly that in this branch I should omit -mcpu=powerpc?
Correct.
Ok, I will fix it in v3.
Quoted 22 lines
Quoted 12 lines
Quoted 12 lines
-mcpu=powerpc is set when user selects
CONFIG_POWERPC_CPU, in which caseCONFIG_TARGET_CPU_BOOLis set as well.arch/powerpc/boot/Makefile else · line 54
Quoted 3 lines
arch/powerpc/boot/Makefile +2
-0+endif +else BOOTCFLAGS += -m32 -mcpu=powerpcSame, for PPC64 I think you don't want that either, unless the
CONFIG_GENERIC_CPUhas been selected in which caseCONFIG_TARGET_CPU_BOOLis not set.Quoted 6 lines
Quoted 2 lines
When
CONFIG_TARGET_CPU_BOOLis set for PPC64 you also want -mcpu=$(CONFIG_TARGET_CPU)I understand that this branch is called for PPC64 build with 32-bit uImage wrapper. So in this case should not be used
TARGET_CPUas it would be 64-bit and not 32-bit as requited for 32-bit uImage wrapper.Why ?
-mcpu=e6500 -m32 works as far as I can see.
Quoted 7 lines
Quoted 5 lines
Quoted 2 lines
Hm... I did not know that. Ok, if you want I will put it into -m32 -mcpu=$(CONFIG_TARGET_CPU) branch too.
And when
CONFIG_TARGET_CPU_BOOLis not set butCONFIG_PPC64_BOOT_WRAPPERis, should be -mcpu=powerpc64le or -mcpu=powerpc64 still passed?Not sure, so keep it like that, will change later if needed.
Ok! Will prepare new version.
Quoted 10 lines
Quoted 10 lines
Quoted 10 lines
Quoted 10 lines
Quoted 10 lines
Anyway, in this change I'm touching only PPC32 build, so all PPC64 stay as it was before.
Quoted 5 lines
Quoted 5 lines
arch/powerpc/boot/Makefile +1
-0endif +endif BOOTCFLAGS += -isystem $(shell $(BOOTCC) -print-file-name=include)
PATCH v3 1/1 powerpc/boot: Don't always pass -mcpu=powerpc when building 32-bit uImage
In reply to Pali RohárWhen CONFIG_TARGET_CPU is specified then pass its value to the compiler -mcpu option. This fixes following build error when building kernel with powerpc e500 SPE capable cross compilers:
BOOTAS arch/powerpc/boot/crt0.o
powerpc-linux-gnuspe-gcc: error: unrecognized argument in option ‘-mcpu=powerpc’
powerpc-linux-gnuspe-gcc: note: valid arguments to ‘-mcpu=’ are: 8540 8548 native make[1]: *** [arch/powerpc/boot/Makefile:231: arch/powerpc/boot/crt0.o] Error 1
Similar change was already introduced for the main powerpc Makefile in commit 446cda1b21d9 ("powerpc/32: Don't always pass -mcpu=powerpc to the compiler").
--- arch/powerpc/boot/Makefile | 14 ++++++++++---- 1 file changed, 10 insertions(+), 4 deletions(-)
arch/powerpc/boot/Makefile +10 -4
@@ -38,13 +38,19 @@ BOOTCFLAGS := -Wall -Wundef -Wstrict-prototypes -Wno-trigraphs \ $(LINUXINCLUDE) ifdef CONFIG_PPC64_BOOT_WRAPPER -ifdef CONFIG_CPU_LITTLE_ENDIAN -BOOTCFLAGS += -m64 -mcpu=powerpc64le +BOOTCFLAGS += -m64 else -BOOTCFLAGS += -m64 -mcpu=powerpc64 +BOOTCFLAGS += -m32 endif + +ifdef CONFIG_TARGET_CPU_BOOL +BOOTCFLAGS += -mcpu=$(CONFIG_TARGET_CPU) +else ifdef CONFIG_PPC64_BOOT_WRAPPER +ifdef CONFIG_CPU_LITTLE_ENDIAN +BOOTCFLAGS += -mcpu=powerpc64le else -BOOTCFLAGS += -m32 -mcpu=powerpc +BOOTCFLAGS += -mcpu=powerpc64 +endif endif BOOTCFLAGS += -isystem $(shell $(BOOTCC) -print-file-name=include)
Signature · 1 line
2.20.1
Re: [PATCH v3] powerpc/boot: Don't always pass -mcpu=powerpc when building 32-bit uImage
Le 28/08/2022 à 11:56, Pali Rohár a écrit :
Quoted 8 lines
When
CONFIG_TARGET_CPUis specified then pass its value to the compiler -mcpu option. This fixes following build error when building kernel with powerpc e500 SPE capable cross compilers:BOOTAS
arch/powerpc/boot/crt0.o
powerpc-linux-gnuspe-gcc: error: unrecognized argument in option ‘-mcpu=powerpc’
powerpc-linux-gnuspe-gcc: note: valid arguments to ‘-mcpu=’ are: 8540 8548 native make[1]: *** [arch/powerpc/boot/Makefile:231:arch/powerpc/boot/crt0.o] Error 1
corenet64_smp_defconfig :
BOOTAS arch/powerpc/boot/crt0.o
powerpc64-linux-gcc: error: missing argument to '-mcpu=' make[1]: *** [arch/powerpc/boot/Makefile:237 : arch/powerpc/boot/crt0.o] Erreur 1
make: *** [arch/powerpc/Makefile:253 : uImage] Erreur 2
Christophe
Quoted 40 lines
Similar change was already introduced for the main powerpc
Makefilein commit446cda1b21d9("powerpc/32: Don't always pass -mcpu=powerpc to the compiler").Fixes 40a75584e526 ("powerpc/boot: Build wrapper for an appropriate CPU")Cc [email protected] # 446cda1b21d9 ("powerpc/32: Don't always pass -mcpu=powerpc to the compiler")Signed-off-by Pali Rohár <[email protected]>--- arch/powerpc/boot/Makefile | 14 ++++++++++---- 1 file changed, 10 insertions(+), 4 deletions(-)arch/powerpc/boot/Makefile +10
-4@@ -38,13 +38,19 @@ BOOTCFLAGS := -Wall -Wundef -Wstrict-prototypes -Wno-trigraphs \ $(LINUXINCLUDE) ifdef CONFIG_PPC64_BOOT_WRAPPER -ifdef CONFIG_CPU_LITTLE_ENDIAN -BOOTCFLAGS += -m64 -mcpu=powerpc64le +BOOTCFLAGS += -m64 else -BOOTCFLAGS += -m64 -mcpu=powerpc64 +BOOTCFLAGS += -m32 endif + +ifdef CONFIG_TARGET_CPU_BOOL +BOOTCFLAGS += -mcpu=$(CONFIG_TARGET_CPU) +else ifdef CONFIG_PPC64_BOOT_WRAPPER +ifdef CONFIG_CPU_LITTLE_ENDIAN +BOOTCFLAGS += -mcpu=powerpc64le else -BOOTCFLAGS += -m32 -mcpu=powerpc +BOOTCFLAGS += -mcpu=powerpc64 +endif endif BOOTCFLAGS += -isystem $(shell $(BOOTCC) -print-file-name=include)
Re: [PATCH v3] powerpc/boot: Don't always pass -mcpu=powerpc when building 32-bit uImage
Le 28/08/2022 à 19:33, Christophe Leroy a écrit :
Quoted 15 lines
Le 28/08/2022 à 11:56, Pali Rohár a écrit :
Quoted 11 lines
When
CONFIG_TARGET_CPUis specified then pass its value to the compiler -mcpu option. This fixes following build error when building kernel with powerpc e500 SPE capable cross compilers:BOOTAS
arch/powerpc/boot/crt0.o
powerpc-linux-gnuspe-gcc: error: unrecognized argument in option ‘-mcpu=powerpc’
powerpc-linux-gnuspe-gcc: note: valid arguments to ‘-mcpu=’ are:
8540 8548 native
make[1]: *** [arch/powerpc/boot/Makefile:231:arch/powerpc/boot/crt0.o] Error 1
Quoted 9 lines
corenet64_smp_defconfig:BOOTAS
arch/powerpc/boot/crt0.o
powerpc64-linux-gcc: error: missing argument to '-mcpu=' make[1]: *** [arch/powerpc/boot/Makefile:237:arch/powerpc/boot/crt0.o] Erreur 1
make: *** [arch/powerpc/Makefile:253: uImage] Erreur 2
Seems like in fact, E5500_CPU and E6500_CPU are not taken into account in CONFIG_TARGET_CPU, and get special treatment directly in arch/powerpc/Makefile.
This goes unnoticed because of CFLAGS-$(CONFIG_TARGET_CPU_BOOL) += $(call cc-option,-mcpu=$(CONFIG_TARGET_CPU))
I think we need to fix that prior to your patch.
Quoted 44 lines
Christophe
Quoted 41 lines
Similar change was already introduced for the main powerpc
Makefilein commit446cda1b21d9("powerpc/32: Don't always pass -mcpu=powerpc to the compiler").Fixes 40a75584e526 ("powerpc/boot: Build wrapper for an appropriateCPU")
Cc: [email protected] #446cda1b21d9("powerpc/32: Don't always pass -mcpu=powerpc to the compiler")Signed-off-by Pali Rohár <[email protected]>---
arch/powerpc/boot/Makefile| 14 ++++++++++----1 file changed, 10 insertions(+), 4 deletions(-)arch/powerpc/boot/Makefile +0
-1@@ -38,13 +38,19 @@ BOOTCFLAGS := -Wall -Wundef -Wstrict-prototypes -Wno-trigraphs \ $(LINUXINCLUDE)ifdef
CONFIG_PPC64_BOOT_WRAPPERarch/powerpc/boot/Makefile +1
-2-ifdef CONFIG_CPU_LITTLE_ENDIAN -BOOTCFLAGS += -m64 -mcpu=powerpc64le +BOOTCFLAGS += -m64else
arch/powerpc/boot/Makefile +1
-1-BOOTCFLAGS += -m64 -mcpu=powerpc64 +BOOTCFLAGS += -m32endif
arch/powerpc/boot/Makefile +6
-0+ +ifdef CONFIG_TARGET_CPU_BOOL +BOOTCFLAGS += -mcpu=$(CONFIG_TARGET_CPU) +else ifdef CONFIG_PPC64_BOOT_WRAPPER +ifdef CONFIG_CPU_LITTLE_ENDIAN +BOOTCFLAGS += -mcpu=powerpc64leelse
arch/powerpc/boot/Makefile +2
-1-BOOTCFLAGS += -m32 -mcpu=powerpc +BOOTCFLAGS += -mcpu=powerpc64 +endifendif
BOOTCFLAGS += -isystem $(shell $(BOOTCC) -print-file-name=include)
Re: [PATCH v3] powerpc/boot: Don't always pass -mcpu=powerpc when building 32-bit uImage
Quoted 26 lines · On Sunday 28 August 2022 17:39:25 Christophe Leroy wrote:
Le 28/08/2022 à 19:33, Christophe Leroy a écrit :
Quoted 15 lines
Le 28/08/2022 à 11:56, Pali Rohár a écrit :
Quoted 11 lines
When
CONFIG_TARGET_CPUis specified then pass its value to the compiler -mcpu option. This fixes following build error when building kernel with powerpc e500 SPE capable cross compilers:BOOTAS
arch/powerpc/boot/crt0.o
powerpc-linux-gnuspe-gcc: error: unrecognized argument in option ‘-mcpu=powerpc’
powerpc-linux-gnuspe-gcc: note: valid arguments to ‘-mcpu=’ are:
8540 8548 native
make[1]: *** [arch/powerpc/boot/Makefile:231:arch/powerpc/boot/crt0.o] Error 1Quoted 9 lines
corenet64_smp_defconfig:BOOTAS
arch/powerpc/boot/crt0.o
powerpc64-linux-gcc: error: missing argument to '-mcpu=' make[1]: *** [arch/powerpc/boot/Makefile:237:arch/powerpc/boot/crt0.o] Erreur 1
make: *** [arch/powerpc/Makefile:253: uImage] Erreur 2
Quoted 8 lines
Seems like in fact,
E5500_CPUandE6500_CPUare not taken into account inCONFIG_TARGET_CPU, and get special treatment directly inarch/powerpc/Makefile.This goes unnoticed because of CFLAGS-$(CONFIG_TARGET_CPU_BOOL) += $(call cc-option,-mcpu=$(CONFIG_TARGET_CPU))
I think we need to fix that prior to your patch.
It looks like that CONFIG_TARGET_CPU is broken.
$ make ARCH=powerpc corenet64_smp_defconfig CROSS_COMPILE=powerpc64-linux-gnu- ... # configuration written to .config
$ grep CONFIG_TARGET_CPU .config CONFIG_TARGET_CPU_BOOL=y
CONFIG_TARGET_CPU_BOOL is set but CONFIG_TARGET_CPU not!
Quoted 44 lines
Quoted 44 lines
Christophe
Quoted 41 lines
Similar change was already introduced for the main powerpc
Makefilein commit446cda1b21d9("powerpc/32: Don't always pass -mcpu=powerpc to the compiler").Fixes 40a75584e526 ("powerpc/boot: Build wrapper for an appropriateCPU")
Cc: [email protected] #446cda1b21d9("powerpc/32: Don't always pass -mcpu=powerpc to the compiler")Signed-off-by Pali Rohár <[email protected]>---
arch/powerpc/boot/Makefile| 14 ++++++++++----1 file changed, 10 insertions(+), 4 deletions(-)arch/powerpc/boot/Makefile +0
-1@@ -38,13 +38,19 @@ BOOTCFLAGS := -Wall -Wundef -Wstrict-prototypes -Wno-trigraphs \ $(LINUXINCLUDE)ifdef
CONFIG_PPC64_BOOT_WRAPPERarch/powerpc/boot/Makefile +1
-2-ifdef CONFIG_CPU_LITTLE_ENDIAN -BOOTCFLAGS += -m64 -mcpu=powerpc64le +BOOTCFLAGS += -m64else
arch/powerpc/boot/Makefile +1
-1-BOOTCFLAGS += -m64 -mcpu=powerpc64 +BOOTCFLAGS += -m32endif
arch/powerpc/boot/Makefile +6
-0+ +ifdef CONFIG_TARGET_CPU_BOOL +BOOTCFLAGS += -mcpu=$(CONFIG_TARGET_CPU) +else ifdef CONFIG_PPC64_BOOT_WRAPPER +ifdef CONFIG_CPU_LITTLE_ENDIAN +BOOTCFLAGS += -mcpu=powerpc64leelse
arch/powerpc/boot/Makefile +2
-1-BOOTCFLAGS += -m32 -mcpu=powerpc +BOOTCFLAGS += -mcpu=powerpc64 +endifendif
BOOTCFLAGS += -isystem $(shell $(BOOTCC) -print-file-name=include)
Re: [PATCH v3] powerpc/boot: Don't always pass -mcpu=powerpc when building 32-bit uImage
Le 28/08/2022 à 19:41, Pali Rohár a écrit :
Quoted 38 lines · On Sunday 28 August 2022 17:39:25 Christophe Leroy wrote:
Quoted 26 lines
Le 28/08/2022 à 19:33, Christophe Leroy a écrit :
Quoted 15 lines
Le 28/08/2022 à 11:56, Pali Rohár a écrit :
Quoted 11 lines
When
CONFIG_TARGET_CPUis specified then pass its value to the compiler -mcpu option. This fixes following build error when building kernel with powerpc e500 SPE capable cross compilers:BOOTAS
arch/powerpc/boot/crt0.o
powerpc-linux-gnuspe-gcc: error: unrecognized argument in option
‘-mcpu=powerpc’
powerpc-linux-gnuspe-gcc: note: valid arguments to ‘-mcpu=’ are:
8540 8548 native
make[1]: *** [arch/powerpc/boot/Makefile:231:arch/powerpc/boot/crt0.o] Error 1Quoted 9 lines
corenet64_smp_defconfig:BOOTAS
arch/powerpc/boot/crt0.o
powerpc64-linux-gcc: error: missing argument to '-mcpu=' make[1]: *** [arch/powerpc/boot/Makefile:237:arch/powerpc/boot/crt0.o] Erreur 1
make: *** [arch/powerpc/Makefile:253: uImage] Erreur 2Quoted 8 lines
Seems like in fact,
E5500_CPUandE6500_CPUare not taken into account inCONFIG_TARGET_CPU, and get special treatment directly inarch/powerpc/Makefile.This goes unnoticed because of CFLAGS-$(CONFIG_TARGET_CPU_BOOL) += $(call cc-option,-mcpu=$(CONFIG_TARGET_CPU))
I think we need to fix that prior to your patch.
It looks like that
CONFIG_TARGET_CPUis broken.
Quoted 8 lines
$ make ARCH=powerpc corenet64_smp_defconfig CROSS_COMPILE=powerpc64-linux-gnu- ... # configuration written to .config$ grep CONFIG_TARGET_CPU .config CONFIG_TARGET_CPU_BOOL=y
CONFIG_TARGET_CPU_BOOLis set butCONFIG_TARGET_CPUnot!
Yes, because there is no default value for E5500_CPU and E6500_CPU. We need to add one for each.
Quoted 45 lines
Quoted 45 lines
Quoted 45 lines
Christophe
Quoted 41 lines
Similar change was already introduced for the main powerpc
Makefilein commit446cda1b21d9("powerpc/32: Don't always pass -mcpu=powerpc to the compiler").Fixes 40a75584e526 ("powerpc/boot: Build wrapper for an appropriateCPU")
Cc: [email protected] #446cda1b21d9("powerpc/32: Don't always pass -mcpu=powerpc to the compiler")Signed-off-by Pali Rohár <[email protected]>--- arch/powerpc/boot/Makefile | 14 ++++++++++---- 1 file changed, 10 insertions(+), 4 deletions(-)arch/powerpc/boot/Makefile +10
-5@@ -38,13 +38,19 @@ BOOTCFLAGS := -Wall -Wundef -Wstrict-prototypes -Wno-trigraphs \ $(LINUXINCLUDE) ifdef CONFIG_PPC64_BOOT_WRAPPER -ifdef CONFIG_CPU_LITTLE_ENDIAN -BOOTCFLAGS += -m64 -mcpu=powerpc64le +BOOTCFLAGS += -m64 else -BOOTCFLAGS += -m64 -mcpu=powerpc64 +BOOTCFLAGS += -m32 endif + +ifdef CONFIG_TARGET_CPU_BOOL +BOOTCFLAGS += -mcpu=$(CONFIG_TARGET_CPU) +else ifdef CONFIG_PPC64_BOOT_WRAPPER +ifdef CONFIG_CPU_LITTLE_ENDIAN +BOOTCFLAGS += -mcpu=powerpc64le else -BOOTCFLAGS += -m32 -mcpu=powerpc +BOOTCFLAGS += -mcpu=powerpc64 +endif endif BOOTCFLAGS += -isystem $(shell $(BOOTCC) -print-file-name=include)
Re: [PATCH v3] powerpc/boot: Don't always pass -mcpu=powerpc when building 32-bit uImage
Quoted 43 lines · On Sunday 28 August 2022 17:43:53 Christophe Leroy wrote:
Le 28/08/2022 à 19:41, Pali Rohár a écrit :
Quoted 42 lines · On Sunday 28 August 2022 17:39:25 Christophe Leroy wrote:
Quoted 26 lines
Le 28/08/2022 à 19:33, Christophe Leroy a écrit :
Quoted 15 lines
Le 28/08/2022 à 11:56, Pali Rohár a écrit :
Quoted 11 lines
When
CONFIG_TARGET_CPUis specified then pass its value to the compiler -mcpu option. This fixes following build error when building kernel with powerpc e500 SPE capable cross compilers:BOOTAS
arch/powerpc/boot/crt0.o
powerpc-linux-gnuspe-gcc: error: unrecognized argument in option
‘-mcpu=powerpc’
powerpc-linux-gnuspe-gcc: note: valid arguments to ‘-mcpu=’ are:
8540 8548 native
make[1]: *** [arch/powerpc/boot/Makefile:231:arch/powerpc/boot/crt0.o] Error 1Quoted 9 lines
corenet64_smp_defconfig:BOOTAS
arch/powerpc/boot/crt0.o
powerpc64-linux-gcc: error: missing argument to '-mcpu=' make[1]: *** [arch/powerpc/boot/Makefile:237:arch/powerpc/boot/crt0.o] Erreur 1
make: *** [arch/powerpc/Makefile:253: uImage] Erreur 2Quoted 8 lines
Seems like in fact,
E5500_CPUandE6500_CPUare not taken into account inCONFIG_TARGET_CPU, and get special treatment directly inarch/powerpc/Makefile.This goes unnoticed because of CFLAGS-$(CONFIG_TARGET_CPU_BOOL) += $(call cc-option,-mcpu=$(CONFIG_TARGET_CPU))
I think we need to fix that prior to your patch.
It looks like that
CONFIG_TARGET_CPUis broken.$ make ARCH=powerpc corenet64_smp_defconfig CROSS_COMPILE=powerpc64-linux-gnu- ... # configuration written to .config
Quoted 7 lines
Quoted 4 lines
$ grep CONFIG_TARGET_CPU .config CONFIG_TARGET_CPU_BOOL=y
CONFIG_TARGET_CPU_BOOLis set butCONFIG_TARGET_CPUnot!Yes, because there is no default value for
E5500_CPUandE6500_CPU. We need to add one for each.
I see... Will you prepare this fixup for your previous patch?
And I think that following construct
$(call cc-option,-mcpu=$(CONFIG_TARGET_CPU))
should be changed just to
-mcpu=$(CONFIG_TARGET_CPU)
Because if user specified that want build for specific target CPU, it should not be silently ignored.
Re: [PATCH v3] powerpc/boot: Don't always pass -mcpu=powerpc when building 32-bit uImage
Quoted 56 lines · On Monday 29 August 2022 10:54:51 Pali Rohár wrote:
Quoted 43 lines · On Sunday 28 August 2022 17:43:53 Christophe Leroy wrote:
Le 28/08/2022 à 19:41, Pali Rohár a écrit :
Quoted 42 lines · On Sunday 28 August 2022 17:39:25 Christophe Leroy wrote:
Quoted 26 lines
Le 28/08/2022 à 19:33, Christophe Leroy a écrit :
Quoted 15 lines
Le 28/08/2022 à 11:56, Pali Rohár a écrit :
Quoted 11 lines
When
CONFIG_TARGET_CPUis specified then pass its value to the compiler -mcpu option. This fixes following build error when building kernel with powerpc e500 SPE capable cross compilers:BOOTAS
arch/powerpc/boot/crt0.o
powerpc-linux-gnuspe-gcc: error: unrecognized argument in option
‘-mcpu=powerpc’
powerpc-linux-gnuspe-gcc: note: valid arguments to ‘-mcpu=’ are:
8540 8548 native
make[1]: *** [arch/powerpc/boot/Makefile:231:arch/powerpc/boot/crt0.o] Error 1Quoted 9 lines
corenet64_smp_defconfig:BOOTAS
arch/powerpc/boot/crt0.o
powerpc64-linux-gcc: error: missing argument to '-mcpu=' make[1]: *** [arch/powerpc/boot/Makefile:237:arch/powerpc/boot/crt0.o] Erreur 1
make: *** [arch/powerpc/Makefile:253: uImage] Erreur 2Quoted 8 lines
Seems like in fact,
E5500_CPUandE6500_CPUare not taken into account inCONFIG_TARGET_CPU, and get special treatment directly inarch/powerpc/Makefile.This goes unnoticed because of CFLAGS-$(CONFIG_TARGET_CPU_BOOL) += $(call cc-option,-mcpu=$(CONFIG_TARGET_CPU))
I think we need to fix that prior to your patch.
It looks like that
CONFIG_TARGET_CPUis broken.$ make ARCH=powerpc corenet64_smp_defconfig CROSS_COMPILE=powerpc64-linux-gnu- ... # configuration written to .configQuoted 7 lines
Quoted 4 lines
$ grep CONFIG_TARGET_CPU .config CONFIG_TARGET_CPU_BOOL=y
CONFIG_TARGET_CPU_BOOLis set butCONFIG_TARGET_CPUnot!Yes, because there is no default value for
E5500_CPUandE6500_CPU. We need to add one for each.I see... Will you prepare this fixup for your previous patch?
And I think that following construct
Quoted 8 lines
$(call cc-option,-mcpu=$(CONFIG_TARGET_CPU))should be changed just to
-mcpu=$(CONFIG_TARGET_CPU)Because if user specified that want build for specific target CPU, it should not be silently ignored.
Christophe, should I do something in this area?
Re: [PATCH v3] powerpc/boot: Don't always pass -mcpu=powerpc when building 32-bit uImage
Quoted 59 lines · On Sunday 09 October 2022 13:06:52 Pali Rohár wrote:
Quoted 58 lines · On Monday 29 August 2022 10:54:51 Pali Rohár wrote:
Quoted 43 lines · On Sunday 28 August 2022 17:43:53 Christophe Leroy wrote:
Le 28/08/2022 à 19:41, Pali Rohár a écrit :
Quoted 42 lines · On Sunday 28 August 2022 17:39:25 Christophe Leroy wrote:
Quoted 26 lines
Le 28/08/2022 à 19:33, Christophe Leroy a écrit :
Quoted 15 lines
Le 28/08/2022 à 11:56, Pali Rohár a écrit :
Quoted 11 lines
When
CONFIG_TARGET_CPUis specified then pass its value to the compiler -mcpu option. This fixes following build error when building kernel with powerpc e500 SPE capable cross compilers:BOOTAS
arch/powerpc/boot/crt0.o
powerpc-linux-gnuspe-gcc: error: unrecognized argument in option
‘-mcpu=powerpc’
powerpc-linux-gnuspe-gcc: note: valid arguments to ‘-mcpu=’ are:
8540 8548 native
make[1]: *** [arch/powerpc/boot/Makefile:231:arch/powerpc/boot/crt0.o] Error 1Quoted 9 lines
corenet64_smp_defconfig:BOOTAS
arch/powerpc/boot/crt0.o
powerpc64-linux-gcc: error: missing argument to '-mcpu=' make[1]: *** [arch/powerpc/boot/Makefile:237:arch/powerpc/boot/crt0.o] Erreur 1
make: *** [arch/powerpc/Makefile:253: uImage] Erreur 2Quoted 8 lines
Seems like in fact,
E5500_CPUandE6500_CPUare not taken into account inCONFIG_TARGET_CPU, and get special treatment directly inarch/powerpc/Makefile.This goes unnoticed because of CFLAGS-$(CONFIG_TARGET_CPU_BOOL) += $(call cc-option,-mcpu=$(CONFIG_TARGET_CPU))
I think we need to fix that prior to your patch.
It looks like that
CONFIG_TARGET_CPUis broken.$ make ARCH=powerpc corenet64_smp_defconfig CROSS_COMPILE=powerpc64-linux-gnu- ... # configuration written to .configQuoted 7 lines
Quoted 4 lines
$ grep CONFIG_TARGET_CPU .config CONFIG_TARGET_CPU_BOOL=y
CONFIG_TARGET_CPU_BOOLis set butCONFIG_TARGET_CPUnot!Yes, because there is no default value for
E5500_CPUandE6500_CPU. We need to add one for each.I see... Will you prepare this fixup for your previous patch?
And I think that following construct
$(call cc-option,-mcpu=$(CONFIG_TARGET_CPU))
Quoted 8 lines
Quoted 6 lines
should be changed just to
-mcpu=$(CONFIG_TARGET_CPU)Because if user specified that want build for specific target CPU, it should not be silently ignored.
Christophe, should I do something in this area?
Christophe, any input from your side?
Re: [PATCH v3] powerpc/boot: Don't always pass -mcpu=powerpc when building 32-bit uImage
Le 01/11/2022 à 23:12, Pali Rohár a écrit :
Quoted 62 lines · On Sunday 09 October 2022 13:06:52 Pali Rohár wrote:
Quoted 61 lines · On Monday 29 August 2022 10:54:51 Pali Rohár wrote:
Quoted 60 lines · On Sunday 28 August 2022 17:43:53 Christophe Leroy wrote:
Quoted 43 lines
Le 28/08/2022 à 19:41, Pali Rohár a écrit :
Quoted 42 lines · On Sunday 28 August 2022 17:39:25 Christophe Leroy wrote:
Quoted 26 lines
Le 28/08/2022 à 19:33, Christophe Leroy a écrit :
Quoted 15 lines
Le 28/08/2022 à 11:56, Pali Rohár a écrit :
Quoted 11 lines
When
CONFIG_TARGET_CPUis specified then pass its value to the compiler -mcpu option. This fixes following build error when building kernel with powerpc e500 SPE capable cross compilers:BOOTAS
arch/powerpc/boot/crt0.o
powerpc-linux-gnuspe-gcc: error: unrecognized argument in option
‘-mcpu=powerpc’
powerpc-linux-gnuspe-gcc: note: valid arguments to ‘-mcpu=’ are:
8540 8548 native
make[1]: *** [arch/powerpc/boot/Makefile:231:arch/powerpc/boot/crt0.o] Error 1Quoted 9 lines
corenet64_smp_defconfig:BOOTAS
arch/powerpc/boot/crt0.o
powerpc64-linux-gcc: error: missing argument to '-mcpu=' make[1]: *** [arch/powerpc/boot/Makefile:237:arch/powerpc/boot/crt0.o] Erreur 1
make: *** [arch/powerpc/Makefile:253: uImage] Erreur 2Quoted 8 lines
Seems like in fact,
E5500_CPUandE6500_CPUare not taken into account inCONFIG_TARGET_CPU, and get special treatment directly inarch/powerpc/Makefile.This goes unnoticed because of CFLAGS-$(CONFIG_TARGET_CPU_BOOL) += $(call cc-option,-mcpu=$(CONFIG_TARGET_CPU))
I think we need to fix that prior to your patch.
It looks like that
CONFIG_TARGET_CPUis broken.$ make ARCH=powerpc corenet64_smp_defconfig CROSS_COMPILE=powerpc64-linux-gnu- ... # configuration written to .configQuoted 7 lines
Quoted 4 lines
$ grep CONFIG_TARGET_CPU .config CONFIG_TARGET_CPU_BOOL=y
CONFIG_TARGET_CPU_BOOLis set butCONFIG_TARGET_CPUnot!Yes, because there is no default value for
E5500_CPUandE6500_CPU. We need to add one for each.I see... Will you prepare this fixup for your previous patch?
And I think that following construct
$(call cc-option,-mcpu=$(CONFIG_TARGET_CPU))should be changed just to
Quoted 8 lines
Quoted 6 lines
Quoted 4 lines
-mcpu=$(CONFIG_TARGET_CPU)Because if user specified that want build for specific target CPU, it should not be silently ignored.
Christophe, should I do something in this area?
Christophe, any input from your side?
Hi, sorry I was on holiday until today. I'll try to have a look in the coming days.
Re: [PATCH v3] powerpc/boot: Don't always pass -mcpu=powerpc when building 32-bit uImage
Quoted 68 lines · On Wednesday 02 November 2022 14:05:35 Christophe Leroy wrote:
Le 01/11/2022 à 23:12, Pali Rohár a écrit :
Quoted 67 lines · On Sunday 09 October 2022 13:06:52 Pali Rohár wrote:
Quoted 66 lines · On Monday 29 August 2022 10:54:51 Pali Rohár wrote:
Quoted 64 lines · On Sunday 28 August 2022 17:43:53 Christophe Leroy wrote:
Quoted 43 lines
Le 28/08/2022 à 19:41, Pali Rohár a écrit :
Quoted 42 lines · On Sunday 28 August 2022 17:39:25 Christophe Leroy wrote:
Quoted 26 lines
Le 28/08/2022 à 19:33, Christophe Leroy a écrit :
Quoted 15 lines
Le 28/08/2022 à 11:56, Pali Rohár a écrit :
Quoted 11 lines
When
CONFIG_TARGET_CPUis specified then pass its value to the compiler -mcpu option. This fixes following build error when building kernel with powerpc e500 SPE capable cross compilers:BOOTAS
arch/powerpc/boot/crt0.o
powerpc-linux-gnuspe-gcc: error: unrecognized argument in option
‘-mcpu=powerpc’
powerpc-linux-gnuspe-gcc: note: valid arguments to ‘-mcpu=’ are:
8540 8548 native
make[1]: *** [arch/powerpc/boot/Makefile:231:arch/powerpc/boot/crt0.o] Error 1Quoted 9 lines
corenet64_smp_defconfig:BOOTAS
arch/powerpc/boot/crt0.o
powerpc64-linux-gcc: error: missing argument to '-mcpu=' make[1]: *** [arch/powerpc/boot/Makefile:237:arch/powerpc/boot/crt0.o] Erreur 1
make: *** [arch/powerpc/Makefile:253: uImage] Erreur 2Quoted 8 lines
Seems like in fact,
E5500_CPUandE6500_CPUare not taken into account inCONFIG_TARGET_CPU, and get special treatment directly inarch/powerpc/Makefile.This goes unnoticed because of CFLAGS-$(CONFIG_TARGET_CPU_BOOL) += $(call cc-option,-mcpu=$(CONFIG_TARGET_CPU))
I think we need to fix that prior to your patch.
It looks like that
CONFIG_TARGET_CPUis broken.$ make ARCH=powerpc corenet64_smp_defconfig CROSS_COMPILE=powerpc64-linux-gnu- ... # configuration written to .configQuoted 7 lines
Quoted 4 lines
$ grep CONFIG_TARGET_CPU .config CONFIG_TARGET_CPU_BOOL=y
CONFIG_TARGET_CPU_BOOLis set butCONFIG_TARGET_CPUnot!Yes, because there is no default value for
E5500_CPUandE6500_CPU. We need to add one for each.I see... Will you prepare this fixup for your previous patch?
And I think that following construct
$(call cc-option,-mcpu=$(CONFIG_TARGET_CPU))should be changed just to
-mcpu=$(CONFIG_TARGET_CPU)Because if user specified that want build for specific target CPU, it should not be silently ignored.
Quoted 6 lines
Quoted 3 lines
Quoted 1 line
Christophe, should I do something in this area?
Christophe, any input from your side?
Hi, sorry I was on holiday until today. I'll try to have a look in the coming days.
Ok, Did you have a time to look at it?
Re: [PATCH v3] powerpc/boot: Don't always pass -mcpu=powerpc when building 32-bit uImage
Le 26/11/2022 à 17:30, Pali Rohár a écrit :
Quoted 69 lines · On Wednesday 02 November 2022 14:05:35 Christophe Leroy wrote:
Quoted 68 lines
Le 01/11/2022 à 23:12, Pali Rohár a écrit :
Quoted 67 lines · On Sunday 09 October 2022 13:06:52 Pali Rohár wrote:
Quoted 66 lines · On Monday 29 August 2022 10:54:51 Pali Rohár wrote:
Quoted 64 lines · On Sunday 28 August 2022 17:43:53 Christophe Leroy wrote:
Quoted 43 lines
Le 28/08/2022 à 19:41, Pali Rohár a écrit :
Quoted 42 lines · On Sunday 28 August 2022 17:39:25 Christophe Leroy wrote:
Quoted 26 lines
Le 28/08/2022 à 19:33, Christophe Leroy a écrit :
Quoted 15 lines
Le 28/08/2022 à 11:56, Pali Rohár a écrit :
Quoted 11 lines
When
CONFIG_TARGET_CPUis specified then pass its value to the compiler -mcpu option. This fixes following build error when building kernel with powerpc e500 SPE capable cross compilers:BOOTAS
arch/powerpc/boot/crt0.o
powerpc-linux-gnuspe-gcc: error: unrecognized argument in option
‘-mcpu=powerpc’
powerpc-linux-gnuspe-gcc: note: valid arguments to ‘-mcpu=’ are:
8540 8548 native
make[1]: *** [arch/powerpc/boot/Makefile:231:arch/powerpc/boot/crt0.o] Error 1Quoted 9 lines
corenet64_smp_defconfig:BOOTAS
arch/powerpc/boot/crt0.o
powerpc64-linux-gcc: error: missing argument to '-mcpu=' make[1]: *** [arch/powerpc/boot/Makefile:237:arch/powerpc/boot/crt0.o] Erreur 1
make: *** [arch/powerpc/Makefile:253: uImage] Erreur 2Quoted 8 lines
Seems like in fact,
E5500_CPUandE6500_CPUare not taken into account inCONFIG_TARGET_CPU, and get special treatment directly inarch/powerpc/Makefile.This goes unnoticed because of CFLAGS-$(CONFIG_TARGET_CPU_BOOL) += $(call cc-option,-mcpu=$(CONFIG_TARGET_CPU))
I think we need to fix that prior to your patch.
It looks like that
CONFIG_TARGET_CPUis broken.$ make ARCH=powerpc corenet64_smp_defconfig CROSS_COMPILE=powerpc64-linux-gnu- ... # configuration written to .configQuoted 7 lines
Quoted 4 lines
$ grep CONFIG_TARGET_CPU .config CONFIG_TARGET_CPU_BOOL=y
CONFIG_TARGET_CPU_BOOLis set butCONFIG_TARGET_CPUnot!Yes, because there is no default value for
E5500_CPUandE6500_CPU. We need to add one for each.I see... Will you prepare this fixup for your previous patch?
And I think that following construct
$(call cc-option,-mcpu=$(CONFIG_TARGET_CPU))should be changed just to
-mcpu=$(CONFIG_TARGET_CPU)Because if user specified that want build for specific target CPU, it should not be silently ignored.
Quoted 8 lines
Quoted 6 lines
Quoted 3 lines
Quoted 1 line
Christophe, should I do something in this area?
Christophe, any input from your side?
Hi, sorry I was on holiday until today. I'll try to have a look in the coming days.
Ok, Did you have a time to look at it?
I just sent a patch for it.
Christophe
Re: [PATCH v3] powerpc/boot: Don't always pass -mcpu=powerpc when building 32-bit uImage
In reply to Christophe LeroyQuoted 43 lines · On Sunday 28 August 2022 17:43:53 Christophe Leroy wrote:
Le 28/08/2022 à 19:41, Pali Rohár a écrit :
Quoted 42 lines · On Sunday 28 August 2022 17:39:25 Christophe Leroy wrote:
Quoted 26 lines
Le 28/08/2022 à 19:33, Christophe Leroy a écrit :
Quoted 15 lines
Le 28/08/2022 à 11:56, Pali Rohár a écrit :
Quoted 11 lines
When
CONFIG_TARGET_CPUis specified then pass its value to the compiler -mcpu option. This fixes following build error when building kernel with powerpc e500 SPE capable cross compilers:BOOTAS
arch/powerpc/boot/crt0.o
powerpc-linux-gnuspe-gcc: error: unrecognized argument in option
‘-mcpu=powerpc’
powerpc-linux-gnuspe-gcc: note: valid arguments to ‘-mcpu=’ are:
8540 8548 native
make[1]: *** [arch/powerpc/boot/Makefile:231:arch/powerpc/boot/crt0.o] Error 1Quoted 9 lines
corenet64_smp_defconfig:BOOTAS
arch/powerpc/boot/crt0.o
powerpc64-linux-gcc: error: missing argument to '-mcpu=' make[1]: *** [arch/powerpc/boot/Makefile:237:arch/powerpc/boot/crt0.o] Erreur 1
make: *** [arch/powerpc/Makefile:253: uImage] Erreur 2Quoted 8 lines
Seems like in fact,
E5500_CPUandE6500_CPUare not taken into account inCONFIG_TARGET_CPU, and get special treatment directly inarch/powerpc/Makefile.This goes unnoticed because of CFLAGS-$(CONFIG_TARGET_CPU_BOOL) += $(call cc-option,-mcpu=$(CONFIG_TARGET_CPU))
I think we need to fix that prior to your patch.
It looks like that
CONFIG_TARGET_CPUis broken.$ make ARCH=powerpc corenet64_smp_defconfig CROSS_COMPILE=powerpc64-linux-gnu- ... # configuration written to .config
Quoted 7 lines
Quoted 4 lines
$ grep CONFIG_TARGET_CPU .config CONFIG_TARGET_CPU_BOOL=y
CONFIG_TARGET_CPU_BOOLis set butCONFIG_TARGET_CPUnot!Yes, because there is no default value for
E5500_CPUandE6500_CPU. We need to add one for each.
With "[PATCH v1] powerpc/64: Set default CPU in Kconfig" patch from
https://lore.kernel.org/linuxppc-dev/3fd60c2d8a28668a42b766b18362a526ef47e757.1670420281.git.christophe.leroy@csgroup.eu/
this change does not throw above compile error anymore.
Quoted 45 lines
Quoted 45 lines
Quoted 45 lines
Quoted 45 lines
Christophe
Quoted 41 lines
Similar change was already introduced for the main powerpc
Makefilein commit446cda1b21d9("powerpc/32: Don't always pass -mcpu=powerpc to the compiler").Fixes 40a75584e526 ("powerpc/boot: Build wrapper for an appropriateCPU")
Cc: [email protected] #446cda1b21d9("powerpc/32: Don't always pass -mcpu=powerpc to the compiler")Signed-off-by Pali Rohár <[email protected]>--- arch/powerpc/boot/Makefile | 14 ++++++++++---- 1 file changed, 10 insertions(+), 4 deletions(-)arch/powerpc/boot/Makefile +10
-5@@ -38,13 +38,19 @@ BOOTCFLAGS := -Wall -Wundef -Wstrict-prototypes -Wno-trigraphs \ $(LINUXINCLUDE) ifdef CONFIG_PPC64_BOOT_WRAPPER -ifdef CONFIG_CPU_LITTLE_ENDIAN -BOOTCFLAGS += -m64 -mcpu=powerpc64le +BOOTCFLAGS += -m64 else -BOOTCFLAGS += -m64 -mcpu=powerpc64 +BOOTCFLAGS += -m32 endif + +ifdef CONFIG_TARGET_CPU_BOOL +BOOTCFLAGS += -mcpu=$(CONFIG_TARGET_CPU) +else ifdef CONFIG_PPC64_BOOT_WRAPPER +ifdef CONFIG_CPU_LITTLE_ENDIAN +BOOTCFLAGS += -mcpu=powerpc64le else -BOOTCFLAGS += -m32 -mcpu=powerpc +BOOTCFLAGS += -mcpu=powerpc64 +endif endif BOOTCFLAGS += -isystem $(shell $(BOOTCC) -print-file-name=include)
Re: [PATCH v3] powerpc/boot: Don't always pass -mcpu=powerpc when building 32-bit uImage
In reply to Christophe LeroyQuoted 74 lines · On Wednesday 07 December 2022 13:39:18 Christophe Leroy wrote:
Le 26/11/2022 à 17:30, Pali Rohár a écrit :
Quoted 73 lines · On Wednesday 02 November 2022 14:05:35 Christophe Leroy wrote:
Quoted 72 lines
Le 01/11/2022 à 23:12, Pali Rohár a écrit :
Quoted 70 lines · On Sunday 09 October 2022 13:06:52 Pali Rohár wrote:
Quoted 59 lines · On Monday 29 August 2022 10:54:51 Pali Rohár wrote:
Quoted 58 lines · On Sunday 28 August 2022 17:43:53 Christophe Leroy wrote:
Quoted 43 lines
Le 28/08/2022 à 19:41, Pali Rohár a écrit :
Quoted 42 lines · On Sunday 28 August 2022 17:39:25 Christophe Leroy wrote:
Quoted 26 lines
Le 28/08/2022 à 19:33, Christophe Leroy a écrit :
Quoted 15 lines
Le 28/08/2022 à 11:56, Pali Rohár a écrit :
Quoted 11 lines
When
CONFIG_TARGET_CPUis specified then pass its value to the compiler -mcpu option. This fixes following build error when building kernel with powerpc e500 SPE capable cross compilers:BOOTAS
arch/powerpc/boot/crt0.o
powerpc-linux-gnuspe-gcc: error: unrecognized argument in option
‘-mcpu=powerpc’
powerpc-linux-gnuspe-gcc: note: valid arguments to ‘-mcpu=’ are:
8540 8548 native
make[1]: *** [arch/powerpc/boot/Makefile:231:arch/powerpc/boot/crt0.o] Error 1Quoted 9 lines
corenet64_smp_defconfig:BOOTAS
arch/powerpc/boot/crt0.o
powerpc64-linux-gcc: error: missing argument to '-mcpu=' make[1]: *** [arch/powerpc/boot/Makefile:237:arch/powerpc/boot/crt0.o] Erreur 1
make: *** [arch/powerpc/Makefile:253: uImage] Erreur 2Quoted 8 lines
Seems like in fact,
E5500_CPUandE6500_CPUare not taken into account inCONFIG_TARGET_CPU, and get special treatment directly inarch/powerpc/Makefile.This goes unnoticed because of CFLAGS-$(CONFIG_TARGET_CPU_BOOL) += $(call cc-option,-mcpu=$(CONFIG_TARGET_CPU))
I think we need to fix that prior to your patch.
It looks like that
CONFIG_TARGET_CPUis broken.$ make ARCH=powerpc corenet64_smp_defconfig CROSS_COMPILE=powerpc64-linux-gnu- ... # configuration written to .configQuoted 7 lines
Quoted 4 lines
$ grep CONFIG_TARGET_CPU .config CONFIG_TARGET_CPU_BOOL=y
CONFIG_TARGET_CPU_BOOLis set butCONFIG_TARGET_CPUnot!Yes, because there is no default value for
E5500_CPUandE6500_CPU. We need to add one for each.I see... Will you prepare this fixup for your previous patch?
And I think that following construct
$(call cc-option,-mcpu=$(CONFIG_TARGET_CPU))Quoted 8 lines
Quoted 6 lines
should be changed just to
-mcpu=$(CONFIG_TARGET_CPU)Because if user specified that want build for specific target CPU, it should not be silently ignored.
Christophe, should I do something in this area?
Christophe, any input from your side?
Quoted 8 lines
Quoted 4 lines
Quoted 2 lines
Hi, sorry I was on holiday until today. I'll try to have a look in the coming days.
Ok, Did you have a time to look at it?
I just sent a patch for it.
Christophe
Thanks!
Re: [PATCH v3] powerpc/boot: Don't always pass -mcpu=powerpc when building 32-bit uImage
In reply to Pali RohárLe 08/12/2022 à 20:16, Pali Rohár a écrit :
Quoted 47 lines · On Sunday 28 August 2022 17:43:53 Christophe Leroy wrote:
Quoted 46 lines
Le 28/08/2022 à 19:41, Pali Rohár a écrit :
Quoted 45 lines · On Sunday 28 August 2022 17:39:25 Christophe Leroy wrote:
Quoted 26 lines
Le 28/08/2022 à 19:33, Christophe Leroy a écrit :
Quoted 15 lines
Le 28/08/2022 à 11:56, Pali Rohár a écrit :
Quoted 11 lines
When
CONFIG_TARGET_CPUis specified then pass its value to the compiler -mcpu option. This fixes following build error when building kernel with powerpc e500 SPE capable cross compilers:BOOTAS
arch/powerpc/boot/crt0.o
powerpc-linux-gnuspe-gcc: error: unrecognized argument in option
‘-mcpu=powerpc’
powerpc-linux-gnuspe-gcc: note: valid arguments to ‘-mcpu=’ are:
8540 8548 native
make[1]: *** [arch/powerpc/boot/Makefile:231:arch/powerpc/boot/crt0.o] Error 1Quoted 9 lines
corenet64_smp_defconfig:BOOTAS
arch/powerpc/boot/crt0.o
powerpc64-linux-gcc: error: missing argument to '-mcpu=' make[1]: *** [arch/powerpc/boot/Makefile:237:arch/powerpc/boot/crt0.o] Erreur 1
make: *** [arch/powerpc/Makefile:253: uImage] Erreur 2Quoted 8 lines
Seems like in fact,
E5500_CPUandE6500_CPUare not taken into account inCONFIG_TARGET_CPU, and get special treatment directly inarch/powerpc/Makefile.This goes unnoticed because of CFLAGS-$(CONFIG_TARGET_CPU_BOOL) += $(call cc-option,-mcpu=$(CONFIG_TARGET_CPU))
I think we need to fix that prior to your patch.
It looks like that
CONFIG_TARGET_CPUis broken.$ make ARCH=powerpc corenet64_smp_defconfig CROSS_COMPILE=powerpc64-linux-gnu- ... # configuration written to .config$ grep CONFIG_TARGET_CPU .config CONFIG_TARGET_CPU_BOOL=y
Quoted 8 lines
Quoted 4 lines
Quoted 1 line
CONFIG_TARGET_CPU_BOOLis set butCONFIG_TARGET_CPUnot!Yes, because there is no default value for
E5500_CPUandE6500_CPU. We need to add one for each.With "[PATCH v1] powerpc/64: Set default CPU in
Kconfig" patch from
https://lore.kernel.org/linuxppc-dev/3fd60c2d8a28668a42b766b18362a526ef47e757.1670420281.git.christophe.leroy@csgroup.eu/
this change does not throw above compile error anymore.
That patch should land in powerpc/next soon. When it has landed, could you resent this patch so that snowpatch checks the build again ?
Because at the time being it is flagged as "failed", see
https://patchwork.ozlabs.org/project/linuxppc-dev/patch/[email protected]/
Christophe
Re: [PATCH v3] powerpc/boot: Don't always pass -mcpu=powerpc when building 32-bit uImage
Quoted 53 lines · On Thursday 08 December 2022 19:57:39 Christophe Leroy wrote:
Le 08/12/2022 à 20:16, Pali Rohár a écrit :
Quoted 52 lines · On Sunday 28 August 2022 17:43:53 Christophe Leroy wrote:
Quoted 50 lines
Le 28/08/2022 à 19:41, Pali Rohár a écrit :
Quoted 38 lines · On Sunday 28 August 2022 17:39:25 Christophe Leroy wrote:
Quoted 26 lines
Le 28/08/2022 à 19:33, Christophe Leroy a écrit :
Quoted 15 lines
Le 28/08/2022 à 11:56, Pali Rohár a écrit :
Quoted 11 lines
When
CONFIG_TARGET_CPUis specified then pass its value to the compiler -mcpu option. This fixes following build error when building kernel with powerpc e500 SPE capable cross compilers:BOOTAS
arch/powerpc/boot/crt0.o
powerpc-linux-gnuspe-gcc: error: unrecognized argument in option
‘-mcpu=powerpc’
powerpc-linux-gnuspe-gcc: note: valid arguments to ‘-mcpu=’ are:
8540 8548 native
make[1]: *** [arch/powerpc/boot/Makefile:231:arch/powerpc/boot/crt0.o] Error 1Quoted 9 lines
corenet64_smp_defconfig:BOOTAS
arch/powerpc/boot/crt0.o
powerpc64-linux-gcc: error: missing argument to '-mcpu=' make[1]: *** [arch/powerpc/boot/Makefile:237:arch/powerpc/boot/crt0.o] Erreur 1
make: *** [arch/powerpc/Makefile:253: uImage] Erreur 2Quoted 8 lines
Seems like in fact,
E5500_CPUandE6500_CPUare not taken into account inCONFIG_TARGET_CPU, and get special treatment directly inarch/powerpc/Makefile.This goes unnoticed because of CFLAGS-$(CONFIG_TARGET_CPU_BOOL) += $(call cc-option,-mcpu=$(CONFIG_TARGET_CPU))
I think we need to fix that prior to your patch.
It looks like that
CONFIG_TARGET_CPUis broken.Quoted 8 lines
$ make ARCH=powerpc corenet64_smp_defconfig CROSS_COMPILE=powerpc64-linux-gnu- ... # configuration written to .config$ grep CONFIG_TARGET_CPU .config CONFIG_TARGET_CPU_BOOL=y
CONFIG_TARGET_CPU_BOOLis set butCONFIG_TARGET_CPUnot!Yes, because there is no default value for
E5500_CPUandE6500_CPU. We need to add one for each.
Quoted 7 lines
Quoted 3 lines
With "[PATCH v1] powerpc/64: Set default CPU in
Kconfig" patch from
https://lore.kernel.org/linuxppc-dev/3fd60c2d8a28668a42b766b18362a526ef47e757.1670420281.git.christophe.leroy@csgroup.eu/
this change does not throw above compile error anymore.That patch should land in powerpc/next soon. When it has landed, could you resent this patch so that snowpatch checks the build again ?
Yes. But I'm still waiting because patch is not in powerpc/next yet.
Quoted 4 lines
Because at the time being it is flagged as "failed", see
https://patchwork.ozlabs.org/project/linuxppc-dev/patch/[email protected]/Christophe
Re: [PATCH v3] powerpc/boot: Don't always pass -mcpu=powerpc when building 32-bit uImage
Quoted 59 lines · On Saturday 24 December 2022 18:44:52 Pali Rohár wrote:
Quoted 58 lines · On Thursday 08 December 2022 19:57:39 Christophe Leroy wrote:
Le 08/12/2022 à 20:16, Pali Rohár a écrit :
Quoted 55 lines · On Sunday 28 August 2022 17:43:53 Christophe Leroy wrote:
Quoted 43 lines
Le 28/08/2022 à 19:41, Pali Rohár a écrit :
Quoted 42 lines · On Sunday 28 August 2022 17:39:25 Christophe Leroy wrote:
Quoted 26 lines
Le 28/08/2022 à 19:33, Christophe Leroy a écrit :
Quoted 15 lines
Le 28/08/2022 à 11:56, Pali Rohár a écrit :
Quoted 11 lines
When
CONFIG_TARGET_CPUis specified then pass its value to the compiler -mcpu option. This fixes following build error when building kernel with powerpc e500 SPE capable cross compilers:BOOTAS
arch/powerpc/boot/crt0.o
powerpc-linux-gnuspe-gcc: error: unrecognized argument in option
‘-mcpu=powerpc’
powerpc-linux-gnuspe-gcc: note: valid arguments to ‘-mcpu=’ are:
8540 8548 native
make[1]: *** [arch/powerpc/boot/Makefile:231:arch/powerpc/boot/crt0.o] Error 1Quoted 9 lines
corenet64_smp_defconfig:BOOTAS
arch/powerpc/boot/crt0.o
powerpc64-linux-gcc: error: missing argument to '-mcpu=' make[1]: *** [arch/powerpc/boot/Makefile:237:arch/powerpc/boot/crt0.o] Erreur 1
make: *** [arch/powerpc/Makefile:253: uImage] Erreur 2Quoted 8 lines
Seems like in fact,
E5500_CPUandE6500_CPUare not taken into account inCONFIG_TARGET_CPU, and get special treatment directly inarch/powerpc/Makefile.This goes unnoticed because of CFLAGS-$(CONFIG_TARGET_CPU_BOOL) += $(call cc-option,-mcpu=$(CONFIG_TARGET_CPU))
I think we need to fix that prior to your patch.
It looks like that
CONFIG_TARGET_CPUis broken.$ make ARCH=powerpc corenet64_smp_defconfig CROSS_COMPILE=powerpc64-linux-gnu- ... # configuration written to .configQuoted 7 lines
Quoted 4 lines
$ grep CONFIG_TARGET_CPU .config CONFIG_TARGET_CPU_BOOL=y
CONFIG_TARGET_CPU_BOOLis set butCONFIG_TARGET_CPUnot!Yes, because there is no default value for
E5500_CPUandE6500_CPU. We need to add one for each.With "[PATCH v1] powerpc/64: Set default CPU in
Kconfig" patch from
https://lore.kernel.org/linuxppc-dev/3fd60c2d8a28668a42b766b18362a526ef47e757.1670420281.git.christophe.leroy@csgroup.eu/
this change does not throw above compile error anymore.
Quoted 4 lines
Quoted 2 lines
That patch should land in powerpc/next soon. When it has landed, could you resent this patch so that snowpatch checks the build again ?
Yes. But I'm still waiting because patch is not in powerpc/next yet.
Seems that it still has not landed. Any suggestions to move forward?
Quoted 4 lines
Quoted 4 lines
Because at the time being it is flagged as "failed", see
https://patchwork.ozlabs.org/project/linuxppc-dev/patch/[email protected]/Christophe
Re: [PATCH v3] powerpc/boot: Don't always pass -mcpu=powerpc when building 32-bit uImage
Le 22/01/2023 à 12:19, Pali Rohár a écrit :
Quoted 60 lines · On Saturday 24 December 2022 18:44:52 Pali Rohár wrote:
Quoted 59 lines · On Thursday 08 December 2022 19:57:39 Christophe Leroy wrote:
Quoted 58 lines
Le 08/12/2022 à 20:16, Pali Rohár a écrit :
Quoted 55 lines · On Sunday 28 August 2022 17:43:53 Christophe Leroy wrote:
Quoted 43 lines
Le 28/08/2022 à 19:41, Pali Rohár a écrit :
Quoted 42 lines · On Sunday 28 August 2022 17:39:25 Christophe Leroy wrote:
Quoted 26 lines
Le 28/08/2022 à 19:33, Christophe Leroy a écrit :
Quoted 15 lines
Le 28/08/2022 à 11:56, Pali Rohár a écrit :
Quoted 11 lines
When
CONFIG_TARGET_CPUis specified then pass its value to the compiler -mcpu option. This fixes following build error when building kernel with powerpc e500 SPE capable cross compilers:BOOTAS
arch/powerpc/boot/crt0.o
powerpc-linux-gnuspe-gcc: error: unrecognized argument in option
‘-mcpu=powerpc’
powerpc-linux-gnuspe-gcc: note: valid arguments to ‘-mcpu=’ are:
8540 8548 native
make[1]: *** [arch/powerpc/boot/Makefile:231:arch/powerpc/boot/crt0.o] Error 1Quoted 9 lines
corenet64_smp_defconfig:BOOTAS
arch/powerpc/boot/crt0.o
powerpc64-linux-gcc: error: missing argument to '-mcpu=' make[1]: *** [arch/powerpc/boot/Makefile:237:arch/powerpc/boot/crt0.o] Erreur 1
make: *** [arch/powerpc/Makefile:253: uImage] Erreur 2Quoted 8 lines
Seems like in fact,
E5500_CPUandE6500_CPUare not taken into account inCONFIG_TARGET_CPU, and get special treatment directly inarch/powerpc/Makefile.This goes unnoticed because of CFLAGS-$(CONFIG_TARGET_CPU_BOOL) += $(call cc-option,-mcpu=$(CONFIG_TARGET_CPU))
I think we need to fix that prior to your patch.
It looks like that
CONFIG_TARGET_CPUis broken.$ make ARCH=powerpc corenet64_smp_defconfig CROSS_COMPILE=powerpc64-linux-gnu- ... # configuration written to .configQuoted 7 lines
Quoted 4 lines
$ grep CONFIG_TARGET_CPU .config CONFIG_TARGET_CPU_BOOL=y
CONFIG_TARGET_CPU_BOOLis set butCONFIG_TARGET_CPUnot!Yes, because there is no default value for
E5500_CPUandE6500_CPU. We need to add one for each.With "[PATCH v1] powerpc/64: Set default CPU in
Kconfig" patch from
https://lore.kernel.org/linuxppc-dev/3fd60c2d8a28668a42b766b18362a526ef47e757.1670420281.git.christophe.leroy@csgroup.eu/
this change does not throw above compile error anymore.
Quoted 6 lines
Quoted 4 lines
Quoted 2 lines
That patch should land in powerpc/next soon. When it has landed, could you resent this patch so that snowpatch checks the build again ?
Yes. But I'm still waiting because patch is not in powerpc/next yet.
Seems that it still has not landed. Any suggestions to move forward?
Hi
I just reposted to see if it passed the CI tests this time.
Christophe
Quoted 5 lines
Quoted 5 lines
Quoted 5 lines
Because at the time being it is flagged as "failed", see
https://patchwork.ozlabs.org/project/linuxppc-dev/patch/[email protected]/Christophe
Re: [PATCH v3] powerpc/boot: Don't always pass -mcpu=powerpc when building 32-bit uImage
Le 25/01/2023 à 08:40, Christophe Leroy a écrit :
Quoted 15 lines
Le 22/01/2023 à 12:19, Pali Rohár a écrit :
Quoted 12 lines · On Saturday 24 December 2022 18:44:52 Pali Rohár wrote:
Quoted 11 lines · On Thursday 08 December 2022 19:57:39 Christophe Leroy wrote:
Quoted 9 lines
Le 08/12/2022 à 20:16, Pali Rohár a écrit :
Quoted 4 lines
With "[PATCH v1] powerpc/64: Set default CPU in
Kconfig" patch from
https://lore.kernel.org/linuxppc-dev/3fd60c2d8a28668a42b766b18362a526ef47e757.1670420281.git.christophe.leroy@csgroup.eu/
this change does not throw above compile error anymore.That patch should land in powerpc/next soon. When it has landed, could you resent this patch so that snowpatch checks the build again ?
Quoted 7 lines
Quoted 3 lines
Quoted 1 line
Yes. But I'm still waiting because patch is not in powerpc/next yet.
Seems that it still has not landed. Any suggestions to move forward?
Hi
I just reposted to see if it passed the CI tests this time.
It is now in the tree.
Christophe
Re: [PATCH v3] powerpc/boot: Don't always pass -mcpu=powerpc when building 32-bit uImage
Quoted 20 lines · On Monday 20 February 2023 08:28:18 Christophe Leroy wrote:
Le 25/01/2023 à 08:40, Christophe Leroy a écrit :
Quoted 19 lines
Le 22/01/2023 à 12:19, Pali Rohár a écrit :
Quoted 15 lines · On Saturday 24 December 2022 18:44:52 Pali Rohár wrote:
Quoted 8 lines · On Thursday 08 December 2022 19:57:39 Christophe Leroy wrote:
Quoted 7 lines
Le 08/12/2022 à 20:16, Pali Rohár a écrit :
Quoted 4 lines
With "[PATCH v1] powerpc/64: Set default CPU in
Kconfig" patch from
https://lore.kernel.org/linuxppc-dev/3fd60c2d8a28668a42b766b18362a526ef47e757.1670420281.git.christophe.leroy@csgroup.eu/
this change does not throw above compile error anymore.Quoted 4 lines
Quoted 2 lines
That patch should land in powerpc/next soon. When it has landed, could you resent this patch so that snowpatch checks the build again ?
Yes. But I'm still waiting because patch is not in powerpc/next yet.
Seems that it still has not landed. Any suggestions to move forward?
Quoted 7 lines
Quoted 3 lines
Hi
I just reposted to see if it passed the CI tests this time.
It is now in the tree.
Christophe
I see, thanks!