dma-buf: cma_heap: Check for device max segment size when attaching
Subsystems (2)
PATCH v2 1/1 dma-buf: cma_heap: Check for device max segment size when attaching
Although there is usually not such a limitation (and when there is it is often only because the driver forgot to change the super small default), it is still correct here to break scatterlist element into chunks of dma_max_mapping_size().
This might cause some issues for users with misbehaving drivers. If bisecting has landed you on this commit, make sure your drivers both set dma_set_max_seg_size() and are checking for contiguousness correctly.
Signed-off-by Andrew Davis <[email protected]>
---
Changes from v1:
- Fixed mixed declarations and code warning
drivers/dma-buf/heaps/cma_heap.c | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-)
drivers/dma-buf/heaps/cma_heap.c +6 -4
@@ -52,16 +52,18 @@ static int cma_heap_attach(struct dma_buf *dmabuf, {struct cma_heap_buffer *buffer = dmabuf->priv;struct dma_heap_attachment *a; +size_t max_segment;int ret; a =kzalloc (sizeof (*a),GFP_KERNEL );if (!a)return -ENOMEM ; - ret =sg_alloc_table_from_pages (&a->table, buffer->pages, - buffer->pagecount,0 , - buffer->pagecount <<PAGE_SHIFT , -GFP_KERNEL ); + max_segment =dma_get_max_seg_size (attachment->dev); + ret =sg_alloc_table_from_pages_segment (&a->table, buffer->pages, + buffer->pagecount,0 , + buffer->pagecount <<PAGE_SHIFT , + max_segment,GFP_KERNEL );if (ret) {kfree (a);return ret;
Signature · 1 line
2.36.1