Skip to contentSkip to conversation

platform/x86: intel_cht_int33fe: Fix comment according to the code flow

PATCH In review Andy Shevchenko 2 participants 4 messages Aug 24, 2022 – Sep 1, 2022 x86 platform drivers

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 platform/x86: intel_cht_int33fe: Fix comment according to the code flow

We don't use software_node_register_nodes() in the code, fix the comment.

Fixes 140355e5db8b ("platform/x86: intel_cht_int33fe: Convert software node array to group")
---
 drivers/platform/x86/intel/chtwc_int33fe.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/platform/x86/intel/chtwc_int33fe.c +1 -1
index c52ac23e2331..9448e2e67c3f 100644
@@ -219,7 +219,7 @@ static int cht_int33fe_add_nodes(struct cht_int33fe_data *data)
 
 	/*
 	 * Update node used in "usb-role-switch" property. Note that we
-	 * rely on software_node_register_nodes() to use the original
+	 * rely on software_node_register_node_group() to use the original
 	 * instance of properties instead of copying them.
 	 */
 	fusb302_mux_refs[0].node = mux_ref_node;
Signature · 1 line
2.35.1
#1 lore raw
Quoted 1 line · Andy Shevchenko

We don't use software_node_register_nodes() in the code, fix the comment.

Any comments?

Signature · 2 lines
With Best Regards,
Andy Shevchenko
#2 lore raw

Hi,

Quoted 4 lines · Andy Shevchenko
Quoted 1 line · Andy Shevchenko

We don't use software_node_register_nodes() in the code, fix the comment.

Any comments?

No, I just have a bit of a patch backlog to process, I'm trying to process the backlog in FIFO order and I have not gotten around to this one yet.

Regards,

Hans

#3 lore raw
In reply to Andy Shevchenko

Hi,

Quoted 4 lines · Andy Shevchenko

We don't use software_node_register_nodes() in the code, fix the comment.

Fixes 140355e5db8b ("platform/x86: intel_cht_int33fe: Convert software node array to group")

Thank you for your patch, I've applied this patch to my review-hans branch:
https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans

Note it will show up in my review-hans branch once I've pushed my local branch there, which might take a while.

Once I've run some tests on this branch the patches there will be added to the platform-drivers-x86/for-next branch and eventually will be included in the pdx86 pull-request to Linus for the next merge-window.

Regards,

Hans

Quoted 17 lines
---
 drivers/platform/x86/intel/chtwc_int33fe.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/platform/x86/intel/chtwc_int33fe.c +1 -1
index c52ac23e2331..9448e2e67c3f 100644
@@ -219,7 +219,7 @@ static int cht_int33fe_add_nodes(struct cht_int33fe_data *data)
 
 	/*
 	 * Update node used in "usb-role-switch" property. Note that we
-	 * rely on software_node_register_nodes() to use the original
+	 * rely on software_node_register_node_group() to use the original
 	 * instance of properties instead of copying them.
 	 */
 	fusb302_mux_refs[0].node = mux_ref_node;