Skip to contentSkip to conversation

scripts: remove obsolete gcc-ld script

PATCH In review Lukas Bulwahn 4 participants 5 messages Aug 25, 2022 – Aug 29, 2022

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 scripts: remove obsolete gcc-ld script

Since commit 8564ed2b3888 ("Kbuild, lto: Add a gcc-ld script to let run gcc as ld") in 2014, there was not specific work on this the gcc-ld script other than treewide clean-ups.

There are no users within the kernel tree, and probably no out-of-tree users either, and there is no dedicated maintainer in MAINTAINERS.

Delete this obsolete gcc-ld script.

---
If there are no objections, I would like to get this patch included through the kbuild tree.

Masahiro-san, please pick this patch.

 scripts/gcc-ld | 30 ------------------------------
 1 file changed, 30 deletions(-)
 delete mode 100755 scripts/gcc-ld
scripts/gcc-ld deleted +0 -30
deleted file mode 100755
index 997b818c3962..000000000000
@@ -1,30 +0,0 @@
-#!/bin/sh
-# SPDX-License-Identifier: GPL-2.0
-# run gcc with ld options
-# used as a wrapper to execute link time optimizations
-# yes virginia, this is not pretty
-
-ARGS="-nostdlib"
-
-while [ "$1" != "" ] ; do
-	case "$1" in
-	-save-temps|-m32|-m64) N="$1" ;;
-	-r) N="$1" ;;
-	-[Wg]*) N="$1" ;;
-	-[olv]|-[Ofd]*|-nostdlib) N="$1" ;;
-	--end-group|--start-group)
-		 N="-Wl,$1" ;;
-	-[RTFGhIezcbyYu]*|\
---script|--defsym|-init|-Map|--oformat|-rpath|\
--rpath-link|--sort-section|--section-start|-Tbss|-Tdata|-Ttext|\
---version-script|--dynamic-list|--version-exports-symbol|--wrap|-m)
-		A="$1" ; shift ; N="-Wl,$A,$1" ;;
-	-[m]*) N="$1" ;;
-	-*) N="-Wl,$1" ;;
-	*)  N="$1" ;;
-	esac
-	ARGS="$ARGS $N"
-	shift
-done
-
-exec $CC $ARGS
Signature · 1 line
2.17.1
Reviewed-by on v1 1/1
#1 lore raw

+ Jiri in case this needs to be carried downstream.

Quoted 11 lines · Lukas Bulwahn

Since commit 8564ed2b3888 ("Kbuild, lto: Add a gcc-ld script to let run gcc as ld") in 2014, there was not specific work on this the gcc-ld script other than treewide clean-ups.

There are no users within the kernel tree, and probably no out-of-tree users either, and there is no dedicated maintainer in MAINTAINERS.

Delete this obsolete gcc-ld script.

No callers in-tree; happy to bring it back though should there later be. Thanks for the patch.

Quoted 49 lines

---
If there are no objections, I would like to get this patch included through the kbuild tree.

Masahiro-san, please pick this patch.

 scripts/gcc-ld | 30 ------------------------------
 1 file changed, 30 deletions(-)
 delete mode 100755 scripts/gcc-ld
scripts/gcc-ld deleted +0 -31
deleted file mode 100755
index 997b818c3962..000000000000
@@ -1,30 +0,0 @@
-#!/bin/sh
-# SPDX-License-Identifier: GPL-2.0
-# run gcc with ld options
-# used as a wrapper to execute link time optimizations
-# yes virginia, this is not pretty
-
-ARGS="-nostdlib"
-
-while [ "$1" != "" ] ; do
-       case "$1" in
-       -save-temps|-m32|-m64) N="$1" ;;
-       -r) N="$1" ;;
-       -[Wg]*) N="$1" ;;
-       -[olv]|-[Ofd]*|-nostdlib) N="$1" ;;
-       --end-group|--start-group)
-                N="-Wl,$1" ;;
-       -[RTFGhIezcbyYu]*|\
---script|--defsym|-init|-Map|--oformat|-rpath|\
--rpath-link|--sort-section|--section-start|-Tbss|-Tdata|-Ttext|\
---version-script|--dynamic-list|--version-exports-symbol|--wrap|-m)
-               A="$1" ; shift ; N="-Wl,$A,$1" ;;
-       -[m]*) N="$1" ;;
-       -*) N="-Wl,$1" ;;
-       *)  N="$1" ;;
-       esac
-       ARGS="$ARGS $N"
-       shift
-done
-
-exec $CC $ARGS
--

2.17.1

Signature · 2 lines
Thanks,
~Nick Desaulniers
#2 lore raw
Quoted 67 lines · Nick Desaulniers

+ Jiri in case this needs to be carried downstream.

Quoted 11 lines · Lukas Bulwahn

Since commit 8564ed2b3888 ("Kbuild, lto: Add a gcc-ld script to let run gcc as ld") in 2014, there was not specific work on this the gcc-ld script other than treewide clean-ups.

There are no users within the kernel tree, and probably no out-of-tree users either, and there is no dedicated maintainer in MAINTAINERS.

Delete this obsolete gcc-ld script.

No callers in-tree; happy to bring it back though should there later be. Thanks for the patch.

Quoted 46 lines

---
If there are no objections, I would like to get this patch included through the kbuild tree.

Masahiro-san, please pick this patch.

 scripts/gcc-ld | 30 ------------------------------
 1 file changed, 30 deletions(-)
 delete mode 100755 scripts/gcc-ld
scripts/gcc-ld deleted +0 -30
deleted file mode 100755
index 997b818c3962..000000000000
@@ -1,30 +0,0 @@
-#!/bin/sh
-# SPDX-License-Identifier: GPL-2.0
-# run gcc with ld options
-# used as a wrapper to execute link time optimizations
-# yes virginia, this is not pretty
-
-ARGS="-nostdlib"
-
-while [ "$1" != "" ] ; do
-       case "$1" in
-       -save-temps|-m32|-m64) N="$1" ;;
-       -r) N="$1" ;;
-       -[Wg]*) N="$1" ;;
-       -[olv]|-[Ofd]*|-nostdlib) N="$1" ;;
-       --end-group|--start-group)
-                N="-Wl,$1" ;;
-       -[RTFGhIezcbyYu]*|\
---script|--defsym|-init|-Map|--oformat|-rpath|\
--rpath-link|--sort-section|--section-start|-Tbss|-Tdata|-Ttext|\
---version-script|--dynamic-list|--version-exports-symbol|--wrap|-m)
-               A="$1" ; shift ; N="-Wl,$A,$1" ;;
-       -[m]*) N="$1" ;;
-       -*) N="-Wl,$1" ;;
-       *)  N="$1" ;;
-       esac
-       ARGS="$ARGS $N"
-       shift
-done
-
-exec $CC $ARGS
Quoted 8 lines
Quoted 3 lines

--
2.17.1

--
Thanks,
~Nick Desaulniers

Applied to linux-kbuild.
Thanks.

Signature · 2 lines
Best Regards
Masahiro Yamada
#3 lore raw
In reply to Nick Desaulniers
Quoted 1 line · Nick Desaulniers

+ Jiri in case this needs to be carried downstream.

Thanks.

Quoted 8 lines · Lukas Bulwahn
Quoted 7 lines

Since commit 8564ed2b3888 ("Kbuild, lto: Add a gcc-ld script to let run gcc as ld") in 2014, there was not specific work on this the gcc-ld script other than treewide clean-ups.

There are no users within the kernel tree, and probably no out-of-tree users either, and there is no dedicated maintainer in MAINTAINERS.

There are out-of-tree users.

Quoted 6 lines
Quoted 3 lines

Delete this obsolete gcc-ld script.

No callers in-tree; happy to bring it back though should there later be. Thanks for the patch.

I agree to have this downstream-only for the time being. We have updates for it queued, so we'd only start tracking the full content now...

BTW the script is not nice at all. How do the clang people cope with the issue? (Running gcc-ld instead of ld with proper arguments when linking using (full) LTO. For example "-z now" -> "-Wl,-z,now".)

Quoted 48 lines
Quoted 46 lines

---
If there are no objections, I would like to get this patch included through the kbuild tree.

Masahiro-san, please pick this patch.

  scripts/gcc-ld | 30 ------------------------------
  1 file changed, 30 deletions(-)

delete mode 100755 scripts/gcc-ld

scripts/gcc-ld deleted +0 -30
deleted file mode 100755
index 997b818c3962..000000000000
@@ -1,30 +0,0 @@
-#!/bin/sh
-# SPDX-License-Identifier: GPL-2.0
-# run gcc with ld options
-# used as a wrapper to execute link time optimizations
-# yes virginia, this is not pretty
-
-ARGS="-nostdlib"
-
-while [ "$1" != "" ] ; do
-       case "$1" in
-       -save-temps|-m32|-m64) N="$1" ;;
-       -r) N="$1" ;;
-       -[Wg]*) N="$1" ;;
-       -[olv]|-[Ofd]*|-nostdlib) N="$1" ;;
-       --end-group|--start-group)
-                N="-Wl,$1" ;;
-       -[RTFGhIezcbyYu]*|\
---script|--defsym|-init|-Map|--oformat|-rpath|\
--rpath-link|--sort-section|--section-start|-Tbss|-Tdata|-Ttext|\
---version-script|--dynamic-list|--version-exports-symbol|--wrap|-m)
-               A="$1" ; shift ; N="-Wl,$A,$1" ;;
-       -[m]*) N="$1" ;;
-       -*) N="-Wl,$1" ;;
-       *)  N="$1" ;;
-       esac
-       ARGS="$ARGS $N"
-       shift
-done
-
-exec $CC $ARGS
Signature · 2 lines
js
suse labs
#4 lore raw
Quoted 24 lines · Jiri Slaby
Quoted 1 line · Nick Desaulniers

+ Jiri in case this needs to be carried downstream.

Thanks.

Quoted 8 lines · Lukas Bulwahn
Quoted 7 lines

Since commit 8564ed2b3888 ("Kbuild, lto: Add a gcc-ld script to let run gcc as ld") in 2014, there was not specific work on this the gcc-ld script other than treewide clean-ups.

There are no users within the kernel tree, and probably no out-of-tree users either, and there is no dedicated maintainer in MAINTAINERS.

There are out-of-tree users.

Quoted 6 lines
Quoted 3 lines

Delete this obsolete gcc-ld script.

No callers in-tree; happy to bring it back though should there later be. Thanks for the patch.

Quoted 6 lines

I agree to have this downstream-only for the time being. We have updates for it queued, so we'd only start tracking the full content now...

BTW the script is not nice at all. How do the clang people cope with the issue? (Running gcc-ld instead of ld with proper arguments when linking using (full) LTO. For example "-z now" -> "-Wl,-z,now".)

This comes from the difference in which layer LTO is implemented.

GCC LTO is a feature of the GCC compiler.
GNU binutils is agnostic about LTO.
So, you need to use $(CC) as the linker driver. scripts/gcc-ld adds the '-Wl,' prefix to linker options.

Clang LTO works in cooperation with the LLD linker. So, the direct use of $(LD) works. scripts/gcc-ld is unneeded.

Signature · 2 lines
Best Regards
Masahiro Yamada