crypto: lib - remove unneeded selection of XOR_BLOCKS
Subsystems (3)
Eric Biggers
maintainerPATCH 1/1 crypto: lib - remove unneeded selection of XOR_BLOCKS
From: Eric Biggers <[email protected]>
CRYPTO_LIB_CHACHA_GENERIC doesn't need to select XOR_BLOCKS. It perhaps was thought that it's needed for __crypto_xor, but that's not the case.
Enabling XOR_BLOCKS is problematic because the XOR_BLOCKS code runs a benchmark when it is initialized. That causes a boot time regression on systems that didn't have it enabled before.
Therefore, remove this unnecessary and problematic selection.
---
I've separated this fix out from the larger patch
https://lore.kernel.org/r/[email protected]
that is currently queued in cryptodev.
lib/crypto/Kconfig | 1 - 1 file changed, 1 deletion(-)
lib/crypto/Kconfig +0 -1
@@ -33,7 +33,6 @@ config CRYPTO_ARCH_HAVE_LIB_CHACHA config CRYPTO_LIB_CHACHA_GENERIC tristate - select XOR_BLOCKS help This symbol can be depended upon by arch implementations of the ChaCha library interface that require the generic code as a
base-commit: 4c612826bec1441214816827979b62f84a097e91
Signature · 1 line
2.37.2
Herbert Xu
maintainerQuoted 14 lines · Eric Biggers
From: Eric Biggers <[email protected]>
CRYPTO_LIB_CHACHA_GENERICdoesn't need to selectXOR_BLOCKS. It perhaps was thought that it's needed for__crypto_xor, but that's not the case.Enabling
XOR_BLOCKSis problematic because theXOR_BLOCKScode runs a benchmark when it is initialized. That causes a boot time regression on systems that didn't have it enabled before.Therefore, remove this unnecessary and problematic selection.
Fixes e56e18985596 ("lib/crypto: add prompts back to crypto libraries")Signed-off-by Eric Biggers <[email protected]>
Quoted 8 lines
---
I've separated this fix out from the larger patch
https://lore.kernel.org/r/[email protected]
that is currently queued in cryptodev.lib/crypto/Kconfig | 1 - 1 file changed, 1 deletion(-)
Patch applied. Thanks.
Signature · 3 lines
Email: Herbert Xu <[email protected]> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt