Skip to contentSkip to conversation

crypto: lib - remove unneeded selection of XOR_BLOCKS

PATCH In review Eric Biggers 2 participants 2 messages Aug 26, 2022

Subsystems (3)
lore
Share & tools
lore

Eric Biggers

author maintainer
#0 lore raw

PATCH 1/1 crypto: lib - remove unneeded selection of XOR_BLOCKS

From: Eric Biggers <[email protected]>

CRYPTO_LIB_CHACHA_GENERIC doesn't need to select XOR_BLOCKS. It perhaps was thought that it's needed for __crypto_xor, but that's not the case.

Enabling XOR_BLOCKS is problematic because the XOR_BLOCKS code runs a benchmark when it is initialized. That causes a boot time regression on systems that didn't have it enabled before.

Therefore, remove this unnecessary and problematic selection.

Fixes e56e18985596 ("lib/crypto: add prompts back to crypto libraries")

---

I've separated this fix out from the larger patch
https://lore.kernel.org/r/[email protected]
that is currently queued in cryptodev.

 lib/crypto/Kconfig | 1 -
 1 file changed, 1 deletion(-)
lib/crypto/Kconfig +0 -1
index 9ff549f63540fa..47816af9a9d7e1 100644
@@ -33,7 +33,6 @@ config CRYPTO_ARCH_HAVE_LIB_CHACHA
 
 config CRYPTO_LIB_CHACHA_GENERIC
 	tristate
-	select XOR_BLOCKS
 	help
 	  This symbol can be depended upon by arch implementations of the
 	  ChaCha library interface that require the generic code as a

base-commit: 4c612826bec1441214816827979b62f84a097e91

Signature · 1 line
2.37.2
maintainer
#1 lore raw
Quoted 14 lines · Eric Biggers

From: Eric Biggers <[email protected]>

CRYPTO_LIB_CHACHA_GENERIC doesn't need to select XOR_BLOCKS. It perhaps was thought that it's needed for __crypto_xor, but that's not the case.

Enabling XOR_BLOCKS is problematic because the XOR_BLOCKS code runs a benchmark when it is initialized. That causes a boot time regression on systems that didn't have it enabled before.

Therefore, remove this unnecessary and problematic selection.

Fixes e56e18985596 ("lib/crypto: add prompts back to crypto libraries")
Quoted 8 lines

---

I've separated this fix out from the larger patch
https://lore.kernel.org/r/[email protected]
that is currently queued in cryptodev.

 lib/crypto/Kconfig | 1 -
 1 file changed, 1 deletion(-)

Patch applied. Thanks.

Signature · 3 lines
Email: Herbert Xu <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt