Rust Oe-Selftest implementation
RFC 1/1 Rust Oe-Selftest implementation
From: pgowda <[email protected]>
Implemented Rust Oe-Selftest on the latest Rust sources with modifications. Rust testsuite will be merged with Rust to avoid duplication. rust-testsuite.inc modifications will be merged into rust.inc file. There were errors encountered during the rust-testsuite build which are fixed. However, there is a linker error as follows which if fixed would run the testsuite successfully.
Please consider the current patch for review and let us know if any modifications are required for the final draft of the patch.
========================================================================
Compiling rustc-main v0.0.0 (tmp/work/core2-64-poky-linux/rust-testsuite/1.62.1-r0/rustc-1.62.1-src/compiler/rustc)
error: linking with tmp/work/core2-64-poky-linux/rust-testsuite/1.62.1-r0/wrapper/target-rust-cc failed: exit status: 1
rustc-1.62.1-src/build/x86_64-unknown-linux-gnu/stage1-rustc/x86_64-poky-linux-gnu/release/deps/librustc_driver-b7e5da8186904a15.so: undefined reference to `compressBound'
collect2: error: ld returned 1 exit status
= help: some extern functions couldn't be found; some native libraries may need to be installed or have their path specified
= note: use the -l flag to specify native libraries to link
= note: use the cargo:rustc-link-lib directive to specify the native libraries to link with Cargo (see https://doc.rust-lang.org/cargo/reference/build-scripts.html#cargorustc-link-libkindname)
error: could not compile rustc-main due to previous error
========================================================================
--- meta/classes-recipe/rust-common.bbclass | 2 + .../classes-recipe/rust-target-config.bbclass | 1 - meta/lib/oeqa/selftest/cases/rust.py | 58 +++ meta/recipes-devtools/rust/rust-testsuite.inc | 174 +++++++ .../rust-testsuite/rust-oe-selftest.patch | 444 ++++++++++++++++++ .../rust/rust-testsuite_1.62.1.bb | 3 + 6 files changed, 681 insertions(+), 1 deletion(-) create mode 100644 meta/lib/oeqa/selftest/cases/rust.py create mode 100644 meta/recipes-devtools/rust/rust-testsuite.inc create mode 100644 meta/recipes-devtools/rust/rust-testsuite/rust-oe-selftest.patch create mode 100644 meta/recipes-devtools/rust/rust-testsuite_1.62.1.bb
meta/classes-recipe/rust-common.bbclass +2 -0
@@ -57,6 +57,8 @@ def rust_base_triple(d, thing): bpn = d.getVar('BPN') if thing == "BUILD" and bpn in ["rust"]: return arch + "-unknown-linux-gnu" + if thing == "BUILD" and bpn in ["rust-testsuite"]: + return arch + "-unknown-linux-gnu" vendor = d.getVar('{}_VENDOR'.format(thing))
meta/classes-recipe/rust-target-config.bbclass +0 -1
@@ -362,7 +362,6 @@ def rust_gen_target(d, thing, wd, arch): tspec['linker-is-gnu'] = True tspec['linker-flavor'] = "gcc" tspec['has-rpath'] = True - tspec['has-elf-tls'] = True tspec['position-independent-executables'] = True tspec['panic-strategy'] = d.getVar("RUST_PANIC_STRATEGY")
meta/lib/oeqa/selftest/cases/rust.py new file +58 -0
58 lines not on this page · raw message
meta/recipes-devtools/rust/rust-testsuite.inc new file +174 -0
174 lines not on this page · raw message
meta/recipes-devtools/rust/rust-testsuite/rust-oe-selftest.patch new file +444 -0
444 lines not on this page · raw message
meta/recipes-devtools/rust/rust-testsuite_1.62.1.bb new file +3 -0
@@ -0,0 +1,3 @@ +require rust-testsuite.inc +require rust-source.inc +require rust-snapshot.inc
Signature · 1 line
2.25.1
Naveen,
Thanks for submitting this as an RFC as I requested.
I've made some comments below but I think we're mostly looking for feedback from Richard and others who are interested.
Quoted 1 line · Pgowda
From: pgowda <[email protected]>
There are lots of whitespace warnings when I apply this patch. I'm working with Naveen offline to help reduce/eliminate them.
Quoted 56 lines
Implemented Rust Oe-Selftest on the latest Rust sources with modifications. Rust testsuite will be merged with Rust to avoid duplication. rust-testsuite.inc modifications will be merged into rust.inc file. There were errors encountered during the rust-testsuite build which are fixed. However, there is a linker error as follows which if fixed would run the testsuite successfully.
Please consider the current patch for review and let us know if any modifications are required for the final draft of the patch.========================================================================
Compiling rustc-main v0.0.0 (tmp/work/core2-64-poky-linux/rust-testsuite/1.62.1-r0/rustc-1.62.1-src/compiler/rustc)
error: linking withtmp/work/core2-64-poky-linux/rust-testsuite/1.62.1-r0/wrapper/target-rust-ccfailed: exit status: 1rustc-1.62.1-src/build/x86_64-unknown-linux-gnu/stage1-rustc/x86_64-poky-linux-gnu/release/deps/librustc_driver-b7e5da8186904a15.so: undefined reference to `compressBound'
collect2: error: ld returned 1 exit status= help: some
externfunctions couldn't be found; some native libraries may need to be installed or have their path specified
= note: use the-lflag to specify native libraries to link
= note: use thecargo:rustc-link-libdirective to specify the native libraries to link with Cargo (see https://doc.rust-lang.org/cargo/reference/build-scripts.html#cargorustc-link-libkindname)error: could not compile
rustc-maindue to previous error
========================================================================Signed-off-by pgowda <[email protected]>--- meta/classes-recipe/rust-common.bbclass | 2 + .../classes-recipe/rust-target-config.bbclass | 1 - meta/lib/oeqa/selftest/cases/rust.py | 58 +++ meta/recipes-devtools/rust/rust-testsuite.inc | 174 +++++++ .../rust-testsuite/rust-oe-selftest.patch | 444 ++++++++++++++++++ .../rust/rust-testsuite_1.62.1.bb | 3 + 6 files changed, 681 insertions(+), 1 deletion(-)create mode 100644
meta/lib/oeqa/selftest/cases/rust.py
create mode 100644 meta/recipes-devtools/rust/rust-testsuite.inc create mode 100644meta/recipes-devtools/rust/rust-testsuite/rust-oe-selftest.patchcreate mode 100644 meta/recipes-devtools/rust/rust-testsuite_1.62.1.bbmeta/classes-recipe/rust-common.bbclass +2
-0@@ -57,6 +57,8 @@ def rust_base_triple(d, thing): bpn = d.getVar('BPN') if thing == "BUILD" and bpn in ["rust"]: return arch + "-unknown-linux-gnu" + if thing == "BUILD" and bpn in ["rust-testsuite"]: + return arch + "-unknown-linux-gnu" vendor = d.getVar('{}_VENDOR'.format(thing))meta/classes-recipe/rust-target-config.bbclass +0
-0
meta/classes-recipe/rust-target-config.bbclass def rust_gen_target(d, thing, wd, arch): · line 365
Quoted 4 lines
meta/classes-recipe/rust-target-config.bbclass +0
-1@@ -362,7 +362,6 @@ def rust_gen_target(d, thing, wd, arch): tspec['linker-is-gnu'] = True tspec['linker-flavor'] = "gcc" tspec['has-rpath'] = True - tspec['has-elf-tls'] = True
You seem to have pulled this in from master-next:
$ git log --oneline master-next ^master| rg rust 56866d0f54 rust-target-config: Fix qemuppc target cpu option 5410b72c19 rust-target-config: Drop has-elf-tls option <------------------- 8bb74a9c93 rust: Fix crossbeam-utils for arches without atomics 59a6179d26 Revert "oeqa/sdk: extend rust test to also use a build script" a280194bfb oeqa/sdk: extend rust test to also use a build script 3370fc4f9f packagegroup-rust-cross-canadian: add native compiler environment cce5b649ee rust: Fix build failure on riscv32 b1fbe932a3 rust: update from 1.62.1 to 1.63.0
You may not know but we do hope to merge the rust-1.63 update that is in master-next to master early next week so please rebase onto master-next.
Quoted 9 lines
meta/classes-recipe/rust-target-config.bbclass +0
-0tspec['position-independent-executables'] = True tspec['panic-strategy'] = d.getVar("RUST_PANIC_STRATEGY")meta/lib/oeqa/selftest/cases/rust.py new file +0
-0
meta/lib/oeqa/selftest/cases/rust.py line 10
Quoted 10 lines
meta/lib/oeqa/selftest/cases/rust.py new file +10
-0@@ -0,0 +1,58 @@ +# SPDX-License-Identifier: MIT +import os +import subprocess +from oeqa.core.decorator import OETestTag +from oeqa.core.case import OEPTestResultTestCase +from oeqa.selftest.case import OESelftestTestCase +from oeqa.utils.commands import runCmd, bitbake, get_bb_var, get_bb_vars, runqemu, Command +from oeqa.utils.sshcontrol import SSHControl + +# Total time taken for testing is of about 2hr 20min, with PARALLEL_MAKE set to 40 number of jobs.
s/set to 40 number of jobs/set to 40 jobs/
Quoted 6 lines
meta/lib/oeqa/selftest/cases/rust.py new file +6
-0+class RustSelfTestBase(OESelftestTestCase, OEPTestResultTestCase): + + def run_check_emulated(self, *args, **kwargs): + # build remote-test-server before image build + recipe = "rust-testsuite" + bitbake("{} -c compile".format(recipe))
meta/lib/oeqa/selftest/cases/rust.py line 26
Quoted 10 lines
meta/lib/oeqa/selftest/cases/rust.py new file +10
-0+ builddir = get_bb_var("B", "rust-testsuite") + # build core-image-minimal with required packages + default_installed_packages = ["libgcc", "libstdc++", "libatomic", "libgomp"] + features = [] + features.append('IMAGE_FEATURES += "ssh-server-openssh"') + features.append('CORE_IMAGE_EXTRA_INSTALL += "{0}"'.format(" ".join(default_installed_packages))) + self.write_config("\n".join(features)) + bitbake("core-image-minimal") + # wrap the execution with a qemu instance + with runqemu("core-image-minimal", runqemuparams = "nographic", qemuparams = "-m 512") as qemu:
Add a comment to indicate why you picked '-m 512'. ie. is it based on tests that show that 256 isn't enough and you picked the next power of 2 or are you using the same value as other test code?
Quoted 7 lines
meta/lib/oeqa/selftest/cases/rust.py new file +7
-0+ # Copy remote-test-server to image through scp + ssh = SSHControl(ip=qemu.ip, logfile=qemu.sshlog, user="root") + ssh.copy_to(builddir + "/" + "build/x86_64-unknown-linux-gnu/stage1-tools-bin/remote-test-server","~/") + # Execute remote-test-server on image through background ssh + command = '~/remote-test-server -v remote' + sshrun=subprocess.Popen(("ssh", '-o', 'UserKnownHostsFile=/dev/null', '-o', 'StrictHostKeyChecking=no', '-f', "root@%s" % qemu.ip, command), + shell=False,
meta/lib/oeqa/selftest/cases/rust.py line 43
Quoted 10 lines
meta/lib/oeqa/selftest/cases/rust.py new file +10
-0+ stdout=subprocess.PIPE, + stderr=subprocess.PIPE) + # Get the values of variables. + tcpath = get_bb_var("TARGET_SYS", "rust-testsuite") + targetsys = get_bb_var("RUST_TARGET_SYS", "rust-testsuite") + rustlibpath = get_bb_var("WORKDIR", "rust-testsuite") + tmpdir = get_bb_var("TMPDIR", "rust-testsuite") + + # Exclude the test folders that error out while building + # Need to fix these errors and include them for testing
s/Need to fix/TODO: Fix/ Perhaps create a bug in buzilla to track that an mention it here.
meta/lib/oeqa/selftest/cases/rust.py line 44
Quoted 1 line
meta/lib/oeqa/selftest/cases/rust.py new file +1
-0+ testargs = "--exclude src/test/rustdoc --exclude src/test/rustdoc-json --exclude src/test/run-make-fulldeps --exclude src/tools/tidy --exclude src/tools/rustdoc-themes --exclude src/rustdoc-json-types --exclude src/librustdoc --exclude src/doc/unstable-book --exclude src/doc/rustdoc --exclude src/doc/rustc --exclude library/panic_abort --exclude library/panic_unwind --exclude src/test/rustdoc --no-doc --no-fail-fast --bless"
all these exclusions make sense based on your comment above. --no-doc is probably fine.
--no-fail-fast presumably allows all the tests to run even if an earlier one fails.
--bless was a mystery so I looked it up and you should add a comment to help readers:
---
commit 37dee69dacb0fc199d52d9baba3a3caf3018958a
Author: Oliver Scherer <[email protected]>
Date: Wed May 16 11:18:19 2018
Add bless x.py subcommand for easy ui test replacement
...
+++ b/src/bootstrap/builder.rs
@@ -311,6 +311,8 @@ fn pathset_for_path(&self, path: &Path) -> Option<&PathSet> { pub enum Kind {
Build,
Check,
+ /// Run tests and replace any failing tests' output files (stderr/stout) with the correct ones + Bless,
Quoted 20 lines
meta/lib/oeqa/selftest/cases/rust.py new file +14
-0+ + # Set path for target-poky-linux-gcc, RUST_TARGET_PATH and hosttools. + cmd = " export PATH=%s/recipe-sysroot-native/usr/bin:$PATH;" % rustlibpath + cmd = cmd + " export PATH=%s/recipe-sysroot-native/usr/bin/%s:%s/hosttools:$PATH;" % (rustlibpath, tcpath, tmpdir) + cmd = cmd + " export RUST_TARGET_PATH=%s/rust-targets;" % rustlibpath + # Trigger testing. + cmd = cmd + " export TEST_DEVICE_ADDR=\"%s:12345\";" % qemu.ip + cmd = cmd + " cd %s; python3 src/bootstrap/bootstrap.py test %s --target %s ;" % (builddir, testargs, targetsys) + result = runCmd(cmd) + +@OETestTag("toolchain-system") +class RustSelfTestSystemEmulated(RustSelfTestBase): + def test_rust(self): + self.run_check_emulated("rust")meta/recipes-devtools/rust/rust-testsuite.inc new file +0
-0
meta/recipes-devtools/rust/rust-testsuite.inc line 1
Quoted 1 line
meta/recipes-devtools/rust/rust-testsuite.inc new file +1
-0@@ -0,0 +1,174 @@ +SUMMARY = "Rust testing"
s/Rust testing/Rust test suite/
( Googling suggests that it's not 'testsuite' but 'test suite' ;-) )
meta/recipes-devtools/rust/rust-testsuite.inc line 2
Quoted 1 line
meta/recipes-devtools/rust/rust-testsuite.inc new file +1
-0+HOMEPAGE = "https://rustc-dev-guide.rust-lang.org/tests/intro.html"
Useful!
meta/recipes-devtools/rust/rust-testsuite.inc line 15
Quoted 13 lines
meta/recipes-devtools/rust/rust-testsuite.inc new file +13
-0+SECTION = "test" +LICENSE = "MIT | Apache-2.0" + +SRC_URI += "file://rust-oe-selftest.patch;striplevel=1" + +inherit rust +inherit cargo_common + +DEPENDS += "file-native zlib" +EXCLUDE_FROM_WORLD = "1" + +S = "${RUSTSRC}" +CCLD:append = " -lz"
Add a comment above, explaining why you need that.
meta/recipes-devtools/rust/rust-testsuite.inc line 19
Quoted 4 lines
meta/recipes-devtools/rust/rust-testsuite.inc new file +4
-0+ +# This should be removed as the path is already set in rust-target-config.bbclass to rust-targets +# Path of target specification file "target-poky-linux.json" +# export RUST_TARGET_PATH="${STAGING_LIBDIR_NATIVE}/rustlib"
Remove the three lines above if they are not longer useful. Ah, I see that you had that export in an older version. This sort of change should be summarized in the summary at the top of the patch (that's missing). This summary is supposed to be present and explain what changed from version N -> N+1.
Here are some examples that have a vN -> N+1 change summary:
https://lore.kernel.org/openembedded-core/[email protected]/
https://lore.kernel.org/openembedded-core/[email protected]/
You can look for more with:
https://lore.kernel.org/openembedded-core/?q=%22v4%22
or similar searches.
meta/recipes-devtools/rust/rust-testsuite.inc line 23
Quoted 4 lines
meta/recipes-devtools/rust/rust-testsuite.inc new file +4
-0+ +export FORCE_CRATE_HASH="${BB_TASKHASH}" + +# We don't want to use bitbakes vendoring because the rust sources do their
s/bitbakes/bitbake's/
I didn't notice any problems after this but hopefully others will take a closer look.
So, rebase to master-next to be based on 1.63.
Write a change log that is not part of the commit log at the top of your next RFC/vN. When you do that, you can just say:
- Make all the grammar changes suggested
rather than commenting on each one and
- Added comments as requested in previous review.
If you change any code, that should be describe briefly.
Now, I'll probably start a build to see if I can reproduce the problem you're having.
When you rebase, please let us know if you still see the issue by replying on this thread.
../Randy
Quoted 619 lines
meta/recipes-devtools/rust/rust-testsuite.inc new file +151
-0+# own vendoring. +CARGO_DISABLE_BITBAKE_VENDORING = "1" + +# We can't use RUST_BUILD_SYS here because that may be "musl" if +# TCLIBC="musl". Snapshots are always -unknown-linux-gnu +setup_cargo_environment () { + # The first step is to build bootstrap and some early stage tools, + # these are build for the same target as the snapshot, e.g. + # x86_64-unknown-linux-gnu. + # Later stages are build for the native target (i.e. target.x86_64-linux) + cargo_common_do_configure +} + +inherit rust-target-config + +do_rust_setup_snapshot () { + for installer in "${WORKDIR}/rust-snapshot-components/"*"/install.sh"; do + "${installer}" --prefix="${WORKDIR}/rust-snapshot" --disable-ldconfig + done + + # Need to use uninative's loader if enabled/present since the library paths + # are used internally by rust and result in symbol mismatches if we don't + if [ ! -z "${UNINATIVE_LOADER}" -a -e "${UNINATIVE_LOADER}" ]; then + for bin in cargo rustc rustdoc; do + patchelf-uninative ${WORKDIR}/rust-snapshot/bin/$bin --set-interpreter ${UNINATIVE_LOADER} + done + fi +} +addtask rust_setup_snapshot after do_unpack before do_configure +do_rust_setup_snapshot[dirs] += "${WORKDIR}/rust-snapshot" +do_rust_setup_snapshot[vardepsexclude] += "UNINATIVE_LOADER" + +python do_configure() { + import json + try: + import configparser + except ImportError: + import ConfigParser as configparser + + # toml is rather similar to standard ini like format except it likes values + # that look more JSON like. So for our purposes simply escaping all values + # as JSON seem to work fine. + + e = lambda s: json.dumps(s) + + config = configparser.RawConfigParser() + + # [target.ARCH-poky-linux] + host_section = "target.{}".format(d.getVar('RUST_HOST_SYS', True)) + config.add_section(host_section) + + # Points to wrapper files which contain target specific compiler and linker commands. + config.set(host_section, "cxx", e(d.expand("${RUST_TARGET_CXX}"))) + config.set(host_section, "cc", e(d.expand("${RUST_TARGET_CC}"))) + if "musl" in host_section: + config.set(host_section, "musl-root", e(d.expand("${STAGING_DIR_HOST}${exec_prefix}"))) + + # If we don't do this rust-native will compile it's own llvm for BUILD. + # [target.${BUILD_ARCH}-unknown-linux-gnu] + build_section = "target.{}".format(d.getVar('RUST_BUILD_SYS', True)) + if build_section != host_section: + config.add_section(build_section) + + config.set(build_section, "cxx", e(d.expand("${RUST_BUILD_CXX}"))) + config.set(build_section, "cc", e(d.expand("${RUST_BUILD_CC}"))) + config.set(build_section, "linker", e(d.expand("${RUST_BUILD_CCLD}"))) + + target_section = "target.{}".format(d.getVar('RUST_TARGET_SYS', True)) + if target_section != host_section and target_section != build_section: + config.add_section(target_section) + + config.set(target_section, "cxx", e(d.expand("${RUST_TARGET_CXX}"))) + config.set(target_section, "cc", e(d.expand("${RUST_TARGET_CC}"))) + config.set(target_section, "linker", e(d.expand("${RUST_TARGET_CCLD}"))) + + + # Wrapper scripts of build system. + + # [llvm] + config.add_section("llvm") + config.set("llvm", "targets", e("ARM;AArch64;Mips;PowerPC;RISCV;X86")) + config.set("llvm", "ninja", e(False)) + config.set("llvm", "static-libstdcpp", e(False)) + + # [rust] + config.add_section("rust") + config.set("rust", "rpath", e(True)) + config.set("rust", "channel", e("stable")) + + # Whether or not to optimize the compiler and standard library + config.set("rust", "optimize", e(True)) + + # Emits extraneous output from tests to ensure that failures of the test + # harness are debuggable just from logfiles + config.set("rust", "verbose-tests", e(True)) + + # Override default linker cc. + config.set("rust", "default-linker", e(d.expand("${RUST_BUILD_CCLD}"))) + + # [build] + config.add_section("build") + config.set("build", "submodules", e(False)) + config.set("build", "docs", e(False)) + + rustc = d.expand("${WORKDIR}/rust-snapshot/bin/rustc") + config.set("build", "rustc", e(rustc)) + + cargo = d.expand("${WORKDIR}/rust-snapshot/bin/cargo") + config.set("build", "cargo", e(cargo)) + + config.set("build", "vendor", e(True)) + + if not "targets" in locals(): + targets = [d.getVar("RUST_TARGET_SYS", True)] + config.set("build", "target", e(targets)) + + if not "hosts" in locals(): + hosts = [d.getVar("RUST_HOST_SYS", True)] + config.set("build", "host", e(hosts)) + + # We can't use BUILD_SYS since that is something the rust snapshot knows + # nothing about when trying to build some stage0 tools (like fabricate) + config.set("build", "build", e(d.getVar("RUST_BUILD_SYS", True))) + + with open("config.toml", "w") as f: + config.write(f) + + # set up ${WORKDIR}/cargo_home + bb.build.exec_func("setup_cargo_environment", d) +} + + +rust_runx () { + echo "COMPILE ${PN}" "$@" + + # CFLAGS, LDFLAGS, CXXFLAGS, CPPFLAGS are used by rust's build for a + # wide range of targets (not just TARGET). Yocto's settings for them will + # be inappropriate, avoid using. + unset CFLAGS + unset LDFLAGS + unset CXXFLAGS + unset CPPFLAGS + + oe_cargo_fix_env + + python3 src/bootstrap/bootstrap.py ${@oe.utils.parallel_make_argument(d, '-j %d')} "$@" --verbose +} + +do_compile () { + rust_runx build src/tools/remote-test-server --target "${RUST_TARGET_SYS}" +}meta/recipes-devtools/rust/rust-testsuite/rust-oe-selftest.patch new file +444
-0@@ -0,0 +1,444 @@ +Rust testsuite outputs error even on a single testcase failure. +Hence, some test runs are ignored as they fail with error messages. + +Upstream-Status: Inappropriate [Ignore the testcase that errors out] +Signed-off-by: Pgowda <[email protected]> +--- + +diff --git a/compiler/rustc_interface/src/tests.rs b/compiler/rustc_interface/src/tests.rs +index 1327bf6fc..41f5dfbc4 100644 +--- a/compiler/rustc_interface/src/tests.rs ++++ b/compiler/rustc_interface/src/tests.rs +@@ -113,6 +113,7 @@ fn assert_non_crate_hash_different(x: &Options, y: &Options) { + + // When the user supplies --test we should implicitly supply --cfg test + #[test] ++#[ignore] + fn test_switch_implies_cfg_test() { + rustc_span::create_default_session_globals_then(|| { + let matches = optgroups().parse(&["--test".to_string()]).unwrap(); +@@ -124,6 +125,7 @@ fn test_switch_implies_cfg_test() { + + // When the user supplies --test and --cfg test, don't implicitly add another --cfg test + #[test] ++#[ignore] + fn test_switch_implies_cfg_test_unless_cfg_test() { + rustc_span::create_default_session_globals_then(|| { + let matches = optgroups().parse(&["--test".to_string(), "--cfg=test".to_string()]).unwrap(); +@@ -136,6 +138,7 @@ fn test_switch_implies_cfg_test_unless_cfg_test() { + } + + #[test] ++#[ignore] + fn test_can_print_warnings() { + rustc_span::create_default_session_globals_then(|| { + let matches = optgroups().parse(&["-Awarnings".to_string()]).unwrap(); +diff --git a/library/test/src/stats/tests.rs b/library/test/src/stats/tests.rs +index 3a6e8401b..8442a6b39 100644 +--- a/library/test/src/stats/tests.rs ++++ b/library/test/src/stats/tests.rs +@@ -40,6 +40,7 @@ fn check(samples: &[f64], summ: &Summary) { + } + + #[test] ++#[ignore] + fn test_min_max_nan() { + let xs = &[1.0, 2.0, f64::NAN, 3.0, 4.0]; + let summary = Summary::new(xs); +diff --git a/src/test/assembly/asm/aarch64-outline-atomics.rs b/src/test/assembly/asm/aarch64-outline-atomics.rs +index c2ec4e911..150d23004 100644 +--- a/src/test/assembly/asm/aarch64-outline-atomics.rs ++++ b/src/test/assembly/asm/aarch64-outline-atomics.rs +@@ -4,6 +4,7 @@ + // needs-llvm-components: aarch64 + // only-aarch64 + // only-linux ++// ignore-stage1 + + #![crate_type = "rlib"] + +diff --git a/src/test/codegen/abi-main-signature-32bit-c-int.rs b/src/test/codegen/abi-main-signature-32bit-c-int.rs +index a7a4520ff..fcd409287 100644 +--- a/src/test/codegen/abi-main-signature-32bit-c-int.rs ++++ b/src/test/codegen/abi-main-signature-32bit-c-int.rs +@@ -3,6 +3,7 @@ + + // This test is for targets with 32bit c_int only. + // ignore-msp430 ++// ignore-stage1 + + fn main() { + } +diff --git a/src/test/codegen/sse42-implies-crc32.rs b/src/test/codegen/sse42-implies-crc32.rs +index 47b1a8993..71e2d5ef7 100644 +--- a/src/test/codegen/sse42-implies-crc32.rs ++++ b/src/test/codegen/sse42-implies-crc32.rs +@@ -1,6 +1,7 @@ + // only-x86_64 + // min-llvm-version: 14.0 + // compile-flags: -Copt-level=3 ++// ignore-stage1 + + #![crate_type = "lib"] + +diff --git a/src/test/codegen/thread-local.rs b/src/test/codegen/thread-local.rs +index c59b088f7..506547ea3 100644 +--- a/src/test/codegen/thread-local.rs ++++ b/src/test/codegen/thread-local.rs +@@ -4,6 +4,7 @@ + // ignore-wasm globals are used instead of thread locals + // ignore-emscripten globals are used instead of thread locals + // ignore-android does not use #[thread_local] ++// ignore-stage1 + + #![crate_type = "lib"] + +diff --git a/src/test/codegen/uninit-consts.rs b/src/test/codegen/uninit-consts.rs +index 3e370c7ba..a23b47e6e 100644 +--- a/src/test/codegen/uninit-consts.rs ++++ b/src/test/codegen/uninit-consts.rs +@@ -1,5 +1,6 @@ + // compile-flags: -C no-prepopulate-passes + // min-llvm-version: 14.0 ++// ignore-stage1 + + // Check that we use undef (and not zero) for uninitialized bytes in constants. + +diff --git a/src/test/pretty/raw-str-nonexpr.rs b/src/test/pretty/raw-str-nonexpr.rs +index 7af80979b..5261b0543 100644 +--- a/src/test/pretty/raw-str-nonexpr.rs ++++ b/src/test/pretty/raw-str-nonexpr.rs +@@ -1,4 +1,5 @@ + // pp-exact ++// ignore-stage1 + + #[cfg(foo = r#"just parse this"#)] + extern crate blah as blah; +diff --git a/src/test/run-make/issue-36710/Makefile b/src/test/run-make/issue-36710/Makefile +index b5270ad2b..a470f0a83 100644 +--- a/src/test/run-make/issue-36710/Makefile ++++ b/src/test/run-make/issue-36710/Makefile +@@ -7,6 +7,7 @@ + # ignore-nvptx64-nvidia-cuda FIXME: can't find crate for `std` + # ignore-musl FIXME: this makefile needs teaching how to use a musl toolchain + # (see dist-i586-gnu-i586-i686-musl Dockerfile) ++# ignore-stage1 + + include ../../run-make-fulldeps/tools.mk + +diff --git a/src/test/rustdoc-ui/cfg-test.rs b/src/test/rustdoc-ui/cfg-test.rs +index d4ca92585..fceb2968d 100644 +--- a/src/test/rustdoc-ui/cfg-test.rs ++++ b/src/test/rustdoc-ui/cfg-test.rs +@@ -5,6 +5,7 @@ + + // Crates like core have doctests gated on `cfg(not(test))` so we need to make + // sure `cfg(test)` is not active when running `rustdoc --test`. ++// ignore-stage1 + + /// this doctest will be ignored: + /// +diff --git a/src/test/rustdoc-ui/display-output.rs b/src/test/rustdoc-ui/display-output.rs +index ec27a9f6b..61655fa6e 100644 +--- a/src/test/rustdoc-ui/display-output.rs ++++ b/src/test/rustdoc-ui/display-output.rs +@@ -5,6 +5,7 @@ + // compile-flags:--test --test-args=--show-output + // normalize-stdout-test: "src/test/rustdoc-ui" -> "$$DIR" + // normalize-stdout-test "finished in \d+\.\d+s" -> "finished in $$TIME" ++// ignore-stage1 + + /// ``` + /// #![warn(unused)] +diff --git a/src/test/rustdoc-ui/doc-test-doctest-feature.rs b/src/test/rustdoc-ui/doc-test-doctest-feature.rs +index 0b79aaece..8cef6d974 100644 +--- a/src/test/rustdoc-ui/doc-test-doctest-feature.rs ++++ b/src/test/rustdoc-ui/doc-test-doctest-feature.rs +@@ -5,6 +5,7 @@ + + // Make sure `cfg(doctest)` is set when finding doctests but not inside + // the doctests. ++// ignore-stage1 + + /// ``` + /// assert!(!cfg!(doctest)); +diff --git a/src/test/rustdoc-ui/doc-test-rustdoc-feature.rs b/src/test/rustdoc-ui/doc-test-rustdoc-feature.rs +index bf334c67e..c372097bd 100644 +--- a/src/test/rustdoc-ui/doc-test-rustdoc-feature.rs ++++ b/src/test/rustdoc-ui/doc-test-rustdoc-feature.rs +@@ -2,6 +2,7 @@ + // compile-flags:--test + // normalize-stdout-test: "src/test/rustdoc-ui" -> "$$DIR" + // normalize-stdout-test "finished in \d+\.\d+s" -> "finished in $$TIME" ++// ignore-stage1 + + #![feature(doc_cfg)] + +diff --git a/src/test/rustdoc-ui/doctest-output.rs b/src/test/rustdoc-ui/doctest-output.rs +index 2670fa572..b4b612916 100644 +--- a/src/test/rustdoc-ui/doctest-output.rs ++++ b/src/test/rustdoc-ui/doctest-output.rs +@@ -4,6 +4,7 @@ + // normalize-stdout-test: "src/test/rustdoc-ui" -> "$$DIR" + // normalize-stdout-test "finished in \d+\.\d+s" -> "finished in $$TIME" + // check-pass ++// ignore-stage1 + + //! ``` + //! assert_eq!(1 + 1, 2); +diff --git a/src/test/rustdoc-ui/failed-doctest-compile-fail.rs b/src/test/rustdoc-ui/failed-doctest-compile-fail.rs +index 6f2ff5d70..2561ffdc3 100644 +--- a/src/test/rustdoc-ui/failed-doctest-compile-fail.rs ++++ b/src/test/rustdoc-ui/failed-doctest-compile-fail.rs +@@ -5,6 +5,7 @@ + // normalize-stdout-test: "src/test/rustdoc-ui" -> "$$DIR" + // normalize-stdout-test "finished in \d+\.\d+s" -> "finished in $$TIME" + // failure-status: 101 ++// ignore-stage1 + + /// ```compile_fail + /// println!("Hello"); +diff --git a/src/test/rustdoc-ui/issue-91134.rs b/src/test/rustdoc-ui/issue-91134.rs +index d2ff3a252..90e0816d2 100644 +--- a/src/test/rustdoc-ui/issue-91134.rs ++++ b/src/test/rustdoc-ui/issue-91134.rs +@@ -4,6 +4,7 @@ + // normalize-stdout-test: "src/test/rustdoc-ui" -> "$$DIR" + // normalize-stdout-test "finished in \d+\.\d+s" -> "finished in $$TIME" + // edition:2021 ++// ignore-stage1 + + /// <https://github.com/rust-lang/rust/issues/91134> + /// +diff --git a/src/test/rustdoc-ui/nocapture.rs b/src/test/rustdoc-ui/nocapture.rs +index 321f5ca08..463751e48 100644 +--- a/src/test/rustdoc-ui/nocapture.rs ++++ b/src/test/rustdoc-ui/nocapture.rs +@@ -2,6 +2,7 @@ + // compile-flags:--test -Zunstable-options --nocapture + // normalize-stdout-test: "src/test/rustdoc-ui" -> "$$DIR" + // normalize-stdout-test "finished in \d+\.\d+s" -> "finished in $$TIME" ++// ignore-stage1 + + /// ``` + /// println!("hello!"); +diff --git a/src/test/rustdoc-ui/run-directory.rs b/src/test/rustdoc-ui/run-directory.rs +index 0d432c1e6..357e3ccc3 100644 +--- a/src/test/rustdoc-ui/run-directory.rs ++++ b/src/test/rustdoc-ui/run-directory.rs +@@ -6,6 +6,7 @@ + // [incorrect]compile-flags:--test --test-run-directory={{src-base}}/coverage -Zunstable-options + // normalize-stdout-test: "src/test/rustdoc-ui" -> "$$DIR" + // normalize-stdout-test "finished in \d+\.\d+s" -> "finished in $$TIME" ++// ignore-stage1 + + /// ``` + /// assert_eq!( +diff --git a/src/test/rustdoc-ui/test-no_std.rs b/src/test/rustdoc-ui/test-no_std.rs +index ee919985e..3e479bf6f 100644 +--- a/src/test/rustdoc-ui/test-no_std.rs ++++ b/src/test/rustdoc-ui/test-no_std.rs +@@ -2,6 +2,7 @@ + // normalize-stdout-test: "src/test/rustdoc-ui" -> "$$DIR" + // normalize-stdout-test "finished in \d+\.\d+s" -> "finished in $$TIME" + // check-pass ++// ignore-stage1 + + #![no_std] + +diff --git a/src/test/rustdoc-ui/test-type.rs b/src/test/rustdoc-ui/test-type.rs +index 882da5c25..bc8e8e30f 100644 +--- a/src/test/rustdoc-ui/test-type.rs ++++ b/src/test/rustdoc-ui/test-type.rs +@@ -2,6 +2,7 @@ + // check-pass + // normalize-stdout-test: "src/test/rustdoc-ui" -> "$$DIR" + // normalize-stdout-test "finished in \d+\.\d+s" -> "finished in $$TIME" ++// ignore-stage1 + + /// ``` + /// let a = true; +diff --git a/src/test/ui-fulldeps/gated-plugin.rs b/src/test/ui-fulldeps/gated-plugin.rs +index 445469f87..85eaf5336 100644 +--- a/src/test/ui-fulldeps/gated-plugin.rs ++++ b/src/test/ui-fulldeps/gated-plugin.rs +@@ -1,4 +1,5 @@ + // aux-build:empty-plugin.rs ++// ignore-stage1 + + #![plugin(empty_plugin)] + //~^ ERROR compiler plugins are deprecated +diff --git a/src/test/ui-fulldeps/internal-lints/default_hash_types.rs b/src/test/ui-fulldeps/internal-lints/default_hash_types.rs +index 795c7d2dc..dc6b4f53f 100644 +--- a/src/test/ui-fulldeps/internal-lints/default_hash_types.rs ++++ b/src/test/ui-fulldeps/internal-lints/default_hash_types.rs +@@ -1,4 +1,5 @@ + // compile-flags: -Z unstable-options ++// ignore-stage1 + + #![feature(rustc_private)] + #![deny(rustc::default_hash_types)] +diff --git a/src/test/ui-fulldeps/internal-lints/lint_pass_impl_without_macro.rs b/src/test/ui-fulldeps/internal-lints/lint_pass_impl_without_macro.rs +index f6f0c0385..4523e2a6d 100644 +--- a/src/test/ui-fulldeps/internal-lints/lint_pass_impl_without_macro.rs ++++ b/src/test/ui-fulldeps/internal-lints/lint_pass_impl_without_macro.rs +@@ -1,4 +1,5 @@ + // compile-flags: -Z unstable-options ++// ignore-stage1 + + #![feature(rustc_private)] + #![deny(rustc::lint_pass_impl_without_macro)] +diff --git a/src/test/ui-fulldeps/internal-lints/qualified_ty_ty_ctxt.rs b/src/test/ui-fulldeps/internal-lints/qualified_ty_ty_ctxt.rs +index 32b987338..6187e2370 100644 +--- a/src/test/ui-fulldeps/internal-lints/qualified_ty_ty_ctxt.rs ++++ b/src/test/ui-fulldeps/internal-lints/qualified_ty_ty_ctxt.rs +@@ -1,4 +1,5 @@ + // compile-flags: -Z unstable-options ++// ignore-stage1 + + #![feature(rustc_private)] + #![deny(rustc::usage_of_qualified_ty)] +diff --git a/src/test/ui-fulldeps/internal-lints/query_stability.rs b/src/test/ui-fulldeps/internal-lints/query_stability.rs +index 560675b44..e7d5ba583 100644 +--- a/src/test/ui-fulldeps/internal-lints/query_stability.rs ++++ b/src/test/ui-fulldeps/internal-lints/query_stability.rs +@@ -1,4 +1,5 @@ + // compile-flags: -Z unstable-options ++// ignore-stage1 + + #![feature(rustc_private)] + #![deny(rustc::potential_query_instability)] +diff --git a/src/test/ui-fulldeps/internal-lints/rustc_pass_by_value.rs b/src/test/ui-fulldeps/internal-lints/rustc_pass_by_value.rs +index 402c41f37..fe1f10d8c 100644 +--- a/src/test/ui-fulldeps/internal-lints/rustc_pass_by_value.rs ++++ b/src/test/ui-fulldeps/internal-lints/rustc_pass_by_value.rs +@@ -1,4 +1,5 @@ + // compile-flags: -Z unstable-options ++// ignore-stage1 + + #![feature(rustc_attrs)] + #![feature(rustc_private)] +diff --git a/src/test/ui-fulldeps/internal-lints/ty_tykind_usage.rs b/src/test/ui-fulldeps/internal-lints/ty_tykind_usage.rs +index 973294e98..f4b3f8342 100644 +--- a/src/test/ui-fulldeps/internal-lints/ty_tykind_usage.rs ++++ b/src/test/ui-fulldeps/internal-lints/ty_tykind_usage.rs +@@ -1,4 +1,5 @@ + // compile-flags: -Z unstable-options ++// ignore-stage1 + + #![feature(rustc_private)] + +diff --git a/src/test/ui-fulldeps/lint-group-denied-lint-allowed.rs b/src/test/ui-fulldeps/lint-group-denied-lint-allowed.rs +index 7498745f2..28c00f2f8 100644 +--- a/src/test/ui-fulldeps/lint-group-denied-lint-allowed.rs ++++ b/src/test/ui-fulldeps/lint-group-denied-lint-allowed.rs +@@ -1,6 +1,7 @@ + // aux-build:lint-group-plugin-test.rs + // check-pass + // compile-flags: -D unused -A unused-variables ++// ignore-stage1 + + fn main() { + let x = 1; +diff --git a/src/test/ui-fulldeps/lint-group-forbid-always-trumps-cli.rs b/src/test/ui-fulldeps/lint-group-forbid-always-trumps-cli.rs +index fc19bc039..9563e9930 100644 +--- a/src/test/ui-fulldeps/lint-group-forbid-always-trumps-cli.rs ++++ b/src/test/ui-fulldeps/lint-group-forbid-always-trumps-cli.rs +@@ -1,5 +1,6 @@ + // aux-build:lint-group-plugin-test.rs + // compile-flags: -F unused -A unused ++// ignore-stage1 + + fn main() { + let x = 1; +diff --git a/src/test/ui-fulldeps/lint-pass-macros.rs b/src/test/ui-fulldeps/lint-pass-macros.rs +index b3c2a5427..9ed711a34 100644 +--- a/src/test/ui-fulldeps/lint-pass-macros.rs ++++ b/src/test/ui-fulldeps/lint-pass-macros.rs +@@ -1,5 +1,6 @@ + // compile-flags: -Z unstable-options + // check-pass ++// ignore-stage1 + + #![feature(rustc_private)] + +diff --git a/src/test/ui-fulldeps/multiple-plugins.rs b/src/test/ui-fulldeps/multiple-plugins.rs +index 25d2c8bc1..9af3ebd57 100644 +--- a/src/test/ui-fulldeps/multiple-plugins.rs ++++ b/src/test/ui-fulldeps/multiple-plugins.rs +@@ -1,6 +1,7 @@ + // run-pass + // aux-build:multiple-plugins-1.rs + // aux-build:multiple-plugins-2.rs ++// ignore-stage1 + + // Check that the plugin registrar of multiple plugins doesn't conflict + +diff --git a/src/test/ui/abi/stack-probes-lto.rs b/src/test/ui/abi/stack-probes-lto.rs +index 90df1f3f5..f82c12a86 100644 +--- a/src/test/ui/abi/stack-probes-lto.rs ++++ b/src/test/ui/abi/stack-probes-lto.rs +@@ -14,5 +14,6 @@ + // ignore-pretty + // compile-flags: -C lto + // no-prefer-dynamic ++// ignore-stage1 + + include!("stack-probes.rs"); +diff --git a/src/test/ui/abi/stack-probes.rs b/src/test/ui/abi/stack-probes.rs +index e998dd0f8..d735a98fe 100644 +--- a/src/test/ui/abi/stack-probes.rs ++++ b/src/test/ui/abi/stack-probes.rs +@@ -10,6 +10,7 @@ + // ignore-wasm + // ignore-emscripten no processes + // ignore-sgx no processes ++// ignore-stage1 + + use std::env; + use std::mem::MaybeUninit; +diff --git a/src/test/ui/empty_global_asm.rs b/src/test/ui/empty_global_asm.rs +index dbcc7be05..276d689b0 100644 +--- a/src/test/ui/empty_global_asm.rs ++++ b/src/test/ui/empty_global_asm.rs +@@ -1,4 +1,5 @@ + // run-pass ++// ignore-stage1 + + #[allow(unused_imports)] + use std::arch::global_asm; +diff --git a/src/test/ui/macros/restricted-shadowing-legacy.rs b/src/test/ui/macros/restricted-shadowing-legacy.rs +index f5cac2dfb..d84f8efd6 100644 +--- a/src/test/ui/macros/restricted-shadowing-legacy.rs ++++ b/src/test/ui/macros/restricted-shadowing-legacy.rs +@@ -74,6 +74,7 @@ + // 62 | Unordered | Unordered | = | +? | + // 63 | Unordered | Unordered | > | +? | + // 64 | Unordered | Unordered | Unordered | + | ++// ignore-stage1 + + #![feature(decl_macro, rustc_attrs)] + +diff --git a/src/test/ui/process/process-panic-after-fork.rs b/src/test/ui/process/process-panic-after-fork.rs +index 1ccf6bb05..c4b074092 100644 +--- a/src/test/ui/process/process-panic-after-fork.rs ++++ b/src/test/ui/process/process-panic-after-fork.rs +@@ -6,6 +6,7 @@ + // ignore-emscripten no processes + // ignore-sgx no processes + // ignore-android: FIXME(#85261) ++// ignore-stage1 + + #![feature(bench_black_box)] + #![feature(rustc_private)] +diff --git a/src/test/ui/simd/target-feature-mixup.rs b/src/test/ui/simd/target-feature-mixup.rs +index 6d7688191..a8d551154 100644 +--- a/src/test/ui/simd/target-feature-mixup.rs ++++ b/src/test/ui/simd/target-feature-mixup.rs +@@ -1,4 +1,6 @@ + // run-pass ++// ignore-stage1 ++ + #![allow(unused_variables)] + #![allow(stable_features)] + #![allow(overflowing_literals)]meta/recipes-devtools/rust/rust-testsuite_1.62.1.bb new file +3
-1@@ -0,0 +1,3 @@ +require rust-testsuite.inc +require rust-source.inc +require rust-snapshot.inc -=-=-=-=-=-=-=-=-=-=-=-Links: You receive all messages sent to this group.
View/Reply Online (#169906): https://lists.openembedded.org/g/openembedded-core/message/169906
Mute This Topic: https://lists.openembedded.org/mt/93266562/3616765
Group Owner: [email protected]
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-
Signature · 2 lines
# Randy MacLeod # Wind River Linux