Skip to contentSkip to conversation

arm: mvebu: Espressobin: When emmc is not present disable it also in OF_LIVE

PATCH In review Pali Rohár 3 participants 4 messages Aug 27, 2022 – Sep 13, 2022

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 arm: mvebu: Espressobin: When emmc is not present disable it also in OF_LIVE

---
 board/Marvell/mvebu_armada-37xx/board.c | 2 ++
 1 file changed, 2 insertions(+)
board/Marvell/mvebu_armada-37xx/board.c +2 -0
index 5ae133879f32..45779198b678 100644
@@ -132,6 +132,8 @@ int board_late_init(void)
 		dev = mmc_dev->dev;
 		device_remove(dev, DM_REMOVE_NORMAL);
 		device_unbind(dev);
+		if (of_live_active())
+			ofnode_set_enabled(dev_ofnode(dev), false);
 	}
 
 	/* Ensure that 'env default -a' set correct value to $fdtfile */
Signature · 1 line
2.20.1
#1 lore raw

Hi Pali,

Quoted 1 line · Pali Rohár

This patch is missing a motivation. Please always add a commit message.

Quoted 19 lines
---
 board/Marvell/mvebu_armada-37xx/board.c | 2 ++
 1 file changed, 2 insertions(+)
board/Marvell/mvebu_armada-37xx/board.c +2 -1
index 5ae133879f32..45779198b678 100644
@@ -132,6 +132,8 @@ int board_late_init(void)
                dev = mmc_dev->dev;
                device_remove(dev, DM_REMOVE_NORMAL);
                device_unbind(dev);
+               if (of_live_active())
+                       ofnode_set_enabled(dev_ofnode(dev), false);
        }
 
        /* Ensure that 'env default -a' set correct value to $fdtfile */
--
Quoted 2 lines

2.20.1

Regards,
Simon

Reviewed-by on v1 1/1
#2 lore raw
In reply to Pali Rohár
Quoted 1 line · Pali Rohár

As mentioned by Simon, please add a short sentence in the commit text as well.

Other than that:

Thanks,
Stefan

Quoted 9 lines
---
  board/Marvell/mvebu_armada-37xx/board.c | 2 ++
  1 file changed, 2 insertions(+)
board/Marvell/mvebu_armada-37xx/board.c +0 -0
index 5ae133879f32..45779198b678 100644

board/Marvell/mvebu_armada-37xx/board.c int board_late_init(void) · line 139

Quoted 8 lines
board/Marvell/mvebu_armada-37xx/board.c +2 -0
@@ -132,6 +132,8 @@ int board_late_init(void)
  		dev = mmc_dev->dev;
  		device_remove(dev, DM_REMOVE_NORMAL);
  		device_unbind(dev);
+		if (of_live_active())
+			ofnode_set_enabled(dev_ofnode(dev), false);
  	}
 
  	/* Ensure that 'env default -a' set correct value to $fdtfile */

Viele Grüße,
Stefan Roese

Signature · 3 lines
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-51 Fax: (+49)-8142-66989-80 Email: [email protected]
#3 lore raw
In reply to Pali Rohár
Quoted 1 line · Pali Rohár

Applied to u-boot-marvell/master

Thanks,
Stefan

Quoted 9 lines
---
  board/Marvell/mvebu_armada-37xx/board.c | 2 ++
  1 file changed, 2 insertions(+)
board/Marvell/mvebu_armada-37xx/board.c +0 -0
index 5ae133879f32..45779198b678 100644

board/Marvell/mvebu_armada-37xx/board.c int board_late_init(void) · line 139

Quoted 8 lines
board/Marvell/mvebu_armada-37xx/board.c +2 -0
@@ -132,6 +132,8 @@ int board_late_init(void)
  		dev = mmc_dev->dev;
  		device_remove(dev, DM_REMOVE_NORMAL);
  		device_unbind(dev);
+		if (of_live_active())
+			ofnode_set_enabled(dev_ofnode(dev), false);
  	}
 
  	/* Ensure that 'env default -a' set correct value to $fdtfile */

Viele Grüße,
Stefan Roese

Signature · 3 lines
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-51 Fax: (+49)-8142-66989-80 Email: [email protected]