Skip to contentSkip to conversation

liburing updates

PATCH Applied Ammar Faizi 2 participants 5 messages Aug 31, 2022 io_uring

lore
Share & tools
lore
#0 lore raw

cover liburing updates

From: Ammar Faizi <[email protected]>

Hi Jens,

Just small liburing updates this time.

1) github bot: Upgrade clang version to 16.

clang-16 is now available, use it.

2) CHANGELOG update.

3) Small cleanup, remove unnecessary goto and label in queue.c.

---

Ammar Faizi (3):
github bot: Upgrade clang version to 16
CHANGELOG: Note about io_uring_{enter,enter2,register,setup}
queue: Remove unnecessary goto and label

 .github/workflows/build.yml | 6 +++---
 CHANGELOG                   | 1 +
 src/queue.c                 | 3 +--
 3 files changed, 5 insertions(+), 5 deletions(-)

base-commit: 1ef00fc157cd0fa96d4da355ee86c977b6e4169e

Signature · 1 line
Ammar Faizi
#1 lore raw

PATCH 1/3 github bot: Upgrade clang version to 16

From: Ammar Faizi <[email protected]>

clang-16 is now available, use it.

---
 .github/workflows/build.yml | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
.github/workflows/build.yml +3 -3
index 333929c..2608644 100644
@@ -91,15 +91,15 @@ jobs:
       uses: actions/checkout@v2
 
     - name: Install Compilers
       run: |
         if [[ "${{matrix.cc_pkg}}" == "clang" ]]; then \
             wget https://apt.llvm.org/llvm.sh -O /tmp/llvm.sh; \
-            sudo bash /tmp/llvm.sh 15; \
-            sudo update-alternatives --install /usr/bin/clang++ clang++ /usr/bin/clang++-15 400; \
-            sudo update-alternatives --install /usr/bin/clang clang /usr/bin/clang-15 400; \
+            sudo bash /tmp/llvm.sh 16; \
+            sudo update-alternatives --install /usr/bin/clang++ clang++ /usr/bin/clang++-16 400; \
+            sudo update-alternatives --install /usr/bin/clang clang /usr/bin/clang-16 400; \
         else \
             sudo apt-get update -y; \
             sudo apt-get install -y ${{matrix.cc_pkg}} ${{matrix.cxx_pkg}}; \
         fi;
 
     - name: Display compiler versions
Signature · 1 line
Ammar Faizi
#2 lore raw

PATCH 2/3 CHANGELOG: Note about `io_uring_{enter,enter2,register,setup}`

In reply to Ammar Faizi

From: Ammar Faizi <[email protected]>

Commit f0b43c84cb3d1 ("syscall: Add io_uring syscall functions") exports 4 new functions. Mention it in the CHANGELOG file.

---
 CHANGELOG | 1 +
 1 file changed, 1 insertion(+)
CHANGELOG +1 -0
index 9c054b0..1f37e92 100644
@@ -1,9 +1,10 @@
 liburing-2.3 release
 
 - Support non-libc build for aarch64.
+- Add io_uring_{enter,enter2,register,setup} syscall functions.
 
 
 liburing-2.2 release
 
 - Support non-libc builds.
 - Optimized syscall handling for x86-64/x86/aarch64.
Signature · 1 line
Ammar Faizi
#3 lore raw

PATCH 3/3 queue: Remove unnecessary goto and label

In reply to Ammar Faizi

From: Ammar Faizi <[email protected]>

This 'goto done' and 'done:' label are not needed, there is no cleanup needed in this path. Simplify it. Just return 0 directly.

---
 src/queue.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
src/queue.c +1 -2
index 277cdcc..a670a8e 100644
@@ -158,25 +158,24 @@ again:
 			cqes[i] = &ring->cq.cqes[(head & mask) << shift];
 
 		return count;
 	}
 
 	if (overflow_checked)
-		goto done;
+		return 0;
 
 	if (cq_ring_needs_flush(ring)) {
 		int flags = IORING_ENTER_GETEVENTS;
 
 		if (ring->int_flags & INT_FLAG_REG_RING)
 			flags |= IORING_ENTER_REGISTERED_RING;
 		__sys_io_uring_enter(ring->enter_ring_fd, 0, 0, flags, NULL);
 		overflow_checked = true;
 		goto again;
 	}
 
-done:
 	return 0;
 }
 
 /*
  * Sync internal state with kernel ring state on the SQ side. Returns the
  * number of pending items in the SQ ring, for the shared ring.
Signature · 1 line
Ammar Faizi
maintainer Applied
#4 lore raw
In reply to Ammar Faizi
Quoted 9 lines · Ammar Faizi

From: Ammar Faizi <[email protected]>

Hi Jens,

Just small liburing updates this time.

1) github bot: Upgrade clang version to 16.

[...]

Applied, thanks!

[1/3] github bot: Upgrade clang version to 16

      commit: 43cc51831a602cae3b9424dc762e3bff9f87a291
[2/3] CHANGELOG: Note about `io_uring_{enter,enter2,register,setup}`
      commit: 56d72cb2ce23ec06b8c96ec94a1be92339859dea
[3/3] queue: Remove unnecessary goto and label
      commit: a71d56ef3259216739677473ddb17ad861c3a964

Best regards,

Signature · 1 line
Jens Axboe