drm/virtio: set fb_modifiers_not_supported
Subsystems (4)
Chia-I Wu
reviewerPATCH 1/1 drm/virtio: set fb_modifiers_not_supported
Without this, the drm core advertises LINEAR modifier which is incorrect.
Also userspace virgl does not support modifiers. For example, it causes chrome on ozone/drm to fail with "Failed to create scanout buffer".
--- drivers/gpu/drm/virtio/virtgpu_display.c | 2 ++ 1 file changed, 2 insertions(+)
drivers/gpu/drm/virtio/virtgpu_display.c +2 -0
@@ -349,6 +349,8 @@ int virtio_gpu_modeset_init(struct virtio_gpu_device *vgdev) vgdev->ddev->mode_config.max_width =XRES_MAX ; vgdev->ddev->mode_config.max_height =YRES_MAX ; + vgdev->ddev->mode_config.fb_modifiers_not_supported = true; +for (i =0 ; i < vgdev->num_scanouts; ++i)vgdev_output_init (vgdev, i);
Signature · 6 lines
2.37.2.789.g6183377224-goog _______________________________________________ Virtualization mailing list [email protected] https://lists.linuxfoundation.org/mailman/listinfo/virtualization
Quoted 10 lines · Chia-I Wu
Without this, the drm core advertises LINEAR modifier which is incorrect.
Also userspace virgl does not support modifiers. For example, it causes chrome on ozone/drm to fail with "Failed to create scanout buffer".
Fixes 2af104290da5 ("drm: introduce fb_modifiers_not_supported flag in
mode_config")Suggested-by Shao-Chuan Lee <[email protected]>Signed-off-by Chia-I Wu <[email protected]>
_______________________________________________
Virtualization mailing list
[email protected]
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
Quoted 9 lines · Chia-I Wu
Without this, the drm core advertises LINEAR modifier which is incorrect.
Also userspace virgl does not support modifiers. For example, it causes chrome on ozone/drm to fail with "Failed to create scanout buffer".
Fixes 2af104290da5 ("drm: introduce fb_modifiers_not_supported flag in mode_config")Suggested-by Shao-Chuan Lee <[email protected]>Signed-off-by Chia-I Wu <[email protected]>
Pushed to drm-misc-next.
thanks,
Gerd