Introduce Architectural LBR for vPMU
Subsystems (4)
cover Introduce Architectural LBR for vPMU
Intel CPU model-specific LBR(Legacy LBR) evolved into Architectural LBR(Arch LBR[0]), it's the replacement of legacy LBR on new platforms. The native support patches were merged into 5.9 kernel tree, and this patch series is to enable Arch LBR in vPMU so that guest can benefit from the feature.
The main advantages of Arch LBR are [1]:
- Faster context switching due to XSAVES support and faster reset of LBR MSRs via the new DEPTH MSR
- Faster LBR read for a non-PEBS event due to XSAVES support, which lowers the overhead of the NMI handler.
- Linux kernel can support the LBR features without knowing the model number of the current CPU.
From end user's point of view, the usage of Arch LBR is the same as the Legacy LBR that has been merged in the mainline.
Note, in this series, we impose one restriction for guest Arch LBR:
Guest can only set the same LBR record depth as host, this is due to the special behavior of MSR_ARCH_LBR_DEPTH: 1) On write to the MSR, it'll reset all Arch LBR recording MSRs to 0s. 2) XRSTORS resets all record MSRs to 0s if the saved depth mismatches MSR_ARCH_LBR_DEPTH. Enforcing the restriction keeps the KVM enabling patch simple and straightforward.
The old patch series was queued in KVM/queue for a while and finally moved to below branch after Paolo's refactor. This new patch set is built on top of Paolo's work + some fixes, it's tested on legacy platform (non-ArchLBR) and SPR platform(ArchLBR capable).
[0] https://software.intel.com/sites/default/files/managed/c5/15/architecture-instruction-set-extensions-programming-reference.pdf
[1] https://lore.kernel.org/lkml/[email protected]/
Original patch set:
https://git.kernel.org/pub/scm/virt/kvm/kvm.git/log/?h=lbr-for-weijiang
Changes in this version:
1. Fixed some minor issues in the refactored patch set.
2. Added a few minor fixes due to recent vPMU code cleanup.
3. Removed Paolo's SOBs in some modified patches.
4. Rebased to queue:kvm/kvm.git
Like Xu (3):
perf/x86/lbr: Simplify the exposure check for the LBR_INFO registers
KVM: vmx/pmu: Emulate MSR_ARCH_LBR_DEPTH for guest Arch LBR
KVM: x86: Add XSAVE Support for Architectural LBR
Paolo Bonzini (4):
KVM: PMU: disable LBR handling if architectural LBR is available
KVM: vmx/pmu: Emulate MSR_ARCH_LBR_CTL for guest Arch LBR
KVM: VMX: Support passthrough of architectural LBRs
KVM: x86: Refine the matching and clearing logic for supported_xss
Sean Christopherson (1):
KVM: x86: Report XSS as an MSR to be saved if there are supported
features
Yang Weijiang (7):
KVM: x86: Refresh CPUID on writes to MSR_IA32_XSS
KVM: x86: Add Arch LBR MSRs to msrs_to_save_all list
KVM: x86/vmx: Check Arch LBR config when return perf capabilities
KVM: x86/vmx: Clear Arch LBREn bit before inject #DB to guest
KVM: x86/vmx: Flip Arch LBREn bit on guest state change
KVM: x86: Add Arch LBR data MSR access interface
KVM: x86/cpuid: Advertise Arch LBR feature in CPUID
arch/x86/events/intel/lbr.c | 6 +- arch/x86/include/asm/kvm_host.h | 3 + arch/x86/include/asm/msr-index.h | 1 + arch/x86/include/asm/vmx.h | 4 + arch/x86/kvm/cpuid.c | 52 +++++++++- arch/x86/kvm/vmx/capabilities.h | 8 ++ arch/x86/kvm/vmx/nested.c | 8 ++ arch/x86/kvm/vmx/pmu_intel.c | 160 +++++++++++++++++++++++++++---- arch/x86/kvm/vmx/vmx.c | 81 +++++++++++++++- arch/x86/kvm/x86.c | 27 +++++- 10 files changed, 317 insertions(+), 33 deletions(-)
base-commit: 372d07084593dc7a399bf9bee815711b1fb1bcf2
Signature · 1 line
2.27.0
PATCH 1/15 perf/x86/lbr: Simplify the exposure check for the LBR_INFO registers
From: Like Xu <[email protected]>
The x86_pmu.lbr_info is 0 unless explicitly initialized, so there's no point checking x86_pmu.intel_cap.lbr_format.
Message-Id: <[email protected]>
--- arch/x86/events/intel/lbr.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)
arch/x86/events/intel/lbr.c +1 -3
@@ -1873,12 +1873,10 @@ void __init intel_pmu_arch_lbr_init(void)*/ int x86_perf_get_lbr (struct x86_pmu_lbr *lbr) { -int lbr_fmt = x86_pmu.intel_cap.lbr_format; - lbr->nr = x86_pmu.lbr_nr; lbr->from = x86_pmu.lbr_from; lbr->to = x86_pmu.lbr_to; - lbr->info = (lbr_fmt ==LBR_FORMAT_INFO ) ? x86_pmu.lbr_info :0 ; + lbr->info = x86_pmu.lbr_info;return 0 ; }
Signature · 1 line
2.27.0
Sean Christopherson
maintainerRe: [PATCH 01/15] perf/x86/lbr: Simplify the exposure check for the LBR_INFO registers
Quoted 5 lines · Yang Weijiang
From: Like Xu <[email protected]>
The x86_pmu.lbr_info is 0 unless explicitly initialized, so there's no point checking x86_pmu.intel_cap.lbr_format.
Quoted 8 lines
Cc Peter Zijlstra <[email protected]>Reviewed-by Kan Liang <[email protected]>Reviewed-by Andi Kleen <[email protected]>Signed-off-by Like Xu <[email protected]>Signed-off-by Yang Weijiang <[email protected]>Message-Id: <[email protected]>
Signed-off-by Paolo Bonzini <[email protected]>---
No need to carry Paolo's SOB for patches that Paolo temporarily queued. And please delete the "Message-Id" entries as well.
Re: [PATCH 01/15] perf/x86/lbr: Simplify the exposure check for the LBR_INFO registers
Quoted 14 lines · Sean Christopherson
Quoted 5 lines · Yang Weijiang
From: Like Xu <[email protected]>
The x86_pmu.lbr_info is 0 unless explicitly initialized, so there's no point checking x86_pmu.intel_cap.lbr_format.
Quoted 8 lines
Cc Peter Zijlstra <[email protected]>Reviewed-by Kan Liang <[email protected]>Reviewed-by Andi Kleen <[email protected]>Signed-off-by Like Xu <[email protected]>Signed-off-by Yang Weijiang <[email protected]>Message-Id: <[email protected]>
Signed-off-by Paolo Bonzini <[email protected]>---
Quoted 2 lines
No need to carry Paolo's SOB for patches that Paolo temporarily queued. And please delete the "Message-Id" entries as well.
Sure, will remove them, thanks!
PATCH 2/15 KVM: x86: Report XSS as an MSR to be saved if there are supported features
In reply to Yang WeijiangFrom: Sean Christopherson <[email protected]>
Add MSR_IA32_XSS to the list of MSRs reported to userspace if supported_xss is non-zero, i.e. KVM supports at least one XSS based feature.
Message-Id: <[email protected]>
--- arch/x86/kvm/x86.c | 5 +++++ 1 file changed, 5 insertions(+)
arch/x86/kvm/x86.c +5 -0
@@ -1451,6 +1451,7 @@ static const u32 msrs_to_save_all[] = {MSR_F15H_PERF_CTR0 ,MSR_F15H_PERF_CTR1 ,MSR_F15H_PERF_CTR2 ,MSR_F15H_PERF_CTR3 ,MSR_F15H_PERF_CTR4 ,MSR_F15H_PERF_CTR5 ,MSR_IA32_XFD ,MSR_IA32_XFD_ERR , + MSR_IA32_XSS, };static u32 msrs_to_save[ARRAY_SIZE (msrs_to_save_all)];
@@ -6941,6 +6942,10 @@ static void kvm_init_msr_list(void)if (!kvm_cpu_cap_has (X86_FEATURE_XFD ))continue ;break ; +case MSR_IA32_XSS : +if (!kvm_caps.supported_xss) +continue ; +break ;default :break ; }
Signature · 1 line
2.27.0
PATCH 3/15 KVM: x86: Refresh CPUID on writes to MSR_IA32_XSS
In reply to Yang WeijiangUpdated CPUID.0xD.0x1, which reports the current required storage size of all features enabled via XCR0 | XSS, when the guest's XSS is modified.
Note, KVM does not yet support any XSS based features, i.e. supported_xss is guaranteed to be zero at this time.
Message-Id: <[email protected]>
--- arch/x86/kvm/cpuid.c | 16 +++++++++++++--- arch/x86/kvm/x86.c | 6 ++++-- 2 files changed, 17 insertions(+), 5 deletions(-)
arch/x86/kvm/cpuid.c +13 -3
@@ -272,9 +272,19 @@ static void __kvm_update_cpuid_runtime(struct kvm_vcpu *vcpu, struct kvm_cpuid_e best->ebx =xstate_required_size (vcpu->arch.xcr0, false); best =cpuid_entry2_find (entries, nent,0xD ,1 ); -if (best && (cpuid_entry_has (best,X86_FEATURE_XSAVES ) || -cpuid_entry_has (best,X86_FEATURE_XSAVEC ))) - best->ebx =xstate_required_size (vcpu->arch.xcr0, true); +if (best) { +if (cpuid_entry_has (best,X86_FEATURE_XSAVES ) || +cpuid_entry_has (best,X86_FEATURE_XSAVEC )) { +u64 xstate = vcpu->arch.xcr0 | vcpu->arch.ia32_xss; + + best->ebx =xstate_required_size (xstate, true); + } + +if (!cpuid_entry_has (best,X86_FEATURE_XSAVES )) { + best->ecx =0 ; + best->edx =0 ; + } + } best =__kvm_find_kvm_cpuid_features (vcpu, entries, nent); if (kvm_hlt_in_guest(vcpu->kvm) && best &&
arch/x86/kvm/x86.c +4 -2
@@ -3647,8 +3647,10 @@ int kvm_set_msr_common(struct kvm_vcpu *vcpu, struct msr_data *msr_info)*/ if (data & ~kvm_caps.supported_xss)return 1 ; - vcpu->arch.ia32_xss = data; -kvm_update_cpuid_runtime (vcpu); +if (vcpu->arch.ia32_xss != data) { + vcpu->arch.ia32_xss = data; +kvm_update_cpuid_runtime (vcpu); + }break ;case MSR_SMI_COUNT :if (!msr_info->host_initiated)
Signature · 1 line
2.27.0
PATCH 4/15 KVM: PMU: disable LBR handling if architectural LBR is available
In reply to Yang WeijiangFrom: Paolo Bonzini <[email protected]>
Traditional LBR is absent on CPU models that have architectural LBR, so disable all processing of traditional LBR MSRs if they are not there.
--- arch/x86/kvm/vmx/pmu_intel.c | 32 ++++++++++++++++++++++---------- 1 file changed, 22 insertions(+), 10 deletions(-)
arch/x86/kvm/vmx/pmu_intel.c +22 -10
@@ -174,19 +174,23 @@ static inline struct kvm_pmc *get_fw_gp_pmc(struct kvm_pmu *pmu, u32 msr)static bool intel_pmu_is_valid_lbr_msr (struct kvm_vcpu *vcpu,u32 index) {struct x86_pmu_lbr *records =vcpu_to_lbr_records (vcpu); -bool ret = false;if (!intel_pmu_lbr_is_enabled (vcpu)) -return ret; +return false; - ret = (index ==MSR_LBR_SELECT ) || (index ==MSR_LBR_TOS ) || - (index >= records->from && index < records->from + records->nr) || - (index >= records->to && index < records->to + records->nr); +if (!guest_cpuid_has (vcpu,X86_FEATURE_ARCH_LBR ) && + (index ==MSR_LBR_SELECT || index ==MSR_LBR_TOS )) +return true; -if (!ret && records->info) - ret = (index >= records->info && index < records->info + records->nr); +if ((index >= records->from && index < records->from + records->nr) || + (index >= records->to && index < records->to + records->nr)) +return true; -return ret; +if (records->info && index >= records->info && + index < records->info + records->nr) +return true; + +return false; }static bool intel_is_valid_msr (struct kvm_vcpu *vcpu,u32 msr)
@@ -703,6 +707,9 @@ static void vmx_update_intercept_for_lbr_msrs(struct kvm_vcpu *vcpu, bool set)vmx_set_intercept_for_msr (vcpu, lbr->info + i,MSR_TYPE_RW , set); } +if (guest_cpuid_has (vcpu,X86_FEATURE_ARCH_LBR )) +return ; +vmx_set_intercept_for_msr (vcpu,MSR_LBR_SELECT ,MSR_TYPE_RW , set);vmx_set_intercept_for_msr (vcpu,MSR_LBR_TOS ,MSR_TYPE_RW , set); }
@@ -743,10 +750,12 @@ void vmx_passthrough_lbr_msrs(struct kvm_vcpu *vcpu) {struct kvm_pmu *pmu =vcpu_to_pmu (vcpu);struct lbr_desc *lbr_desc =vcpu_to_lbr_desc (vcpu); +bool lbr_enable = !guest_cpuid_has (vcpu,X86_FEATURE_ARCH_LBR ) && + (vmcs_read64 (GUEST_IA32_DEBUGCTL ) &DEBUGCTLMSR_LBR );if (!lbr_desc->event) {vmx_disable_lbr_msrs_passthrough (vcpu); -if (vmcs_read64 (GUEST_IA32_DEBUGCTL ) &DEBUGCTLMSR_LBR ) +if (lbr_enable) goto warn;if (test_bit (INTEL_PMC_IDX_FIXED_VLBR , pmu->pmc_in_use)) goto warn;
@@ -769,7 +778,10 @@ void vmx_passthrough_lbr_msrs(struct kvm_vcpu *vcpu)static void intel_pmu_cleanup (struct kvm_vcpu *vcpu) { -if (!(vmcs_read64 (GUEST_IA32_DEBUGCTL ) &DEBUGCTLMSR_LBR )) +bool lbr_enable = !guest_cpuid_has (vcpu,X86_FEATURE_ARCH_LBR ) && + (vmcs_read64 (GUEST_IA32_DEBUGCTL ) &DEBUGCTLMSR_LBR ); + +if (!lbr_enable)intel_pmu_release_guest_lbr_event (vcpu); }
Signature · 1 line
2.27.0
PATCH 5/15 KVM: vmx/pmu: Emulate MSR_ARCH_LBR_DEPTH for guest Arch LBR
In reply to Yang WeijiangFrom: Like Xu <[email protected]>
The number of Arch LBR entries available is determined by the value in host MSR_ARCH_LBR_DEPTH.DEPTH. The supported LBR depth values are enumerated in CPUID.(EAX=01CH, ECX=0):EAX[7:0]. For each bit "n" set in this field, the MSR_ARCH_LBR_DEPTH.DEPTH value of "8*(n+1)" is supported. In the first generation of Arch LBR, max entry size is 32, host configures the max size and guest always honors the setting.
Write to MSR_ARCH_LBR_DEPTH has side-effect, all LBR entries are reset to 0. Kernel PMU driver can leverage this effect to do fask reset to LBR record MSRs. KVM allows guest to achieve it when Arch LBR records MSRs are passed through to the guest.
--- arch/x86/include/asm/kvm_host.h | 3 ++ arch/x86/kvm/vmx/pmu_intel.c | 57 +++++++++++++++++++++++++++++++-- 2 files changed, 58 insertions(+), 2 deletions(-)
arch/x86/include/asm/kvm_host.h +3 -0
@@ -549,6 +549,9 @@ struct kvm_pmu {* redundant check before cleanup if guest don't use vPMU at all. */ u8 event_count; + +/* Guest arch lbr depth supported by KVM. */ +u64 kvm_arch_lbr_depth; };struct kvm_pmu_ops ;
arch/x86/kvm/vmx/pmu_intel.c +55 -2
99 lines not on this page · raw message
Signature · 1 line
2.27.0
PATCH 6/15 KVM: vmx/pmu: Emulate MSR_ARCH_LBR_CTL for guest Arch LBR
In reply to Yang WeijiangFrom: Paolo Bonzini <[email protected]>
Arch LBR is enabled by setting MSR_ARCH_LBR_CTL.LBREn to 1. A new guest state field named "Guest IA32_LBR_CTL" is added to enhance guest LBR usage. When guest Arch LBR is enabled, a guest LBR event will be created like the model-specific LBR does. Clear guest LBR enable bit on host PMI handling so guest can see expected config.
On processors that support Arch LBR, MSR_IA32_DEBUGCTLMSR[bit 0] has no meaning. It can be written to 0 or 1, but reads will always return 0. Like IA32_DEBUGCTL, IA32_ARCH_LBR_CTL msr is also preserved on INIT.
Regardless of the Arch LBR or legacy LBR, when the LBR_EN bit 0 of the corresponding control MSR is set to 1, LBR recording will be enabled.
Message-Id: <[email protected]>
--- arch/x86/events/intel/lbr.c | 2 - arch/x86/include/asm/msr-index.h | 1 + arch/x86/include/asm/vmx.h | 2 + arch/x86/kvm/vmx/pmu_intel.c | 67 ++++++++++++++++++++++++++++---- arch/x86/kvm/vmx/vmx.c | 7 ++++ 5 files changed, 69 insertions(+), 10 deletions(-)
arch/x86/events/intel/lbr.c +0 -2
@@ -160,8 +160,6 @@ enum { ARCH_LBR_RETURN |\ ARCH_LBR_OTHER_BRANCH) -#define ARCH_LBR_CTL_MASK 0x7f000e -static void intel_pmu_lbr_filter (struct cpu_hw_events *cpuc); static __always_inline bool is_lbr_call_stack_bit_set(u64 config)
arch/x86/include/asm/msr-index.h +1 -0
@@ -215,6 +215,7 @@#define LBR_INFO_BR_TYPE (0xfull << LBR_INFO_BR_TYPE_OFFSET)#define MSR_ARCH_LBR_CTL 0x000014ce +#define ARCH_LBR_CTL_MASK 0x7f000e#define ARCH_LBR_CTL_LBREN BIT(0)#define ARCH_LBR_CTL_CPL_OFFSET 1#define ARCH_LBR_CTL_CPL (0x3ull << ARCH_LBR_CTL_CPL_OFFSET)
arch/x86/include/asm/vmx.h +2 -0
@@ -257,6 +257,8 @@ enum vmcs_field {GUEST_BNDCFGS_HIGH =0x00002813 ,GUEST_IA32_RTIT_CTL =0x00002814 ,GUEST_IA32_RTIT_CTL_HIGH =0x00002815 , +GUEST_IA32_LBR_CTL =0x00002816 , +GUEST_IA32_LBR_CTL_HIGH =0x00002817 ,HOST_IA32_PAT =0x00002c00 ,HOST_IA32_PAT_HIGH =0x00002c01 , HOST_IA32_EFER = 0x00002c02,
arch/x86/kvm/vmx/pmu_intel.c +59 -8
116 lines not on this page · raw message
arch/x86/kvm/vmx/vmx.c +7 -0
@@ -2104,6 +2104,13 @@ static int vmx_set_msr(struct kvm_vcpu *vcpu, struct msr_data *msr_info) VM_EXIT_SAVE_DEBUG_CONTROLS) get_vmcs12(vcpu)->guest_ia32_debugctl = data; + /* + * For Arch LBR, IA32_DEBUGCTL[bit 0] has no meaning. + * It can be written to 0 or 1, but reads will always return 0. + */ + if (guest_cpuid_has(vcpu, X86_FEATURE_ARCH_LBR)) + data &= ~DEBUGCTLMSR_LBR; + vmcs_write64(GUEST_IA32_DEBUGCTL, data); if (intel_pmu_lbr_is_enabled(vcpu) && !to_vmx(vcpu)->lbr_desc.event && (data & DEBUGCTLMSR_LBR))
Signature · 1 line
2.27.0
PATCH 7/15 KVM: VMX: Support passthrough of architectural LBRs
In reply to Yang WeijiangFrom: Paolo Bonzini <[email protected]>
MSR_ARCH_LBR_* can be pointed to by records->from, records->to and records->info, so list them in is_valid_passthrough_msr.
--- arch/x86/kvm/vmx/vmx.c | 3 +++ 1 file changed, 3 insertions(+)
arch/x86/kvm/vmx/vmx.c +3 -0
@@ -638,6 +638,9 @@ static bool is_valid_passthrough_msr(u32 msr) case MSR_LBR_NHM_TO ... MSR_LBR_NHM_TO + 31: case MSR_LBR_CORE_FROM ... MSR_LBR_CORE_FROM + 8: case MSR_LBR_CORE_TO ... MSR_LBR_CORE_TO + 8: + case MSR_ARCH_LBR_FROM_0 ... MSR_ARCH_LBR_FROM_0 + 31: + case MSR_ARCH_LBR_TO_0 ... MSR_ARCH_LBR_TO_0 + 31: + case MSR_ARCH_LBR_INFO_0 ... MSR_ARCH_LBR_INFO_0 + 31:/* LBR MSRs. These are handled in vmx_update_intercept_for_lbr_msrs() */ return true; }
Signature · 1 line
2.27.0
Sean Christopherson
maintainerRe: [PATCH 07/15] KVM: VMX: Support passthrough of architectural LBRs
Quoted 6 lines · Yang Weijiang
From: Paolo Bonzini <[email protected]>
MSR_ARCH_LBR_* can be pointed to by
records->from,records->toandrecords->info, so list them inis_valid_passthrough_msr.Signed-off-by Paolo Bonzini <[email protected]>
As the person sending the patches, these need your SOB.
Re: [PATCH 07/15] KVM: VMX: Support passthrough of architectural LBRs
Quoted 8 lines · Sean Christopherson
Quoted 6 lines · Yang Weijiang
From: Paolo Bonzini <[email protected]>
MSR_ARCH_LBR_* can be pointed to by
records->from,records->toandrecords->info, so list them inis_valid_passthrough_msr.Signed-off-by Paolo Bonzini <[email protected]>As the person sending the patches, these need your SOB.
Oops, will add.
PATCH 8/15 KVM: x86: Add Arch LBR MSRs to msrs_to_save_all list
In reply to Yang WeijiangArch LBR MSR_ARCH_LBR_DEPTH and MSR_ARCH_LBR_CTL are queried by userspace application before it wants to {save|restore} the Arch LBR data. Other LBR related data MSRs are omitted here intentionally due to lengthy list(32*3). Userspace can still use KVM_{GET|SET}_MSRS to access them if necessary.
--- arch/x86/kvm/x86.c | 10 ++++++++++ 1 file changed, 10 insertions(+)
arch/x86/kvm/x86.c +10 -0
@@ -1452,6 +1452,7 @@ static const u32 msrs_to_save_all[] = {MSR_F15H_PERF_CTR3 ,MSR_F15H_PERF_CTR4 ,MSR_F15H_PERF_CTR5 ,MSR_IA32_XFD ,MSR_IA32_XFD_ERR ,MSR_IA32_XSS , + MSR_ARCH_LBR_CTL, MSR_ARCH_LBR_DEPTH, };static u32 msrs_to_save[ARRAY_SIZE (msrs_to_save_all)];
@@ -3839,6 +3840,8 @@ int kvm_set_msr_common(struct kvm_vcpu *vcpu, struct msr_data *msr_info)case MSR_IA32_PEBS_ENABLE :case MSR_IA32_DS_AREA :case MSR_PEBS_DATA_CFG : +case MSR_ARCH_LBR_CTL : +case MSR_ARCH_LBR_DEPTH : case MSR_F15H_PERF_CTL0 ... MSR_F15H_PERF_CTR5:if (kvm_pmu_is_valid_msr (vcpu, msr))return kvm_pmu_set_msr (vcpu, msr_info);
@@ -3942,6 +3945,8 @@ int kvm_get_msr_common(struct kvm_vcpu *vcpu, struct msr_data *msr_info)case MSR_IA32_PEBS_ENABLE :case MSR_IA32_DS_AREA :case MSR_PEBS_DATA_CFG : +case MSR_ARCH_LBR_CTL : +case MSR_ARCH_LBR_DEPTH : case MSR_F15H_PERF_CTL0 ... MSR_F15H_PERF_CTR5:if (kvm_pmu_is_valid_msr (vcpu, msr_info->index))return kvm_pmu_get_msr (vcpu, msr_info);
@@ -6948,6 +6953,11 @@ static void kvm_init_msr_list(void)if (!kvm_caps.supported_xss)continue ;break ; +case MSR_ARCH_LBR_DEPTH : +case MSR_ARCH_LBR_CTL : +if (!kvm_cpu_cap_has (X86_FEATURE_ARCH_LBR )) +continue ; +break ;default :break ; }
Signature · 1 line
2.27.0
PATCH 9/15 KVM: x86: Refine the matching and clearing logic for supported_xss
In reply to Yang WeijiangFrom: Paolo Bonzini <[email protected]>
Refine the code path of the existing clearing of supported_xss in this way:
initialize the supported_xss with the filter of KVM_SUPPORTED_XSS mask and update its value in a bit clear manner (rather than bit setting).
Message-Id: <[email protected]>
--- arch/x86/kvm/vmx/vmx.c | 5 +++-- arch/x86/kvm/x86.c | 6 +++++- 2 files changed, 8 insertions(+), 3 deletions(-)
arch/x86/kvm/vmx/vmx.c +3 -2
@@ -7717,9 +7717,10 @@ static __init void vmx_set_cpu_caps(void)kvm_cpu_cap_set (X86_FEATURE_UMIP );/* CPUID 0xD.1 */ - kvm_caps.supported_xss =0 ; -if (!cpu_has_vmx_xsaves ()) +if (!cpu_has_vmx_xsaves ()) {kvm_cpu_cap_clear (X86_FEATURE_XSAVES ); + kvm_caps.supported_xss =0 ; + }/* CPUID 0x80000001 and 0x7 (RDPID) */ if (!cpu_has_vmx_rdtscp ()) {
arch/x86/kvm/x86.c +5 -1
@@ -213,6 +213,8 @@ static struct kvm_user_return_msrs __percpu *user_return_msrs; | XFEATURE_MASK_BNDCSR | XFEATURE_MASK_AVX512 \ | XFEATURE_MASK_PKRU | XFEATURE_MASK_XTILE) +#define KVM_SUPPORTED_XSS 0 +u64 __read_mostly host_efer;EXPORT_SYMBOL_GPL (host_efer);
@@ -11965,8 +11967,10 @@ int kvm_arch_hardware_setup(void *opaque)rdmsrl_safe (MSR_EFER , &host_efer); -if (boot_cpu_has (X86_FEATURE_XSAVES )) +if (boot_cpu_has (X86_FEATURE_XSAVES )) {rdmsrl (MSR_IA32_XSS , host_xss); + kvm_caps.supported_xss = host_xss &KVM_SUPPORTED_XSS ; + }kvm_init_pmu_capability ();
Signature · 1 line
2.27.0
PATCH 10/15 KVM: x86/vmx: Check Arch LBR config when return perf capabilities
In reply to Yang WeijiangTwo new bit fields(VM_EXIT_CLEAR_IA32_LBR_CTL, VM_ENTRY_LOAD_IA32_LBR_CTL) are added to support guest Arch LBR. These two bits should be set in order to make Arch LBR workable in both guest and host. Since we don't support Arch LBR in nested guest, clear the two bits before run L2 VM.
--- arch/x86/include/asm/vmx.h | 2 ++ arch/x86/kvm/vmx/capabilities.h | 8 ++++++++ arch/x86/kvm/vmx/nested.c | 8 ++++++++ arch/x86/kvm/vmx/vmx.c | 16 ++++++++++++++-- 4 files changed, 32 insertions(+), 2 deletions(-)
arch/x86/include/asm/vmx.h +2 -0
@@ -102,6 +102,7 @@#define VM_EXIT_CLEAR_BNDCFGS 0x00800000#define VM_EXIT_PT_CONCEAL_PIP 0x01000000#define VM_EXIT_CLEAR_IA32_RTIT_CTL 0x02000000 +#define VM_EXIT_CLEAR_IA32_LBR_CTL 0x04000000#define VM_EXIT_ALWAYSON_WITHOUT_TRUE_MSR 0x00036dff
@@ -115,6 +116,7 @@#define VM_ENTRY_LOAD_BNDCFGS 0x00010000#define VM_ENTRY_PT_CONCEAL_PIP 0x00020000#define VM_ENTRY_LOAD_IA32_RTIT_CTL 0x00040000 +#define VM_ENTRY_LOAD_IA32_LBR_CTL 0x00200000#define VM_ENTRY_ALWAYSON_WITHOUT_TRUE_MSR 0x000011ff
arch/x86/kvm/vmx/capabilities.h +8 -0
@@ -401,6 +401,11 @@ static inline bool vmx_pebs_supported(void)return boot_cpu_has (X86_FEATURE_PEBS ) && kvm_pmu_cap.pebs_ept; } +static inline bool cpu_has_vmx_arch_lbr (void ) +{ +return vmcs_config.vmentry_ctrl &VM_ENTRY_LOAD_IA32_LBR_CTL ; +} +static inline u64 vmx_get_perf_capabilities (void ) {u64 perf_cap =PMU_CAP_FW_WRITES ;
@@ -420,6 +425,9 @@ static inline u64 vmx_get_perf_capabilities(void) perf_cap &= ~PERF_CAP_PEBS_BASELINE ; } +if (boot_cpu_has (X86_FEATURE_ARCH_LBR ) && !cpu_has_vmx_arch_lbr ()) + perf_cap &= ~PMU_CAP_LBR_FMT ; +return perf_cap; }
arch/x86/kvm/vmx/nested.c +8 -0
@@ -2338,6 +2338,10 @@ static void prepare_vmcs02_early(struct vcpu_vmx *vmx, struct loaded_vmcs *vmcs0if (guest_efer != host_efer) exec_control |=VM_ENTRY_LOAD_IA32_EFER ; } + +if (cpu_has_vmx_arch_lbr ()) + exec_control &= ~VM_ENTRY_LOAD_IA32_LBR_CTL ; +vm_entry_controls_set (vmx, exec_control);/*
@@ -2352,6 +2356,10 @@ static void prepare_vmcs02_early(struct vcpu_vmx *vmx, struct loaded_vmcs *vmcs0 exec_control |=VM_EXIT_LOAD_IA32_EFER ; else exec_control &= ~VM_EXIT_LOAD_IA32_EFER; + +if (cpu_has_vmx_arch_lbr ()) + exec_control &= ~VM_EXIT_CLEAR_IA32_LBR_CTL ; +vm_exit_controls_set (vmx, exec_control);/*
arch/x86/kvm/vmx/vmx.c +14 -2
@@ -2559,6 +2559,7 @@ static __init int setup_vmcs_config(struct vmcs_config *vmcs_conf, { VM_ENTRY_LOAD_IA32_EFER, VM_EXIT_LOAD_IA32_EFER }, { VM_ENTRY_LOAD_BNDCFGS, VM_EXIT_CLEAR_BNDCFGS }, { VM_ENTRY_LOAD_IA32_RTIT_CTL, VM_EXIT_CLEAR_IA32_RTIT_CTL }, + { VM_ENTRY_LOAD_IA32_LBR_CTL, VM_EXIT_CLEAR_IA32_LBR_CTL }, };memset (vmcs_conf,0 ,sizeof (*vmcs_conf));
@@ -2679,7 +2680,8 @@ static __init int setup_vmcs_config(struct vmcs_config *vmcs_conf,VM_EXIT_LOAD_IA32_EFER |VM_EXIT_CLEAR_BNDCFGS |VM_EXIT_PT_CONCEAL_PIP | -VM_EXIT_CLEAR_IA32_RTIT_CTL ; +VM_EXIT_CLEAR_IA32_RTIT_CTL | +VM_EXIT_CLEAR_IA32_LBR_CTL ;if (adjust_vmx_controls (min, opt,MSR_IA32_VMX_EXIT_CTLS , &_vmexit_control) <0 )return -EIO ;
@@ -2703,7 +2705,8 @@ static __init int setup_vmcs_config(struct vmcs_config *vmcs_conf,VM_ENTRY_LOAD_IA32_EFER |VM_ENTRY_LOAD_BNDCFGS |VM_ENTRY_PT_CONCEAL_PIP | -VM_ENTRY_LOAD_IA32_RTIT_CTL ; +VM_ENTRY_LOAD_IA32_RTIT_CTL | +VM_ENTRY_LOAD_IA32_LBR_CTL ;if (adjust_vmx_controls (min, opt,MSR_IA32_VMX_ENTRY_CTLS , &_vmentry_control) <0 )return -EIO ;
@@ -4803,6 +4806,11 @@ static void vmx_vcpu_reset(struct kvm_vcpu *vcpu, bool init_event)vpid_sync_context (vmx->vpid);vmx_update_fb_clear_dis (vcpu, vmx); + +if (!init_event) { +if (cpu_has_vmx_arch_lbr ()) +vmcs_write64 (GUEST_IA32_LBR_CTL ,0 ); + } }static void vmx_enable_irq_window (struct kvm_vcpu *vcpu)
@@ -6198,6 +6206,10 @@ void dump_vmcs(struct kvm_vcpu *vcpu) vmentry_ctl & VM_ENTRY_LOAD_IA32_PERF_GLOBAL_CTRL)pr_err ("PerfGlobCtl = 0x%016llx\n" ,vmcs_read64 (GUEST_IA32_PERF_GLOBAL_CTRL )); +if (kvm_cpu_cap_has (X86_FEATURE_ARCH_LBR ) && + vmentry_ctl &VM_ENTRY_LOAD_IA32_LBR_CTL ) +pr_err ("ArchLBRCtl = 0x%016llx\n" , +vmcs_read64 (GUEST_IA32_LBR_CTL ));if (vmentry_ctl &VM_ENTRY_LOAD_BNDCFGS )pr_err ("BndCfgS = 0x%016llx\n" ,vmcs_read64 (GUEST_BNDCFGS )); pr_err("Interruptibility = %08x ActivityState = %08x\n",
Signature · 1 line
2.27.0
PATCH 11/15 KVM: x86: Add XSAVE Support for Architectural LBR
In reply to Yang WeijiangFrom: Like Xu <[email protected]>
On processors supporting XSAVES and XRSTORS, Architectural LBR XSAVE support is enumerated from CPUID.(EAX=0DH, ECX=1):ECX[bit 15]. The detailed sub-leaf for Arch LBR is enumerated in CPUID.(0DH, 0FH).
XSAVES provides a faster means than RDMSR for guest to read all LBRs. When guest IA32_XSS[bit 15] is set, the Arch LBR state can be saved using XSAVES and restored by XRSTORS with the appropriate RFBM.
Message-Id: <[email protected]>
--- arch/x86/kvm/vmx/vmx.c | 4 ++++ arch/x86/kvm/x86.c | 2 +- 2 files changed, 5 insertions(+), 1 deletion(-)
arch/x86/kvm/vmx/vmx.c +4 -0
@@ -7714,6 +7714,10 @@ static __init void vmx_set_cpu_caps(void)kvm_cpu_cap_check_and_set (X86_FEATURE_DS );kvm_cpu_cap_check_and_set (X86_FEATURE_DTES64 ); } +if (!cpu_has_vmx_arch_lbr ()) { +kvm_cpu_cap_clear (X86_FEATURE_ARCH_LBR ); + kvm_caps.supported_xss &= ~XFEATURE_MASK_LBR ; + }if (!enable_pmu)kvm_cpu_cap_clear (X86_FEATURE_PDCM );
arch/x86/kvm/x86.c +1 -1
@@ -213,7 +213,7 @@ static struct kvm_user_return_msrs __percpu *user_return_msrs; | XFEATURE_MASK_BNDCSR | XFEATURE_MASK_AVX512 \ | XFEATURE_MASK_PKRU | XFEATURE_MASK_XTILE) -#define KVM_SUPPORTED_XSS 0 +#define KVM_SUPPORTED_XSS XFEATURE_MASK_LBRu64 __read_mostly host_efer;EXPORT_SYMBOL_GPL (host_efer);
Signature · 1 line
2.27.0
PATCH 12/15 KVM: x86/vmx: Clear Arch LBREn bit before inject #DB to guest
In reply to Yang WeijiangOn a debug breakpoint event (#DB), IA32_LBR_CTL.LBREn is cleared. So need to clear the bit manually before inject #DB.
Message-Id: <[email protected]>
--- arch/x86/kvm/vmx/vmx.c | 20 ++++++++++++++++++++ 1 file changed, 20 insertions(+)
arch/x86/kvm/vmx/vmx.c +20 -0
@@ -1687,6 +1687,20 @@ static void vmx_clear_hlt(struct kvm_vcpu *vcpu)vmcs_write32 (GUEST_ACTIVITY_STATE ,GUEST_ACTIVITY_ACTIVE ); } +static void disable_arch_lbr_ctl (struct kvm_vcpu *vcpu) +{ +struct lbr_desc *lbr_desc =vcpu_to_lbr_desc (vcpu); +struct kvm_pmu *pmu =vcpu_to_pmu (vcpu); + +if (kvm_cpu_cap_has (X86_FEATURE_ARCH_LBR ) && +test_bit (INTEL_PMC_IDX_FIXED_VLBR , pmu->pmc_in_use) && + lbr_desc->event) { +u64 ctl =vmcs_read64 (GUEST_IA32_LBR_CTL ); + +vmcs_write64 (GUEST_IA32_LBR_CTL , ctl & ~ARCH_LBR_CTL_LBREN ); + } +} +static void vmx_queue_exception (struct kvm_vcpu *vcpu) {struct vcpu_vmx *vmx =to_vmx (vcpu);
@@ -1722,6 +1736,9 @@ static void vmx_queue_exception(struct kvm_vcpu *vcpu)vmcs_write32 (VM_ENTRY_INTR_INFO_FIELD , intr_info);vmx_clear_hlt (vcpu); + +if (nr ==DB_VECTOR ) +disable_arch_lbr_ctl (vcpu); } static void vmx_setup_uret_msr(struct vcpu_vmx *vmx, unsigned int msr,
@@ -4886,6 +4903,9 @@ static void vmx_inject_nmi(struct kvm_vcpu *vcpu) INTR_TYPE_NMI_INTR | INTR_INFO_VALID_MASK | NMI_VECTOR);vmx_clear_hlt (vcpu); + +if (vcpu->arch.exception.nr ==DB_VECTOR ) +disable_arch_lbr_ctl (vcpu); }bool vmx_get_nmi_mask (struct kvm_vcpu *vcpu)
Signature · 1 line
2.27.0
PATCH 13/15 KVM: x86/vmx: Flip Arch LBREn bit on guest state change
In reply to Yang WeijiangPer spec:"IA32_LBR_CTL.LBREn is saved and cleared on #SMI, and restored on RSM. On a warm reset, all LBR MSRs, including IA32_LBR_DEPTH, have their values preserved. However, IA32_LBR_CTL.LBREn is cleared to 0, disabling LBRs." At guest SMM entry, store guest IA32_LBR_CTL in SMRAM and clear LBREn in VMCS, do reverse things at SMM exit. Also clear LBREn at warm reset.
Message-Id: <[email protected]>
--- arch/x86/kvm/vmx/vmx.c | 26 ++++++++++++++++++++++++++ 1 file changed, 26 insertions(+)
arch/x86/kvm/vmx/vmx.c +26 -0
@@ -4827,6 +4827,8 @@ static void vmx_vcpu_reset(struct kvm_vcpu *vcpu, bool init_event)if (!init_event) {if (cpu_has_vmx_arch_lbr ())vmcs_write64 (GUEST_IA32_LBR_CTL ,0 ); + }else { +disable_arch_lbr_ctl (vcpu); } }
@@ -7967,6 +7969,8 @@ static int vmx_smi_allowed(struct kvm_vcpu *vcpu, bool for_injection)static int vmx_enter_smm (struct kvm_vcpu *vcpu,char *smstate) { +struct lbr_desc *lbr_desc =vcpu_to_lbr_desc (vcpu); +struct kvm_pmu *pmu =vcpu_to_pmu (vcpu);struct vcpu_vmx *vmx =to_vmx (vcpu);/*
@@ -7983,11 +7987,22 @@ static int vmx_enter_smm(struct kvm_vcpu *vcpu, char *smstate) vmx->nested.smm.vmxon = vmx->nested.vmxon; vmx->nested.vmxon = false;vmx_clear_hlt (vcpu); + +if (kvm_cpu_cap_has (X86_FEATURE_ARCH_LBR ) && +test_bit (INTEL_PMC_IDX_FIXED_VLBR , pmu->pmc_in_use) && + lbr_desc->event &&guest_cpuid_has (vcpu,X86_FEATURE_LM )) { +u64 ctl =vmcs_read64 (GUEST_IA32_LBR_CTL ); + +put_smstate (u64, smstate,0x7f10 , ctl); +vmcs_write64 (GUEST_IA32_LBR_CTL , ctl & ~ARCH_LBR_CTL_LBREN ); + } +return 0 ; }static int vmx_leave_smm (struct kvm_vcpu *vcpu,const char *smstate) { +struct lbr_desc *lbr_desc =vcpu_to_lbr_desc (vcpu);struct vcpu_vmx *vmx =to_vmx (vcpu);int ret;
@@ -8004,6 +8019,17 @@ static int vmx_leave_smm(struct kvm_vcpu *vcpu, const char *smstate) vmx->nested.nested_run_pending =1 ; vmx->nested.smm.guest_mode = false; } + +if (kvm_cpu_cap_has (X86_FEATURE_ARCH_LBR ) && +guest_cpuid_has (vcpu,X86_FEATURE_LM )) { +u64 ctl =GET_SMSTATE (u64, smstate,0x7f10 ); + +vmcs_write64 (GUEST_IA32_LBR_CTL , ctl |ARCH_LBR_CTL_LBREN ); + +if (intel_pmu_lbr_is_enabled (vcpu) && !lbr_desc->event) +intel_pmu_create_guest_lbr_event (vcpu); + } +return 0 ; }
Signature · 1 line
2.27.0
PATCH 14/15 KVM: x86: Add Arch LBR data MSR access interface
In reply to Yang WeijiangArch LBR MSRs are xsave-supported, but they're operated as "independent" xsave feature by PMU code, i.e., during thread/process context switch, the MSRs are saved/restored with perf_event_task_sched_{in|out} instead of generic kernel fpu switch code, i.e.,save_fpregs_to_fpstate() and restore_fpregs_from_fpstate(). When vcpu guest/host fpu state swap happens, Arch LBR MSRs are retained so they can be accessed directly.
Message-Id: <[email protected]>
--- arch/x86/kvm/vmx/pmu_intel.c | 10 ++++++++++ 1 file changed, 10 insertions(+)
arch/x86/kvm/vmx/pmu_intel.c +10 -0
@@ -414,6 +414,11 @@ static int intel_pmu_get_msr(struct kvm_vcpu *vcpu, struct msr_data *msr_info) msr_info->data =vmcs_read64 (GUEST_IA32_LBR_CTL ); }return 0 ; + case MSR_ARCH_LBR_FROM_0 ... MSR_ARCH_LBR_FROM_0 + 31: + case MSR_ARCH_LBR_TO_0 ... MSR_ARCH_LBR_TO_0 + 31: + case MSR_ARCH_LBR_INFO_0 ... MSR_ARCH_LBR_INFO_0 + 31: +rdmsrl (msr_info->index, msr_info->data); +return 0 ;default :if ((pmc =get_gp_pmc (pmu, msr,MSR_IA32_PERFCTR0 )) || (pmc =get_gp_pmc (pmu, msr,MSR_IA32_PMC0 ))) {
@@ -528,6 +533,11 @@ static int intel_pmu_set_msr(struct kvm_vcpu *vcpu, struct msr_data *msr_info) (data & ARCH_LBR_CTL_LBREN))intel_pmu_create_guest_lbr_event (vcpu);return 0 ; + case MSR_ARCH_LBR_FROM_0 ... MSR_ARCH_LBR_FROM_0 + 31: + case MSR_ARCH_LBR_TO_0 ... MSR_ARCH_LBR_TO_0 + 31: + case MSR_ARCH_LBR_INFO_0 ... MSR_ARCH_LBR_INFO_0 + 31: +wrmsrl (msr_info->index, msr_info->data); +return 0 ;default :if ((pmc =get_gp_pmc (pmu, msr,MSR_IA32_PERFCTR0 )) || (pmc =get_gp_pmc (pmu, msr,MSR_IA32_PMC0 ))) {
Signature · 1 line
2.27.0
PATCH 15/15 KVM: x86/cpuid: Advertise Arch LBR feature in CPUID
In reply to Yang WeijiangAdd Arch LBR feature bit in CPU cap-mask to expose the feature. Only max LBR depth is supported for guest, and it's consistent with host Arch LBR settings.
Message-Id: <[email protected]>
--- arch/x86/kvm/cpuid.c | 36 +++++++++++++++++++++++++++++++++++- 1 file changed, 35 insertions(+), 1 deletion(-)
arch/x86/kvm/cpuid.c +35 -1
@@ -134,6 +134,19 @@ static int kvm_check_cpuid(struct kvm_vcpu *vcpu,if (vaddr_bits !=48 && vaddr_bits !=57 && vaddr_bits !=0 )return -EINVAL ; } +if (kvm_cpu_cap_has (X86_FEATURE_ARCH_LBR )) { + best =cpuid_entry2_find (entries, nent,0x1c ,0 ); +if (best) { +unsigned int eax, ebx, ecx, edx; + +/* Reject user-space CPUID if depth is different from host's.*/ +cpuid_count (0x1c ,0 , &eax, &ebx, &ecx, &edx); + +if ((eax &0xff ) && + (best->eax &0xff ) !=BIT (fls (eax &0xff ) -1 )) +return -EINVAL ; + } + }/* * Exposing dynamic xfeatures to the guest requires additional
@@ -631,7 +644,7 @@ void kvm_set_cpu_caps(void)F (SPEC_CTRL_SSBD ) |F (ARCH_CAPABILITIES ) |F (INTEL_STIBP ) |F (MD_CLEAR ) |F (AVX512_VP2INTERSECT ) |F (FSRM ) |F (SERIALIZE ) |F (TSXLDTRK ) |F (AVX512_FP16 ) | -F (AMX_TILE ) |F (AMX_INT8 ) |F (AMX_BF16 ) +F (AMX_TILE ) |F (AMX_INT8 ) |F (AMX_BF16 ) |F (ARCH_LBR ) );/* TSC_ADJUST and ARCH_CAPABILITIES are emulated in software. */
@@ -1055,6 +1068,27 @@ static inline int __do_cpuid_func(struct kvm_cpuid_array *array, u32 function) goto out; }break ; +/* Architectural LBR */ +case 0x1c : { +u32 lbr_depth_mask = entry->eax &0xff ; + +if (!lbr_depth_mask || + !kvm_cpu_cap_has (X86_FEATURE_ARCH_LBR )) { + entry->eax = entry->ebx = entry->ecx = entry->edx =0 ; +break ; + } +/* +* KVM only exposes the maximum supported depth, which is the +* fixed value used on the host side. +* KVM doesn't allow VMM userspace to adjust LBR depth because +* guest LBR emulation depends on the configuration of host LBR +* driver. +*/ + lbr_depth_mask =BIT ((fls (lbr_depth_mask) -1 )); + entry->eax &= ~0xff ; + entry->eax |= lbr_depth_mask; +break ; + }/* Intel AMX TILE */ case 0x1d :if (!kvm_cpu_cap_has (X86_FEATURE_AMX_TILE )) {
Signature · 1 line
2.27.0
Sean Christopherson
maintainerQuoted 4 lines · Yang Weijiang
The old patch series was queued in KVM/queue for a while and finally moved to below branch after Paolo's refactor. This new patch set is built on top of Paolo's work + some fixes, it's tested on legacy platform (non-ArchLBR) and SPR platform(ArchLBR capable).
...
Quoted 3 lines
Changes in this version:
1. Fixed some minor issues in the refactored patch set.
2. Added a few minor fixes due to recent vPMU code cleanup.
Please elaborate on what was broken, i.e. why this was de-queued, as well as on what was fixed an dhow. That will help bring me up to speed and expedite review.
Quoted 6 lines · Sean Christopherson
Quoted 3 lines · Yang Weijiang
The old patch series was queued in KVM/queue for a while and finally moved to below branch after Paolo's refactor. This new patch set is built on top of Paolo's work + some fixes, it's tested on legacy platform
Please elaborate on what was broken, i.e. why this was de-queued, as well as on what was fixed an dhow. That will help bring me up to speed and expedite review.
Thanks Sean!
The de-queued reason I read from community is, the PEBS and Arch-LBR patches broke selftest/KUTs due to host-initiated 0 writes to PMU msrs. Paolo tried to fix it but you didn't agree on the solution. Plus your comments below:
Quoted 4 lines · Paolo Bonzini
Quoted 1 line · Sean Christopherson
Can we just punt this out of kvm/queue until its been properly reviewed?
Yes, I agree. I have started making some changes and pushed the result to kvm/arch-lbr-for-weijiang.
What are fixed in this series:
1. An missing of -1: if ((entry->eax & 0xff) != (1 << (depth_bit - 1)))
2. Removed exit bit check in cpu_has_vmx_arch_lbr(void), moved it to setup_vmcs_config().
3. A redundant check kvm_cpu_cap_has(X86_FEATURE_ARCH_LBR) in kvm_check_cpuid().
4. KUT/selftest failures due to lack of MSR_ARCH_LBR_CTL and MSR_ARCH_LBR_DEPTH in kvm_set_msr_common() before validate pmu msrs.
5. Calltrace in L1 when L1 tried to vmcs_write64(GUEST_IA32_LBR_CTL, 0) in vmx_vcpu_reset(), use cpu_has_vmx_arch_lbr() instead.
6. Removed VM_ENTRY_LOAD_IA32_LBR_CTL and VM_EXIT_CLEAR_IA32_LBR_CTL from exec_control in nested case.
Quoted 27 lines · Weijiang
Quoted 6 lines · Sean Christopherson
Quoted 3 lines · Yang Weijiang
The old patch series was queued in KVM/queue for a while and finally moved to below branch after Paolo's refactor. This new patch set is built on top of Paolo's work + some fixes, it's tested on legacy platform
Please elaborate on what was broken, i.e. why this was de-queued, as well as on what was fixed an dhow. That will help bring me up to speed and expedite review.
Thanks Sean!
The de-queued reason I read from community is, the PEBS and Arch-LBR patches broke selftest/KUTs due to host-initiated 0 writes to PMU msrs. Paolo tried to fix it but you didn't agree on the solution. Plus your comments below:Quoted 2 lines · Paolo Bonzini
Quoted 1 line · Sean Christopherson
Can we just punt this out of kvm/queue until its been properly
reviewed?
Quoted 2 lines
Yes, I agree. I have started making some changes and pushed the result to kvm/arch-lbr-for-weijiang.
What are fixed in this series:
1. An missing of -1: if ((
entry->eax&0xff) != (1 << (depth_bit- 1)))2. Removed exit bit check in
cpu_has_vmx_arch_lbr(void), moved it tosetup_vmcs_config().
Quoted 8 lines
3. A redundant check
kvm_cpu_cap_has(X86_FEATURE_ARCH_LBR)inkvm_check_cpuid().4. KUT/selftest failures due to lack of
MSR_ARCH_LBR_CTLandMSR_ARCH_LBR_DEPTHinkvm_set_msr_common()before validate pmu msrs.5. Calltrace in L1 when L1 tried to
vmcs_write64(GUEST_IA32_LBR_CTL, 0)invmx_vcpu_reset(), usecpu_has_vmx_arch_lbr()instead.6. Removed
VM_ENTRY_LOAD_IA32_LBR_CTLandVM_EXIT_CLEAR_IA32_LBR_CTLfromexec_controlin nested case.
Hi, Sean,
Could you kindly review this post and give some comments on the series so that I can prepare next version?
Thanks!
Quoted 7 lines · Weijiang
Quoted 6 lines · Weijiang
Quoted 5 lines · Sean Christopherson
Quoted 4 lines · Yang Weijiang
The old patch series was queued in KVM/queue for a while and finally moved to below branch after Paolo's refactor. This new patch set is built on top of Paolo's work + some fixes, it's tested on legacy platform
[...]
Quoted 19 lines
Quoted 10 lines
What are fixed in this series:
1. An missing of -1: if ((
entry->eax&0xff) != (1 << (depth_bit- 1)))2. Removed exit bit check in
cpu_has_vmx_arch_lbr(void), moved it tosetup_vmcs_config().3. A redundant check
kvm_cpu_cap_has(X86_FEATURE_ARCH_LBR)inkvm_check_cpuid().Quoted 9 lines
4. KUT/selftest failures due to lack of
MSR_ARCH_LBR_CTLandMSR_ARCH_LBR_DEPTHinkvm_set_msr_common()before validate pmu msrs.5. Calltrace in L1 when L1 tried to vmcs_write64(GUEST_IA32_LBR_CTL,
0) invmx_vcpu_reset(), usecpu_has_vmx_arch_lbr()instead.6. Removed
VM_ENTRY_LOAD_IA32_LBR_CTLandVM_EXIT_CLEAR_IA32_LBR_CTLfromexec_controlin nested case.
Quoted 6 lines
Hi, Sean,
Could you kindly review this post and give some comments on the series so that I can prepare next version?
Thanks!
Ping...
In case you missed previous email...