Skip to contentSkip to conversation

nvmet-tcp: handle ICReq PDU received in NVMET_TCP_Q_LIVE state

PATCH Superseded Varun Prakash 3 participants 3 messages Sep 4, 2022 – Sep 12, 2022

Subsystems (2)

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 nvmet-tcp: handle ICReq PDU received in NVMET_TCP_Q_LIVE state

If target receives ICReq PDU in queue state NVMET_TCP_Q_LIVE then call nvmet_tcp_fatal_error() and return -EPROTO.

---
 drivers/nvme/target/tcp.c | 7 +++++++
 1 file changed, 7 insertions(+)
drivers/nvme/target/tcp.c +7 -0
index a3694a32f6d5..02df2fc7dfe7 100644
@@ -976,6 +976,13 @@ static int nvmet_tcp_done_recv_pdu(struct nvmet_tcp_queue *queue)
 		return nvmet_tcp_handle_icreq(queue);
 	}
 
+	if (unlikely(hdr->type == nvme_tcp_icreq)) {
+		pr_err("queue %d: received icreq pdu in state %d\n",
+			queue->idx, queue->state);
+		nvmet_tcp_fatal_error(queue);
+		return -EPROTO;
+	}
+
 	if (hdr->type == nvme_tcp_h2c_data) {
 		ret = nvmet_tcp_handle_h2c_data_pdu(queue);
 		if (unlikely(ret))
Signature · 1 line
2.31.1
#1 lore raw
Quoted 3 lines · Varun Prakash

If target receives ICReq PDU in queue state NVMET_TCP_Q_LIVE then call nvmet_tcp_fatal_error() and return -EPROTO.

Can you please state the detailed scenario in the commit log ?

-ck

maintainer
#2 lore raw
Quoted 6 lines · Chaitanya Kulkarni
Quoted 3 lines · Varun Prakash

If target receives ICReq PDU in queue state NVMET_TCP_Q_LIVE then call nvmet_tcp_fatal_error() and return -EPROTO.

Can you please state the detailed scenario in the commit log ?

Can't find the original patch... Where was this sent?