Skip to contentSkip to conversation

common/iavf: do not copy desc/buff in async mode

PATCH Applied Steven Zou 2 participants 2 messages Sep 5, 2022

lore
Share & tools
lore

Steven Zou

author
#0 lore raw

PATCH 1/1 common/iavf: do not copy desc/buff in async mode

If cmd_details are defined or async flag is set,
don't copy the desc/buff back to temp.

Signed-off-by Steven Zou <[email protected]>
---
 drivers/common/iavf/iavf_adminq.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/common/iavf/iavf_adminq.c +2 -1
index 0bf5af0cbe..2e59820b3b 100644
@@ -784,7 +784,8 @@ enum iavf_status iavf_asq_send_command(struct iavf_hw *hw,
 	}
 
 	/* if ready, copy the desc back to temp */
-	if (iavf_asq_done(hw)) {
+	if (iavf_asq_done(hw) &&
+		!details->async && !details->postpone) {
 		iavf_memcpy(desc, desc_on_ring, sizeof(struct iavf_aq_desc),
 			    IAVF_DMA_TO_NONDMA);
 		if (buff != NULL)
Signature · 1 line
2.34.1
Acked-by on v1 1/1 Applied
#1 lore raw
Quoted 10 lines

-----Original Message-----
From: Zou, Steven <[email protected]>
Sent: Monday, September 5, 2022 9:42 AM
To: [email protected]
Cc: Zhang, Qi Z <[email protected]>; Yang, Guang3 <[email protected]>; Zou, Steven <[email protected]>
Subject: [PATCH] common/iavf: do not copy desc/buff in async mode

Quoted 3 lines

If cmd_details are defined or async flag is set, don't copy the desc/buff back to temp.

Added

Fixes e5b2a9e957e7 ("net/avf/base: add base code for avf PMD")
Cc [email protected]
Quoted 1 line
Signed-off-by Steven Zou <[email protected]>
Acked-by Qi Zhang <[email protected]>

Applied to dpdk-next-net-intel.

Thanks
Qi