ARM: dts: fix Moxa SDIO 'compatible', remove 'sdhci' misnomer
Subsystems (2)
PATCH v2 1/1 ARM: dts: fix Moxa SDIO 'compatible', remove 'sdhci' misnomer
Driver moxart-mmc.c has .compatible = "moxa,moxart-mmc".
But moxart .dts/.dtsi and the documentation file moxa,moxart-dma.txt contain compatible = "moxa,moxart-sdhci".
Change moxart .dts/.dtsi files and moxa,moxart-dma.txt to match the driver.
Replace 'sdhci' with 'mmc' in names too, since SDHCI is a different controller from FTSDC010.
---
v1 -> v2:
Per Arnd Bergmann's suggestion, replaced sdhci with mmc in names too.
Documentation/devicetree/bindings/dma/moxa,moxart-dma.txt | 4 ++-- arch/arm/boot/dts/moxart-uc7112lx.dts | 2 +- arch/arm/boot/dts/moxart.dtsi | 4 ++-- 3 files changed, 5 insertions(+), 5 deletions(-)
Documentation/devicetree/bindings/dma/moxa,moxart-dma.txt +2 -2
@@ -34,8 +34,8 @@ Example: Use specific request line passing from dma For example, MMC request line is 5 - sdhci: sdhci@98e00000 { - compatible = "moxa,moxart-sdhci"; + mmc: mmc@98e00000 { + compatible = "moxa,moxart-mmc"; reg = <0x98e00000 0x5C>; interrupts = <5 0>; clocks = <&clk_apb>;
arch/arm/boot/dts/moxart-uc7112lx.dts +1 -1
@@ -79,7 +79,7 @@ &clk_pll { clocks = <&ref12>; }; -&sdhci { +&mmc { status = "okay"; };
arch/arm/boot/dts/moxart.dtsi +2 -2
@@ -93,8 +93,8 @@ watchdog: watchdog@98500000 { clock-names = "PCLK"; }; - sdhci: sdhci@98e00000 { - compatible = "moxa,moxart-sdhci"; + mmc: mmc@98e00000 { + compatible = "moxa,moxart-mmc"; reg = <0x98e00000 0x5C>; interrupts = <5 IRQ_TYPE_LEVEL_HIGH>; clocks = <&clk_apb>;
Signature · 1 line
2.34.1
Quoted 5 lines · Sergei Antonov
Driver
moxart-mmc.chas .compatible = "moxa,moxart-mmc".But moxart .dts/.dtsi and the documentation file moxa,moxart-dma.txt contain compatible = "moxa,moxart-sdhci".
Quoted 8 lines
Change moxart .dts/.dtsi files and moxa,moxart-dma.txt to match the driver.
Replace 'sdhci' with 'mmc' in names too, since SDHCI is a different controller from FTSDC010.
Signed-off-by Sergei Antonov <[email protected]>Suggested-by Arnd Bergmann <[email protected]>Cc Jonas Jensen <[email protected]>
Quoted 2 lines
v1 -> v2:
Per Arnd Bergmann's suggestion, replaced sdhci with mmc in names too.
Looks good to me now. Let's wait for more comments, or possibly for Jonas to pick it up into his tree. If everyone is fine with this version, can you send it to [email protected] so I can pick it up into the soc tree?
Arnd
Quoted 13 lines · Sergei Antonov
Driver
moxart-mmc.chas .compatible = "moxa,moxart-mmc".But moxart .dts/.dtsi and the documentation file moxa,moxart-dma.txt contain compatible = "moxa,moxart-sdhci".
Change moxart .dts/.dtsi files and moxa,moxart-dma.txt to match the driver.
Replace 'sdhci' with 'mmc' in names too, since SDHCI is a different controller from FTSDC010.
Signed-off-by Sergei Antonov <[email protected]>Suggested-by Arnd Bergmann <[email protected]>Cc Jonas Jensen <[email protected]>
Quoted 9 lines
---
v1 -> v2:
Per Arnd Bergmann's suggestion, replaced sdhci with mmc in names too.Documentation/devicetree/bindings/dma/moxa,moxart-dma.txt | 4 ++-- arch/arm/boot/dts/moxart-uc7112lx.dts | 2 +- arch/arm/boot/dts/moxart.dtsi | 4 ++-- 3 files changed, 5 insertions(+), 5 deletions(-)