drivers/base: Fix unsigned comparison to -1 in CPUMAP_FILE_MAX_BYTES
Subsystems (2)
PATCH 1/1 drivers/base: Fix unsigned comparison to -1 in CPUMAP_FILE_MAX_BYTES
As PAGE_SIZE is unsigned long, -1 > PAGE_SIZE when NR_CPUS <= 3. This leads to very large file sizes:
topology$ ls -l
total 0
-r--r--r-- 1 root root 18446744073709551615 Sep 5 11:59 core_cpus -r--r--r-- 1 root root 4096 Sep 5 11:59 core_cpus_list -r--r--r-- 1 root root 4096 Sep 5 10:58 core_id -r--r--r-- 1 root root 18446744073709551615 Sep 5 10:10 core_siblings -r--r--r-- 1 root root 4096 Sep 5 11:59 core_siblings_list -r--r--r-- 1 root root 18446744073709551615 Sep 5 11:59 die_cpus -r--r--r-- 1 root root 4096 Sep 5 11:59 die_cpus_list -r--r--r-- 1 root root 4096 Sep 5 11:59 die_id -r--r--r-- 1 root root 18446744073709551615 Sep 5 11:59 package_cpus -r--r--r-- 1 root root 4096 Sep 5 11:59 package_cpus_list -r--r--r-- 1 root root 4096 Sep 5 10:58 physical_package_id -r--r--r-- 1 root root 18446744073709551615 Sep 5 10:10 thread_siblings -r--r--r-- 1 root root 4096 Sep 5 11:59 thread_siblings_list
Adjust the inequality to catch the case when NR_CPUS is configured to a small value.
--- include/linux/cpumask.h | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)
include/linux/cpumask.h +3 -2
@@ -1127,9 +1127,10 @@ cpumap_print_list_to_buf(char *buf, const struct cpumask *mask,* cover a worst-case of every other cpu being on one of two nodes for a * very large NR_CPUS. * -* Use PAGE_SIZE as a minimum for smaller configurations. +* Use PAGE_SIZE as a minimum for smaller configurations while avoiding +* unsigned comparison to -1. */ -#define CPUMAP_FILE_MAX_BYTES ((((NR_CPUS * 9)/32 - 1) > PAGE_SIZE) \ +#define CPUMAP_FILE_MAX_BYTES ((((NR_CPUS * 9)/32) > PAGE_SIZE + 1) \ ? (NR_CPUS * 9)/32 - 1 : PAGE_SIZE)#define CPULIST_FILE_MAX_BYTES (((NR_CPUS * 7)/2 > PAGE_SIZE) ? (NR_CPUS * 7)/2 : PAGE_SIZE)
Signature · 1 line
2.31.1
Greg Kroah-Hartman
maintainerQuoted 6 lines · Phil Auld
As
PAGE_SIZEis unsigned long, -1 >PAGE_SIZEwhenNR_CPUS<= 3. This leads to very large file sizes:topology$ ls -l
total 0
-r--r--r-- 1 root root 18446744073709551615 Sep 5 11:59core_cpus
Yeah, lots of CPUs! :)
Quoted 48 lines
(quoted diff) +0
-12-r--r--r-- 1 root root 4096 Sep 5 11:59 core_cpus_list -r--r--r-- 1 root root 4096 Sep 5 10:58 core_id -r--r--r-- 1 root root 18446744073709551615 Sep 5 10:10 core_siblings -r--r--r-- 1 root root 4096 Sep 5 11:59 core_siblings_list -r--r--r-- 1 root root 18446744073709551615 Sep 5 11:59 die_cpus -r--r--r-- 1 root root 4096 Sep 5 11:59 die_cpus_list -r--r--r-- 1 root root 4096 Sep 5 11:59 die_id -r--r--r-- 1 root root 18446744073709551615 Sep 5 11:59 package_cpus -r--r--r-- 1 root root 4096 Sep 5 11:59 package_cpus_list -r--r--r-- 1 root root 4096 Sep 5 10:58 physical_package_id -r--r--r-- 1 root root 18446744073709551615 Sep 5 10:10 thread_siblings -r--r--r-- 1 root root 4096 Sep 5 11:59 thread_siblings_listAdjust the inequality to catch the case when
NR_CPUSis configured to a small value.Fixes 7ee951acd31a ("drivers/base: fix userspace break from using bin_attributes for cpumap and cpulist")Reported-by feng xiangjun <[email protected]>Signed-off-by Phil Auld <[email protected]>Cc Greg Kroah-Hartman <[email protected]>Cc "Rafael J. Wysocki" <[email protected]>Cc Yury Norov <[email protected]>Cc feng xiangjun <[email protected]>--- include/linux/cpumask.h | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)include/linux/cpumask.h +3
-2@@ -1127,9 +1127,10 @@ cpumap_print_list_to_buf(char *buf, const struct cpumask *mask,* cover a worst-case of every other cpu being on one of two nodes for a * very large NR_CPUS. * -* Use PAGE_SIZE as a minimum for smaller configurations. +* Use PAGE_SIZE as a minimum for smaller configurations while avoiding +* unsigned comparison to -1. */ -#define CPUMAP_FILE_MAX_BYTES ((((NR_CPUS * 9)/32 - 1) > PAGE_SIZE) \ +#define CPUMAP_FILE_MAX_BYTES ((((NR_CPUS * 9)/32) > PAGE_SIZE + 1) \ ? (NR_CPUS * 9)/32 - 1 : PAGE_SIZE)#define CPULIST_FILE_MAX_BYTES (((NR_CPUS * 7)/2 > PAGE_SIZE) ? (NR_CPUS * 7)/2 : PAGE_SIZE)Signature · 1 line
2.31.1
Nice catch. What type of systems did you run this on to verify it will work?
thanks,
greg k-h
Quoted 10 lines · On Tue, Sep 06, 2022 at 07:02:37PM +0200 Greg Kroah-Hartman wrote:
Quoted 6 lines · Phil Auld
As
PAGE_SIZEis unsigned long, -1 >PAGE_SIZEwhenNR_CPUS<= 3. This leads to very large file sizes:topology$ ls -l
total 0
-r--r--r-- 1 root root 18446744073709551615 Sep 5 11:59core_cpusYeah, lots of CPUs! :)
Yep, apparently things like lscpu fail with this size.
Quoted 45 lines
Quoted 45 lines
(quoted diff) +0
-12-r--r--r-- 1 root root 4096 Sep 5 11:59 core_cpus_list -r--r--r-- 1 root root 4096 Sep 5 10:58 core_id -r--r--r-- 1 root root 18446744073709551615 Sep 5 10:10 core_siblings -r--r--r-- 1 root root 4096 Sep 5 11:59 core_siblings_list -r--r--r-- 1 root root 18446744073709551615 Sep 5 11:59 die_cpus -r--r--r-- 1 root root 4096 Sep 5 11:59 die_cpus_list -r--r--r-- 1 root root 4096 Sep 5 11:59 die_id -r--r--r-- 1 root root 18446744073709551615 Sep 5 11:59 package_cpus -r--r--r-- 1 root root 4096 Sep 5 11:59 package_cpus_list -r--r--r-- 1 root root 4096 Sep 5 10:58 physical_package_id -r--r--r-- 1 root root 18446744073709551615 Sep 5 10:10 thread_siblings -r--r--r-- 1 root root 4096 Sep 5 11:59 thread_siblings_listAdjust the inequality to catch the case when
NR_CPUSis configured to a small value.Fixes 7ee951acd31a ("drivers/base: fix userspace break from using bin_attributes for cpumap and cpulist")Reported-by feng xiangjun <[email protected]>Signed-off-by Phil Auld <[email protected]>Cc Greg Kroah-Hartman <[email protected]>Cc "Rafael J. Wysocki" <[email protected]>Cc Yury Norov <[email protected]>Cc feng xiangjun <[email protected]>--- include/linux/cpumask.h | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)include/linux/cpumask.h +3
-2@@ -1127,9 +1127,10 @@ cpumap_print_list_to_buf(char *buf, const struct cpumask *mask,* cover a worst-case of every other cpu being on one of two nodes for a * very large NR_CPUS. * -* Use PAGE_SIZE as a minimum for smaller configurations. +* Use PAGE_SIZE as a minimum for smaller configurations while avoiding +* unsigned comparison to -1. */ -#define CPUMAP_FILE_MAX_BYTES ((((NR_CPUS * 9)/32 - 1) > PAGE_SIZE) \ +#define CPUMAP_FILE_MAX_BYTES ((((NR_CPUS * 9)/32) > PAGE_SIZE + 1) \ ? (NR_CPUS * 9)/32 - 1 : PAGE_SIZE)#define CPULIST_FILE_MAX_BYTES (((NR_CPUS * 7)/2 > PAGE_SIZE) ? (NR_CPUS * 7)/2 : PAGE_SIZE)
Quoted 7 lines
Quoted 3 lines
Signature · 1 line
2.31.1Nice catch. What type of systems did you run this on to verify it will work?
Feng ran it on his 2 cpu laptop. I ran it on my usual test bed (80 cpus) but configured both with NR_CPUS at 8192 and at 2.
It's not really dependent on the actual system. It's a compile time config option. I failed to set it small when testing the first one.
The fix here is just maths :)
With NR_CPUS == 2:
# ls -l /sys/devices/system/cpu/cpu0/topology/ total 0 -r--r--r--. 1 root root 4096 Sep 6 11:40 cluster_cpus -r--r--r--. 1 root root 4096 Sep 6 11:40 cluster_cpus_list -r--r--r--. 1 root root 4096 Sep 6 11:40 cluster_id -r--r--r--. 1 root root 4096 Sep 6 11:40 core_cpus -r--r--r--. 1 root root 4096 Sep 6 11:40 core_cpus_list -r--r--r--. 1 root root 4096 Sep 6 11:40 core_id -r--r--r--. 1 root root 4096 Sep 6 11:29 core_siblings -r--r--r--. 1 root root 4096 Sep 6 11:40 core_siblings_list ...
Cheers,
Phil
Quoted 4 lines
thanks,
greg k-h
Yury Norov
maintainerQuoted 39 lines · Phil Auld
As
PAGE_SIZEis unsigned long, -1 >PAGE_SIZEwhenNR_CPUS<= 3. This leads to very large file sizes:topology$ ls -l
total 0(quoted diff) +0
-13-r--r--r-- 1 root root 18446744073709551615 Sep 5 11:59 core_cpus -r--r--r-- 1 root root 4096 Sep 5 11:59 core_cpus_list -r--r--r-- 1 root root 4096 Sep 5 10:58 core_id -r--r--r-- 1 root root 18446744073709551615 Sep 5 10:10 core_siblings -r--r--r-- 1 root root 4096 Sep 5 11:59 core_siblings_list -r--r--r-- 1 root root 18446744073709551615 Sep 5 11:59 die_cpus -r--r--r-- 1 root root 4096 Sep 5 11:59 die_cpus_list -r--r--r-- 1 root root 4096 Sep 5 11:59 die_id -r--r--r-- 1 root root 18446744073709551615 Sep 5 11:59 package_cpus -r--r--r-- 1 root root 4096 Sep 5 11:59 package_cpus_list -r--r--r-- 1 root root 4096 Sep 5 10:58 physical_package_id -r--r--r-- 1 root root 18446744073709551615 Sep 5 10:10 thread_siblings -r--r--r-- 1 root root 4096 Sep 5 11:59 thread_siblings_listAdjust the inequality to catch the case when
NR_CPUSis configured to a small value.Fixes 7ee951acd31a ("drivers/base: fix userspace break from using bin_attributes for cpumap and cpulist")Reported-by feng xiangjun <[email protected]>Signed-off-by Phil Auld <[email protected]>Cc Greg Kroah-Hartman <[email protected]>Cc "Rafael J. Wysocki" <[email protected]>Cc Yury Norov <[email protected]>Cc feng xiangjun <[email protected]>--- include/linux/cpumask.h | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)include/linux/cpumask.h +0
-0
include/linux/cpumask.h cpumap_print_list_to_buf(char *buf, const struct cpumask *mask, · line 1133
Quoted 9 lines
include/linux/cpumask.h +3
-2@@ -1127,9 +1127,10 @@ cpumap_print_list_to_buf(char *buf, const struct cpumask *mask,* cover a worst-case of every other cpu being on one of two nodes for a * very large NR_CPUS. * -* Use PAGE_SIZE as a minimum for smaller configurations. +* Use PAGE_SIZE as a minimum for smaller configurations while avoiding +* unsigned comparison to -1. */ -#define CPUMAP_FILE_MAX_BYTES ((((NR_CPUS * 9)/32 - 1) > PAGE_SIZE) \ +#define CPUMAP_FILE_MAX_BYTES ((((NR_CPUS * 9)/32) > PAGE_SIZE + 1) \
Maybe it would be easier to read with less braces and '>=' instead of '>'?
#define CPUMAP_FILE_MAX_BYTES \
(NR_CPUS * 9 / 32 >= PAGE_SIZE ? NR_CPUS * 9 / 32 - 1 : PAGE_SIZE)Anyways, this is a good catch. If you think it doesn't worth an update, I can take it in bitmap-for-next as-is.
Quoted 5 lines
include/linux/cpumask.h +0
-0? (NR_CPUS * 9)/32 - 1 : PAGE_SIZE)#define CPULIST_FILE_MAX_BYTES (((NR_CPUS * 7)/2 > PAGE_SIZE) ? (NR_CPUS * 7)/2 : PAGE_SIZE)Signature · 1 line
2.31.1
Yury Norov
maintainerQuoted 51 lines · Yury Norov
Quoted 39 lines · Phil Auld
As
PAGE_SIZEis unsigned long, -1 >PAGE_SIZEwhenNR_CPUS<= 3. This leads to very large file sizes:topology$ ls -l
total 0(quoted diff) +0
-13-r--r--r-- 1 root root 18446744073709551615 Sep 5 11:59 core_cpus -r--r--r-- 1 root root 4096 Sep 5 11:59 core_cpus_list -r--r--r-- 1 root root 4096 Sep 5 10:58 core_id -r--r--r-- 1 root root 18446744073709551615 Sep 5 10:10 core_siblings -r--r--r-- 1 root root 4096 Sep 5 11:59 core_siblings_list -r--r--r-- 1 root root 18446744073709551615 Sep 5 11:59 die_cpus -r--r--r-- 1 root root 4096 Sep 5 11:59 die_cpus_list -r--r--r-- 1 root root 4096 Sep 5 11:59 die_id -r--r--r-- 1 root root 18446744073709551615 Sep 5 11:59 package_cpus -r--r--r-- 1 root root 4096 Sep 5 11:59 package_cpus_list -r--r--r-- 1 root root 4096 Sep 5 10:58 physical_package_id -r--r--r-- 1 root root 18446744073709551615 Sep 5 10:10 thread_siblings -r--r--r-- 1 root root 4096 Sep 5 11:59 thread_siblings_listAdjust the inequality to catch the case when
NR_CPUSis configured to a small value.Fixes 7ee951acd31a ("drivers/base: fix userspace break from using bin_attributes for cpumap and cpulist")Reported-by feng xiangjun <[email protected]>Signed-off-by Phil Auld <[email protected]>Cc Greg Kroah-Hartman <[email protected]>Cc "Rafael J. Wysocki" <[email protected]>Cc Yury Norov <[email protected]>Cc feng xiangjun <[email protected]>--- include/linux/cpumask.h | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)include/linux/cpumask.h +0
-0include/linux/cpumask.h cpumap_print_list_to_buf(char *buf, const struct cpumask *mask, · line 1133
Quoted 9 lines
include/linux/cpumask.h +3
-2@@ -1127,9 +1127,10 @@ cpumap_print_list_to_buf(char *buf, const struct cpumask *mask,* cover a worst-case of every other cpu being on one of two nodes for a * very large NR_CPUS. * -* Use PAGE_SIZE as a minimum for smaller configurations. +* Use PAGE_SIZE as a minimum for smaller configurations while avoiding +* unsigned comparison to -1. */ -#define CPUMAP_FILE_MAX_BYTES ((((NR_CPUS * 9)/32 - 1) > PAGE_SIZE) \ +#define CPUMAP_FILE_MAX_BYTES ((((NR_CPUS * 9)/32) > PAGE_SIZE + 1) \Maybe it would be easier to read with less braces and '>=' instead of '>'?
Quoted 5 lines
#define CPUMAP_FILE_MAX_BYTES \ (NR_CPUS * 9 / 32 >= PAGE_SIZE ? NR_CPUS * 9 / 32 - 1 : PAGE_SIZE)Anyways, this is a good catch. If you think it doesn't worth an update, I can take it in bitmap-for-next as-is.
Ah, I screwed in math. '>=' wouldn't work of course...
Quoted 51 lines · On Tue, Sep 06, 2022 at 11:09:53AM -0700 Yury Norov wrote:
Quoted 39 lines · Phil Auld
As
PAGE_SIZEis unsigned long, -1 >PAGE_SIZEwhenNR_CPUS<= 3. This leads to very large file sizes:topology$ ls -l
total 0(quoted diff) +0
-13-r--r--r-- 1 root root 18446744073709551615 Sep 5 11:59 core_cpus -r--r--r-- 1 root root 4096 Sep 5 11:59 core_cpus_list -r--r--r-- 1 root root 4096 Sep 5 10:58 core_id -r--r--r-- 1 root root 18446744073709551615 Sep 5 10:10 core_siblings -r--r--r-- 1 root root 4096 Sep 5 11:59 core_siblings_list -r--r--r-- 1 root root 18446744073709551615 Sep 5 11:59 die_cpus -r--r--r-- 1 root root 4096 Sep 5 11:59 die_cpus_list -r--r--r-- 1 root root 4096 Sep 5 11:59 die_id -r--r--r-- 1 root root 18446744073709551615 Sep 5 11:59 package_cpus -r--r--r-- 1 root root 4096 Sep 5 11:59 package_cpus_list -r--r--r-- 1 root root 4096 Sep 5 10:58 physical_package_id -r--r--r-- 1 root root 18446744073709551615 Sep 5 10:10 thread_siblings -r--r--r-- 1 root root 4096 Sep 5 11:59 thread_siblings_listAdjust the inequality to catch the case when
NR_CPUSis configured to a small value.Fixes 7ee951acd31a ("drivers/base: fix userspace break from using bin_attributes for cpumap and cpulist")Reported-by feng xiangjun <[email protected]>Signed-off-by Phil Auld <[email protected]>Cc Greg Kroah-Hartman <[email protected]>Cc "Rafael J. Wysocki" <[email protected]>Cc Yury Norov <[email protected]>Cc feng xiangjun <[email protected]>--- include/linux/cpumask.h | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)include/linux/cpumask.h +0
-0include/linux/cpumask.h cpumap_print_list_to_buf(char *buf, const struct cpumask *mask, · line 1133
Quoted 9 lines
include/linux/cpumask.h +3
-2@@ -1127,9 +1127,10 @@ cpumap_print_list_to_buf(char *buf, const struct cpumask *mask,* cover a worst-case of every other cpu being on one of two nodes for a * very large NR_CPUS. * -* Use PAGE_SIZE as a minimum for smaller configurations. +* Use PAGE_SIZE as a minimum for smaller configurations while avoiding +* unsigned comparison to -1. */ -#define CPUMAP_FILE_MAX_BYTES ((((NR_CPUS * 9)/32 - 1) > PAGE_SIZE) \ +#define CPUMAP_FILE_MAX_BYTES ((((NR_CPUS * 9)/32) > PAGE_SIZE + 1) \Maybe it would be easier to read with less braces and '>=' instead of '>'?
Quoted 6 lines
#define CPUMAP_FILE_MAX_BYTES \ (NR_CPUS * 9 / 32 >= PAGE_SIZE ? NR_CPUS * 9 / 32 - 1 : PAGE_SIZE)Anyways, this is a good catch. If you think it doesn't worth an update, I can take it in bitmap-for-next as-is.
It would work as
#define CPUMAP_FILE_MAX_BYTES (((NR_CPUS * 9)/32 > PAGE_SIZE) \
? (NR_CPUS * 9)/32 - 1 : PAGE_SIZE)
Since 4097 > PAGE_SIZE and then you'd get PAGE_SIZE anyway. That is we could just leave the 1 out of the inequality completely.
If I recall at least some of the parens are needed to make the compiler happy.
I can resend with the above if you want.
Cheers,
Phil
Quoted 6 lines
Quoted 5 lines
include/linux/cpumask.h +0
-0? (NR_CPUS * 9)/32 - 1 : PAGE_SIZE)#define CPULIST_FILE_MAX_BYTES (((NR_CPUS * 7)/2 > PAGE_SIZE) ? (NR_CPUS * 7)/2 : PAGE_SIZE)Signature · 1 line
2.31.1
Yury Norov
maintainerQuoted 63 lines · Phil Auld
Quoted 51 lines · On Tue, Sep 06, 2022 at 11:09:53AM -0700 Yury Norov wrote:
Quoted 39 lines · Phil Auld
As
PAGE_SIZEis unsigned long, -1 >PAGE_SIZEwhenNR_CPUS<= 3. This leads to very large file sizes:topology$ ls -l
total 0(quoted diff) +0
-13-r--r--r-- 1 root root 18446744073709551615 Sep 5 11:59 core_cpus -r--r--r-- 1 root root 4096 Sep 5 11:59 core_cpus_list -r--r--r-- 1 root root 4096 Sep 5 10:58 core_id -r--r--r-- 1 root root 18446744073709551615 Sep 5 10:10 core_siblings -r--r--r-- 1 root root 4096 Sep 5 11:59 core_siblings_list -r--r--r-- 1 root root 18446744073709551615 Sep 5 11:59 die_cpus -r--r--r-- 1 root root 4096 Sep 5 11:59 die_cpus_list -r--r--r-- 1 root root 4096 Sep 5 11:59 die_id -r--r--r-- 1 root root 18446744073709551615 Sep 5 11:59 package_cpus -r--r--r-- 1 root root 4096 Sep 5 11:59 package_cpus_list -r--r--r-- 1 root root 4096 Sep 5 10:58 physical_package_id -r--r--r-- 1 root root 18446744073709551615 Sep 5 10:10 thread_siblings -r--r--r-- 1 root root 4096 Sep 5 11:59 thread_siblings_listAdjust the inequality to catch the case when
NR_CPUSis configured to a small value.Fixes 7ee951acd31a ("drivers/base: fix userspace break from using bin_attributes for cpumap and cpulist")Reported-by feng xiangjun <[email protected]>Signed-off-by Phil Auld <[email protected]>Cc Greg Kroah-Hartman <[email protected]>Cc "Rafael J. Wysocki" <[email protected]>Cc Yury Norov <[email protected]>Cc feng xiangjun <[email protected]>--- include/linux/cpumask.h | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)include/linux/cpumask.h +0
-0include/linux/cpumask.h cpumap_print_list_to_buf(char *buf, const struct cpumask *mask, · line 1133
Quoted 9 lines
include/linux/cpumask.h +3
-2@@ -1127,9 +1127,10 @@ cpumap_print_list_to_buf(char *buf, const struct cpumask *mask,* cover a worst-case of every other cpu being on one of two nodes for a * very large NR_CPUS. * -* Use PAGE_SIZE as a minimum for smaller configurations. +* Use PAGE_SIZE as a minimum for smaller configurations while avoiding +* unsigned comparison to -1. */ -#define CPUMAP_FILE_MAX_BYTES ((((NR_CPUS * 9)/32 - 1) > PAGE_SIZE) \ +#define CPUMAP_FILE_MAX_BYTES ((((NR_CPUS * 9)/32) > PAGE_SIZE + 1) \Maybe it would be easier to read with less braces and '>=' instead of '>'?
Quoted 6 lines
#define CPUMAP_FILE_MAX_BYTES \ (NR_CPUS * 9 / 32 >= PAGE_SIZE ? NR_CPUS * 9 / 32 - 1 : PAGE_SIZE)Anyways, this is a good catch. If you think it doesn't worth an update, I can take it in bitmap-for-next as-is.
It would work as
#define CPUMAP_FILE_MAX_BYTES (((NR_CPUS * 9)/32 > PAGE_SIZE) \ ? (NR_CPUS * 9)/32 - 1 : PAGE_SIZE)
Quoted 6 lines
Since 4097 >
PAGE_SIZEand then you'd getPAGE_SIZEanyway. That is we could just leave the 1 out of the inequality completely.If I recall at least some of the parens are needed to make the compiler happy.
I can resend with the above if you want.
Yes, please