regulator: dt-bindings: qcom,rpmh: Indicate regulator-allow-set-load dependencies
Subsystems (3)
PATCH v2 1/1 regulator: dt-bindings: qcom,rpmh: Indicate regulator-allow-set-load dependencies
For RPMH regulators it doesn't make sense to indicate regulator-allow-set-load without saying what modes you can switch to, so be sure to indicate a dependency on regulator-allowed-modes.
With this in place devicetree validation can catch issues like this:
/mnt/extrassd/git/linux-next/arch/arm64/boot/dts/qcom/sm8350-hdk.dtb: pm8350-rpmh-regulators: ldo5: 'regulator-allowed-modes' is a dependency of 'regulator-allow-set-load'
From schema: /mnt/extrassd/git/linux-next/Documentation/devicetree/bindings/regulator/qcom,rpmh-regulator.yaml
---
v1: https://lore.kernel.org/linux-arm-msm/[email protected]/
Changes since v1:
- Dropped first two patches in the series as they were user error (thanks Krzysztof for highlighting this!)
- No change in the remaining patch
Krzysztof also asked if this patch in particular should apply to other regulators, which I think it should for those regulator's who implement set_mode(). Unfortunately I don't know of a good way to get that information in order to apply it at a broader scope for devicetree regulator validation. At least with this in place RPMH users can get better coverage... if someone has suggestions for how to broaden the scope I'm all ears!
Thanks,
Andrew
.../devicetree/bindings/regulator/qcom,rpmh-regulator.yaml | 4 ++++ 1 file changed, 4 insertions(+)
Documentation/devicetree/bindings/regulator/qcom,rpmh-regulator.yaml +4 -0
@@ -99,12 +99,16 @@ properties: type: object $ref: "regulator.yaml#" description: BOB regulator node. + dependencies: + regulator-allow-set-load: ["regulator-allowed-modes"] patternProperties: "^(smps|ldo|lvs)[0-9]+$": type: object $ref: "regulator.yaml#" description: smps/ldo regulator nodes(s). + dependencies: + regulator-allow-set-load: ["regulator-allowed-modes"] required: - compatible
Signature · 1 line
2.37.2
Rob Herring
maintainerQuoted 27 lines · Andrew Halaney
For RPMH regulators it doesn't make sense to indicate regulator-allow-set-load without saying what modes you can switch to, so be sure to indicate a dependency on regulator-allowed-modes.
With this in place devicetree validation can catch issues like this:
/mnt/extrassd/git/linux-next/arch/arm64/boot/dts/qcom/sm8350-hdk.dtb: pm8350-rpmh-regulators: ldo5: 'regulator-allowed-modes' is a dependency of 'regulator-allow-set-load'
From schema:/mnt/extrassd/git/linux-next/Documentation/devicetree/bindings/regulator/qcom,rpmh-regulator.yamlSuggested-by Johan Hovold <[email protected]>Signed-off-by Andrew Halaney <[email protected]>---
v1: https://lore.kernel.org/linux-arm-msm/[email protected]/
Changes since v1:
- Dropped first two patches in the series as they were user error (thanks Krzysztof for highlighting this!)
- No change in the remaining patchKrzysztof also asked if this patch in particular should apply to other regulators, which I think it should for those regulator's who implement
set_mode(). Unfortunately I don't know of a good way to get that information in order to apply it at a broader scope for devicetree regulator validation. At least with this in place RPMH users can get better coverage... if someone has suggestions for how to broaden the scope I'm all ears!
Quoted 6 lines
Thanks,
Andrew.../devicetree/bindings/regulator/qcom,rpmh-regulator.yaml | 4 ++++ 1 file changed, 4 insertions(+)
Running 'make dtbs_check' with the schema in this patch gives the following warnings. Consider if they are expected or the schema is incorrect. These may not be new warnings.
Note that it is not yet a requirement to have 0 warnings for dtbs_check. This will change in the future.
Full log is available here: https://patchwork.ozlabs.org/patch/
pm8150l-rpmh-regulators: ldo6: 'regulator-allowed-modes' is a dependency of 'regulator-allow-set-load'
arch/arm64/boot/dts/qcom/sm8150-sony-xperia-kumano-bahamut.dtb arch/arm64/boot/dts/qcom/sm8150-sony-xperia-kumano-griffin.dtb arch/arm64/boot/dts/qcom/sm8250-sony-xperia-edo-pdx203.dtb arch/arm64/boot/dts/qcom/sm8250-sony-xperia-edo-pdx206.dtb
pm8150l-rpmh-regulators: ldo9: 'regulator-allowed-modes' is a dependency of 'regulator-allow-set-load'
arch/arm64/boot/dts/qcom/sm8150-sony-xperia-kumano-bahamut.dtb arch/arm64/boot/dts/qcom/sm8150-sony-xperia-kumano-griffin.dtb arch/arm64/boot/dts/qcom/sm8250-sony-xperia-edo-pdx203.dtb arch/arm64/boot/dts/qcom/sm8250-sony-xperia-edo-pdx206.dtb
pm8350-rpmh-regulators: ldo5: 'regulator-allowed-modes' is a dependency of 'regulator-allow-set-load'
arch/arm64/boot/dts/qcom/sm8350-hdk.dtb
pm8350-rpmh-regulators: ldo6: 'regulator-allowed-modes' is a dependency of 'regulator-allow-set-load'
arch/arm64/boot/dts/qcom/sm8350-hdk.dtb
pm8350-rpmh-regulators: ldo7: 'regulator-allowed-modes' is a dependency of 'regulator-allow-set-load'
arch/arm64/boot/dts/qcom/sm8350-hdk.dtb
pm8350-rpmh-regulators: ldo9: 'regulator-allowed-modes' is a dependency of 'regulator-allow-set-load'
arch/arm64/boot/dts/qcom/sm8350-hdk.dtb
pmc8280-1-rpmh-regulators: ldo3: 'regulator-allowed-modes' is a dependency of 'regulator-allow-set-load'
arch/arm64/boot/dts/qcom/sc8280xp-crd.dtb arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dtb
pmc8280-1-rpmh-regulators: ldo4: 'regulator-allowed-modes' is a dependency of 'regulator-allow-set-load'
arch/arm64/boot/dts/qcom/sc8280xp-crd.dtb arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dtb
pmc8280-1-rpmh-regulators: ldo6: 'regulator-allowed-modes' is a dependency of 'regulator-allow-set-load'
arch/arm64/boot/dts/qcom/sc8280xp-crd.dtb arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dtb
pmc8280-2-rpmh-regulators: ldo3: 'regulator-allowed-modes' is a dependency of 'regulator-allow-set-load'
arch/arm64/boot/dts/qcom/sc8280xp-crd.dtb arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dtb
pmc8280-2-rpmh-regulators: ldo4: 'regulator-allowed-modes' is a dependency of 'regulator-allow-set-load'
arch/arm64/boot/dts/qcom/sc8280xp-crd.dtb arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dtb
pmc8280-2-rpmh-regulators: ldo6: 'regulator-allowed-modes' is a dependency of 'regulator-allow-set-load'
arch/arm64/boot/dts/qcom/sc8280xp-crd.dtb
pmc8280-2-rpmh-regulators: ldo7: 'regulator-allowed-modes' is a dependency of 'regulator-allow-set-load'
arch/arm64/boot/dts/qcom/sc8280xp-crd.dtb arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dtb
pmc8280-2-rpmh-regulators: ldo9: 'regulator-allowed-modes' is a dependency of 'regulator-allow-set-load'
arch/arm64/boot/dts/qcom/sc8280xp-crd.dtb arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dtb
pmc8280c-rpmh-regulators: ldo12: 'regulator-allowed-modes' is a dependency of 'regulator-allow-set-load'
arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dtb
pmc8280c-rpmh-regulators: ldo13: 'regulator-allowed-modes' is a dependency of 'regulator-allow-set-load'
arch/arm64/boot/dts/qcom/sc8280xp-crd.dtb arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dtb
pmc8280c-rpmh-regulators: ldo1: 'regulator-allowed-modes' is a dependency of 'regulator-allow-set-load'
arch/arm64/boot/dts/qcom/sc8280xp-crd.dtb arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dtb
pmc8280c-rpmh-regulators: ldo7: 'regulator-allowed-modes' is a dependency of 'regulator-allow-set-load'
arch/arm64/boot/dts/qcom/sc8280xp-crd.dtb
pmm8155au-1-rpmh-regulators: ldo10: 'regulator-allowed-modes' is a dependency of 'regulator-allow-set-load'
arch/arm64/boot/dts/qcom/sa8155p-adp.dtb
pmm8155au-1-rpmh-regulators: ldo5: 'regulator-allowed-modes' is a dependency of 'regulator-allow-set-load'
arch/arm64/boot/dts/qcom/sa8155p-adp.dtb
pmm8155au-2-rpmh-regulators: ldo5: 'regulator-allowed-modes' is a dependency of 'regulator-allow-set-load'
arch/arm64/boot/dts/qcom/sa8155p-adp.dtb
pmm8155au-2-rpmh-regulators: ldo8: 'regulator-allowed-modes' is a dependency of 'regulator-allow-set-load'
arch/arm64/boot/dts/qcom/sa8155p-adp.dtb
pmm8540-a-regulators: ldo13: 'regulator-allowed-modes' is a dependency of 'regulator-allow-set-load'
arch/arm64/boot/dts/qcom/sa8295p-adp.dtb
pmm8540-a-regulators: ldo3: 'regulator-allowed-modes' is a dependency of 'regulator-allow-set-load'
arch/arm64/boot/dts/qcom/sa8295p-adp.dtb
pmm8540-a-regulators: ldo5: 'regulator-allowed-modes' is a dependency of 'regulator-allow-set-load'
arch/arm64/boot/dts/qcom/sa8295p-adp.dtb
pmm8540-a-regulators: ldo7: 'regulator-allowed-modes' is a dependency of 'regulator-allow-set-load'
arch/arm64/boot/dts/qcom/sa8295p-adp.dtb
pmm8540-c-regulators: ldo10: 'regulator-allowed-modes' is a dependency of 'regulator-allow-set-load'
arch/arm64/boot/dts/qcom/sa8295p-adp.dtb
pmm8540-c-regulators: ldo17: 'regulator-allowed-modes' is a dependency of 'regulator-allow-set-load'
arch/arm64/boot/dts/qcom/sa8295p-adp.dtb
pmm8540-c-regulators: ldo1: 'regulator-allowed-modes' is a dependency of 'regulator-allow-set-load'
arch/arm64/boot/dts/qcom/sa8295p-adp.dtb
pmm8540-c-regulators: ldo2: 'regulator-allowed-modes' is a dependency of 'regulator-allow-set-load'
arch/arm64/boot/dts/qcom/sa8295p-adp.dtb
pmm8540-c-regulators: ldo3: 'regulator-allowed-modes' is a dependency of 'regulator-allow-set-load'
arch/arm64/boot/dts/qcom/sa8295p-adp.dtb
pmm8540-c-regulators: ldo4: 'regulator-allowed-modes' is a dependency of 'regulator-allow-set-load'
arch/arm64/boot/dts/qcom/sa8295p-adp.dtb
pmm8540-c-regulators: ldo6: 'regulator-allowed-modes' is a dependency of 'regulator-allow-set-load'
arch/arm64/boot/dts/qcom/sa8295p-adp.dtb
pmm8540-c-regulators: ldo7: 'regulator-allowed-modes' is a dependency of 'regulator-allow-set-load'
arch/arm64/boot/dts/qcom/sa8295p-adp.dtb
pmm8540-g-regulators: ldo3: 'regulator-allowed-modes' is a dependency of 'regulator-allow-set-load'
arch/arm64/boot/dts/qcom/sa8295p-adp.dtb
pmm8540-g-regulators: ldo7: 'regulator-allowed-modes' is a dependency of 'regulator-allow-set-load'
arch/arm64/boot/dts/qcom/sa8295p-adp.dtb
pmm8540-g-regulators: ldo8: 'regulator-allowed-modes' is a dependency of 'regulator-allow-set-load'
arch/arm64/boot/dts/qcom/sa8295p-adp.dtb
pmm8540-g-regulators: qcom,pmic-id:0: 'g' is not one of ['a', 'b', 'c', 'd', 'e', 'f', 'h', 'k']
arch/arm64/boot/dts/qcom/sa8295p-adp.dtb
pmm8540-g-regulators: Unevaluated properties are not allowed ('qcom,pmic-id' was unexpected)
arch/arm64/boot/dts/qcom/sa8295p-adp.dtb
Quoted 45 lines · Rob Herring
Quoted 27 lines · Andrew Halaney
For RPMH regulators it doesn't make sense to indicate regulator-allow-set-load without saying what modes you can switch to, so be sure to indicate a dependency on regulator-allowed-modes.
With this in place devicetree validation can catch issues like this:
/mnt/extrassd/git/linux-next/arch/arm64/boot/dts/qcom/sm8350-hdk.dtb: pm8350-rpmh-regulators: ldo5: 'regulator-allowed-modes' is a dependency of 'regulator-allow-set-load'
From schema:/mnt/extrassd/git/linux-next/Documentation/devicetree/bindings/regulator/qcom,rpmh-regulator.yamlSuggested-by Johan Hovold <[email protected]>Signed-off-by Andrew Halaney <[email protected]>---
v1: https://lore.kernel.org/linux-arm-msm/[email protected]/
Changes since v1:
- Dropped first two patches in the series as they were user error (thanks Krzysztof for highlighting this!)
- No change in the remaining patchKrzysztof also asked if this patch in particular should apply to other regulators, which I think it should for those regulator's who implement
set_mode(). Unfortunately I don't know of a good way to get that information in order to apply it at a broader scope for devicetree regulator validation. At least with this in place RPMH users can get better coverage... if someone has suggestions for how to broaden the scope I'm all ears!Quoted 6 lines
Thanks,
Andrew.../devicetree/bindings/regulator/qcom,rpmh-regulator.yaml | 4 ++++ 1 file changed, 4 insertions(+)Running 'make
dtbs_check' with the schema in this patch gives the following warnings. Consider if they are expected or the schema is incorrect. These may not be new warnings.Note that it is not yet a requirement to have 0 warnings for
dtbs_check. This will change in the future.Full log is available here: https://patchwork.ozlabs.org/patch/
<snip>
Quoted 10 lines
pmm8540-g-regulators: ldo8: 'regulator-allowed-modes' is a dependency of 'regulator-allow-set-load'
arch/arm64/boot/dts/qcom/sa8295p-adp.dtbpmm8540-g-regulators: qcom,pmic-id:0: 'g' is not one of ['a', 'b', 'c', 'd', 'e', 'f', 'h', 'k']
arch/arm64/boot/dts/qcom/sa8295p-adp.dtbpmm8540-g-regulators: Unevaluated properties are not allowed ('qcom,pmic-id' was unexpected)
arch/arm64/boot/dts/qcom/sa8295p-adp.dtb
Please note in case I didn't make it obvious in the commit message, the regulator-allowed-modes dependency warning is the intent of this commit, and those warnings go away once this patch series is applied:
https://lore.kernel.org/all/[email protected]/
The last two are old warnings (that I have yet to look into).
Thanks,
Andrew
Hi,
Quoted 28 lines · Andrew Halaney
For RPMH regulators it doesn't make sense to indicate regulator-allow-set-load without saying what modes you can switch to, so be sure to indicate a dependency on regulator-allowed-modes.
With this in place devicetree validation can catch issues like this:
/mnt/extrassd/git/linux-next/arch/arm64/boot/dts/qcom/sm8350-hdk.dtb: pm8350-rpmh-regulators: ldo5: 'regulator-allowed-modes' is a dependency of 'regulator-allow-set-load'
From schema:/mnt/extrassd/git/linux-next/Documentation/devicetree/bindings/regulator/qcom,rpmh-regulator.yamlSuggested-by Johan Hovold <[email protected]>Signed-off-by Andrew Halaney <[email protected]>---
v1: https://lore.kernel.org/linux-arm-msm/[email protected]/
Changes since v1:
- Dropped first two patches in the series as they were user error (thanks Krzysztof for highlighting this!)
- No change in the remaining patchKrzysztof also asked if this patch in particular should apply to other regulators, which I think it should for those regulator's who implement
set_mode(). Unfortunately I don't know of a good way to get that information in order to apply it at a broader scope for devicetree regulator validation. At least with this in place RPMH users can get better coverage... if someone has suggestions for how to broaden the scope I'm all ears!
Quoted 5 lines
Thanks,
Andrew.../devicetree/bindings/regulator/qcom,rpmh-regulator.yaml | 4 ++++ 1 file changed, 4 insertions(+)
Quoted 11 lines · Andrew Halaney
For RPMH regulators it doesn't make sense to indicate regulator-allow-set-load without saying what modes you can switch to, so be sure to indicate a dependency on regulator-allowed-modes.
With this in place devicetree validation can catch issues like this:
/mnt/extrassd/git/linux-next/arch/arm64/boot/dts/qcom/sm8350-hdk.dtb: pm8350-rpmh-regulators: ldo5: 'regulator-allowed-modes' is a dependency of 'regulator-allow-set-load'
From schema:/mnt/extrassd/git/linux-next/Documentation/devicetree/bindings/regulator/qcom,rpmh-regulator.yamlSuggested-by Johan Hovold <[email protected]>Signed-off-by Andrew Halaney <[email protected]>
Looks good to me.
Quoted 8 lines
---
v1: https://lore.kernel.org/linux-arm-msm/[email protected]/
Changes since v1:
- Dropped first two patches in the series as they were user error (thanks Krzysztof for highlighting this!)
- No change in the remaining patch
Quoted 7 lines
Krzysztof also asked if this patch in particular should apply to other regulators, which I think it should for those regulator's who implement
set_mode(). Unfortunately I don't know of a good way to get that information in order to apply it at a broader scope for devicetree regulator validation. At least with this in place RPMH users can get better coverage... if someone has suggestions for how to broaden the scope I'm all ears!
I guess the commit message could have tried to capture that is feature of the hardware (as Linux implementation details shouldn't impact the binding). And apparently there are regulators that do not need this (e.g. RPM).
Johan
Quoted 33 lines · Johan Hovold
Quoted 11 lines · Andrew Halaney
For RPMH regulators it doesn't make sense to indicate regulator-allow-set-load without saying what modes you can switch to, so be sure to indicate a dependency on regulator-allowed-modes.
With this in place devicetree validation can catch issues like this:
/mnt/extrassd/git/linux-next/arch/arm64/boot/dts/qcom/sm8350-hdk.dtb: pm8350-rpmh-regulators: ldo5: 'regulator-allowed-modes' is a dependency of 'regulator-allow-set-load'
From schema:/mnt/extrassd/git/linux-next/Documentation/devicetree/bindings/regulator/qcom,rpmh-regulator.yamlSuggested-by Johan Hovold <[email protected]>Signed-off-by Andrew Halaney <[email protected]>Looks good to me.
Reviewed-by Johan Hovold <[email protected]>Quoted 8 lines
---
v1: https://lore.kernel.org/linux-arm-msm/[email protected]/
Changes since v1:
- Dropped first two patches in the series as they were user error (thanks Krzysztof for highlighting this!)
- No change in the remaining patchQuoted 7 lines
Krzysztof also asked if this patch in particular should apply to other regulators, which I think it should for those regulator's who implement
set_mode(). Unfortunately I don't know of a good way to get that information in order to apply it at a broader scope for devicetree regulator validation. At least with this in place RPMH users can get better coverage... if someone has suggestions for how to broaden the scope I'm all ears!
Quoted 7 lines
I guess the commit message could have tried to capture that is feature of the hardware (as Linux implementation details shouldn't impact the binding). And apparently there are regulators that do not need this (e.g. RPM).
Johan
Thanks for the suggestion Johan. I've posted another spin with that addition and your (and Douglas') R-B tags over here:
https://lore.kernel.org/linux-arm-msm/[email protected]/T/#u
Thanks,
Andrew