dt-bindings: pwm: tegra: Add compatible string for Tegra234
Subsystems (3)
PATCH 1/3 dt-bindings: pwm: tegra: Add compatible string for Tegra234
Tegra234 has 8 different PWM controllers and each controller has only one output. Add a device tree compatible string for Tegra234.
--- Documentation/devicetree/bindings/pwm/nvidia,tegra20-pwm.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Documentation/devicetree/bindings/pwm/nvidia,tegra20-pwm.txt +1 -1
@@ -9,7 +9,7 @@ Required properties: - "nvidia,tegra132-pwm", "nvidia,tegra20-pwm": for Tegra132 - "nvidia,tegra210-pwm", "nvidia,tegra20-pwm": for Tegra210 - "nvidia,tegra186-pwm": for Tegra186 - - "nvidia,tegra194-pwm": for Tegra194 + - "nvidia,tegra194-pwm": for Tegra194, Tegra234 - reg: physical base address and length of the controller's registers - #pwm-cells: should be 2. See pwm.yaml in this directory for a description of the cells format.
Signature · 1 line
2.17.1
PATCH 2/3 arm64: tegra: Add PWM controllers on Tegra234
Tegra234 has eight single-channel PWM controllers, one of them in the AON block.
---
V3: Update binding doc and fix compatible property.
arch/arm64/boot/dts/nvidia/tegra234.dtsi | 80 +++++++++++++++++++++++- 1 file changed, 78 insertions(+), 2 deletions(-)
arch/arm64/boot/dts/nvidia/tegra234.dtsi +78 -2
@@ -829,8 +829,7 @@ }; pwm1: pwm@3280000 { - compatible = "nvidia,tegra194-pwm", - "nvidia,tegra186-pwm"; + compatible = "nvidia,tegra194-pwm"; reg = <0x3280000 0x10000>; clocks = <&bpmp TEGRA234_CLK_PWM1>; clock-names = "pwm";
@@ -840,6 +839,83 @@ #pwm-cells = <2>; }; + pwm2: pwm@3290000 { + compatible = "nvidia,tegra194-pwm"; + reg = <0x3290000 0x10000>; + clocks = <&bpmp TEGRA234_CLK_PWM2>; + clock-names = "pwm"; + resets = <&bpmp TEGRA234_RESET_PWM2>; + reset-names = "pwm"; + status = "disabled"; + #pwm-cells = <2>; + }; + + pwm3: pwm@32a0000 { + compatible = "nvidia,tegra194-pwm"; + reg = <0x32a0000 0x10000>; + clocks = <&bpmp TEGRA234_CLK_PWM3>; + clock-names = "pwm"; + resets = <&bpmp TEGRA234_RESET_PWM3>; + reset-names = "pwm"; + status = "disabled"; + #pwm-cells = <2>; + }; + + pwm4: pwm@c340000 { + compatible = "nvidia,tegra194-pwm"; + reg = <0xc340000 0x10000>; + clocks = <&bpmp TEGRA234_CLK_PWM4>; + clock-names = "pwm"; + resets = <&bpmp TEGRA234_RESET_PWM4>; + reset-names = "pwm"; + status = "disabled"; + #pwm-cells = <2>; + }; + + pwm5: pwm@32c0000 { + compatible = "nvidia,tegra194-pwm"; + reg = <0x32c0000 0x10000>; + clocks = <&bpmp TEGRA234_CLK_PWM5>; + clock-names = "pwm"; + resets = <&bpmp TEGRA234_RESET_PWM5>; + reset-names = "pwm"; + status = "disabled"; + #pwm-cells = <2>; + }; + + pwm6: pwm@32d0000 { + compatible = "nvidia,tegra194-pwm"; + reg = <0x32d0000 0x10000>; + clocks = <&bpmp TEGRA234_CLK_PWM6>; + clock-names = "pwm"; + resets = <&bpmp TEGRA234_RESET_PWM6>; + reset-names = "pwm"; + status = "disabled"; + #pwm-cells = <2>; + }; + + pwm7: pwm@32e0000 { + compatible = "nvidia,tegra194-pwm"; + reg = <0x32e0000 0x10000>; + clocks = <&bpmp TEGRA234_CLK_PWM7>; + clock-names = "pwm"; + resets = <&bpmp TEGRA234_RESET_PWM7>; + reset-names = "pwm"; + status = "disabled"; + #pwm-cells = <2>; + }; + + pwm8: pwm@32f0000 { + compatible = "nvidia,tegra194-pwm"; + reg = <0x32f0000 0x10000>; + clocks = <&bpmp TEGRA234_CLK_PWM8>; + clock-names = "pwm"; + resets = <&bpmp TEGRA234_RESET_PWM8>; + reset-names = "pwm"; + status = "disabled"; + #pwm-cells = <2>; + }; + spi@3300000 { compatible = "nvidia,tegra234-qspi"; reg = <0x3300000 0x1000>;
Signature · 1 line
2.17.1
PATCH 3/3 arm64: tegra: Add user PWM support on Jetson Orin
In reply to Sandipan PatraEnable in device tree and use it to drive the PWM controllers on 40 pin header of Orin dev-kit.
---
V2: Overriding by node label instead of node path.
arch/arm64/boot/dts/nvidia/tegra234-p3737-0000.dtsi | 12 ++++++++++++ 1 file changed, 12 insertions(+)
arch/arm64/boot/dts/nvidia/tegra234-p3737-0000.dtsi +12 -0
@@ -3,3 +3,15 @@ / { compatible = "nvidia,p3737-0000"; }; + +&pwm1 { + status = "okay"; +}; + +&pwm5 { + status = "okay"; +}; + +&pwm8 { + status = "okay"; +};
Signature · 1 line
2.17.1
Quoted 13 lines · Sandipan Patra
Tegra234 has 8 different PWM controllers and each controller has only one output. Add a device tree compatible string for Tegra234.
Signed-off-by Sandipan Patra <[email protected]>--- Documentation/devicetree/bindings/pwm/nvidia,tegra20-pwm.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)Documentation/devicetree/bindings/pwm/nvidia,tegra20-pwm.txt +0
-0
Documentation/devicetree/bindings/pwm/nvidia,tegra20-pwm.txt Required properties: · line 12
Quoted 5 lines
Documentation/devicetree/bindings/pwm/nvidia,tegra20-pwm.txt +1
-1@@ -9,7 +9,7 @@ Required properties: - "nvidia,tegra132-pwm", "nvidia,tegra20-pwm": for Tegra132 - "nvidia,tegra210-pwm", "nvidia,tegra20-pwm": for Tegra210 - "nvidia,tegra186-pwm": for Tegra186 - - "nvidia,tegra194-pwm": for Tegra194 + - "nvidia,tegra194-pwm": for Tegra194, Tegra234
The commit msg suggest it is different. Are you sure they are exactly the same? If not the same, but compatible, you should use fallback.
Best regards,
Krzysztof
Quoted 25 lines
-----Original Message-----
From: Krzysztof Kozlowski <[email protected]>
Sent: Thursday, September 8, 2022 5:44 PM
To: Sandipan Patra <[email protected]>; [email protected]; Jonathan Hunter <[email protected]>; [email protected]; [email protected]; [email protected]; linux- [email protected]; [email protected]
Cc: Bibek Basu <[email protected]>; Krishna Yarlagadda <[email protected]>
Subject: Re: [PATCH 1/3] dt-bindings: pwm: tegra: Add compatible string for Tegra234External email: Use caution opening links or attachments
Quoted 8 lines · Sandipan Patra
Tegra234 has 8 different PWM controllers and each controller has only one output. Add a device tree compatible string for Tegra234.
Signed-off-by Sandipan Patra <[email protected]>--- Documentation/devicetree/bindings/pwm/nvidia,tegra20-pwm.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Quoted 15 lines
Documentation/devicetree/bindings/pwm/nvidia,tegra20-pwm.txt Required properties: · line 12
Quoted 12 lines
diff --git
a/Documentation/devicetree/bindings/pwm/nvidia,tegra20-pwm.txtb/Documentation/devicetree/bindings/pwm/nvidia,tegra20-pwm.txtindex74c41e34c3b6..331c1e66e8fa100644Documentation/devicetree/bindings/pwm/nvidia,tegra20-pwm.txt +1
-1@@ -9,7 +9,7 @@ Required properties: - "nvidia,tegra132-pwm", "nvidia,tegra20-pwm": for Tegra132 - "nvidia,tegra210-pwm", "nvidia,tegra20-pwm": for Tegra210 - "nvidia,tegra186-pwm": for Tegra186 - - "nvidia,tegra194-pwm": for Tegra194 + - "nvidia,tegra194-pwm": for Tegra194, Tegra234The commit msg suggest it is different. Are you sure they are exactly the same? If not the same, but compatible, you should use fallback.
Tegra194 and Tegra234 are 2 different chips using exactly same pwm module and dt node. This change is to convey that same compatible is used for Tegra234 as well.
Thanks & Regards,
Sandipan
Quoted 3 lines
Best regards,
Krzysztof
Quoted 41 lines · Sandipan Patra
Quoted 25 lines
-----Original Message-----
From: Krzysztof Kozlowski <[email protected]>
Sent: Thursday, September 8, 2022 5:44 PM
To: Sandipan Patra <[email protected]>; [email protected]; Jonathan Hunter <[email protected]>; [email protected]; [email protected]; [email protected]; linux- [email protected]; [email protected]
Cc: Bibek Basu <[email protected]>; Krishna Yarlagadda <[email protected]>
Subject: Re: [PATCH 1/3] dt-bindings: pwm: tegra: Add compatible string for Tegra234External email: Use caution opening links or attachments
Quoted 8 lines · Sandipan Patra
Tegra234 has 8 different PWM controllers and each controller has only one output. Add a device tree compatible string for Tegra234.
Signed-off-by Sandipan Patra <[email protected]>--- Documentation/devicetree/bindings/pwm/nvidia,tegra20-pwm.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)Quoted 15 lines
Documentation/devicetree/bindings/pwm/nvidia,tegra20-pwm.txt Required properties: · line 12
Quoted 12 lines
diff --git
a/Documentation/devicetree/bindings/pwm/nvidia,tegra20-pwm.txtb/Documentation/devicetree/bindings/pwm/nvidia,tegra20-pwm.txtindex74c41e34c3b6..331c1e66e8fa100644Documentation/devicetree/bindings/pwm/nvidia,tegra20-pwm.txt +1
-1@@ -9,7 +9,7 @@ Required properties: - "nvidia,tegra132-pwm", "nvidia,tegra20-pwm": for Tegra132 - "nvidia,tegra210-pwm", "nvidia,tegra20-pwm": for Tegra210 - "nvidia,tegra186-pwm": for Tegra186 - - "nvidia,tegra194-pwm": for Tegra194 + - "nvidia,tegra194-pwm": for Tegra194, Tegra234The commit msg suggest it is different. Are you sure they are exactly the same? If not the same, but compatible, you should use fallback.
Quoted 2 lines
Tegra194 and Tegra234 are 2 different chips using exactly same pwm module and dt node. This change is to convey that same compatible is used for Tegra234 as well.
Then recommended is to have Tegra234 specific compatible with fallback to 194.
Best regards,
Krzysztof