Skip to contentSkip to conversation

leds: bcm63138: refer to ARCH_BCMBCA instead of ARCH_BCM4908

PATCH In review Lukas Bulwahn 3 participants 3 messages Sep 7, 2022

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 leds: bcm63138: refer to ARCH_BCMBCA instead of ARCH_BCM4908

Commit dd5c672d7ca9 ("arm64: bcmbca: Merge ARCH_BCM4908 to ARCH_BCMBCA") removes config ARCH_BCM4908 as config ARCH_BCMBCA has the same intent.

Probably due to concurrent development, commit a0ba692072d8 ("leds:
bcm63138: add support for BCM63138 controller") introduces 'LED Support for Broadcom BCM63138 SoC' that depends on ARCH_BCM4908, but this use was not visible during the config refactoring from the commit above. Hence, these two changes create a reference to a non-existing config symbol.

Adjust the LEDS_BCM63138 definition to refer to ARCH_BCMBCA instead of ARCH_BCM4908 to remove the reference to the non-existing config symbol ARCH_BCM4908.

---
 drivers/leds/blink/Kconfig | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/leds/blink/Kconfig +2 -2
index 945c84286a4e..bdcb7377cd4e 100644
@@ -1,10 +1,10 @@
 config LEDS_BCM63138
 	tristate "LED Support for Broadcom BCM63138 SoC"
 	depends on LEDS_CLASS
-	depends on ARCH_BCM4908 || ARCH_BCM_5301X || BCM63XX || COMPILE_TEST
+	depends on ARCH_BCMBCA || ARCH_BCM_5301X || BCM63XX || COMPILE_TEST
 	depends on HAS_IOMEM
 	depends on OF
-	default ARCH_BCM4908
+	default ARCH_BCMBCA
 	help
 	  This option enables support for LED controller that is part of
 	  BCM63138 SoC. The same hardware block is known to be also used
Signature · 1 line
2.17.1
Acked-by on v1 1/1
#1 lore raw
Quoted 26 lines · Lukas Bulwahn

Commit dd5c672d7ca9 ("arm64: bcmbca: Merge ARCH_BCM4908 to ARCH_BCMBCA") removes config ARCH_BCM4908 as config ARCH_BCMBCA has the same intent.

Probably due to concurrent development, commit a0ba692072d8 ("leds:
bcm63138: add support for BCM63138 controller") introduces 'LED Support for Broadcom BCM63138 SoC' that depends on ARCH_BCM4908, but this use was not visible during the config refactoring from the commit above. Hence, these two changes create a reference to a non-existing config symbol.

Adjust the LEDS_BCM63138 definition to refer to ARCH_BCMBCA instead of ARCH_BCM4908 to remove the reference to the non-existing config symbol ARCH_BCM4908.

---
  drivers/leds/blink/Kconfig | 4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)
drivers/leds/blink/Kconfig +0 -0
index 945c84286a4e..bdcb7377cd4e 100644
@@ -1,10 +1,10 @@
  config LEDS_BCM63138
  	tristate "LED Support for Broadcom BCM63138 SoC"

drivers/leds/blink/Kconfig line 10

Quoted 10 lines
drivers/leds/blink/Kconfig +2 -2
  	depends on LEDS_CLASS
-	depends on ARCH_BCM4908 || ARCH_BCM_5301X || BCM63XX || COMPILE_TEST
+	depends on ARCH_BCMBCA || ARCH_BCM_5301X || BCM63XX || COMPILE_TEST
  	depends on HAS_IOMEM
  	depends on OF
-	default ARCH_BCM4908
+	default ARCH_BCMBCA
  	help
  	  This option enables support for LED controller that is part of
  	  BCM63138 SoC. The same hardware block is known to be also used
Acked-by on v1 1/1
#2 lore raw
In reply to Lukas Bulwahn
Quoted 9 lines · Lukas Bulwahn

Commit dd5c672d7ca9 ("arm64: bcmbca: Merge ARCH_BCM4908 to ARCH_BCMBCA") removes config ARCH_BCM4908 as config ARCH_BCMBCA has the same intent.

Probably due to concurrent development, commit a0ba692072d8 ("leds:
bcm63138: add support for BCM63138 controller") introduces 'LED Support for Broadcom BCM63138 SoC' that depends on ARCH_BCM4908, but this use was not visible during the config refactoring from the commit above. Hence, these two changes create a reference to a non-existing config symbol.

Quoted 5 lines

Adjust the LEDS_BCM63138 definition to refer to ARCH_BCMBCA instead of ARCH_BCM4908 to remove the reference to the non-existing config symbol ARCH_BCM4908.

Signature · 1 line
Florian