mm/huge_memory: prevent THP_ZERO_PAGE_ALLOC increased twice
Subsystems (4)
PATCH v2 1/1 mm/huge_memory: prevent THP_ZERO_PAGE_ALLOC increased twice
If two or more threads call get_huge_zero_page concurrently, THP_ZERO_PAGE_ALLOC may increased two or more times. But actually, this should only count as once since the extra zero pages has been freed. Redefine its meaning to indicate the times a huge zero page used for thp is successfully allocated.
Update Documentation/admin-guide/mm/transhuge.rst together.
---v1->v2: Update documnet.
Documentation/admin-guide/mm/transhuge.rst | 7 +++---- mm/huge_memory.c | 2 +- 2 files changed, 4 insertions(+), 5 deletions(-)
Documentation/admin-guide/mm/transhuge.rst +3 -4
@@ -366,10 +366,9 @@ thp_split_pmd page table entry. thp_zero_page_alloc - is incremented every time a huge zero page is - successfully allocated. It includes allocations which where - dropped due race with other allocation. Note, it doesn't count - every map of the huge zero page, only its allocation. + is incremented every time a huge zero page used for thp is + successfully allocated. Note, it doesn't count every map of + the huge zero page, only its allocation. thp_zero_page_alloc_failed is incremented if kernel fails to allocate
mm/huge_memory.c +1 -1
@@ -163,7 +163,6 @@ static bool get_huge_zero_page(void)count_vm_event (THP_ZERO_PAGE_ALLOC_FAILED );return false; } -count_vm_event (THP_ZERO_PAGE_ALLOC );preempt_disable ();if (cmpxchg (&huge_zero_page,NULL , zero_page)) {preempt_enable ();
@@ -175,6 +174,7 @@ static bool get_huge_zero_page(void)/* We take additional reference here. It will be put back by shrinker */ atomic_set (&huge_zero_refcount,2 );preempt_enable (); +count_vm_event (THP_ZERO_PAGE_ALLOC );return true; }
Signature · 1 line
2.25.1
Quoted 5 lines · Liu Shixin
If two or more threads call
get_huge_zero_pageconcurrently,THP_ZERO_PAGE_ALLOCmay increased two or more times. But actually, this should only count as once since the extra zero pages has been freed. Redefine its meaning to indicate the times a huge zero page used for thp is successfully allocated.
I don't particularly care, but it is not obvoius why the new behaviour is better.
All huge zero pages are freed apart from possibly the last one allocated.
Signature · 1 line
Kiryl Shutsemau / Kirill A. Shutemov
Quoted 8 lines · Kirill A. Shutemov
Quoted 5 lines · Liu Shixin
If two or more threads call
get_huge_zero_pageconcurrently,THP_ZERO_PAGE_ALLOCmay increased two or more times. But actually, this should only count as once since the extra zero pages has been freed. Redefine its meaning to indicate the times a huge zero page used for thp is successfully allocated.I don't particularly care, but it is not obvoius why the new behaviour is better.
The user who read the value may be more concerned about the huge zero pages that are really allocated using for thp and can indicated the times of calling huge_zero_page_shrinker. I misunderstood when I first saw it.
Quoted 3 lines
All huge zero pages are freed apart from possibly the last one allocated.
Quoted 9 lines · Liu Shixin
Quoted 6 lines · Kirill A. Shutemov
Quoted 5 lines · Liu Shixin
If two or more threads call
get_huge_zero_pageconcurrently,THP_ZERO_PAGE_ALLOCmay increased two or more times. But actually, this should only count as once since the extra zero pages has been freed. Redefine its meaning to indicate the times a huge zero page used for thp is successfully allocated.
Quoted 6 lines
Quoted 2 lines
I don't particularly care, but it is not obvoius why the new behaviour is better.
The user who read the value may be more concerned about the huge zero pages that are really allocated using for thp and can indicated the times of calling
huge_zero_page_shrinker.
I misunderstood when I first saw it.
Please, explain the motivation in the commit message.
Signature · 1 line
Kiryl Shutsemau / Kirill A. Shutemov
Quoted 9 lines · Kirill A. Shutemov
Quoted 8 lines · Liu Shixin
Quoted 6 lines · Kirill A. Shutemov
Quoted 5 lines · Liu Shixin
If two or more threads call
get_huge_zero_pageconcurrently,THP_ZERO_PAGE_ALLOCmay increased two or more times. But actually, this should only count as once since the extra zero pages has been freed. Redefine its meaning to indicate the times a huge zero page used for thp is successfully allocated.
Quoted 7 lines
Quoted 6 lines
Quoted 2 lines
I don't particularly care, but it is not obvoius why the new behaviour is better.
The user who read the value may be more concerned about the huge zero pages that are really allocated using for thp and can indicated the times of calling
huge_zero_page_shrinker.
I misunderstood when I first saw it.Please, explain the motivation in the commit message.
Thanks, I add the motivation.
https://lore.kernel.org/all/[email protected]/