Add IGT support for Bigjoiner
v3 cover Add IGT support for Bigjoiner
Add IGT support for bigjoiner:
* Pipe-D won't support mode > 5K
* To use 8K mode on a pipe then consecutive pipe must be available & free.
V2: - Rebase
V3: - Optimizations in helper
Bhanuprakash Modem (52):
lib/igt_kms: Add a helper for valid pipe/output constraint lib/igt_kms: Bigjoiner check in max_bpc constraint tests/kms_async_flips: Add support for Bigjoiner tests/kms_atomic: Add support for Bigjoiner tests/kms_atomic_interruptible: Add support for Bigjoiner tests/kms_atomic_transition: Add support for Bigjoiner tests/kms_color_helper: Helper to check Bigjoiner constraint tests/kms_color: Add support for Bigjoiner tests/chamelium/kms_color_chamelium: Add support for Bigjoiner tests/kms_concurrent: Add support for Bigjoiner tests/kms_content_protection: Add support for Bigjoiner tests/kms_cursor_crc: Add support for Bigjoiner tests/kms_cursor_edge_walk: Add support for Bigjoiner tests/kms_cursor_legacy: Add support for Bigjoiner tests/kms_display_modes: Add support for Bigjoiner tests/kms_dp_tiled_display: Add support for Bigjoiner tests/kms_flip_event_leak: Add support for Bigjoiner tests/kms_invalid_mode: Add support for Bigjoiner tests/kms_lease: Add support for Bigjoiner tests/kms_multipipe_modeset: Find the suitable mode instead of using
default
tests/kms_pipe_crc_basic: Add support for Bigjoiner tests/kms_plane: Add support for Bigjoiner tests/kms_plane_alpha_blend: Add support for Bigjoiner tests/kms_plane_cursor: Add support for Bigjoiner tests/kms_plane_lowres: Add support for Bigjoiner tests/kms_plane_multiple: Add support for Bigjoiner tests/kms_plane_scaling: Add support for Bigjoiner tests/kms_prime: Add support for Bigjoiner tests/kms_properties: Add support for Bigjoiner tests/kms_rmfb: Add support for Bigjoiner tests/kms_rotation_crc: Add support for Bigjoiner tests/kms_scaling_modes: Add support for Bigjoiner tests/kms_sequence: Add support for Bigjoiner tests/kms_universal_plane: Add support for Bigjoiner tests/kms_vblank: Add support for Bigjoiner tests/kms_vrr: Add support for Bigjoiner tests/i915/kms_big_fb: Add support for Bigjoiner tests/i915/kms_big_joiner: Negative tests for Bigjoiner tests/i915/kms_busy: Add support for Bigjoiner tests/i915/kms_ccs: Add support for Bigjoiner tests/i915/kms_cdclk: Add support for Bigjoiner tests/i915/kms_draw_crc: Add support for Bigjoiner tests/i915/kms_fence_pin_leak: Add support for Bigjoiner tests/i915/kms_flip_scaled_crc: Add support for Bigjoiner tests/i915/kms_flip_tiling: Add support for Bigjoiner tests/i915/kms_frontbuffer_tracking: Add support for Bigjoiner tests/i915/kms_mmap_write_crc: Add support for Bigjoiner tests/i915/kms_psr2_sf: Add support for Bigjoiner tests/i915/kms_psr2_su: Add support for Bigjoiner tests/i915/kms_psr: Add support for Bigjoiner tests/i915/kms_psr_stress_test: Add support for Bigjoiner tests/i915/kms_pwrite_crc: Add support for Bigjoiner
lib/igt_kms.c | 54 ++++++- lib/igt_kms.h | 1 + tests/chamelium/kms_color_chamelium.c | 9 ++ tests/i915/kms_big_fb.c | 13 ++ tests/i915/kms_big_joiner.c | 118 +++++++++++--- tests/i915/kms_busy.c | 105 +++++++++---- tests/i915/kms_ccs.c | 18 ++- tests/i915/kms_cdclk.c | 93 ++++++----- tests/i915/kms_draw_crc.c | 11 +- tests/i915/kms_fence_pin_leak.c | 9 ++ tests/i915/kms_flip_scaled_crc.c | 13 +- tests/i915/kms_flip_tiling.c | 7 + tests/i915/kms_frontbuffer_tracking.c | 16 +- tests/i915/kms_mmap_write_crc.c | 6 + tests/i915/kms_psr.c | 4 + tests/i915/kms_psr2_sf.c | 7 + tests/i915/kms_psr2_su.c | 7 + tests/i915/kms_psr_stress_test.c | 8 +- tests/i915/kms_pwrite_crc.c | 7 + tests/kms_async_flips.c | 24 ++- tests/kms_atomic.c | 32 +++- tests/kms_atomic_interruptible.c | 40 +++++ tests/kms_atomic_transition.c | 50 +++++- tests/kms_color.c | 9 +- tests/kms_color_helper.c | 12 ++ tests/kms_color_helper.h | 1 + tests/kms_concurrent.c | 10 +- tests/kms_content_protection.c | 17 ++ tests/kms_cursor_crc.c | 47 +++++- tests/kms_cursor_edge_walk.c | 6 + tests/kms_cursor_legacy.c | 202 +++++++++++++++--------- tests/kms_display_modes.c | 104 +++++++----- tests/kms_dp_tiled_display.c | 1 + tests/kms_flip_event_leak.c | 10 ++ tests/kms_invalid_mode.c | 6 + tests/kms_lease.c | 6 + tests/kms_multipipe_modeset.c | 9 ++ tests/kms_pipe_crc_basic.c | 24 +++ tests/kms_plane.c | 30 ++-- tests/kms_plane_alpha_blend.c | 7 + tests/kms_plane_cursor.c | 8 +- tests/kms_plane_lowres.c | 3 + tests/kms_plane_multiple.c | 15 +- tests/kms_plane_scaling.c | 218 +++++++++++++++++--------- tests/kms_prime.c | 11 +- tests/kms_properties.c | 18 +++ tests/kms_rmfb.c | 10 +- tests/kms_rotation_crc.c | 25 ++- tests/kms_scaling_modes.c | 8 +- tests/kms_sequence.c | 6 + tests/kms_universal_plane.c | 94 +++++++++-- tests/kms_vblank.c | 54 ++++++- tests/kms_vrr.c | 6 + 53 files changed, 1253 insertions(+), 376 deletions(-)
--
2.35.1
PATCH v3 1/52 lib/igt_kms: Add a helper for valid pipe/output constraint
Add an IGT helper to check the given pipe/output combo is valid to decide whether to run/skip the subtest.
Example:
* Pipe-D can't support mode > 5K
* To use 8K mode on a pipe then consecutive pipe must be available & free.
* MSO is supported only on PIPE_A/PIPE_B.
This helper is supposed to be a superset of all constraints of pipe/output combo. But as of now, this helper supports only Bigjoiner.
V2:
- Rename the helper
- Add is_i915 constraint
- Add pre-condition check (igt_output_set_pipe called)
- Update documentaion
- Minor cleanup in Bigjoiner helper
--- lib/igt_kms.c | 49 ++++++++++++++++++++++++++++++++++++++++++++++--- lib/igt_kms.h | 1 + 2 files changed, 47 insertions(+), 3 deletions(-)
lib/igt_kms.c +46 -3
@@ -5743,6 +5743,7 @@ bool igt_check_bigjoiner_support(igt_display_t *display) {uint8_t i, total_pipes =0 , pipes_in_use =0 ;enum pipe p; +igt_output_t *output;struct {enum pipe idx;drmModeModeInfo *mode;
@@ -5756,9 +5757,7 @@ bool igt_check_bigjoiner_support(igt_display_t *display)* Get list of pipes in use those were set by igt_output_set_pipe() * just before calling this function. */ -for (i =0 ; i < display->n_outputs; i++) { -igt_output_t *output = &display->outputs[i]; - +for_each_connected_output (display, output) {if (output->pending_pipe ==PIPE_NONE )continue ;
@@ -5824,3 +5823,47 @@ bool igt_parse_mode_string(const char *mode_string, drmModeModeInfo *mode)return true; } + +/* +* i915_pipe_output_combo_valid: +* @display: a pointer to an #igt_display_t structure +* +* Every individual test must use igt_output_set_pipe() before calling this +* helper, so that this function will get all active pipes from connected +* outputs (i.e. pending_pipe != PIPE_NONE) and check the selected combo is +* valid or not. +* +* This helper is supposed to be a superset of all constraints of pipe/output +* combo. +* +* Example: +* * Pipe-D can't support mode > 5K +* * To use 8K mode on a pipe then consecutive pipe must be free. +* * MSO is supported only on PIPE_A/PIPE_B. +* +* Returns: true if a valid pipe/output mode combo found, else false +*/ +bool i915_pipe_output_combo_valid (igt_display_t *display) +{ +int combo =0 ; +igt_output_t *output; + +if (!is_i915_device (display->drm_fd)) +return true; + +for_each_connected_output (display, output) { +if (output->pending_pipe ==PIPE_NONE ) +continue ; + + combo++; + } + +igt_assert_f (combo,"At least one pipe/output combo needed.\n" ); + +/* +* Check the given pipe/output combo is valid for Bigjoiner. +* +* TODO: Update this helper to support other features like MSO. +*/ +return igt_check_bigjoiner_support (display); +}
lib/igt_kms.h +1 -0
@@ -975,5 +975,6 @@ bool igt_max_bpc_constraint(igt_display_t *display, enum pipe pipe, igt_output_t *output, int bpc);bool igt_check_bigjoiner_support (igt_display_t *display);bool igt_parse_mode_string (const char *mode_string,drmModeModeInfo *mode); +bool i915_pipe_output_combo_valid (igt_display_t *display);#endif /* __IGT_KMS_H__ */
--
2.35.1
Re: [igt-dev] [i-g-t V3 01/52] lib/igt_kms: Add a helper for valid pipe/output constraint
Quoted 18 lines · Bhanuprakash Modem
Add an IGT helper to check the given pipe/output combo is valid to decide whether to run/skip the subtest.
Example:
* Pipe-D can't support mode > 5K
* To use 8K mode on a pipe then consecutive pipe must be available & free.
* MSO is supported only on PIPE_A/PIPE_B.This helper is supposed to be a superset of all constraints of pipe/output combo. But as of now, this helper supports only Bigjoiner.
V2:
- Rename the helper
- Addis_i915constraint
- Add pre-condition check (igt_output_set_pipecalled)
- Update documentaion
- Minor cleanup in Bigjoiner helper
Quoted 2 lines
Cc Petri Latvala <[email protected]>Signed-off-by Bhanuprakash Modem <[email protected]>
Quoted 90 lines
--- lib/igt_kms.c | 49 ++++++++++++++++++++++++++++++++++++++++++++++--- lib/igt_kms.h | 1 + 2 files changed, 47 insertions(+), 3 deletions(-)lib/igt_kms.c +46
-3@@ -5743,6 +5743,7 @@ bool igt_check_bigjoiner_support(igt_display_t *display) {uint8_t i, total_pipes =0 , pipes_in_use =0 ;enum pipe p; +igt_output_t *output;struct {enum pipe idx;drmModeModeInfo *mode;@@ -5756,9 +5757,7 @@ bool igt_check_bigjoiner_support(igt_display_t *display)* Get list of pipes in use those were set by igt_output_set_pipe() * just before calling this function. */ -for (i =0 ; i < display->n_outputs; i++) { -igt_output_t *output = &display->outputs[i]; - +for_each_connected_output (display, output) {if (output->pending_pipe ==PIPE_NONE )continue ;@@ -5824,3 +5823,47 @@ bool igt_parse_mode_string(const char *mode_string, drmModeModeInfo *mode)return true; } + +/* +* i915_pipe_output_combo_valid: +* @display: a pointer to an #igt_display_t structure +* +* Every individual test must use igt_output_set_pipe() before calling this +* helper, so that this function will get all active pipes from connected +* outputs (i.e. pending_pipe != PIPE_NONE) and check the selected combo is +* valid or not. +* +* This helper is supposed to be a superset of all constraints of pipe/output +* combo. +* +* Example: +* * Pipe-D can't support mode > 5K +* * To use 8K mode on a pipe then consecutive pipe must be free. +* * MSO is supported only on PIPE_A/PIPE_B. +* +* Returns: true if a valid pipe/output mode combo found, else false +*/ +bool i915_pipe_output_combo_valid (igt_display_t *display) +{ +int combo =0 ; +igt_output_t *output; + +if (!is_i915_device (display->drm_fd)) +return true; + +for_each_connected_output (display, output) { +if (output->pending_pipe ==PIPE_NONE ) +continue ; + + combo++; + } + +igt_assert_f (combo,"At least one pipe/output combo needed.\n" ); + +/* +* Check the given pipe/output combo is valid for Bigjoiner. +* +* TODO: Update this helper to support other features like MSO. +*/ +return igt_check_bigjoiner_support (display); +}lib/igt_kms.h +1
-1@@ -975,5 +975,6 @@ bool igt_max_bpc_constraint(igt_display_t *display, enum pipe pipe, igt_output_t *output, int bpc);bool igt_check_bigjoiner_support (igt_display_t *display);bool igt_parse_mode_string (const char *mode_string,drmModeModeInfo *mode); +bool i915_pipe_output_combo_valid (igt_display_t *display);#endif /* __IGT_KMS_H__ */ --2.35.1
PATCH v3 2/52 lib/igt_kms: Bigjoiner check in max_bpc constraint
In reply to Bhanuprakash ModemThere is a possibility of commit failure if the selected pipe/output won't support Bigjoiner or 8K. So we need to handle this case.
--- lib/igt_kms.c | 5 +++++ 1 file changed, 5 insertions(+)
lib/igt_kms.c +5 -0
@@ -5713,6 +5713,11 @@ bool igt_max_bpc_constraint(igt_display_t *display, enum pipe pipe, for_each_connector_mode(output) { igt_output_override_mode(output, &connector->modes[j__]); + + if (is_i915_device(display->drm_fd) && + !igt_check_bigjoiner_support(display)) + continue; + igt_display_commit2(display, display->is_atomic ? COMMIT_ATOMIC : COMMIT_LEGACY); if (!igt_check_output_bpc_equal(display->drm_fd, pipe,
Signature · 1 line
2.35.1
PATCH v3 3/52 tests/kms_async_flips: Add support for Bigjoiner
In reply to Bhanuprakash ModemThis patch will add a check to Skip the subtest if a selected pipe/output combo won't support Bigjoiner or 8K mode.
Example:
* Pipe-D wont support a mode > 5K
* To use 8K mode on a pipe then consecutive pipe must be available & free.
V2: - Use updated helper name
--- tests/kms_async_flips.c | 24 +++++++++++------------- 1 file changed, 11 insertions(+), 13 deletions(-)
tests/kms_async_flips.c +11 -13
@@ -330,15 +330,6 @@ static void test_cursor(data_t *data)struct igt_fb cursor_fb;struct drm_mode_cursor cur; -/* -* Intel's PSR2 selective fetch adds other planes to state when -* necessary, causing the async flip to fail because async flip is not -* supported in cursor plane. -*/ -igt_skip_on_f (i915_psr2_selective_fetch_check (data->drm_fd), -"PSR2 sel fetch causes cursor to be added to primary plane " \ -"pages flips and async flip is not supported in cursor\n" ); -do_or_die (drmGetCap (data->drm_fd,DRM_CAP_CURSOR_WIDTH , &width));do_or_die (drmGetCap (data->drm_fd,DRM_CAP_CURSOR_WIDTH , &height));
@@ -380,12 +371,12 @@ static void test_invalid(data_t *data)struct igt_fb fb;drmModeModeInfo *mode; +test_init (data); + mode =igt_output_get_mode (data->output); width = mode->hdisplay; height = mode->vdisplay; -test_init (data); -igt_create_fb (data->drm_fd, width, height,DRM_FORMAT_XRGB8888 ,I915_FORMAT_MOD_Y_TILED , &fb);
@@ -542,9 +533,16 @@ static void run_test(data_t *data, void (*test)(data_t *)) {igt_output_t *output;enum pipe pipe; +igt_display_t *display = &data->display; + +for_each_pipe (display, pipe) { +for_each_valid_output_on_pipe (display, pipe, output) { +igt_display_reset (display); + +igt_output_set_pipe (output, pipe); +if (!i915_pipe_output_combo_valid (display)) +continue ; -for_each_pipe (&data->display, pipe) { -for_each_valid_output_on_pipe (&data->display, pipe, output) { igt_dynamic_f("pipe-%s-%s", kmstest_pipe_name(pipe), output->name) { data->output = output; data->pipe = pipe;
Signature · 1 line
2.35.1
PATCH v3 4/52 tests/kms_atomic: Add support for Bigjoiner
In reply to Bhanuprakash ModemThis patch will add a check to Skip the subtest if a selected pipe/output combo won't support Bigjoiner or 8K mode.
Example:
* Pipe-D wont support a mode > 5K
* To use 8K mode on a pipe then consecutive pipe must be available & free.
V2: - Use updated helper name
--- tests/kms_atomic.c | 32 ++++++++++++++++++++++++++++---- 1 file changed, 28 insertions(+), 4 deletions(-)
tests/kms_atomic.c +28 -4
@@ -1265,6 +1265,10 @@ static void atomic_plane_damage(igt_pipe_t *pipe, igt_plane_t *plane, struct igtstatic void atomic_setup (igt_display_t *display,enum pipe pipe,igt_output_t *output,igt_plane_t *primary,struct igt_fb *fb) { +igt_info ("Using (pipe %s + %s) to run the subtest.\n" , +kmstest_pipe_name (pipe),igt_output_name (output)); + +igt_display_reset (display);igt_output_set_pipe (output, pipe);igt_plane_set_fb (primary, fb);
@@ -1293,6 +1297,7 @@ igt_mainigt_plane_t *primary =NULL ;drmModeModeInfo *mode;struct igt_fb fb; +bool valid_config = false; igt_fixture { display.drm_fd =drm_open_driver_master (DRIVER_ANY );
@@ -1303,8 +1308,16 @@ igt_mainigt_require (display.is_atomic);igt_display_require_output (&display); -for_each_pipe_with_valid_output (&display, pipe, output) -break ; +for_each_pipe_with_valid_output (&display, pipe, output) { +igt_display_reset (&display); + +igt_output_set_pipe (output, pipe); +if (i915_pipe_output_combo_valid (&display)) { + valid_config = true; +break ; + } + } +igt_require (valid_config); pipe_obj = &display.pipes[pipe]; primary =igt_pipe_get_plane_type (pipe_obj,DRM_PLANE_TYPE_PRIMARY );
@@ -1342,9 +1355,13 @@ igt_main igt_subtest("plane-primary-overlay-mutable-zpos") {uint32_t format_primary =DRM_FORMAT_ARGB8888 ;uint32_t format_overlay =DRM_FORMAT_ARGB1555 ; +igt_plane_t *overlay; -igt_plane_t *overlay = -igt_pipe_get_plane_type (pipe_obj,DRM_PLANE_TYPE_OVERLAY ); +igt_info ("Using (pipe %s + %s) to run the subtest.\n" , +kmstest_pipe_name (pipe),igt_output_name (output)); + +igt_display_reset (&display); + overlay =igt_pipe_get_plane_type (pipe_obj,DRM_PLANE_TYPE_OVERLAY );igt_require (overlay);igt_require (igt_plane_has_prop (primary,IGT_PLANE_ZPOS ));
@@ -1361,6 +1378,10 @@ igt_mainigt_describe ("Verify the reported zpos property of planes by making sure " \"only higher zpos planes cover the lower zpos ones." ); igt_subtest("plane-immutable-zpos") { +igt_info ("Using (pipe %s + %s) to run the subtest.\n" , +kmstest_pipe_name (pipe),igt_output_name (output)); + +igt_display_reset (&display);igt_output_set_pipe (output, pipe);plane_immutable_zpos (&display, pipe_obj, output); }
@@ -1370,6 +1391,9 @@ igt_main igt_subtest("test-only") {atomic_clear (&display, pipe, primary, output); +igt_info ("Using (pipe %s + %s) to run the subtest.\n" , +kmstest_pipe_name (pipe),igt_output_name (output)); +test_only (pipe_obj, primary, output); }
Signature · 1 line
2.35.1
PATCH v3 5/52 tests/kms_atomic_interruptible: Add support for Bigjoiner
In reply to Bhanuprakash ModemThis patch will add a check to Skip the subtest if a selected pipe/output combo won't support Bigjoiner or 8K mode.
Example:
* Pipe-D wont support a mode > 5K
* To use 8K mode on a pipe then consecutive pipe must be available & free.
V2: - Use updated helper name
--- tests/kms_atomic_interruptible.c | 40 ++++++++++++++++++++++++++++++++ 1 file changed, 40 insertions(+)
tests/kms_atomic_interruptible.c +40 -0
@@ -82,11 +82,15 @@ static void run_plane_test(igt_display_t *display, enum pipe pipe, igt_output_tigt_plane_t *primary, *plane;int block; +igt_info ("Using (pipe %s + %s) to run the subtest.\n" , +kmstest_pipe_name (pipe),igt_output_name (output)); +/* * Make sure we start with everything disabled to force a real modeset. * igt_display_require only sets sw state, and assumes the first test * doesn't care about hw state. */ +igt_display_reset (display);igt_display_commit2 (display,COMMIT_ATOMIC );igt_output_set_pipe (output, pipe);
@@ -265,6 +269,21 @@ static void run_plane_test(igt_display_t *display, enum pipe pipe, igt_output_tigt_remove_fb (display->drm_fd, &fb); } +static bool pipe_output_combo_valid (igt_display_t *display, +enum pipe pipe,igt_output_t *output) +{ +bool ret = true; + +igt_display_reset (display); + +igt_output_set_pipe (output, pipe); +if (!i915_pipe_output_combo_valid (display)) + ret = false; +igt_output_set_pipe (output,PIPE_NONE ); + +return ret; +} + igt_main {igt_display_t display;
@@ -286,6 +305,9 @@ igt_mainigt_describe ("Tests the interrupt properties of legacy modeset" ); igt_subtest_with_dynamic("legacy-setmode") {for_each_pipe_with_valid_output (&display, pipe, output) { +if (!pipe_output_combo_valid (&display, pipe, output)) +continue ; + igt_dynamic_f("%s-pipe-%s", igt_output_name(output), kmstest_pipe_name(pipe))run_plane_test (&display, pipe, output, test_legacy_modeset,DRM_PLANE_TYPE_PRIMARY );break ;
@@ -295,6 +317,9 @@ igt_mainigt_describe ("Tests the interrupt properties of atomic modeset" ); igt_subtest_with_dynamic("atomic-setmode") {for_each_pipe_with_valid_output (&display, pipe, output) { +if (!pipe_output_combo_valid (&display, pipe, output)) +continue ; + igt_dynamic_f("%s-pipe-%s", igt_output_name(output), kmstest_pipe_name(pipe))run_plane_test (&display, pipe, output, test_atomic_modeset,DRM_PLANE_TYPE_PRIMARY );break ;
@@ -304,6 +329,9 @@ igt_mainigt_describe ("Tests the interrupt properties for DPMS" ); igt_subtest_with_dynamic("legacy-dpms") {for_each_pipe_with_valid_output (&display, pipe, output) { +if (!pipe_output_combo_valid (&display, pipe, output)) +continue ; + igt_dynamic_f("%s-pipe-%s", igt_output_name(output), kmstest_pipe_name(pipe))run_plane_test (&display, pipe, output, test_legacy_dpms,DRM_PLANE_TYPE_PRIMARY );break ;
@@ -313,6 +341,9 @@ igt_mainigt_describe ("Tests the interrupt properties for pageflip" ); igt_subtest_with_dynamic("legacy-pageflip") {for_each_pipe_with_valid_output (&display, pipe, output) { +if (!pipe_output_combo_valid (&display, pipe, output)) +continue ; + igt_dynamic_f("%s-pipe-%s", igt_output_name(output), kmstest_pipe_name(pipe))run_plane_test (&display, pipe, output, test_pageflip,DRM_PLANE_TYPE_PRIMARY );break ;
@@ -322,6 +353,9 @@ igt_mainigt_describe ("Tests the interrupt properties for cursor" ); igt_subtest_with_dynamic("legacy-cursor") {for_each_pipe_with_valid_output (&display, pipe, output) { +if (!pipe_output_combo_valid (&display, pipe, output)) +continue ; + igt_dynamic_f("%s-pipe-%s", igt_output_name(output), kmstest_pipe_name(pipe))run_plane_test (&display, pipe, output, test_setcursor,DRM_PLANE_TYPE_CURSOR );break ;
@@ -331,6 +365,9 @@ igt_mainigt_describe ("Tests the interrupt properties for primary plane" ); igt_subtest_with_dynamic("universal-setplane-primary") {for_each_pipe_with_valid_output (&display, pipe, output) { +if (!pipe_output_combo_valid (&display, pipe, output)) +continue ; + igt_dynamic_f("%s-pipe-%s", igt_output_name(output), kmstest_pipe_name(pipe))run_plane_test (&display, pipe, output, test_setplane,DRM_PLANE_TYPE_PRIMARY );break ;
@@ -340,6 +377,9 @@ igt_mainigt_describe ("Tests the interrupt properties for cursor plane" ); igt_subtest_with_dynamic("universal-setplane-cursor") {for_each_pipe_with_valid_output (&display, pipe, output) { +if (!pipe_output_combo_valid (&display, pipe, output)) +continue ; + igt_dynamic_f("%s-pipe-%s", igt_output_name(output), kmstest_pipe_name(pipe))run_plane_test (&display, pipe, output, test_setplane,DRM_PLANE_TYPE_CURSOR );break ;
Signature · 1 line
2.35.1
PATCH v3 6/52 tests/kms_atomic_transition: Add support for Bigjoiner
In reply to Bhanuprakash ModemThis patch will add a check to Skip the subtest if a selected pipe/output combo won't support Bigjoiner or 8K mode.
Example:
* Pipe-D wont support a mode > 5K
* To use 8K mode on a pipe then consecutive pipe must be available & free.
V2: - Use updated helper name
--- tests/kms_atomic_transition.c | 50 ++++++++++++++++++++++++++++++++--- 1 file changed, 46 insertions(+), 4 deletions(-)
tests/kms_atomic_transition.c +46 -4
@@ -68,6 +68,10 @@ run_primary_test(data_t *data, enum pipe pipe, igt_output_t *output)unsigned flags =DRM_MODE_ATOMIC_TEST_ONLY |DRM_MODE_ATOMIC_ALLOW_MODESET ;igt_display_reset (&data->display); + +igt_info ("Using (pipe %s + %s) to run the subtest.\n" , +kmstest_pipe_name (pipe),igt_output_name (output)); +igt_output_set_pipe (output, pipe); primary =igt_output_get_plane_type (output,DRM_PLANE_TYPE_PRIMARY );
@@ -487,6 +491,9 @@ run_transition_test(data_t *data, enum pipe pipe, igt_output_t *output,unsigned flags =0 ;int ret; +igt_info ("Using (pipe %s + %s) to run the subtest.\n" , +kmstest_pipe_name (pipe),igt_output_name (output)); +if (fencing)prepare_fencing (data, pipe);else
@@ -753,8 +760,13 @@ static unsigned set_combinations(data_t *data, unsigned mask, struct igt_fb *fb)if (output->pending_pipe !=PIPE_NONE )continue ; - mode =igt_output_get_mode (output); -break ; +igt_output_set_pipe (output, pipe); +if (i915_pipe_output_combo_valid (&data->display)) { + mode =igt_output_get_mode (output); +break ; + }else { +igt_output_set_pipe (output,PIPE_NONE ); + } }if (!mode)
@@ -839,8 +851,17 @@ retry:continue ;igt_output_set_pipe (output, i); - mode =igt_output_get_mode (output); -break ; +if (i915_pipe_output_combo_valid (&data->display)) { + mode =igt_output_get_mode (output); + +igt_info ("(pipe %s + %s), mode:" , +kmstest_pipe_name (i),igt_output_name (output)); +kmstest_dump_mode (mode); + +break ; + }else { +igt_output_set_pipe (output,PIPE_NONE ); + } }if (mode) {
@@ -979,6 +1000,21 @@ static void run_modeset_transition(data_t *data, int requested_outputs, bool nonigt_remove_fb (data->drm_fd, &data->fbs[1 ]); } +static bool pipe_output_combo_valid (igt_display_t *display, +enum pipe pipe,igt_output_t *output) +{ +bool ret = true; + +igt_display_reset (display); + +igt_output_set_pipe (output, pipe); +if (!i915_pipe_output_combo_valid (display)) + ret = false; +igt_output_set_pipe (output,PIPE_NONE ); + +return ret; +} +static int opt_handler (int opt,int opt_index,void *_data) {data_t *data = _data;
@@ -1078,6 +1114,9 @@ igt_main_args("", long_opts, help_str, opt_handler, &data)if (pipe_count ==2 * count && !data.extended)break ; +if (!pipe_output_combo_valid (&data.display, pipe, output)) +continue ; + pipe_count++; igt_dynamic_f("pipe-%s-%s", kmstest_pipe_name(pipe), igt_output_name(output))run_primary_test (&data, pipe, output);
@@ -1104,6 +1143,9 @@ igt_main_args("", long_opts, help_str, opt_handler, &data)if (pipe_count ==2 * count && !data.extended)break ; +if (!pipe_output_combo_valid (&data.display, pipe, output)) +continue ; + pipe_count++; igt_dynamic_f("pipe-%s-%s", kmstest_pipe_name(pipe),
Signature · 1 line
2.35.1
PATCH v3 7/52 tests/kms_color_helper: Helper to check Bigjoiner constraint
In reply to Bhanuprakash ModemAdd a helper to Skip the subtest if a selected pipe/output combo won't support Bigjoiner or 8K mode.
Example:
* Pipe-D wont support a mode > 5K
* To use 8K mode on a pipe then consecutive pipe must be available & free.
V2: - Use updated helper name
--- tests/kms_color_helper.c | 12 ++++++++++++ tests/kms_color_helper.h | 1 + 2 files changed, 13 insertions(+)
tests/kms_color_helper.c +12 -0
@@ -24,6 +24,18 @@#include "kms_color_helper.h" +bool pipe_output_combo_valid (data_t *data,enum pipe pipe) +{ +bool ret = true; + +igt_output_set_pipe (data->output, pipe); +if (!i915_pipe_output_combo_valid (&data->display)) + ret = false; +igt_output_set_pipe (data->output,PIPE_NONE ); + +return ret; +} +bool panel_supports_deep_color (int drm_fd,char *output_name) {
tests/kms_color_helper.h +1 -0
@@ -69,6 +69,7 @@ typedef struct {color_t coeffs[]; } gamma_lut_t; +bool pipe_output_combo_valid (data_t *data,enum pipe pipe);bool panel_supports_deep_color (int fd,char *output_name);uint64_t get_max_bpc (igt_output_t *output); void paint_gradient_rectangles(data_t *data,
Signature · 1 line
2.35.1
PATCH v3 8/52 tests/kms_color: Add support for Bigjoiner
In reply to Bhanuprakash ModemThis patch will add a check to Skip the subtest if a selected pipe/output combo won't support Bigjoiner or 8K mode.
Example:
* Pipe-D wont support a mode > 5K
* To use 8K mode on a pipe then consecutive pipe must be available & free.
V2: - Use updated helper name
--- tests/kms_color.c | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-)
tests/kms_color.c +8 -1
@@ -722,9 +722,13 @@ run_gamma_degamma_tests_for_pipe(data_t *data, enum pipe p, data->drm_format =DRM_FORMAT_XRGB8888 ; data->mode =igt_output_get_mode (data->output); +if (!pipe_output_combo_valid (data, p)) + goto out; + igt_dynamic_f("pipe-%s-%s", kmstest_pipe_name(p), data->output->name)igt_assert (test_t (data, data->primary)); +out:test_cleanup (data); }
@@ -752,6 +756,9 @@ run_ctm_tests_for_pipe(data_t *data, enum pipe p, data->drm_format =DRM_FORMAT_XRGB8888 ; data->mode =igt_output_get_mode (data->output); +if (!pipe_output_combo_valid (data, p)) + goto out; + igt_dynamic_f("pipe-%s-%s", kmstest_pipe_name(p), data->output->name) {bool success = false;int i;
@@ -780,6 +787,7 @@ run_ctm_tests_for_pipe(data_t *data, enum pipe p,igt_assert (success); } +out:test_cleanup (data); }
@@ -820,7 +828,6 @@ run_deep_color_tests_for_pipe(data_t *data, enum pipe p)igt_display_reset (&data->display);igt_output_set_prop_value (output,IGT_CONNECTOR_MAX_BPC ,10 );igt_output_set_pipe (output, p); -igt_display_commit_atomic (&data->display,DRM_MODE_ATOMIC_ALLOW_MODESET ,NULL );if (is_i915_device (data->drm_fd) && !igt_max_bpc_constraint (&data->display, p, output,10 ))
Signature · 1 line
2.35.1
PATCH v3 9/52 tests/chamelium/kms_color_chamelium: Add support for Bigjoiner
In reply to Bhanuprakash ModemThis patch will add a check to Skip the subtest if a selected pipe/output combo won't support Bigjoiner or 8K mode.
Example:
* Pipe-D wont support a mode > 5K
* To use 8K mode on a pipe then consecutive pipe must be available & free.
V2: - Use updated helper name
--- tests/chamelium/kms_color_chamelium.c | 9 +++++++++ 1 file changed, 9 insertions(+)
tests/chamelium/kms_color_chamelium.c +9 -0
@@ -458,6 +458,9 @@ run_gamma_degamma_tests_for_pipe(data_t *data, enum pipe p, data->drm_format =DRM_FORMAT_XRGB8888 ; data->mode =igt_output_get_mode (data->output); +if (!pipe_output_combo_valid (data, p)) +return ; + igt_dynamic_f("pipe-%s-%s", kmstest_pipe_name(p), data->output->name)igt_assert (test_t (data, data->primary, data->ports[port_idx])); }
@@ -493,6 +496,9 @@ run_ctm_tests_for_pipe(data_t *data, enum pipe p, data->drm_format =DRM_FORMAT_XRGB8888 ; data->mode =igt_output_get_mode (data->output); +if (!pipe_output_combo_valid (data, p)) +return ; + igt_dynamic_f("pipe-%s-%s", kmstest_pipe_name(p), data->output->name) {bool success = false;int i;
@@ -538,6 +544,9 @@ run_limited_range_ctm_test_for_pipe(data_t *data, enum pipe p, data->drm_format =DRM_FORMAT_XRGB8888 ; data->mode =igt_output_get_mode (data->output); +if (!pipe_output_combo_valid (data, p)) +return ; + igt_dynamic_f("pipe-%s-%s", kmstest_pipe_name(p), data->output->name)igt_assert (test_t (data, data->primary, data->ports[port_idx])); }
Signature · 1 line
2.35.1
PATCH v3 10/52 tests/kms_concurrent: Add support for Bigjoiner
In reply to Bhanuprakash ModemThis patch will add a check to Skip the subtest if a selected pipe/output combo won't support Bigjoiner or 8K mode.
Example:
* Pipe-D wont support a mode > 5K
* To use 8K mode on a pipe then consecutive pipe must be available & free.
V2: - Use updated helper name
--- tests/kms_concurrent.c | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-)
tests/kms_concurrent.c +9 -1
@@ -330,9 +330,17 @@ run_tests_for_pipe(data_t *data, enum pipe pipe)igt_describe ("Test atomic mode setting concurrently with multiple planes and screen " "resolution." ); igt_subtest_with_dynamic_f("pipe-%s", kmstest_pipe_name(pipe)) { -for_each_valid_output_on_pipe (&data->display, pipe, output) +for_each_valid_output_on_pipe (&data->display, pipe, output) { +igt_display_reset (&data->display); + +igt_output_set_pipe (output, pipe); +if (!i915_pipe_output_combo_valid (&data->display)) +continue ; + +igt_output_set_pipe (output,PIPE_NONE ); igt_dynamic_f("%s", igt_output_name(output))run_test (data, pipe, output); + } } }
Signature · 1 line
2.35.1
PATCH v3 11/52 tests/kms_content_protection: Add support for Bigjoiner
In reply to Bhanuprakash ModemThis patch will add a check to Skip the subtest if a selected pipe/output combo won't support Bigjoiner or 8K mode.
Example:
* Pipe-D wont support a mode > 5K
* To use 8K mode on a pipe then consecutive pipe must be available & free.
V2: - Use updated helper name
--- tests/kms_content_protection.c | 17 +++++++++++++++++ 1 file changed, 17 insertions(+)
tests/kms_content_protection.c +17 -0
@@ -338,6 +338,15 @@ static void test_content_protection_on_output(igt_output_t *output,if (!igt_pipe_is_free (display, pipe))continue ; +igt_output_set_pipe (output, pipe); +if (!i915_pipe_output_combo_valid (display)) { +igt_output_set_pipe (output,PIPE_NONE ); +continue ; + } + +igt_info ("Using (pipe %s + %s) to run the subtest.\n" , +kmstest_pipe_name (pipe),igt_output_name (output)); +modeset_with_fb (pipe, output, s);test_cp_enable_with_retry (output, s,3 , content_type, false, false);
@@ -610,6 +619,14 @@ test_content_protection_mst(int content_type)igt_assert_f (igt_pipe_connector_valid (pipe, output),"Output-pipe combination invalid\n" );igt_output_set_pipe (output, pipe); +if (!i915_pipe_output_combo_valid (display)){ +igt_output_set_pipe (output,PIPE_NONE ); +continue ; + } + +igt_info ("Using (pipe %s + %s) to run the subtest.\n" , +kmstest_pipe_name (pipe),igt_output_name (output)); +prepare_modeset_on_mst_output (output); mst_output[dp_mst_outputs++] = output;
Signature · 1 line
2.35.1
PATCH v3 12/52 tests/kms_cursor_crc: Add support for Bigjoiner
In reply to Bhanuprakash ModemThis patch will add a check to Skip the subtest if a selected pipe/output combo won't support Bigjoiner or 8K mode.
Example:
* Pipe-D wont support a mode > 5K
* To use 8K mode on a pipe then consecutive pipe must be available & free.
V2: - Use updated helper name
--- tests/kms_cursor_crc.c | 47 +++++++++++++++++++++++++++++++++++------- 1 file changed, 40 insertions(+), 7 deletions(-)
tests/kms_cursor_crc.c +40 -7
@@ -687,6 +687,21 @@ static void test_rapid_movement(data_t *data)igt_assert_lt (usec,0.9 *400 *1000000 / data->refresh); } +static bool pipe_output_combo_valid (data_t *data,enum pipe pipe) +{ +bool ret = true; +igt_display_t *display = &data->display; + +igt_display_reset (display); + +igt_output_set_pipe (data->output, pipe); +if (!i915_pipe_output_combo_valid (display)) + ret = false; +igt_output_set_pipe (data->output,PIPE_NONE ); + +return ret; +} +static void run_size_tests (data_t *data,void (*testfunc)(data_t *),int w,int h) {
@@ -708,15 +723,18 @@ static void run_size_tests(data_t *data, void (*testfunc)(data_t *), }create_cursor_fb (data, w, h); -if (require_cursor_size (data, w, h)) { -igt_info ("Cursor size %dx%d not supported by driver\n" , w, h); - -igt_remove_fb (data->drm_fd, &data->fb); -return ; - } -for_each_pipe (&data->display, pipe) { data->pipe = pipe; + +if (!pipe_output_combo_valid (data, pipe)) +continue ; + +if (require_cursor_size (data, w, h)) { +igt_info ("Cursor size %dx%d not supported by driver\n" , w, h); + +continue ; + } +igt_dynamic_f ("pipe-%s-%s" , kmstest_pipe_name(pipe), igt_output_name(data->output))run_test (data, testfunc, w, h);
@@ -761,6 +779,9 @@ static void run_tests_on_pipe(data_t *data)for_each_pipe (&data->display, pipe) { data->pipe = pipe; +if (!pipe_output_combo_valid (data, pipe)) +continue ; +igt_dynamic_f ("pipe-%s-%s" ,kmstest_pipe_name (pipe), data->output->name)
@@ -775,6 +796,9 @@ static void run_tests_on_pipe(data_t *data)for_each_pipe (&data->display, pipe) { data->pipe = pipe; +if (!pipe_output_combo_valid (data, pipe)) +continue ; +igt_dynamic_f ("pipe-%s-%s" ,kmstest_pipe_name (pipe), data->output->name)
@@ -789,6 +813,9 @@ static void run_tests_on_pipe(data_t *data)for_each_pipe (&data->display, pipe) { data->pipe = pipe; +if (!pipe_output_combo_valid (data, pipe)) +continue ; +igt_dynamic_f ("pipe-%s-%s" ,kmstest_pipe_name (pipe), data->output->name)
@@ -807,6 +834,9 @@ static void run_tests_on_pipe(data_t *data) data->pipe = pipe; data->flags =TEST_DPMS ; +if (!pipe_output_combo_valid (data, pipe)) +continue ; +if (require_cursor_size (data, data->cursor_max_w, data->cursor_max_h)) {igt_debug ("Cursor size %dx%d not supported by driver\n" , data->cursor_max_w, data->cursor_max_h);
@@ -828,6 +858,9 @@ static void run_tests_on_pipe(data_t *data) data->pipe = pipe; data->flags =TEST_SUSPEND ; +if (!pipe_output_combo_valid (data, pipe)) +continue ; +if (require_cursor_size (data, data->cursor_max_w, data->cursor_max_h)) {igt_debug ("Cursor size %dx%d not supported by driver\n" , data->cursor_max_w, data->cursor_max_h);
Signature · 1 line
2.35.1
PATCH v3 13/52 tests/kms_cursor_edge_walk: Add support for Bigjoiner
In reply to Bhanuprakash ModemThis patch will add a check to Skip the subtest if a selected pipe/output combo won't support Bigjoiner or 8K mode.
Example:
* Pipe-D wont support a mode > 5K
* To use 8K mode on a pipe then consecutive pipe must be available & free.
V2: - Use updated helper name
--- tests/kms_cursor_edge_walk.c | 6 ++++++ 1 file changed, 6 insertions(+)
tests/kms_cursor_edge_walk.c +6 -0
@@ -351,6 +351,12 @@ igt_main_args("", long_opts, help_str, opt_handler, &data) data.curh = data.curw;igt_require (data.curw <= max_curw && data.curh <= max_curh); +igt_display_reset (&data.display); +igt_output_set_pipe (data.output, data.pipe); +if (!i915_pipe_output_combo_valid (&data.display)) +continue ; + +igt_output_set_pipe (data.output,PIPE_NONE ); igt_dynamic_f("pipe-%s-%s-%dx%d", kmstest_pipe_name(data.pipe), data.output->name,
Signature · 1 line
2.35.1
PATCH v3 14/52 tests/kms_cursor_legacy: Add support for Bigjoiner
In reply to Bhanuprakash ModemAs many 2x tests are currently running on Pipe-A & B only, those tests will always SKIP if there is any 8K supported panel in the config. Instead of Skipping the test, add some intelligence to the subtest to identify the valid pipe/output combo to execute the subtest.
V2: - Use updated helper name
--- tests/kms_cursor_legacy.c | 202 +++++++++++++++++++++++--------------- 1 file changed, 124 insertions(+), 78 deletions(-)
tests/kms_cursor_legacy.c +124 -78
@@ -177,31 +177,21 @@ static void stress(igt_display_t *display,munmap (results,PAGE_SIZE ); } -static igt_output_t *set_fb_on_crtc (igt_display_t *display,enum pipe pipe,struct igt_fb *fb_info) +static void set_fb_on_crtc (igt_display_t *display,enum pipe pipe, +igt_output_t *output,struct igt_fb *fb_info) { -igt_output_t *output; - -for_each_valid_output_on_pipe (display, pipe, output) { -drmModeModeInfoPtr mode; -igt_plane_t *primary; - -if (output->pending_pipe !=PIPE_NONE ) -continue ; - -igt_output_set_pipe (output, pipe); - mode =igt_output_get_mode (output); +drmModeModeInfoPtr mode; +igt_plane_t *primary; -igt_create_pattern_fb (display->drm_fd, - mode->hdisplay, mode->vdisplay, -DRM_FORMAT_XRGB8888 ,I915_TILING_NONE , fb_info); +igt_output_set_pipe (output, pipe); + mode =igt_output_get_mode (output); - primary =igt_output_get_plane_type (output,DRM_PLANE_TYPE_PRIMARY ); -igt_plane_set_fb (primary, fb_info); +igt_create_pattern_fb (display->drm_fd, + mode->hdisplay, mode->vdisplay, +DRM_FORMAT_XRGB8888 ,I915_TILING_NONE , fb_info); -return output; - } - -return NULL ; + primary =igt_output_get_plane_type (output,DRM_PLANE_TYPE_PRIMARY ); +igt_plane_set_fb (primary, fb_info); } static igt_plane_t
@@ -236,36 +226,44 @@ static void populate_cursor_args(igt_display_t *display, enum pipe pipe, arg[1 ] = *arg; } -static enum pipe find_connected_pipe (igt_display_t *display,bool second) +static enum pipe +find_connected_pipe (igt_display_t *display,bool second,igt_output_t **output) { -enum pipe pipe, first =PIPE_NONE ; -igt_output_t *output; -igt_output_t *first_output =NULL ; +enum pipe pipe; +bool first_output = false;bool found = false;if (!second) {igt_pipe_crc_free (pipe_crc); pipe_crc =NULL ; - -/* Clear display, events will be eaten by commit.. */ -igt_display_reset (display); } -for_each_pipe_with_valid_output (display, pipe, output) { -if (first == pipe || output == first_output) -continue ; +/* Clear display, events will be eaten by commit.. */ +igt_display_reset (display); -if (second) { - first = pipe; - first_output = output; - second = false; -continue ; - } +for_each_pipe (display, pipe) { +for_each_valid_output_on_pipe (display, pipe, *output) { +if ((*output)->pending_pipe !=PIPE_NONE ) +continue ; - found = true; -break ; +igt_output_set_pipe (*output, pipe); +if (i915_pipe_output_combo_valid (display)) { + found = true; + +if (second) { + first_output = true; + second = false; + found = false; + } +break ; + } +igt_output_set_pipe (*output,PIPE_NONE ); + } +if (found) +break ; } +igt_display_reset (display);if (first_output)igt_require_f (found,"No second valid output found\n" );else
@@ -429,10 +427,9 @@ static void flip(igt_display_t *display, results =mmap (NULL ,PAGE_SIZE ,PROT_WRITE ,MAP_SHARED |MAP_ANON ,-1 ,0 );igt_assert (results !=MAP_FAILED ); -igt_display_reset (display); - - flip_pipe =find_connected_pipe (display, !!flip_pipe); - cursor_pipe =find_connected_pipe (display, !!cursor_pipe); + flip_pipe =find_connected_pipe (display, !!flip_pipe, &output); + cursor_pipe =find_connected_pipe (display, !!cursor_pipe, &output2); +igt_skip_on (!output || !output2);igt_info ("Using pipe %s for page flip, pipe %s for cursor\n" ,kmstest_pipe_name (flip_pipe),kmstest_pipe_name (cursor_pipe));
@@ -446,15 +443,15 @@ static void flip(igt_display_t *display, DRM_PLANE_TYPE_OVERLAY)); } -igt_require ((output =set_fb_on_crtc (display, flip_pipe, &fb_info))); +set_fb_on_crtc (display, flip_pipe, output, &fb_info);if (flip_pipe != cursor_pipe) { -igt_require ((output2 =set_fb_on_crtc (display, cursor_pipe, &fb_info2))); +set_fb_on_crtc (display, cursor_pipe, output2, &fb_info2);if (try_commit (display)) {override_output_modes (display, output, output2); -igt_require ((output =set_fb_on_crtc (display, flip_pipe, &fb_info))); -igt_require ((output2 =set_fb_on_crtc (display, cursor_pipe, &fb_info2))); +set_fb_on_crtc (display, flip_pipe, output, &fb_info); +set_fb_on_crtc (display, cursor_pipe, output2, &fb_info2); } }
@@ -546,7 +543,7 @@ static void basic_flip_cursor(igt_display_t *display,struct drm_event_vblank vbl;struct igt_fb fb_info, cursor_fb, cursor_fb2, argb_fb;unsigned vblank_start; -enum pipe pipe =find_connected_pipe (display, false); +enum pipe pipe;uint64_t ahnd =0 ;igt_spin_t *spin;int i, miss1 =0 , miss2 =0 , delta;
@@ -562,7 +559,13 @@ static void basic_flip_cursor(igt_display_t *display,if (mode >= flip_test_atomic)igt_require (display->is_atomic); -igt_require ((output =set_fb_on_crtc (display, pipe, &fb_info))); + pipe =find_connected_pipe (display, false, &output); +igt_require (output); + +igt_info ("Using pipe %s & %s\n" , +kmstest_pipe_name (pipe),igt_output_name (output)); + +set_fb_on_crtc (display, pipe, output, &fb_info);igt_create_color_fb (display->drm_fd,64 ,64 ,DRM_FORMAT_ARGB8888 ,0 ,1. ,1. ,1. , &cursor_fb); cursor =set_cursor_on_pipe (display, pipe, &cursor_fb);
@@ -717,7 +720,7 @@ static void flip_vs_cursor(igt_display_t *display, enum flip_test mode, int nloostruct igt_fb fb_info, cursor_fb, cursor_fb2, argb_fb;unsigned vblank_start;int target, cpu; -enum pipe pipe =find_connected_pipe (display, false); +enum pipe pipe;volatile unsigned long *shared;cpu_set_t mask, oldmask;igt_output_t *output;
@@ -726,7 +729,13 @@ static void flip_vs_cursor(igt_display_t *display, enum flip_test mode, int nlooif (mode >= flip_test_atomic)igt_require (display->is_atomic); -igt_require ((output =set_fb_on_crtc (display, pipe, &fb_info))); + pipe =find_connected_pipe (display, false, &output); +igt_require (output); + +igt_info ("Using pipe %s & %s\n" , +kmstest_pipe_name (pipe),igt_output_name (output)); + +set_fb_on_crtc (display, pipe, output, &fb_info);igt_create_color_fb (display->drm_fd,64 ,64 ,DRM_FORMAT_ARGB8888 ,0 ,1. ,1. ,1. , &cursor_fb); cursor =set_cursor_on_pipe (display, pipe, &cursor_fb);
@@ -843,12 +852,18 @@ static void nonblocking_modeset_vs_cursor(igt_display_t *display, int loops) {struct igt_fb fb_info, cursor_fb;igt_output_t *output; -enum pipe pipe =find_connected_pipe (display, false); +enum pipe pipe;struct drm_mode_cursor arg[2 ];igt_plane_t *primary, *cursor =NULL ;igt_require (display->is_atomic); -igt_require ((output =set_fb_on_crtc (display, pipe, &fb_info))); + pipe =find_connected_pipe (display, false, &output); +igt_require (output); + +igt_info ("Using pipe %s & %s\n" , +kmstest_pipe_name (pipe),igt_output_name (output)); + +set_fb_on_crtc (display, pipe, output, &fb_info); primary =igt_output_get_plane_type (output,DRM_PLANE_TYPE_PRIMARY );igt_create_color_fb (display->drm_fd,64 ,64 ,DRM_FORMAT_ARGB8888 ,0 ,1. ,1. ,1. , &cursor_fb); cursor =set_cursor_on_pipe (display, pipe, &cursor_fb);
@@ -935,8 +950,7 @@ static void two_screens_flip_vs_cursor(igt_display_t *display, int nloops, bool {struct drm_mode_cursor arg1[2 ], arg2[2 ];struct igt_fb fb_info, fb2_info, cursor_fb; -enum pipe pipe =find_connected_pipe (display, false); -enum pipe pipe2 =find_connected_pipe (display, true); +enum pipe pipe, pipe2;igt_output_t *output, *output2;bool enabled = false;volatile unsigned long *shared;
@@ -952,22 +966,28 @@ static void two_screens_flip_vs_cursor(igt_display_t *display, int nloops, booligt_require (drmGetCap (display->drm_fd,DRM_CAP_CRTC_IN_VBLANK_EVENT , &val) ==0 ); } +if (atomic) +igt_require (display->is_atomic); + shared =mmap (NULL ,PAGE_SIZE ,PROT_WRITE ,MAP_SHARED |MAP_ANON ,-1 ,0 );igt_assert (shared !=MAP_FAILED ); -igt_fail_on (modeset && !atomic); + pipe =find_connected_pipe (display, false, &output); + pipe2 =find_connected_pipe (display, true, &output2); +igt_skip_on (!output || !output2); -if (atomic) -igt_require (display->is_atomic); +igt_info ("Using pipe %s & %s and pipe %s & %s\n" , +kmstest_pipe_name (pipe),igt_output_name (output), +kmstest_pipe_name (pipe2),igt_output_name (output2)); -igt_require ((output =set_fb_on_crtc (display, pipe, &fb_info))); -igt_require ((output2 =set_fb_on_crtc (display, pipe2, &fb2_info))); +set_fb_on_crtc (display, pipe, output, &fb_info); +set_fb_on_crtc (display, pipe2, output2, &fb2_info);if (try_commit (display)) {override_output_modes (display, output, output2); -igt_require ((output =set_fb_on_crtc (display, pipe, &fb_info))); -igt_require ((output2 =set_fb_on_crtc (display, pipe2, &fb2_info))); +set_fb_on_crtc (display, pipe, output, &fb_info); +set_fb_on_crtc (display, pipe2, output2, &fb2_info); }igt_create_color_fb (display->drm_fd,64 ,64 ,DRM_FORMAT_ARGB8888 ,0 ,1. ,1. ,1. , &cursor_fb);
@@ -1120,7 +1140,7 @@ static void cursor_vs_flip(igt_display_t *display, enum flip_test mode, int nloounsigned vblank_start, vblank_last;volatile unsigned long *shared;long target; -enum pipe pipe =find_connected_pipe (display, false); +enum pipe pipe;igt_output_t *output;uint32_t vrefresh;int fail_count;
@@ -1132,7 +1152,13 @@ static void cursor_vs_flip(igt_display_t *display, enum flip_test mode, int nloo shared =mmap (NULL ,PAGE_SIZE ,PROT_WRITE ,MAP_SHARED |MAP_ANON ,-1 ,0 );igt_assert (shared !=MAP_FAILED ); -igt_require ((output =set_fb_on_crtc (display, pipe, &fb_info))); + pipe =find_connected_pipe (display, false, &output); +igt_require (output); + +igt_info ("Using pipe %s & %s\n" , +kmstest_pipe_name (pipe),igt_output_name (output)); + +set_fb_on_crtc (display, pipe, output, &fb_info); vrefresh =igt_output_get_mode (output)->vrefresh;igt_create_color_fb (display->drm_fd,64 ,64 ,DRM_FORMAT_ARGB8888 ,0 ,1. ,1. ,1. , &cursor_fb);
@@ -1224,10 +1250,7 @@ static void two_screens_cursor_vs_flip(igt_display_t *display, int nloops, boolstruct igt_fb fb_info[2 ], cursor_fb;volatile unsigned long *shared;int target[2 ]; -enum pipe pipe[2 ] = { -find_connected_pipe (display, false), -find_connected_pipe (display, true) - }; +enum pipe pipe[2 ];igt_output_t *outputs[2 ];igt_plane_t *cursors[2 ];
@@ -1237,14 +1260,22 @@ static void two_screens_cursor_vs_flip(igt_display_t *display, int nloops, boolif (atomic)igt_require (display->is_atomic); -igt_require ((outputs[0 ] =set_fb_on_crtc (display, pipe[0 ], &fb_info[0 ]))); -igt_require ((outputs[1 ] =set_fb_on_crtc (display, pipe[1 ], &fb_info[1 ]))); + pipe[0 ] =find_connected_pipe (display, false, &outputs[0 ]); + pipe[1 ] =find_connected_pipe (display, true, &outputs[1 ]); +igt_skip_on (!outputs[0 ] || !outputs[1 ]); + +igt_info ("Using pipe %s & %s and pipe %s & %s\n" , +kmstest_pipe_name (pipe[0 ]),igt_output_name (outputs[0 ]), +kmstest_pipe_name (pipe[1 ]),igt_output_name (outputs[1 ])); + +set_fb_on_crtc (display, pipe[0 ], outputs[0 ], &fb_info[0 ]); +set_fb_on_crtc (display, pipe[1 ], outputs[1 ], &fb_info[1 ]);if (try_commit (display)) {override_output_modes (display, outputs[0 ], outputs[1 ]); -igt_require ((outputs[0 ] =set_fb_on_crtc (display, pipe[0 ], &fb_info[0 ]))); -igt_require ((outputs[1 ] =set_fb_on_crtc (display, pipe[1 ], &fb_info[1 ]))); +set_fb_on_crtc (display, pipe[0 ], outputs[0 ], &fb_info[0 ]); +set_fb_on_crtc (display, pipe[1 ], outputs[1 ], &fb_info[1 ]); }igt_create_color_fb (display->drm_fd,64 ,64 ,DRM_FORMAT_ARGB8888 ,0 ,1. ,1. ,1. , &cursor_fb);
@@ -1345,7 +1376,7 @@ static void flip_vs_cursor_crc(igt_display_t *display, bool atomic)struct drm_event_vblank vbl;struct igt_fb fb_info, cursor_fb;unsigned vblank_start; -enum pipe pipe =find_connected_pipe (display, false); +enum pipe pipe;igt_crc_t crcs[3 ];igt_output_t *output;igt_plane_t *cursor;
@@ -1353,7 +1384,13 @@ static void flip_vs_cursor_crc(igt_display_t *display, bool atomic)if (atomic)igt_require (display->is_atomic); -igt_require ((output =set_fb_on_crtc (display, pipe, &fb_info))); + pipe =find_connected_pipe (display, false, &output); +igt_require (output); + +igt_info ("Using pipe %s & %s\n" , +kmstest_pipe_name (pipe),igt_output_name (output)); + +set_fb_on_crtc (display, pipe, output, &fb_info);igt_create_color_fb (display->drm_fd,64 ,64 ,DRM_FORMAT_ARGB8888 ,0 ,1. ,1. ,1. , &cursor_fb);populate_cursor_args (display, pipe, arg, &cursor_fb);
@@ -1409,9 +1446,9 @@ static void flip_vs_cursor_busy_crc(igt_display_t *display, bool atomic)struct drm_event_vblank vbl;struct igt_fb fb_info[2 ], cursor_fb;unsigned vblank_start; -enum pipe pipe =find_connected_pipe (display, false); -igt_pipe_t *pipe_connected = &display->pipes[pipe]; -igt_plane_t *plane_primary =igt_pipe_get_plane_type (pipe_connected,DRM_PLANE_TYPE_PRIMARY ); +enum pipe pipe; +igt_pipe_t *pipe_connected; +igt_plane_t *plane_primary;igt_crc_t crcs[2 ], test_crc;uint64_t ahnd;igt_output_t *output;
@@ -1423,7 +1460,16 @@ static void flip_vs_cursor_busy_crc(igt_display_t *display, bool atomic)if (atomic)igt_require (display->is_atomic); -igt_require ((output =set_fb_on_crtc (display, pipe, &fb_info[0 ]))); + pipe =find_connected_pipe (display, false, &output); +igt_require (output); + +igt_info ("Using pipe %s & %s\n" , +kmstest_pipe_name (pipe),igt_output_name (output)); + + pipe_connected = &display->pipes[pipe]; + plane_primary =igt_pipe_get_plane_type (pipe_connected,DRM_PLANE_TYPE_PRIMARY ); + +set_fb_on_crtc (display, pipe, output, &fb_info[0 ]);igt_create_color_pattern_fb (display->drm_fd, fb_info[0 ].width, fb_info[0 ].height,DRM_FORMAT_XRGB8888 ,I915_FORMAT_MOD_X_TILED ,.1 ,.1 ,.1 , &fb_info[1 ]);
Signature · 1 line
2.35.1
PATCH v3 15/52 tests/kms_display_modes: Add support for Bigjoiner
In reply to Bhanuprakash ModemAs many 2x tests are currently running on Pipe-A & B only, those tests will always SKIP if there is any 8K supported panel in the config. Instead of Skipping the test, add some intelligence to the subtest to identify the valid pipe/output combo to execute the subtest.
V2: - Use updated helper name
--- tests/kms_display_modes.c | 104 +++++++++++++++++++++++--------------- 1 file changed, 62 insertions(+), 42 deletions(-)
tests/kms_display_modes.c +62 -42
@@ -34,31 +34,26 @@ typedef struct {int n_pipes; } data_t; -static void run_extendedmode_basic (data_t *data,int pipe1,int pipe2) +static void run_extendedmode_basic (data_t *data, +enum pipe pipe1,igt_output_t *output1, +enum pipe pipe2,igt_output_t *output2) {struct igt_fb fb, fbs[2 ];drmModeModeInfo *mode[2 ]; -igt_output_t *output, *extended_output[2 ];igt_display_t *display = &data->display;igt_plane_t *plane[2 ];igt_pipe_crc_t *pipe_crc[2 ] = {0 };igt_crc_t ref_crc[2 ], crc[2 ]; -int count =0 , width, height; +int width, height;cairo_t *cr; -for_each_connected_output (display, output) { - extended_output[count] = output; - count++; +igt_display_reset (display); -if (count >1 ) -break ; - } - -igt_output_set_pipe (extended_output[0 ], pipe1); -igt_output_set_pipe (extended_output[1 ], pipe2); +igt_output_set_pipe (output1, pipe1); +igt_output_set_pipe (output2, pipe2); - mode[0 ] =igt_output_get_mode (extended_output[0 ]); - mode[1 ] =igt_output_get_mode (extended_output[1 ]); + mode[0 ] =igt_output_get_mode (output1); + mode[1 ] =igt_output_get_mode (output2); pipe_crc[0 ] =igt_pipe_crc_new (data->drm_fd, pipe1,INTEL_PIPE_CRC_SOURCE_AUTO ); pipe_crc[1 ] =igt_pipe_crc_new (data->drm_fd, pipe2,INTEL_PIPE_CRC_SOURCE_AUTO );
@@ -115,8 +110,8 @@ static void run_extendedmode_basic(data_t *data, int pipe1, int pipe2)igt_pipe_crc_free (pipe_crc[0 ]);igt_pipe_crc_free (pipe_crc[1 ]); -igt_output_set_pipe (extended_output[0 ],PIPE_NONE ); -igt_output_set_pipe (extended_output[1 ],PIPE_NONE ); +igt_output_set_pipe (output1,PIPE_NONE ); +igt_output_set_pipe (output2,PIPE_NONE );igt_plane_set_fb (igt_pipe_get_plane_type (&display->pipes[pipe1],DRM_PLANE_TYPE_PRIMARY ),NULL );
@@ -129,43 +124,68 @@ static void run_extendedmode_basic(data_t *data, int pipe1, int pipe2)igt_assert_crc_equal (&crc[1 ], &ref_crc[1 ]); } +#define for_each_connected_output_local (display, output) \ + for (int j__ = 0; assert(igt_can_fail()), j__ < (display)->n_outputs; j__++) \ + for_each_if ((((output) = &(display)->outputs[j__]), \ + igt_output_is_connected((output)))) + +#define for_each_valid_output_on_pipe_local (display, pipe, output) \ + for_each_connected_output_local((display), (output)) \ + for_each_if (igt_pipe_connector_valid((pipe), (output))) + +static void run_extendedmode_test (data_t *data) { +enum pipe pipe1, pipe2; +igt_output_t *output1, *output2; +igt_display_t *display = &data->display; + +igt_display_reset (display); + +for_each_pipe (display, pipe1) { +for_each_valid_output_on_pipe (display, pipe1, output1) { +for_each_pipe (display, pipe2) { +if (pipe1 == pipe2) +continue ; + +for_each_valid_output_on_pipe_local (display, pipe2, output2) { +if (output1 == output2) +continue ; + +igt_display_reset (display); + +igt_output_set_pipe (output1, pipe1); +igt_output_set_pipe (output2, pipe2); + +if (!i915_pipe_output_combo_valid (display)) +continue ; + +igt_dynamic_f ("pipe-%s-%s-pipe-%s-%s" , +kmstest_pipe_name (pipe1), +igt_output_name (output1), +kmstest_pipe_name (pipe2), + igt_output_name(output2)) +run_extendedmode_basic (data, + pipe1, output1, + pipe2, output2); + } + } + } + } +} + igt_main {data_t data; -int valid_output =0 , i, j =0 ; -igt_output_t *output; -int pipe[IGT_MAX_PIPES ]; igt_fixture { data.drm_fd =drm_open_driver_master (DRIVER_ANY );kmstest_set_vt_graphics_mode ();igt_display_require (&data.display, data.drm_fd); - -for_each_connected_output (&data.display, output) { - valid_output++; - -if (valid_output >1 ) -break ; - } - - data.n_pipes =0 ; -for_each_pipe (&data.display, i) { - data.n_pipes++; - pipe[j] = i; - j++; - } - -igt_require_f (valid_output >1 ,"No valid second output found\n" ); +igt_display_require_output (&data.display); }igt_describe ("Test for validating display extended mode with a pair of connected displays" ); - igt_subtest_with_dynamic("extended-mode-basic") { -for (i =0 ; i < data.n_pipes -1 ; i++) { -igt_dynamic_f ("pipe-%s%s" ,kmstest_pipe_name (pipe[i]), -kmstest_pipe_name (pipe[i+1 ])); -run_extendedmode_basic (&data, pipe[i], pipe[i+1 ]); - } - } + igt_subtest_with_dynamic("extended-mode-basic") +run_extendedmode_test (&data); igt_fixture {igt_display_fini (&data.display);
Signature · 1 line
2.35.1
PATCH v3 16/52 tests/kms_dp_tiled_display: Add support for Bigjoiner
In reply to Bhanuprakash ModemThis patch will add a check to Skip the subtest if a selected pipe/output combo won't support Bigjoiner or 8K mode.
Example:
* Pipe-D wont support a mode > 5K
* To use 8K mode on a pipe then consecutive pipe must be available & free.
V2: - Use updated helper name
--- tests/kms_dp_tiled_display.c | 1 + 1 file changed, 1 insertion(+)
tests/kms_dp_tiled_display.c +1 -0
@@ -271,6 +271,7 @@ static void setup_mode(data_t *data)igt_require (found);igt_output_override_mode (output, mode); } +igt_require (i915_pipe_output_combo_valid (data->display));igt_display_commit_atomic (data->display,DRM_MODE_ATOMIC_ALLOW_MODESET ,NULL ); }
Signature · 1 line
2.35.1
Re: [igt-dev] [i-g-t V3 16/52] tests/kms_dp_tiled_display: Add support for Bigjoiner
Quoted 10 lines · Bhanuprakash Modem
This patch will add a check to Skip the subtest if a selected pipe/output combo won't support Bigjoiner or 8K mode.
Example:
* Pipe-D wont support a mode > 5K
* To use 8K mode on a pipe then consecutive pipe must be available & free.V2: - Use updated helper name
Signed-off-by Bhanuprakash Modem <[email protected]>
Quoted 16 lines
--- tests/kms_dp_tiled_display.c | 1 + 1 file changed, 1 insertion(+)tests/kms_dp_tiled_display.c +1
-0@@ -271,6 +271,7 @@ static void setup_mode(data_t *data)igt_require (found);igt_output_override_mode (output, mode); } +igt_require (i915_pipe_output_combo_valid (data->display));igt_display_commit_atomic (data->display,DRM_MODE_ATOMIC_ALLOW_MODESET ,NULL ); }
PATCH v3 17/52 tests/kms_flip_event_leak: Add support for Bigjoiner
In reply to Bhanuprakash ModemThis patch will add a check to Skip the subtest if a selected pipe/output combo won't support Bigjoiner or 8K mode.
Example:
* Pipe-D wont support a mode > 5K
* To use 8K mode on a pipe then consecutive pipe must be available & free.
V2: - Use updated helper name
--- tests/kms_flip_event_leak.c | 10 ++++++++++ 1 file changed, 10 insertions(+)
tests/kms_flip_event_leak.c +10 -0
@@ -48,6 +48,9 @@ static void test(data_t *data, enum pipe pipe, igt_output_t *output)struct igt_fb fb[2 ];int fd, ret; +igt_info ("Using (pipe %s + %s) to run the subtest.\n" , +kmstest_pipe_name (pipe),igt_output_name (output)); +/* select the pipe we want to use */ igt_output_set_pipe (output, pipe);
@@ -102,6 +105,13 @@ igt_simple_mainigt_display_require (&data.display, data.drm_fd);for_each_pipe_with_valid_output (&data.display, pipe, output) { +igt_display_reset (&data.display); + +igt_output_set_pipe (output, pipe); +if (!i915_pipe_output_combo_valid (&data.display)) +continue ; + +igt_output_set_pipe (output,PIPE_NONE );test (&data, pipe, output); valid_tests++; }
Signature · 1 line
2.35.1
PATCH v3 18/52 tests/kms_invalid_mode: Add support for Bigjoiner
In reply to Bhanuprakash ModemThis patch will add a check to Skip the subtest if a selected pipe/output combo won't support Bigjoiner or 8K mode.
Example:
* Pipe-D wont support a mode > 5K
* To use 8K mode on a pipe then consecutive pipe must be available & free.
V2: - Use updated helper name
--- tests/kms_invalid_mode.c | 6 ++++++ 1 file changed, 6 insertions(+)
tests/kms_invalid_mode.c +6 -0
@@ -293,6 +293,12 @@ igt_mainfor (int i =0 ; i <ARRAY_SIZE (subtests); i++) { igt_subtest_with_dynamic(subtests[i].name) {for_each_pipe_with_valid_output (&data.display, pipe, output) { +igt_display_reset (&data.display); + +igt_output_set_pipe (output, pipe); +if (!i915_pipe_output_combo_valid (&data.display)) +continue ; + igt_dynamic_f("%s-pipe-%s", igt_output_name(output), kmstest_pipe_name(pipe)) { data.output = output; data.pipe = pipe;
Signature · 1 line
2.35.1
PATCH v3 19/52 tests/kms_lease: Add support for Bigjoiner
In reply to Bhanuprakash ModemThis patch will add a check to Skip the subtest if a selected pipe/output combo won't support Bigjoiner or 8K mode.
Example:
* Pipe-D wont support a mode > 5K
* To use 8K mode on a pipe then consecutive pipe must be available & free.
V2: - Use updated helper name
--- tests/kms_lease.c | 6 ++++++ 1 file changed, 6 insertions(+)
tests/kms_lease.c +6 -0
@@ -823,6 +823,12 @@ static void run_test(data_t *data, void (*testfunc)(data_t *))kmstest_pipe_name (p), igt_output_name(output)); +igt_display_reset (display); + +igt_output_set_pipe (output, p); +if (!i915_pipe_output_combo_valid (display)) +continue ; + data->pipe = p; data->crtc_id =pipe_to_crtc_id (display, p); data->connector_id = output->id;
Signature · 1 line
2.35.1
PATCH v3 20/52 tests/kms_multipipe_modeset: Find the suitable mode instead of using default
In reply to Bhanuprakash ModemThis patch will add a check to Skip the subtest if a selected pipe/output combo won't support Bigjoiner or 8K mode.
Example:
* Pipe-D wont support a mode > 5K
* To use 8K mode on a pipe then consecutive pipe must be available & free.
--- tests/kms_multipipe_modeset.c | 9 +++++++++ 1 file changed, 9 insertions(+)
tests/kms_multipipe_modeset.c +9 -0
@@ -46,6 +46,15 @@ static void run_test(data_t *data, int valid_outputs)drmModeModeInfo *mode;int i =0 ; +/* Find suitable mode/resolution combo */ +for_each_connected_output (display, output) { + pipe = &display->pipes[i]; +igt_output_set_pipe (output, i); + + i++; + } +igt_require (igt_override_all_active_output_modes_to_fit_bw (display)); +for_each_connected_output (display, output) { mode =igt_output_get_mode (output);igt_assert (mode);
Signature · 1 line
2.35.1
Re: [igt-dev] [i-g-t V3 20/52] tests/kms_multipipe_modeset: Find the suitable mode instead of using default
Quoted 19 lines · Bhanuprakash Modem
This patch will add a check to Skip the subtest if a selected pipe/output combo won't support Bigjoiner or 8K mode.
Example:
* Pipe-D wont support a mode > 5K
* To use 8K mode on a pipe then consecutive pipe must be available & free.Signed-off-by Bhanuprakash Modem <[email protected]>--- tests/kms_multipipe_modeset.c | 9 +++++++++ 1 file changed, 9 insertions(+)tests/kms_multipipe_modeset.c +0
-0@@ -46,6 +46,15 @@ static void run_test(data_t *data, int valid_outputs)drmModeModeInfo *mode;int i =0 ;
tests/kms_multipipe_modeset.c static void run_test(data_t *data, int valid_outputs) · line 57
Quoted 10 lines
tests/kms_multipipe_modeset.c +9
-0+/* Find suitable mode/resolution combo */ +for_each_connected_output (display, output) { + pipe = &display->pipes[i]; +igt_output_set_pipe (output, i); + + i++; + } +igt_require (igt_override_all_active_output_modes_to_fit_bw (display)); +
Agree with the idea of the patch. Please update the commit message for this subtest as here we're actually reducing the mode from 8k to a mode that can be supported on single pipe. With this updated the patch LGTM.
Thanks,Karthik.B.S
Quoted 3 lines
tests/kms_multipipe_modeset.c +0
-0for_each_connected_output (display, output) { mode =igt_output_get_mode (output);igt_assert (mode);
Re: [igt-dev] [i-g-t V3 20/52] tests/kms_multipipe_modeset: Find the suitable mode instead of using default
Quoted 24 lines · Karthik B S
Quoted 23 lines · Bhanuprakash Modem
This patch will add a check to Skip the subtest if a selected pipe/output combo won't support Bigjoiner or 8K mode.
Example:
* Pipe-D wont support a mode > 5K
* To use 8K mode on a pipe then consecutive pipe must be available & free.Signed-off-by Bhanuprakash Modem <[email protected]>---
tests/kms_multipipe_modeset.c| 9 +++++++++1 file changed, 9 insertions(+)tests/kms_multipipe_modeset.c +4
-0@@ -46,6 +46,15 @@ static void run_test(data_t *data, int valid_outputs) drmModeModeInfo *mode; int i = 0; + /* Find suitable mode/resolution combo */ + for_each_connected_output(display, output) { + pipe = &display->pipes[i]; + igt_output_set_pipe(output, i);
Quoted 8 lines
tests/kms_multipipe_modeset.c static void run_test(data_t *data, int valid_outputs)
Quoted 6 lines
tests/kms_multipipe_modeset.c +5
-0+ + i++; + } +igt_require (igt_override_all_active_output_modes_to_fit_bw (display)); +Agree with the idea of the patch. Please update the commit message for this subtest as here we're actually reducing the mode from 8k to a mode that can be supported on single pipe. With this updated the patch LGTM.
Thanks Karthik, I have floated a new rev with this change.
- Bhanu
Quoted 8 lines
Thanks,
Karthik.B.SQuoted 3 lines
tests/kms_multipipe_modeset.c +0
-0for_each_connected_output(display, output) { mode = igt_output_get_mode(output); igt_assert(mode);
PATCH v3 21/52 tests/kms_pipe_crc_basic: Add support for Bigjoiner
In reply to Bhanuprakash ModemThis patch will add a check to Skip the subtest if a selected pipe/output combo won't support Bigjoiner or 8K mode.
Example:
* Pipe-D wont support a mode > 5K
* To use 8K mode on a pipe then consecutive pipe must be available & free.
V2: - Use updated helper name
--- tests/kms_pipe_crc_basic.c | 24 ++++++++++++++++++++++++ 1 file changed, 24 insertions(+)
tests/kms_pipe_crc_basic.c +24 -0
@@ -271,6 +271,21 @@ static void test_disable_crc_after_crtc(data_t *data, enum pipe pipe,igt_remove_fb (data->drm_fd, &data->fb); } +static bool pipe_output_combo_valid (igt_display_t *display, +enum pipe pipe,igt_output_t *output) +{ +bool ret = true; + +igt_display_reset (display); + +igt_output_set_pipe (output, pipe); +if (!i915_pipe_output_combo_valid (display)) + ret = false; +igt_output_set_pipe (output,PIPE_NONE ); + +return ret; +} +data_t data = {0 , }; igt_main
@@ -319,6 +334,9 @@ igt_mainigt_describe (tests[i].desc); igt_subtest_with_dynamic(tests[i].name) {for_each_pipe_with_single_output (&data.display, pipe, output) { +if (!pipe_output_combo_valid (&data.display, pipe, output)) +continue ; + igt_dynamic_f("pipe-%s-%s", kmstest_pipe_name(pipe), output->name) {if (tests[i].flags &TEST_SUSPEND ) {test_read_crc (&data, pipe, output,0 );
@@ -347,6 +365,9 @@ igt_main "does not cause issues."); igt_subtest_with_dynamic("disable-crc-after-crtc") {for_each_pipe_with_single_output (&data.display, pipe, output) { +if (!pipe_output_combo_valid (&data.display, pipe, output)) +continue ; + igt_dynamic_f("pipe-%s-%s", kmstest_pipe_name(pipe), output->name)test_disable_crc_after_crtc (&data, pipe, output); }
@@ -355,6 +376,9 @@ igt_mainigt_describe ("Basic sanity check for CRC mismatches" ); igt_subtest_with_dynamic("compare-crc-sanitycheck") {for_each_pipe_with_single_output (&data.display, pipe, output) { +if (!pipe_output_combo_valid (&data.display, pipe, output)) +continue ; + igt_dynamic_f("pipe-%s-%s", kmstest_pipe_name(pipe), output->name)test_compare_crc (&data, pipe, output); }
Signature · 1 line
2.35.1
PATCH v3 22/52 tests/kms_plane: Add support for Bigjoiner
In reply to Bhanuprakash ModemThis patch will add a check to Skip the subtest if a selected pipe/output combo won't support Bigjoiner or 8K mode.
Example:
* Pipe-D wont support a mode > 5K
* To use 8K mode on a pipe then consecutive pipe must be available & free.
V2: - Use updated helper name
--- tests/kms_plane.c | 30 +++++++++++++++++++----------- 1 file changed, 19 insertions(+), 11 deletions(-)
tests/kms_plane.c +19 -11
@@ -56,6 +56,7 @@ typedef struct { typedef struct { int drm_fd; igt_display_t display; + igt_output_t *output; igt_pipe_crc_t *pipe_crc; const color_t *colors; int num_colors;
@@ -273,11 +274,11 @@ static void test_plane_position(data_t *data, enum pipe pipe) {int n_planes = data->display.pipes[pipe].n_planes; -igt_output_t *output; +igt_output_t *output = data->output;igt_crc_t reference_crc; - output =igt_get_single_output_for_pipe (&data->display, pipe); -igt_require (output); +igt_info ("Using (pipe %s + %s) to run the subtest.\n" , +kmstest_pipe_name (pipe),igt_output_name (output));test_init (data, pipe);test_grab_crc (data, output, pipe, &green, data->flags, &reference_crc);
@@ -380,11 +381,11 @@ test_plane_panning_with_output(data_t *data,static void test_plane_panning (data_t *data,enum pipe pipe) { -igt_output_t *output; +igt_output_t *output = data->output;igt_crc_t ref_crc; - output =igt_get_single_output_for_pipe (&data->display, pipe); -igt_require (output); +igt_info ("Using (pipe %s + %s) to run the subtest.\n" , +kmstest_pipe_name (pipe),igt_output_name (output));test_init (data, pipe);
@@ -1050,7 +1051,7 @@ test_pixel_formats(data_t *data, enum pipe pipe)igt_plane_t *primary;drmModeModeInfo *mode;bool result; -igt_output_t *output; +igt_output_t *output = data->output;igt_plane_t *plane;if (data->extended) {
@@ -1061,10 +1062,10 @@ test_pixel_formats(data_t *data, enum pipe pipe) data->num_colors =ARRAY_SIZE (colors_reduced); } -test_init (data, pipe); +igt_info ("Using (pipe %s + %s) to run the subtest.\n" , +kmstest_pipe_name (pipe),igt_output_name (output)); - output =igt_get_single_output_for_pipe (&data->display, pipe); -igt_require (output); +test_init (data, pipe); mode =igt_output_get_mode (output);
@@ -1108,7 +1109,14 @@ static void run_test(data_t *data, void (*test)(data_t *, enum pipe))enum pipe pipe;int count =0 ; -for_each_pipe (&data->display, pipe) { +for_each_pipe_with_single_output (&data->display, pipe, data->output) { +igt_display_reset (&data->display); + +igt_output_set_pipe (data->output, pipe); +if (!i915_pipe_output_combo_valid (&data->display)) +continue ; + +igt_output_set_pipe (data->output,PIPE_NONE ); igt_dynamic_f("pipe-%s-planes", kmstest_pipe_name(pipe))test (data, pipe);
Signature · 1 line
2.35.1
PATCH v3 23/52 tests/kms_plane_alpha_blend: Add support for Bigjoiner
In reply to Bhanuprakash ModemThis patch will add a check to Skip the subtest if a selected pipe/output combo won't support Bigjoiner or 8K mode.
Example:
* Pipe-D wont support a mode > 5K
* To use 8K mode on a pipe then consecutive pipe must be available & free.
V2: - Use updated helper name
--- tests/kms_plane_alpha_blend.c | 7 +++++++ 1 file changed, 7 insertions(+)
tests/kms_plane_alpha_blend.c +7 -0
@@ -476,6 +476,13 @@ static void run_test_on_pipe_planes(data_t *data, enum pipe pipe, bool blend,bool found = false;bool multiply = false; +igt_display_reset (display); +igt_output_set_pipe (output, pipe); +igt_require (i915_pipe_output_combo_valid (display)); + +igt_info ("Using (pipe %s + %s) to run the subtest.\n" , +kmstest_pipe_name (pipe),igt_output_name (output)); +for_each_plane_on_pipe (display, pipe, plane) {if (!igt_plane_has_prop (plane,IGT_PLANE_ALPHA ))continue ;
Signature · 1 line
2.35.1
PATCH v3 24/52 tests/kms_plane_cursor: Add support for Bigjoiner
In reply to Bhanuprakash ModemThis patch will add a check to Skip the subtest if a selected pipe/output combo won't support Bigjoiner or 8K mode.
Example:
* Pipe-D wont support a mode > 5K
* To use 8K mode on a pipe then consecutive pipe must be available & free.
V2: - Use updated helper name
--- tests/kms_plane_cursor.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-)
tests/kms_plane_cursor.c +6 -2
@@ -83,12 +83,16 @@ static void test_init(data_t *data, enum pipe pipe_id, igt_output_t *output) data->overlay =igt_pipe_get_plane_type (data->pipe,DRM_PLANE_TYPE_OVERLAY ); data->cursor =igt_pipe_get_plane_type (data->pipe,DRM_PLANE_TYPE_CURSOR ); +igt_output_set_pipe (data->output, data->pipe_id); +igt_require (i915_pipe_output_combo_valid (display)); + +igt_info ("Using (pipe %s + %s) to run the subtest.\n" , +kmstest_pipe_name (data->pipe_id),igt_output_name (data->output)); +igt_require_pipe_crc (data->drm_fd); data->pipe_crc =igt_pipe_crc_new (data->drm_fd, data->pipe_id,INTEL_PIPE_CRC_SOURCE_AUTO ); -igt_output_set_pipe (data->output, data->pipe_id); -/* Overlay rectangle for a rect in the center of the screen */ data->or.x = data->mode->hdisplay /4 ; data->or.y = data->mode->vdisplay /4 ;
Signature · 1 line
2.35.1
PATCH v3 25/52 tests/kms_plane_lowres: Add support for Bigjoiner
In reply to Bhanuprakash ModemThis patch will add a check to Skip the subtest if a selected pipe/output combo won't support Bigjoiner or 8K mode.
Example:
* Pipe-D wont support a mode > 5K
* To use 8K mode on a pipe then consecutive pipe must be available & free.
V2: - Use updated helper name
--- tests/kms_plane_lowres.c | 3 +++ 1 file changed, 3 insertions(+)
tests/kms_plane_lowres.c +3 -0
@@ -277,6 +277,9 @@ static void run_test(data_t *data, uint64_t modifier)igt_display_reset (&data->display);igt_output_set_pipe (data->output, data->pipe); +if (!i915_pipe_output_combo_valid (&data->display)) +continue ; + data->pipe_crc =igt_pipe_crc_new (data->drm_fd, data->pipe,INTEL_PIPE_CRC_SOURCE_AUTO );
Signature · 1 line
2.35.1
Re: [igt-dev] [i-g-t V3 25/52] tests/kms_plane_lowres: Add support for Bigjoiner
Quoted 10 lines · Bhanuprakash Modem
This patch will add a check to Skip the subtest if a selected pipe/output combo won't support Bigjoiner or 8K mode.
Example:
* Pipe-D wont support a mode > 5K
* To use 8K mode on a pipe then consecutive pipe must be available & free.V2: - Use updated helper name
Signed-off-by Bhanuprakash Modem <[email protected]>
Quoted 18 lines
--- tests/kms_plane_lowres.c | 3 +++ 1 file changed, 3 insertions(+)tests/kms_plane_lowres.c +3
-0@@ -277,6 +277,9 @@ static void run_test(data_t *data, uint64_t modifier)igt_display_reset (&data->display);igt_output_set_pipe (data->output, data->pipe); +if (!i915_pipe_output_combo_valid (&data->display)) +continue ; + data->pipe_crc =igt_pipe_crc_new (data->drm_fd, data->pipe,INTEL_PIPE_CRC_SOURCE_AUTO );
PATCH v3 26/52 tests/kms_plane_multiple: Add support for Bigjoiner
In reply to Bhanuprakash ModemThis patch will add a check to Skip the subtest if a selected pipe/output combo won't support Bigjoiner or 8K mode.
Example:
* Pipe-D wont support a mode > 5K
* To use 8K mode on a pipe then consecutive pipe must be available & free.
V2: - Use updated helper name
--- tests/kms_plane_multiple.c | 15 ++++++++++++--- 1 file changed, 12 insertions(+), 3 deletions(-)
tests/kms_plane_multiple.c +12 -3
@@ -102,6 +102,7 @@ get_reference_crc(data_t *data, igt_output_t *output, enum pipe pipe,igt_plane_t *primary;int ret; +igt_display_reset (&data->display);igt_output_set_pipe (output, pipe); primary =igt_output_get_plane_type (output,DRM_PLANE_TYPE_PRIMARY );
@@ -289,6 +290,9 @@ test_plane_position_with_output(data_t *data, enum pipe pipe,bool loop_forever;char info[256 ]; +igt_info ("Using (pipe %s + %s) to run the subtest.\n" , +kmstest_pipe_name (pipe),igt_output_name (output)); +if (opt.iterations ==LOOP_FOREVER ) { loop_forever = true;sprintf (info,"forever" );
@@ -374,12 +378,17 @@ static void run_test(data_t *data, uint64_t modifier) {enum pipe pipe;igt_output_t *output; +igt_display_t *display = &data->display; -if (!igt_display_has_format_mod (&data->display,DRM_FORMAT_XRGB8888 , modifier)) +if (!igt_display_has_format_mod (display,DRM_FORMAT_XRGB8888 , modifier))return ; -for_each_pipe_with_valid_output (&data->display, pipe, output) { -igt_display_reset (&data->display); +for_each_pipe_with_valid_output (display, pipe, output) { +igt_display_reset (display); + +igt_output_set_pipe (output, pipe); +if (!i915_pipe_output_combo_valid (display)) +continue ; igt_dynamic_f("pipe-%s-%s", kmstest_pipe_name(pipe), output->name)test_plane_position (data, pipe, output, modifier);
Signature · 1 line
2.35.1
Re: [igt-dev] [i-g-t V3 26/52] tests/kms_plane_multiple: Add support for Bigjoiner
Quoted 10 lines · Bhanuprakash Modem
This patch will add a check to Skip the subtest if a selected pipe/output combo won't support Bigjoiner or 8K mode.
Example:
* Pipe-D wont support a mode > 5K
* To use 8K mode on a pipe then consecutive pipe must be available & free.V2: - Use updated helper name
Signed-off-by Bhanuprakash Modem <[email protected]>
Quoted 47 lines
--- tests/kms_plane_multiple.c | 15 ++++++++++++--- 1 file changed, 12 insertions(+), 3 deletions(-)tests/kms_plane_multiple.c +12
-3@@ -102,6 +102,7 @@ get_reference_crc(data_t *data, igt_output_t *output, enum pipe pipe,igt_plane_t *primary;int ret; +igt_display_reset (&data->display);igt_output_set_pipe (output, pipe); primary =igt_output_get_plane_type (output,DRM_PLANE_TYPE_PRIMARY );@@ -289,6 +290,9 @@ test_plane_position_with_output(data_t *data, enum pipe pipe,bool loop_forever;char info[256 ]; +igt_info ("Using (pipe %s + %s) to run the subtest.\n" , +kmstest_pipe_name (pipe),igt_output_name (output)); +if (opt.iterations ==LOOP_FOREVER ) { loop_forever = true;sprintf (info,"forever" );@@ -374,12 +378,17 @@ static void run_test(data_t *data, uint64_t modifier) {enum pipe pipe;igt_output_t *output; +igt_display_t *display = &data->display; -if (!igt_display_has_format_mod (&data->display,DRM_FORMAT_XRGB8888 , modifier)) +if (!igt_display_has_format_mod (display,DRM_FORMAT_XRGB8888 , modifier))return ; -for_each_pipe_with_valid_output (&data->display, pipe, output) { -igt_display_reset (&data->display); +for_each_pipe_with_valid_output (display, pipe, output) { +igt_display_reset (display); + +igt_output_set_pipe (output, pipe); +if (!i915_pipe_output_combo_valid (display)) +continue ; igt_dynamic_f("pipe-%s-%s", kmstest_pipe_name(pipe), output->name)test_plane_position (data, pipe, output, modifier);
PATCH v3 27/52 tests/kms_plane_scaling: Add support for Bigjoiner
In reply to Bhanuprakash ModemAs many 2x tests are currently running on Pipe-A & B only, those tests will always SKIP if there is any 8K supported panel in the config. Instead of Skipping the test, add some intelligence to the subtest to identify the valid pipe/output combo to execute the subtest.
V2: - Use updated helper name
--- tests/kms_plane_scaling.c | 218 +++++++++++++++++++++++++------------- 1 file changed, 145 insertions(+), 73 deletions(-)
tests/kms_plane_scaling.c +145 -73
@@ -546,30 +546,45 @@ static void test_scaler_with_pixel_format_pipe(data_t *d, int width, int height, } } -static void find_connected_pipe (igt_display_t *display,bool second,enum pipe *pipe,igt_output_t **output) +static enum pipe +find_connected_pipe (igt_display_t *display,bool second,igt_output_t **output) { -enum pipe first =PIPE_NONE ; -igt_output_t *first_output =NULL ; +enum pipe pipe; +bool first_output = false;bool found = false; -for_each_pipe_with_valid_output (display, *pipe, *output) { -if (first == *pipe || *output == first_output) -continue ; +igt_display_reset (display); -if (second) { - first = *pipe; - first_output = *output; - second = false; -continue ; - } +for_each_pipe (display, pipe) { +for_each_valid_output_on_pipe (display, pipe, *output) { +if ((*output)->pending_pipe !=PIPE_NONE ) +continue ; -return ; +igt_output_set_pipe (*output, pipe); +if (i915_pipe_output_combo_valid (display)) { + found = true; + +if (second) { + first_output = true; + second = false; + found = false; + } +break ; + } +igt_output_set_pipe (*output,PIPE_NONE ); + } +if (found) +break ; } +igt_display_reset (display); +if (first_output)igt_require_f (found,"No second valid output found\n" );else igt_require_f (found,"No valid outputs found\n" ); + +return pipe; } static void
@@ -749,13 +764,16 @@ static void test_scaler_with_multi_pipe_plane(data_t *d)enum pipe pipe1, pipe2;int ret1, ret2; -cleanup_crtc (d); - -find_connected_pipe (display, false, &pipe1, &output1); -find_connected_pipe (display, true, &pipe2, &output2); +cleanup_fbs (d); + pipe1 =find_connected_pipe (display, false, &output1); + pipe2 =find_connected_pipe (display, true, &output2);igt_skip_on (!output1 || !output2); +igt_info ("Using (pipe %s + %s) and (pipe %s + %s) to run the subtest.\n" , +kmstest_pipe_name (pipe1),igt_output_name (output1), +kmstest_pipe_name (pipe2),igt_output_name (output2)); +igt_output_set_pipe (output1, pipe1);igt_output_set_pipe (output2, pipe2);
@@ -820,6 +838,22 @@ static void test_scaler_with_multi_pipe_plane(data_t *d)igt_assert_eq (ret1 && ret2,0 ); } +static bool +pipe_output_combo_valid (igt_display_t *display, +enum pipe pipe,igt_output_t *output) +{ +bool ret = true; + +igt_display_reset (display); + +igt_output_set_pipe (output, pipe); +if (!i915_pipe_output_combo_valid (display)) + ret = false; +igt_output_set_pipe (output,PIPE_NONE ); + +return ret; +} +static int opt_handler (int opt,int opt_index,void *_data) {data_t *data = _data;
@@ -861,17 +895,22 @@ igt_main_args("", long_opts, help_str, opt_handler, &data)for (int index =0 ; index <ARRAY_SIZE (scaler_with_pixel_format_tests); index++) {igt_describe (scaler_with_pixel_format_tests[index].describe); igt_subtest_with_dynamic(scaler_with_pixel_format_tests[index].name) { -for_each_pipe_with_single_output (&data.display, pipe, output) - igt_dynamic_f("pipe-%s-%s", kmstest_pipe_name(pipe), igt_output_name(output)) { -drmModeModeInfo *mode; - - mode =igt_output_get_mode (output); - -test_scaler_with_pixel_format_pipe (&data, -get_width (mode, scaler_with_pixel_format_tests[index].sf), -get_height (mode, scaler_with_pixel_format_tests[index].sf), - scaler_with_pixel_format_tests[index].is_upscale, - pipe, output); +for_each_pipe (&data.display, pipe) { +for_each_valid_output_on_pipe (&data.display, pipe, output) { +if (!pipe_output_combo_valid (&data.display, pipe, output)) +continue ; + + igt_dynamic_f("pipe-%s-%s", kmstest_pipe_name(pipe), igt_output_name(output)) { +drmModeModeInfo *mode =igt_output_get_mode (output); + +test_scaler_with_pixel_format_pipe (&data, +get_width (mode, scaler_with_pixel_format_tests[index].sf), +get_height (mode, scaler_with_pixel_format_tests[index].sf), + scaler_with_pixel_format_tests[index].is_upscale, + pipe, output); + } +break ; + } } } }
@@ -879,17 +918,22 @@ igt_main_args("", long_opts, help_str, opt_handler, &data)for (int index =0 ; index <ARRAY_SIZE (scaler_with_rotation_tests); index++) {igt_describe (scaler_with_rotation_tests[index].describe); igt_subtest_with_dynamic(scaler_with_rotation_tests[index].name) { -for_each_pipe_with_single_output (&data.display, pipe, output) - igt_dynamic_f("pipe-%s-%s", kmstest_pipe_name(pipe), igt_output_name(output)) { -drmModeModeInfo *mode; - - mode =igt_output_get_mode (output); - -test_scaler_with_rotation_pipe (&data, -get_width (mode, scaler_with_rotation_tests[index].sf), -get_height (mode, scaler_with_rotation_tests[index].sf), - scaler_with_rotation_tests[index].is_upscale, - pipe, output); +for_each_pipe (&data.display, pipe) { +for_each_valid_output_on_pipe (&data.display, pipe, output) { +if (!pipe_output_combo_valid (&data.display, pipe, output)) +continue ; + + igt_dynamic_f("pipe-%s-%s", kmstest_pipe_name(pipe), igt_output_name(output)) { +drmModeModeInfo *mode =igt_output_get_mode (output); + +test_scaler_with_rotation_pipe (&data, +get_width (mode, scaler_with_rotation_tests[index].sf), +get_height (mode, scaler_with_rotation_tests[index].sf), + scaler_with_rotation_tests[index].is_upscale, + pipe, output); + } +break ; + } } } }
@@ -897,85 +941,113 @@ igt_main_args("", long_opts, help_str, opt_handler, &data)for (int index =0 ; index <ARRAY_SIZE (scaler_with_modifiers_tests); index++) {igt_describe (scaler_with_modifiers_tests[index].describe); igt_subtest_with_dynamic(scaler_with_modifiers_tests[index].name) { -for_each_pipe_with_single_output (&data.display, pipe, output) - igt_dynamic_f("pipe-%s-%s", kmstest_pipe_name(pipe), igt_output_name(output)) { -drmModeModeInfo *mode; - - mode =igt_output_get_mode (output); - -test_scaler_with_modifier_pipe (&data, -get_width (mode, scaler_with_rotation_tests[index].sf), -get_height (mode, scaler_with_rotation_tests[index].sf), - scaler_with_rotation_tests[index].is_upscale, - pipe, output); +for_each_pipe (&data.display, pipe) { +for_each_valid_output_on_pipe (&data.display, pipe, output) { +if (!pipe_output_combo_valid (&data.display, pipe, output)) +continue ; + + igt_dynamic_f("pipe-%s-%s", kmstest_pipe_name(pipe), igt_output_name(output)) { +drmModeModeInfo *mode =igt_output_get_mode (output); + +test_scaler_with_modifier_pipe (&data, +get_width (mode, scaler_with_rotation_tests[index].sf), +get_height (mode, scaler_with_rotation_tests[index].sf), + scaler_with_rotation_tests[index].is_upscale, + pipe, output); + } +break ; + } } } }igt_describe ("Tests scaling with clipping and clamping, pixel formats." ); igt_subtest_with_dynamic("plane-scaler-with-clipping-clamping-pixel-formats") { -for_each_pipe_with_single_output (&data.display, pipe, output) { -drmModeModeInfo *mode; +for_each_pipe (&data.display, pipe) { +for_each_valid_output_on_pipe (&data.display, pipe, output) { +if (!pipe_output_combo_valid (&data.display, pipe, output)) +continue ; - mode =igt_output_get_mode (output); + igt_dynamic_f("pipe-%s-%s", kmstest_pipe_name(pipe), igt_output_name(output)) { +drmModeModeInfo *mode =igt_output_get_mode (output); - igt_dynamic_f("pipe-%s-%s", kmstest_pipe_name(pipe), igt_output_name(output)) -test_scaler_with_pixel_format_pipe (&data, mode->hdisplay +100 , +test_scaler_with_pixel_format_pipe (&data, mode->hdisplay +100 , mode->vdisplay +100 , false, pipe, output); + } +break ; + } } }igt_describe ("Tests scaling with clipping and clamping, rotation." ); igt_subtest_with_dynamic("plane-scaler-with-clipping-clamping-rotation") { -for_each_pipe_with_single_output (&data.display, pipe, output) { -drmModeModeInfo *mode; +for_each_pipe (&data.display, pipe) { +for_each_valid_output_on_pipe (&data.display, pipe, output) { +if (!pipe_output_combo_valid (&data.display, pipe, output)) +continue ; - mode =igt_output_get_mode (output); + igt_dynamic_f("pipe-%s-%s", kmstest_pipe_name(pipe), igt_output_name(output)) { +drmModeModeInfo *mode =igt_output_get_mode (output); - igt_dynamic_f("pipe-%s-%s", kmstest_pipe_name(pipe), igt_output_name(output)) -test_scaler_with_rotation_pipe (&data, mode->hdisplay +100 , +test_scaler_with_rotation_pipe (&data, mode->hdisplay +100 , mode->vdisplay +100 , false, pipe, output); + } +break ; + } } }igt_describe ("Tests scaling with clipping and clamping, modifiers." ); igt_subtest_with_dynamic("plane-scaler-with-clipping-clamping-modifiers") { -for_each_pipe_with_single_output (&data.display, pipe, output) { -drmModeModeInfo *mode; - - mode =igt_output_get_mode (output); - - igt_dynamic_f("pipe-%s-%s", kmstest_pipe_name(pipe), igt_output_name(output)) -test_scaler_with_modifier_pipe (&data, mode->hdisplay +100 , +for_each_pipe (&data.display, pipe) { +for_each_valid_output_on_pipe (&data.display, pipe, output) { +if (!pipe_output_combo_valid (&data.display, pipe, output)) +continue ; + + igt_dynamic_f("pipe-%s-%s", kmstest_pipe_name(pipe), igt_output_name(output)) { +drmModeModeInfo *mode =igt_output_get_mode (output); +test_scaler_with_modifier_pipe (&data, mode->hdisplay +100 , mode->vdisplay +100 , false, pipe, output); + } +break ; + } } }for (int index =0 ; index <ARRAY_SIZE (scaler_with_2_planes_tests); index++) {igt_describe (scaler_with_2_planes_tests[index].describe); igt_subtest_with_dynamic(scaler_with_2_planes_tests[index].name) { -for_each_pipe_with_single_output (&data.display, pipe, output) - igt_dynamic_f("pipe-%s-%s", kmstest_pipe_name(pipe), igt_output_name(output)) { -drmModeModeInfo *mode; +for_each_pipe (&data.display, pipe) { +for_each_valid_output_on_pipe (&data.display, pipe, output) { +if (!pipe_output_combo_valid (&data.display, pipe, output)) +continue ; - mode =igt_output_get_mode (output); + igt_dynamic_f("pipe-%s-%s", kmstest_pipe_name(pipe), igt_output_name(output)) { +drmModeModeInfo *mode =igt_output_get_mode (output); -test_planes_scaling_combo (&data, +test_planes_scaling_combo (&data,get_width (mode, scaler_with_2_planes_tests[index].sf_plane1),get_height (mode, scaler_with_2_planes_tests[index].sf_plane1),get_width (mode, scaler_with_2_planes_tests[index].sf_plane2),get_height (mode, scaler_with_2_planes_tests[index].sf_plane2), pipe, output, scaler_with_2_planes_tests[index].test_type); + } +break ; } } + } }igt_describe ("Negative test for number of scalers per pipe." ); igt_subtest_with_dynamic("invalid-num-scalers") { -for_each_pipe_with_valid_output (&data.display, pipe, output) +for_each_pipe_with_valid_output (&data.display, pipe, output) { +if (!pipe_output_combo_valid (&data.display, pipe, output)) +continue ; +igt_dynamic_f ("pipe-%s-%s-invalid-num-scalers" , kmstest_pipe_name(pipe), igt_output_name(output))test_invalid_num_scalers (&data, pipe, output); + } } }
Signature · 1 line
2.35.1
PATCH v3 28/52 tests/kms_prime: Add support for Bigjoiner
In reply to Bhanuprakash ModemThis patch will add a check to Skip the subtest if a selected pipe/output combo won't support Bigjoiner or 8K mode.
Example:
* Pipe-D wont support a mode > 5K
* To use 8K mode on a pipe then consecutive pipe must be available & free.
V2: - Use updated helper name
--- tests/kms_prime.c | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-)
tests/kms_prime.c +7 -4
@@ -89,14 +89,17 @@ static igt_output_t *setup_display(int importer_fd, igt_display_t *display,bool found = false;for_each_pipe_with_valid_output (display, *pipe, output) { - found = true; -break ; +igt_display_reset (display); + +igt_output_set_pipe (output, *pipe); +if (i915_pipe_output_combo_valid (display)) { + found = true; +break ; + } }igt_require_f (found,"No valid connector/pipe found\n" ); -igt_display_reset (display); -igt_output_set_pipe (output, *pipe);return output; }
Signature · 1 line
2.35.1
PATCH v3 29/52 tests/kms_properties: Add support for Bigjoiner
In reply to Bhanuprakash ModemThis patch will add a check to Skip the subtest if a selected pipe/output combo won't support Bigjoiner or 8K mode.
Example:
* Pipe-D wont support a mode > 5K
* To use 8K mode on a pipe then consecutive pipe must be available & free.
V2: - Use updated helper name
--- tests/kms_properties.c | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+)
tests/kms_properties.c +18 -0
@@ -241,6 +241,12 @@ static void plane_properties(igt_display_t *display, bool atomic) found = false;for_each_valid_output_on_pipe (display, pipe, output) { +igt_display_reset (display); + +igt_output_set_pipe (output, pipe); +if (!i915_pipe_output_combo_valid (display)) +continue ; + found_any = found = true;run_plane_property_tests (display, pipe, output, atomic);
@@ -264,6 +270,12 @@ static void crtc_properties(igt_display_t *display, bool atomic) found = false;for_each_valid_output_on_pipe (display, pipe, output) { +igt_display_reset (display); + +igt_output_set_pipe (output, pipe); +if (!i915_pipe_output_combo_valid (display)) +continue ; + found_any_valid_pipe = found = true;run_crtc_property_tests (display, pipe, output, atomic);
@@ -290,6 +302,12 @@ static void connector_properties(igt_display_t *display, bool atomic)if (!igt_pipe_connector_valid (pipe, output))continue ; +igt_display_reset (display); + +igt_output_set_pipe (output, pipe); +if (!i915_pipe_output_combo_valid (display)) +continue ; + found = true;run_connector_property_tests (display, pipe, output, atomic);break ;
Signature · 1 line
2.35.1
PATCH v3 30/52 tests/kms_rmfb: Add support for Bigjoiner
In reply to Bhanuprakash ModemThis patch will add a check to Skip the subtest if a selected pipe/output combo won't support Bigjoiner or 8K mode.
Example:
* Pipe-D wont support a mode > 5K
* To use 8K mode on a pipe then consecutive pipe must be available & free.
V2: - Use updated helper name
--- tests/kms_rmfb.c | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-)
tests/kms_rmfb.c +8 -2
@@ -155,8 +155,15 @@ run_rmfb_test(struct rmfb_data *data, bool reopen) {igt_output_t *output;enum pipe pipe; +igt_display_t *display = &data->display; + +for_each_pipe_with_single_output (display, pipe, output) { +igt_display_reset (display); + +igt_output_set_pipe (output, pipe); +if (!i915_pipe_output_combo_valid (display)) +continue ; -for_each_pipe_with_single_output (&data->display, pipe, output) {igt_dynamic_f ("pipe-%s-%s" ,kmstest_pipe_name (pipe), igt_output_name(output))test_rmfb (data, output, pipe, reopen);
@@ -192,7 +199,6 @@ igt_mainigt_describe (tests[i].description); igt_subtest_with_dynamic(tests[i].name) {run_rmfb_test (&data, tests[i].reopen); - } }
Signature · 1 line
2.35.1
PATCH v3 31/52 tests/kms_rotation_crc: Add support for Bigjoiner
In reply to Bhanuprakash ModemThis patch will add a check to Skip the subtest if a selected pipe/output combo won't support Bigjoiner or 8K mode.
Example:
* Pipe-D wont support a mode > 5K
* To use 8K mode on a pipe then consecutive pipe must be available & free.
V2: - Use updated helper name
--- tests/kms_rotation_crc.c | 25 ++++++++++++++++++++++++- 1 file changed, 24 insertions(+), 1 deletion(-)
tests/kms_rotation_crc.c +24 -1
@@ -198,6 +198,8 @@ static void prepare_crtc(data_t *data, igt_output_t *output, enum pipe pipe,cleanup_crtc (data);igt_output_set_pipe (output, pipe); +igt_require (i915_pipe_output_combo_valid (display)); +igt_plane_set_rotation (plane,IGT_ROTATION_0 );/* create the pipe_crc object for this pipe */
@@ -461,6 +463,7 @@ static void test_plane_rotation(data_t *data, int plane_type, bool test_bad_formigt_output_t *output;enum pipe pipe;int pipe_count =0 , connected_outputs =0 ; +bool found = false;if (is_amdgpu_device (data->gfx_fd)) igt_require(plane_type != DRM_PLANE_TYPE_OVERLAY &&
@@ -478,6 +481,13 @@ static void test_plane_rotation(data_t *data, int plane_type, bool test_bad_formigt_plane_t *plane;int i, j, c; +igt_display_reset (display); + +igt_output_set_pipe (output, pipe); +if (!i915_pipe_output_combo_valid (display)) +continue ; + + found = true; mode =igt_output_get_mode (output);/*
@@ -568,6 +578,7 @@ static void test_plane_rotation(data_t *data, int plane_type, bool test_bad_formigt_pipe_crc_stop (data->pipe_crc); } } +igt_require_f (found,"No valid pipe/output combo found.\n" ); } typedef struct {
@@ -677,6 +688,7 @@ static void test_multi_plane_rotation(data_t *data, enum pipe pipe)bool have_crc;// flag if can use previously logged crc for comparison igt_crc_t crclog[16 ] = {};//4 * 4 rotation crc storage for packed formats char *str1, *str2;// for debug printouts +bool found = false;/* * These are those modes which are tested. For testing feel interesting
@@ -706,11 +718,20 @@ static void test_multi_plane_rotation(data_t *data, enum pipe pipe) {IGT_ROTATION_270, .2f, .4f, I915_FORMAT_MOD_Yf_TILED }, }; +igt_display_require_output (display); +for_each_valid_output_on_pipe (display, pipe, output) {int i, j, k, l, flipsw, fliphw; + +igt_display_reset (display); +igt_output_set_pipe (output, pipe); +if (!i915_pipe_output_combo_valid (display)) +continue ; + + found = true; + mode =igt_output_get_mode (output); -igt_display_require_output (display);igt_display_commit2 (display,COMMIT_ATOMIC ); used_w =TEST_WIDTH (mode);
@@ -890,6 +911,8 @@ static void test_multi_plane_rotation(data_t *data, enum pipe pipe)igt_remove_fb (data->gfx_fd, &planeconfigs[c].fbs[d][MULTIPLANE_ROTATED ]); } } + +igt_require_f (found,"No valid pipe/output combo found.\n" ); } static void test_plane_rotation_exhaust_fences(data_t *data,
Signature · 1 line
2.35.1
PATCH v3 32/52 tests/kms_scaling_modes: Add support for Bigjoiner
In reply to Bhanuprakash ModemThis patch will add a check to Skip the subtest if a selected pipe/output combo won't support Bigjoiner or 8K mode.
Example:
* Pipe-D wont support a mode > 5K
* To use 8K mode on a pipe then consecutive pipe must be available & free.
V2: - Use updated helper name
--- tests/kms_scaling_modes.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-)
tests/kms_scaling_modes.c +6 -2
@@ -93,13 +93,17 @@ static void test_scaling_mode(data_t *data, uint32_t flags)enum pipe pipe;for_each_pipe_with_valid_output (display, pipe, output) { +igt_display_reset (display); +if (!has_scaling_mode (output))continue ; +igt_output_set_pipe (output, pipe); +if (!i915_pipe_output_combo_valid (display)) +continue ; + igt_dynamic_f("%s-pipe-%s", output->name, kmstest_pipe_name(pipe))test_scaling_mode_on_output (display, pipe, output, flags); - -igt_display_reset (display); } }
Signature · 1 line
2.35.1
PATCH v3 33/52 tests/kms_sequence: Add support for Bigjoiner
In reply to Bhanuprakash ModemThis patch will add a check to Skip the subtest if a selected pipe/output combo won't support Bigjoiner or 8K mode.
Example:
* Pipe-D wont support a mode > 5K
* To use 8K mode on a pipe then consecutive pipe must be available & free.
V2: - Use updated helper name
--- tests/kms_sequence.c | 6 ++++++ 1 file changed, 6 insertions(+)
tests/kms_sequence.c +6 -0
@@ -285,6 +285,12 @@ igt_main "drmCrtcQueueSequence"); igt_subtest_with_dynamic_f("%s-%s", f->name, m->name) {for_each_pipe_with_valid_output (&data.display, p, output) { +igt_display_reset (&data.display); + +igt_output_set_pipe (output, p); +if (!i915_pipe_output_combo_valid (&data.display)) +continue ; + igt_dynamic_f("%s-pipe-%s", igt_output_name(output), kmstest_pipe_name(p)) { data.pipe = p; data.output = output;
Signature · 1 line
2.35.1
PATCH v3 34/52 tests/kms_universal_plane: Add support for Bigjoiner
In reply to Bhanuprakash ModemThis patch will add a check to Skip the subtest if a selected pipe/output combo won't support Bigjoiner or 8K mode.
Example:
* Pipe-D wont support a mode > 5K
* To use 8K mode on a pipe then consecutive pipe must be available & free.
V2: - Use updated helper name
--- tests/kms_universal_plane.c | 94 +++++++++++++++++++++++++++++++++---- 1 file changed, 84 insertions(+), 10 deletions(-)
tests/kms_universal_plane.c +84 -10
@@ -366,6 +366,9 @@ sanity_test_pipe(data_t *data, enum pipe pipe, igt_output_t *output)igt_require_pipe (&data->display, pipe); +igt_info ("Using (pipe %s + %s) to run the subtest.\n" , +kmstest_pipe_name (pipe),igt_output_name (output)); +igt_output_set_pipe (output, pipe); mode =igt_output_get_mode (output);
@@ -479,6 +482,9 @@ pageflip_test_pipe(data_t *data, enum pipe pipe, igt_output_t *output)igt_require_pipe (&data->display, pipe); +igt_info ("Using (pipe %s + %s) to run the subtest.\n" , +kmstest_pipe_name (pipe),igt_output_name (output)); +igt_output_set_pipe (output, pipe);pageflip_test_init (&test, output, pipe);
@@ -582,6 +588,9 @@ cursor_leak_test_pipe(data_t *data, enum pipe pipe, igt_output_t *output)igt_require (display->has_cursor_plane);igt_require_intel (data->drm_fd); +igt_info ("Using (pipe %s + %s) to run the subtest.\n" , +kmstest_pipe_name (pipe),igt_output_name (output)); +igt_output_set_pipe (output, pipe); mode =igt_output_get_mode (output);
@@ -710,6 +719,9 @@ gen9_test_pipe(data_t *data, enum pipe pipe, igt_output_t *output)igt_skip_on (data->display_ver <9 );igt_require_pipe (&data->display, pipe); +igt_info ("Using (pipe %s + %s) to run the subtest.\n" , +kmstest_pipe_name (pipe),igt_output_name (output)); +igt_output_set_pipe (output, pipe);gen9_test_init (&test, output, pipe);
@@ -745,6 +757,22 @@ gen9_test_pipe(data_t *data, enum pipe pipe, igt_output_t *output)gen9_test_fini (&test, output); } +static bool +pipe_output_combo_valid (igt_display_t *display, +enum pipe pipe,igt_output_t *output) +{ +bool ret = true; + +igt_display_reset (display); + +igt_output_set_pipe (output, pipe); +if (!i915_pipe_output_combo_valid (display)) + ret = false; +igt_output_set_pipe (output,PIPE_NONE ); + +return ret; +} +static void run_tests_for_pipe (data_t *data,enum pipe pipe) {
@@ -763,34 +791,79 @@ run_tests_for_pipe(data_t *data, enum pipe pipe)igt_describe ("Check the switching between different primary plane fbs with CRTC off" );igt_subtest_f ("universal-plane-pipe-%s-functional" , - kmstest_pipe_name(pipe)) -for_each_valid_output_on_pipe (&data->display, pipe, output) + kmstest_pipe_name(pipe)) { +bool found = false; + +for_each_valid_output_on_pipe (&data->display, pipe, output) { +if (!pipe_output_combo_valid (&data->display, pipe, output)) +continue ; + + found = true;functional_test_pipe (data, pipe, output); + } +igt_require_f (found,"No valid pipe/output combo found.\n" ); + }igt_describe ("Test for scale-up or scale-down using universal plane API without covering CRTC" );igt_subtest_f ("universal-plane-pipe-%s-sanity" , - kmstest_pipe_name(pipe)) -for_each_valid_output_on_pipe (&data->display, pipe, output) + kmstest_pipe_name(pipe)) { +bool found = false; + +for_each_valid_output_on_pipe (&data->display, pipe, output) { +if (!pipe_output_combo_valid (&data->display, pipe, output)) +continue ; + + found = true;sanity_test_pipe (data, pipe, output); + } +igt_require_f (found,"No valid pipe/output combo found.\n" ); + }igt_describe ("Check pageflips while primary plane is disabled before IOCTL or between IOCTL" " and pageflip execution" );igt_subtest_f ("disable-primary-vs-flip-pipe-%s" , - kmstest_pipe_name(pipe)) -for_each_valid_output_on_pipe (&data->display, pipe, output) + kmstest_pipe_name(pipe)) { +bool found = false; + +for_each_valid_output_on_pipe (&data->display, pipe, output) { +if (!pipe_output_combo_valid (&data->display, pipe, output)) +continue ; + + found = true;pageflip_test_pipe (data, pipe, output); + } +igt_require_f (found,"No valid pipe/output combo found.\n" ); + }igt_describe ("Check for cursor leaks after performing cursor operations" );igt_subtest_f ("cursor-fb-leak-pipe-%s" , - kmstest_pipe_name(pipe)) -for_each_valid_output_on_pipe (&data->display, pipe, output) + kmstest_pipe_name(pipe)) { +bool found = false; + +for_each_valid_output_on_pipe (&data->display, pipe, output) { +if (!pipe_output_combo_valid (&data->display, pipe, output)) +continue ; + + found = true;cursor_leak_test_pipe (data, pipe, output); + } +igt_require_f (found,"No valid pipe/output combo found.\n" ); + }igt_describe ("Check if pageflip succeeds in windowed setting" );igt_subtest_f ("universal-plane-gen9-features-pipe-%s" , - kmstest_pipe_name(pipe)) -for_each_valid_output_on_pipe (&data->display, pipe, output) + kmstest_pipe_name(pipe)) { +bool found = false; + +for_each_valid_output_on_pipe (&data->display, pipe, output) { +if (!pipe_output_combo_valid (&data->display, pipe, output)) +continue ; + + found = true;gen9_test_pipe (data, pipe, output); + } +igt_require_f (found,"No valid pipe/output combo found.\n" ); + } }static data_t data;
@@ -808,6 +881,7 @@ igt_mainigt_require_pipe_crc (data.drm_fd);igt_display_require (&data.display, data.drm_fd); +igt_display_require_output (&data.display); }for_each_pipe_static (pipe) {
Signature · 1 line
2.35.1
PATCH v3 35/52 tests/kms_vblank: Add support for Bigjoiner
In reply to Bhanuprakash ModemThis patch will add a check to Skip the subtest if a selected pipe/output combo won't support Bigjoiner or 8K mode.
Example:
* Pipe-D wont support a mode > 5K
* To use 8K mode on a pipe then consecutive pipe must be available & free.
V2: - Use updated helper name
--- tests/kms_vblank.c | 54 ++++++++++++++++++++++++++++++++++++++++++++-- 1 file changed, 52 insertions(+), 2 deletions(-)
tests/kms_vblank.c +52 -2
@@ -175,6 +175,22 @@ static void run_test(data_t *data, void (*testfunc)(data_t *, int, int))cleanup_crtc (data, fd, output); } +static bool +pipe_output_combo_valid (igt_display_t *display, +enum pipe pipe,igt_output_t *output) +{ +bool ret = true; + +igt_display_reset (display); + +igt_output_set_pipe (output, pipe); +if (!i915_pipe_output_combo_valid (display)) + ret = false; +igt_output_set_pipe (output,PIPE_NONE ); + +return ret; +} +static void crtc_id_subtest (data_t *data,int fd) {igt_display_t *display = &data->display;
@@ -188,6 +204,15 @@ static void crtc_id_subtest(data_t *data, int fd)uint64_t val;union drm_wait_vblank vbl; +igt_display_reset (display); + +igt_output_set_pipe (output, p); +if (!i915_pipe_output_combo_valid (display)) +continue ; + +igt_info ("Using (pipe %s + %s) to run the subtest.\n" , +kmstest_pipe_name (p),igt_output_name (output)); + crtc_id = display->pipes[p].crtc_id;if (drmGetCap (display->drm_fd,DRM_CAP_CRTC_IN_VBLANK_EVENT , &val) ==0 ) expected_crtc_id = crtc_id;
@@ -449,10 +474,18 @@ static void run_subtests_for_pipe(data_t *data)igt_subtest_f ("pipe-%s-%s-%s" ,kmstest_pipe_name (data->pipe), f->name, m->name) { +int found =0 ; +for_each_valid_output_on_pipe (&data->display, data->pipe, data->output) { +if (!pipe_output_combo_valid (&data->display, data->pipe, data->output)) +continue ; + data->flags = m->flags |NOHANG ;run_test (data, f->func); + + found++; } +igt_require_f (found,"No valid pipe/output combo found.\n" ); }/* Skip the -hang version if NOHANG flag is set */
@@ -464,13 +497,20 @@ static void run_subtests_for_pipe(data_t *data) kmstest_pipe_name(data->pipe), f->name, m->name) {igt_hang_t hang; +int found =0 ; hang =igt_allow_hang (data->display.drm_fd,0 ,0 );for_each_valid_output_on_pipe (&data->display, data->pipe, data->output) { +if (!pipe_output_combo_valid (&data->display, data->pipe, data->output)) +continue ; + data->flags = m->flags;run_test (data, f->func); + + found++; }igt_disallow_hang (data->display.drm_fd, hang); +igt_require_f (found,"No valid pipe/output combo found.\n" ); } } }
@@ -482,12 +522,22 @@ static void invalid_subtest(data_t *data, int fd)unsigned long valid_flags;igt_display_t * display = &data->display;enum pipe pipe =0 ; -igt_output_t * output =igt_get_single_output_for_pipe (display, pipe); +igt_output_t *output; + +igt_display_reset (display); + + output =igt_get_single_output_for_pipe (display, pipe); +igt_require (output); data->pipe = pipe; data->output = output; +igt_output_set_pipe (output, pipe); -igt_display_require_output_on_pipe (display, pipe); +igt_require (i915_pipe_output_combo_valid (display)); + +igt_info ("Using (pipe %s + %s) to run the subtest.\n" , +kmstest_pipe_name (pipe),igt_output_name (output)); +prepare_crtc (data, fd, output);/* First check all is well with a simple query */
Signature · 1 line
2.35.1
PATCH v3 36/52 tests/kms_vrr: Add support for Bigjoiner
In reply to Bhanuprakash ModemThis patch will add a check to Skip the subtest if a selected pipe/output combo won't support Bigjoiner or 8K mode.
Example:
* Pipe-D wont support a mode > 5K
* To use 8K mode on a pipe then consecutive pipe must be available & free.
V2: - Use updated helper name
--- tests/kms_vrr.c | 6 ++++++ 1 file changed, 6 insertions(+)
tests/kms_vrr.c +6 -0
@@ -444,6 +444,12 @@ run_vrr_test(data_t *data, test_t test, uint32_t flags)for_each_pipe (&data->display, pipe) {if (igt_pipe_connector_valid (pipe, output)) { +igt_display_reset (&data->display); + +igt_output_set_pipe (output, pipe); +if (!i915_pipe_output_combo_valid (&data->display)) +continue ; +igt_dynamic_f ("pipe-%s-%s" , kmstest_pipe_name(pipe), output->name)test (data, pipe, output, flags);
Signature · 1 line
2.35.1
PATCH v3 37/52 tests/i915/kms_big_fb: Add support for Bigjoiner
In reply to Bhanuprakash ModemThis patch will add a check to Skip the subtest if a selected pipe/output combo won't support Bigjoiner or 8K mode.
Example:
* Pipe-D wont support a mode > 5K
* To use 8K mode on a pipe then consecutive pipe must be available & free.
V2: - Use updated helper name
--- tests/i915/kms_big_fb.c | 13 +++++++++++++ 1 file changed, 13 insertions(+)
tests/i915/kms_big_fb.c +13 -0
@@ -397,6 +397,9 @@ static bool test_pipe(data_t *data)igt_plane_t *primary;bool ret = false; +igt_info ("Using (pipe %s + %s) to run the subtest.\n" , +kmstest_pipe_name (data->pipe),igt_output_name (data->output)); +if (data->format ==DRM_FORMAT_C8 && !igt_pipe_obj_has_prop (&data->display.pipes[data->pipe],IGT_CRTC_GAMMA_LUT ))
@@ -472,6 +475,10 @@ max_hw_stride_async_flip_test(data_t *data)igt_crc_t compare_crc, async_crc;igt_require (data->display.is_atomic); + +igt_info ("Using (pipe %s + %s) to run the subtest.\n" , +kmstest_pipe_name (data->pipe),igt_output_name (data->output)); +igt_output_set_pipe (data->output, data->pipe); primary =igt_output_get_plane_type (data->output,DRM_PLANE_TYPE_PRIMARY );
@@ -592,6 +599,12 @@ static void test_scanout(data_t *data) data->format, data->modifier);for_each_pipe_with_valid_output (&data->display, data->pipe, data->output) { +igt_display_reset (&data->display); + +igt_output_set_pipe (data->output, data->pipe); +if (!i915_pipe_output_combo_valid (&data->display)) +continue ; +if (data->async_flip_test) {if (max_hw_stride_async_flip_test (data))return ;
Signature · 1 line
2.35.1
PATCH v3 38/52 tests/i915/kms_big_joiner: Negative tests for Bigjoiner
In reply to Bhanuprakash ModemAdd negative tests to validate Bigjoiner or 8K mode.
Example:
* Pipe-D wont support a mode > 5K
* To use 8K mode on a pipe then consecutive pipe must be available & free.
Kernel should reject the commit/modeset if above conditions won't met.
--- tests/i915/kms_big_joiner.c | 118 ++++++++++++++++++++++++++++++------ 1 file changed, 98 insertions(+), 20 deletions(-)
tests/i915/kms_big_joiner.c +98 -20
@@ -43,6 +43,44 @@ typedef struct { } big_joiner_output[2 ]; } data_t; +static void test_invalid (data_t *data) +{ +igt_output_t *output; +igt_display_t *display = &data->display; +int ret; + +igt_info ("Bigjoiner test on " ); +for_each_connected_output (display, output){ +enum pipe p = output->pending_pipe; +drmModeModeInfo *mode; +igt_pipe_t *pipe; +igt_plane_t *plane; + +if (p ==PIPE_NONE ) +continue ; + + mode =igt_output_get_mode (output); +igt_info ("pipe:%s, output:%s, mode:" ,kmstest_pipe_name (p),igt_output_name (output)); +kmstest_dump_mode (mode); + + pipe = &display->pipes[p]; + plane =igt_pipe_get_plane_type (pipe,DRM_PLANE_TYPE_PRIMARY ); + +igt_plane_set_fb (plane, &data->fb); +igt_fb_set_size (&data->fb, plane, mode->hdisplay, mode->vdisplay); +igt_plane_set_size (plane, mode->hdisplay, mode->vdisplay); + } + +/* This commit is expectd to fail as this pipe is being used for big joiner */ + ret =igt_display_try_commit_atomic (display,DRM_MODE_ATOMIC_TEST_ONLY | +DRM_MODE_ATOMIC_ALLOW_MODESET ,NULL ); + +igt_display_reset (&data->display); +igt_display_commit2 (display,COMMIT_ATOMIC ); + +igt_assert_lt (ret,0 ); +} +static void test_invalid_modeset (data_t *data) {drmModeModeInfo *mode;
@@ -261,19 +299,17 @@ igt_mainigt_require (data.display.is_atomic);for_each_connected_output (&data.display, output) { -if (count <2 ) { -for (i =0 ; i < output->config.connector->count_modes; i++) { - mode = &output->config.connector->modes[i]; -if (mode->hdisplay >MAX_HDISPLAY_PER_PIPE ) { - data.big_joiner_output[count].mode_number = i; - data.big_joiner_output[count].id = output->id; - count++; - - width =max (width, mode->hdisplay); - height =max (height, mode->vdisplay); -break ; - } - } +igt_sort_connector_modes (output->config.connector, + sort_drm_modes_by_res_dsc); + + mode = &output->config.connector->modes[0 ]; +if (mode->hdisplay >MAX_HDISPLAY_PER_PIPE ) { + data.big_joiner_output[count].mode_number = i; + data.big_joiner_output[count].id = output->id; + count++; + + width =max (width, mode->hdisplay); + height =max (height, mode->vdisplay); } valid_output++; }
@@ -303,13 +339,55 @@ igt_mainigt_describe ("Verify if the modeset on the adjoining pipe is rejected " "when the pipe is active with a big joiner modeset" ); igt_subtest_with_dynamic("invalid-modeset") { -igt_require_f (valid_output >1 ,"No valid Second output found\n" ); -for (i =0 ; i < data.n_pipes -1 ; i++) { - data.pipe1 = pipe_seq[i]; - data.pipe2 = pipe_seq[i +1 ]; -igt_dynamic_f ("pipe-%s-%s" ,kmstest_pipe_name (pipe_seq[i]), - kmstest_pipe_name(pipe_seq[i + 1])) -test_invalid_modeset (&data); +enum pipe pipe; + +for_each_pipe_with_valid_output (&data.display, pipe, output) { +igt_display_reset (&data.display); + +igt_sort_connector_modes (output->config.connector, + sort_drm_modes_by_res_dsc); + +igt_output_set_pipe (output, pipe); +igt_output_override_mode (output, + &output->config.connector->modes[0 ]); +if (!igt_check_bigjoiner_support (&data.display)) { + igt_dynamic("single-connector") { +test_invalid (&data); + } + } + } + +igt_display_reset (&data.display); +for_each_pipe (&data.display, pipe) { +for_each_valid_output_on_pipe (&data.display, pipe, output) { +if (output->pending_pipe !=PIPE_NONE ) +continue ; + +igt_sort_connector_modes (output->config.connector, + sort_drm_modes_by_res_dsc); + +igt_output_set_pipe (output, pipe); +igt_output_override_mode (output, + &output->config.connector->modes[0 ]); + +break ; + } + } +if (valid_output >1 && + !igt_check_bigjoiner_support (&data.display)) { + igt_dynamic("multi-connector") { +test_invalid (&data); + } + } + +if (valid_output >1 ) { +for (i =0 ; i < data.n_pipes -1 ; i++) { + data.pipe1 = pipe_seq[i]; + data.pipe2 = pipe_seq[i +1 ]; +igt_dynamic_f ("pipe-%s-%s" ,kmstest_pipe_name (pipe_seq[i]), + kmstest_pipe_name(pipe_seq[i + 1])) +test_invalid_modeset (&data); + } } }
Signature · 1 line
2.35.1
PATCH v4 38/52 tests/i915/kms_big_joiner: Negative tests for Bigjoiner
Add negative tests to validate Bigjoiner or 8K mode.
Example:
* Pipe-D wont support a mode > 5K
* To use 8K mode on a pipe then consecutive pipe must be available & free.
Kernel should reject the commit/modeset if above conditions won't met.
V2:
- Fix redundant negative tests
--- tests/i915/kms_big_joiner.c | 194 ++++++++++++++++-------------------- 1 file changed, 85 insertions(+), 109 deletions(-)
tests/i915/kms_big_joiner.c +85 -109
@@ -45,111 +45,40 @@ typedef struct {static void test_invalid_modeset (data_t *data) { -drmModeModeInfo *mode; +igt_output_t *output;igt_display_t *display = &data->display; -igt_output_t *output, *big_joiner_output =NULL , *second_output =NULL ;int ret; -igt_pipe_t *pipe; -igt_plane_t *plane; - -igt_display_reset (display); - -for_each_connected_output (display, output) { - mode = &output->config.connector->modes[0 ]; - -if (data->big_joiner_output[0 ].id == output->id) { - big_joiner_output = output; - }else if (second_output ==NULL ) { - second_output = output; - } - } - -igt_output_set_pipe (big_joiner_output, data->pipe1); - - mode = &big_joiner_output->config.connector->modes[data->big_joiner_output[0 ].mode_number]; -igt_output_override_mode (big_joiner_output, mode); - pipe = &display->pipes[data->pipe1]; - plane =igt_pipe_get_plane_type (pipe,DRM_PLANE_TYPE_PRIMARY ); +igt_info ("Bigjoiner test on " ); +for_each_connected_output (display, output){ +enum pipe p = output->pending_pipe; +drmModeModeInfo *mode; +igt_pipe_t *pipe; +igt_plane_t *plane; -igt_plane_set_fb (plane, &data->fb); -igt_fb_set_size (&data->fb, plane, mode->hdisplay, mode->vdisplay); -igt_plane_set_size (plane, mode->hdisplay, mode->vdisplay); +if (p ==PIPE_NONE ) +continue ; -igt_display_commit2 (display,COMMIT_ATOMIC ); + mode =igt_output_get_mode (output); +igt_info ("pipe:%s, output:%s, mode:" ,kmstest_pipe_name (p),igt_output_name (output)); +kmstest_dump_mode (mode); -igt_output_set_pipe (second_output, data->pipe2); + pipe = &display->pipes[p]; + plane =igt_pipe_get_plane_type (pipe,DRM_PLANE_TYPE_PRIMARY ); - mode =igt_output_get_mode (second_output); - - pipe = &display->pipes[data->pipe2]; - plane =igt_pipe_get_plane_type (pipe,DRM_PLANE_TYPE_PRIMARY ); - -igt_plane_set_fb (plane, &data->fb); -igt_fb_set_size (&data->fb, plane, mode->hdisplay, mode->vdisplay); -igt_plane_set_size (plane, mode->hdisplay, mode->vdisplay); +igt_plane_set_fb (plane, &data->fb); +igt_fb_set_size (&data->fb, plane, mode->hdisplay, mode->vdisplay); +igt_plane_set_size (plane, mode->hdisplay, mode->vdisplay); + }/* This commit is expectd to fail as this pipe is being used for big joiner */ ret =igt_display_try_commit_atomic (display,DRM_MODE_ATOMIC_TEST_ONLY |DRM_MODE_ATOMIC_ALLOW_MODESET ,NULL ); -igt_assert_lt (ret,0 ); - -igt_output_set_pipe (big_joiner_output,PIPE_NONE ); -igt_output_set_pipe (second_output,PIPE_NONE ); - - pipe = &display->pipes[data->pipe1]; - plane =igt_pipe_get_plane_type (pipe,DRM_PLANE_TYPE_PRIMARY ); - -/* -* Do not explicitly set the plane of the second output to NULL, -* as it is the adjacent pipe to the big joiner output and -* setting the big joiner plane to NULL will take care of this. -*/ -igt_plane_set_fb (plane,NULL ); -igt_display_commit2 (display,COMMIT_ATOMIC ); -igt_output_override_mode (big_joiner_output,NULL ); - -igt_output_set_pipe (second_output, data->pipe2); - - mode =igt_output_get_mode (second_output); - - pipe = &display->pipes[data->pipe2]; - plane =igt_pipe_get_plane_type (pipe,DRM_PLANE_TYPE_PRIMARY ); - -igt_plane_set_fb (plane, &data->fb); -igt_fb_set_size (&data->fb, plane, mode->hdisplay, mode->vdisplay); -igt_plane_set_size (plane, mode->hdisplay, mode->vdisplay); +igt_display_reset (&data->display);igt_display_commit2 (display,COMMIT_ATOMIC ); -igt_output_set_pipe (big_joiner_output, data->pipe1); - - mode = &big_joiner_output->config.connector->modes[data->big_joiner_output[0 ].mode_number]; -igt_output_override_mode (big_joiner_output, mode); - - pipe = &display->pipes[data->pipe1]; - plane =igt_pipe_get_plane_type (pipe,DRM_PLANE_TYPE_PRIMARY ); - -igt_plane_set_fb (plane, &data->fb); -igt_fb_set_size (&data->fb, plane, mode->hdisplay, mode->vdisplay); -igt_plane_set_size (plane, mode->hdisplay, mode->vdisplay); - -/* This commit is expected to fail as the adjacent pipe is already in use*/ - ret =igt_display_try_commit_atomic (display,DRM_MODE_ATOMIC_TEST_ONLY | -DRM_MODE_ATOMIC_ALLOW_MODESET ,NULL );igt_assert_lt (ret,0 ); - -igt_output_set_pipe (big_joiner_output,PIPE_NONE ); -igt_output_set_pipe (second_output,PIPE_NONE ); -igt_plane_set_fb (plane,NULL ); - - pipe = &display->pipes[data->pipe2]; - plane =igt_pipe_get_plane_type (pipe,DRM_PLANE_TYPE_PRIMARY ); -igt_plane_set_fb (plane,NULL ); - -igt_display_commit2 (display,COMMIT_ATOMIC ); - -igt_output_override_mode (big_joiner_output,NULL ); }static void test_basic_modeset (data_t *data)
@@ -261,19 +190,17 @@ igt_mainigt_require (data.display.is_atomic);for_each_connected_output (&data.display, output) { -if (count <2 ) { -for (i =0 ; i < output->config.connector->count_modes; i++) { - mode = &output->config.connector->modes[i]; -if (mode->hdisplay >MAX_HDISPLAY_PER_PIPE ) { - data.big_joiner_output[count].mode_number = i; - data.big_joiner_output[count].id = output->id; - count++; - - width =max (width, mode->hdisplay); - height =max (height, mode->vdisplay); -break ; - } - } +igt_sort_connector_modes (output->config.connector, + sort_drm_modes_by_res_dsc); + + mode = &output->config.connector->modes[0 ]; +if (mode->hdisplay >MAX_HDISPLAY_PER_PIPE ) { + data.big_joiner_output[count].mode_number = i; + data.big_joiner_output[count].id = output->id; + count++; + + width =max (width, mode->hdisplay); + height =max (height, mode->vdisplay); } valid_output++; }
@@ -303,14 +230,63 @@ igt_mainigt_describe ("Verify if the modeset on the adjoining pipe is rejected " "when the pipe is active with a big joiner modeset" ); igt_subtest_with_dynamic("invalid-modeset") { -igt_require_f (valid_output >1 ,"No valid Second output found\n" ); -for (i =0 ; i < data.n_pipes -1 ; i++) { - data.pipe1 = pipe_seq[i]; - data.pipe2 = pipe_seq[i +1 ]; -igt_dynamic_f ("pipe-%s-%s" ,kmstest_pipe_name (pipe_seq[i]), - kmstest_pipe_name(pipe_seq[i + 1])) + data.pipe1 = pipe_seq[j -1 ]; + +igt_display_reset (&data.display); +for_each_connected_output (&data.display, output) { +igt_sort_connector_modes (output->config.connector, + sort_drm_modes_by_res_dsc); + +if (data.big_joiner_output[0 ].id != output->id) +continue ; + +igt_sort_connector_modes (output->config.connector, + sort_drm_modes_by_res_dsc); + +igt_output_set_pipe (output, data.pipe1); +igt_output_override_mode (output, &output->config.connector->modes[0 ]); + +igt_assert (!igt_check_bigjoiner_support (&data.display)); + +igt_dynamic_f ("pipe-%s-%s" , +kmstest_pipe_name (data.pipe1), + igt_output_name(output))test_invalid_modeset (&data); } + +if (valid_output >1 ) { +for (i =0 ; i < data.n_pipes -1 ; i++) { +igt_output_t *first_output =NULL , *second_output =NULL ; + + data.pipe1 = pipe_seq[i]; + data.pipe2 = pipe_seq[i +1 ]; + +igt_display_reset (&data.display); +for_each_connected_output (&data.display, output) { +igt_sort_connector_modes (output->config.connector, + sort_drm_modes_by_res_dsc); + +if (data.big_joiner_output[0 ].id == output->id) { + first_output = output; +igt_output_set_pipe (output, data.pipe1); +igt_output_override_mode (output, &output->config.connector->modes[0 ]); + }else if (second_output ==NULL ) { + second_output = output; +igt_output_set_pipe (output, data.pipe2); +igt_output_override_mode (output, &output->config.connector->modes[0 ]); + } + } + +igt_assert (!igt_check_bigjoiner_support (&data.display)); + +igt_dynamic_f ("pipe-%s-%s-pipe-%s-%s" , +kmstest_pipe_name (data.pipe1), +igt_output_name (first_output), +kmstest_pipe_name (data.pipe2), + igt_output_name(second_output)) +test_invalid_modeset (&data); + } + } }igt_describe ("Verify simultaneous modeset on 2 big joiner outputs" );
--
2.37.3
Re: [igt-dev] [i-g-t V4 38/52] tests/i915/kms_big_joiner: Negative tests for Bigjoiner
Quoted 188 lines · Bhanuprakash Modem
Add negative tests to validate Bigjoiner or 8K mode.
Example:
* Pipe-D wont support a mode > 5K
* To use 8K mode on a pipe then consecutive pipe must be available & free.Kernel should reject the commit/modeset if above conditions won't met.
V2:
- Fix redundant negative testsSigned-off-by Bhanuprakash Modem <[email protected]>--- tests/i915/kms_big_joiner.c | 194 ++++++++++++++++-------------------- 1 file changed, 85 insertions(+), 109 deletions(-)tests/i915/kms_big_joiner.c +30
-105@@ -45,111 +45,40 @@ typedef struct {static void test_invalid_modeset (data_t *data) { -drmModeModeInfo *mode; +igt_output_t *output;igt_display_t *display = &data->display; -igt_output_t *output, *big_joiner_output =NULL , *second_output =NULL ;int ret; -igt_pipe_t *pipe; -igt_plane_t *plane; - -igt_display_reset (display); - -for_each_connected_output (display, output) { - mode = &output->config.connector->modes[0 ]; - -if (data->big_joiner_output[0 ].id == output->id) { - big_joiner_output = output; - }else if (second_output ==NULL ) { - second_output = output; - } - } - -igt_output_set_pipe (big_joiner_output, data->pipe1); - - mode = &big_joiner_output->config.connector->modes[data->big_joiner_output[0 ].mode_number]; -igt_output_override_mode (big_joiner_output, mode); - pipe = &display->pipes[data->pipe1]; - plane =igt_pipe_get_plane_type (pipe,DRM_PLANE_TYPE_PRIMARY ); +igt_info ("Bigjoiner test on " ); +for_each_connected_output (display, output){ +enum pipe p = output->pending_pipe; +drmModeModeInfo *mode; +igt_pipe_t *pipe; +igt_plane_t *plane; -igt_plane_set_fb (plane, &data->fb); -igt_fb_set_size (&data->fb, plane, mode->hdisplay, mode->vdisplay); -igt_plane_set_size (plane, mode->hdisplay, mode->vdisplay); +if (p ==PIPE_NONE ) +continue ; -igt_display_commit2 (display,COMMIT_ATOMIC ); + mode =igt_output_get_mode (output); +igt_info ("pipe:%s, output:%s, mode:" ,kmstest_pipe_name (p),igt_output_name (output)); +kmstest_dump_mode (mode); -igt_output_set_pipe (second_output, data->pipe2); + pipe = &display->pipes[p]; + plane =igt_pipe_get_plane_type (pipe,DRM_PLANE_TYPE_PRIMARY ); - mode =igt_output_get_mode (second_output); - - pipe = &display->pipes[data->pipe2]; - plane =igt_pipe_get_plane_type (pipe,DRM_PLANE_TYPE_PRIMARY ); - -igt_plane_set_fb (plane, &data->fb); -igt_fb_set_size (&data->fb, plane, mode->hdisplay, mode->vdisplay); -igt_plane_set_size (plane, mode->hdisplay, mode->vdisplay); +igt_plane_set_fb (plane, &data->fb); +igt_fb_set_size (&data->fb, plane, mode->hdisplay, mode->vdisplay); +igt_plane_set_size (plane, mode->hdisplay, mode->vdisplay); + }/* This commit is expectd to fail as this pipe is being used for big joiner */ ret =igt_display_try_commit_atomic (display,DRM_MODE_ATOMIC_TEST_ONLY |DRM_MODE_ATOMIC_ALLOW_MODESET ,NULL ); -igt_assert_lt (ret,0 ); - -igt_output_set_pipe (big_joiner_output,PIPE_NONE ); -igt_output_set_pipe (second_output,PIPE_NONE ); - - pipe = &display->pipes[data->pipe1]; - plane =igt_pipe_get_plane_type (pipe,DRM_PLANE_TYPE_PRIMARY ); - -/* -* Do not explicitly set the plane of the second output to NULL, -* as it is the adjacent pipe to the big joiner output and -* setting the big joiner plane to NULL will take care of this. -*/ -igt_plane_set_fb (plane,NULL ); -igt_display_commit2 (display,COMMIT_ATOMIC ); -igt_output_override_mode (big_joiner_output,NULL ); - -igt_output_set_pipe (second_output, data->pipe2); - - mode =igt_output_get_mode (second_output); - - pipe = &display->pipes[data->pipe2]; - plane =igt_pipe_get_plane_type (pipe,DRM_PLANE_TYPE_PRIMARY ); - -igt_plane_set_fb (plane, &data->fb); -igt_fb_set_size (&data->fb, plane, mode->hdisplay, mode->vdisplay); -igt_plane_set_size (plane, mode->hdisplay, mode->vdisplay); +igt_display_reset (&data->display);igt_display_commit2 (display,COMMIT_ATOMIC ); -igt_output_set_pipe (big_joiner_output, data->pipe1); - - mode = &big_joiner_output->config.connector->modes[data->big_joiner_output[0 ].mode_number]; -igt_output_override_mode (big_joiner_output, mode); - - pipe = &display->pipes[data->pipe1]; - plane =igt_pipe_get_plane_type (pipe,DRM_PLANE_TYPE_PRIMARY ); - -igt_plane_set_fb (plane, &data->fb); -igt_fb_set_size (&data->fb, plane, mode->hdisplay, mode->vdisplay); -igt_plane_set_size (plane, mode->hdisplay, mode->vdisplay); - -/* This commit is expected to fail as the adjacent pipe is already in use*/ - ret =igt_display_try_commit_atomic (display,DRM_MODE_ATOMIC_TEST_ONLY | -DRM_MODE_ATOMIC_ALLOW_MODESET ,NULL );igt_assert_lt (ret,0 ); - -igt_output_set_pipe (big_joiner_output,PIPE_NONE ); -igt_output_set_pipe (second_output,PIPE_NONE ); -igt_plane_set_fb (plane,NULL ); - - pipe = &display->pipes[data->pipe2]; - plane =igt_pipe_get_plane_type (pipe,DRM_PLANE_TYPE_PRIMARY ); -igt_plane_set_fb (plane,NULL ); - -igt_display_commit2 (display,COMMIT_ATOMIC ); - -igt_output_override_mode (big_joiner_output,NULL ); }static void test_basic_modeset (data_t *data)@@ -261,19 +190,17 @@ igt_mainigt_require (data.display.is_atomic);for_each_connected_output (&data.display, output) { -if (count <2 ) { -for (i =0 ; i < output->config.connector->count_modes; i++) { - mode = &output->config.connector->modes[i]; -if (mode->hdisplay >MAX_HDISPLAY_PER_PIPE ) { - data.big_joiner_output[count].mode_number = i; - data.big_joiner_output[count].id = output->id; - count++; - - width =max (width, mode->hdisplay); - height =max (height, mode->vdisplay); -break ; - } - } +igt_sort_connector_modes (output->config.connector, + sort_drm_modes_by_res_dsc); + + mode = &output->config.connector->modes[0 ]; +if (mode->hdisplay >MAX_HDISPLAY_PER_PIPE ) { + data.big_joiner_output[count].mode_number = i; + data.big_joiner_output[count].id = output->id; + count++; + + width =max (width, mode->hdisplay); + height =max (height, mode->vdisplay); } valid_output++; }@@ -303,14 +230,63 @@ igt_mainigt_describe ("Verify if the modeset on the adjoining pipe is rejected " "when the pipe is active with a big joiner modeset" ); igt_subtest_with_dynamic("invalid-modeset") { -igt_require_f (valid_output >1 ,"No valid Second output found\n" ); -for (i =0 ; i < data.n_pipes -1 ; i++) {
tests/i915/kms_big_joiner.c igt_main · line 238
Quoted 10 lines
tests/i915/kms_big_joiner.c +6
-4- data.pipe1 = pipe_seq[i]; - data.pipe2 = pipe_seq[i +1 ]; -igt_dynamic_f ("pipe-%s-%s" ,kmstest_pipe_name (pipe_seq[i]), -kmstest_pipe_name (pipe_seq[i +1 ])) + data.pipe1 = pipe_seq[j -1 ]; + +igt_display_reset (&data.display); +for_each_connected_output (&data.display, output) { +igt_sort_connector_modes (output->config.connector, + sort_drm_modes_by_res_dsc);
Please remove this as this looks redundant. With this removed, the patch LGTM.
Quoted 57 lines
tests/i915/kms_big_joiner.c +49
-1+ +if (data.big_joiner_output[0 ].id != output->id) +continue ; + +igt_sort_connector_modes (output->config.connector, + sort_drm_modes_by_res_dsc); + +igt_output_set_pipe (output, data.pipe1); +igt_output_override_mode (output, &output->config.connector->modes[0 ]); + +igt_assert (!igt_check_bigjoiner_support (&data.display)); + +igt_dynamic_f ("pipe-%s-%s" , +kmstest_pipe_name (data.pipe1), + igt_output_name(output))test_invalid_modeset (&data); } + +if (valid_output >1 ) { +for (i =0 ; i < data.n_pipes -1 ; i++) { +igt_output_t *first_output =NULL , *second_output =NULL ; + + data.pipe1 = pipe_seq[i]; + data.pipe2 = pipe_seq[i +1 ]; + +igt_display_reset (&data.display); +for_each_connected_output (&data.display, output) { +igt_sort_connector_modes (output->config.connector, + sort_drm_modes_by_res_dsc); + +if (data.big_joiner_output[0 ].id == output->id) { + first_output = output; +igt_output_set_pipe (output, data.pipe1); +igt_output_override_mode (output, &output->config.connector->modes[0 ]); + }else if (second_output ==NULL ) { + second_output = output; +igt_output_set_pipe (output, data.pipe2); +igt_output_override_mode (output, &output->config.connector->modes[0 ]); + } + } + +igt_assert (!igt_check_bigjoiner_support (&data.display)); + +igt_dynamic_f ("pipe-%s-%s-pipe-%s-%s" , +kmstest_pipe_name (data.pipe1), +igt_output_name (first_output), +kmstest_pipe_name (data.pipe2), + igt_output_name(second_output)) +test_invalid_modeset (&data); + } + } }igt_describe ("Verify simultaneous modeset on 2 big joiner outputs" ); --2.37.3
PATCH v3 39/52 tests/i915/kms_busy: Add support for Bigjoiner
In reply to Bhanuprakash ModemThis patch will add a check to Skip the subtest if a selected pipe/output combo won't support Bigjoiner or 8K mode.
Example:
* Pipe-D wont support a mode > 5K
* To use 8K mode on a pipe then consecutive pipe must be available & free.
V2: - Use updated helper name
--- tests/i915/kms_busy.c | 105 ++++++++++++++++++++++++++++-------------- 1 file changed, 71 insertions(+), 34 deletions(-)
tests/i915/kms_busy.c +71 -34
@@ -32,15 +32,12 @@ IGT_TEST_DESCRIPTION("Basic check of KMS ABI with busy framebuffers.");static bool all_pipes = false; -static igt_output_t * -set_fb_on_crtc (igt_display_t *dpy,int pipe,struct igt_fb *fb) +static void +set_fb_on_crtc (igt_display_t *dpy,int pipe, +igt_output_t *output,struct igt_fb *fb) {drmModeModeInfoPtr mode;igt_plane_t *primary; -igt_output_t *output; - - output =igt_get_single_output_for_pipe (dpy, pipe); -igt_require (output);igt_output_set_pipe (output, pipe); mode =igt_output_get_mode (output);
@@ -51,8 +48,6 @@ set_fb_on_crtc(igt_display_t *dpy, int pipe, struct igt_fb *fb) primary =igt_output_get_plane_type (output,DRM_PLANE_TYPE_PRIMARY );igt_plane_set_fb (primary, fb); - -return output; }static void do_cleanup_display (igt_display_t *dpy)
@@ -136,18 +131,23 @@ static void flip_to_fb(igt_display_t *dpy, int pipe,put_ahnd (ahnd); } -static void test_flip (igt_display_t *dpy,int pipe,bool modeset) +static void test_flip (igt_display_t *dpy,int pipe, +igt_output_t *output,bool modeset) {struct igt_fb fb[2 ];int warmup[] = {0 ,1 ,0 ,-1 };struct timespec tv = {}; -igt_output_t *output;int timeout;if (modeset)igt_require (dpy->is_atomic); - output =set_fb_on_crtc (dpy, pipe, &fb[0 ]); +igt_info ("Using (pipe %s + %s) to run the subtest.\n" , +kmstest_pipe_name (pipe),igt_output_name (output)); + +igt_display_reset (dpy); + +set_fb_on_crtc (dpy, pipe, output, &fb[0 ]);igt_display_commit2 (dpy,COMMIT_LEGACY ); igt_create_pattern_fb(dpy->drm_fd,
@@ -224,13 +224,18 @@ static void test_atomic_commit_hang(igt_display_t *dpy, igt_plane_t *primary, }static void test_hang (igt_display_t *dpy, -enum pipe pipe,bool modeset,bool hang_newfb) +enum pipe pipe,igt_output_t *output, +bool modeset,bool hang_newfb) {struct igt_fb fb[2 ]; -igt_output_t *output;igt_plane_t *primary; - output =set_fb_on_crtc (dpy, pipe, &fb[0 ]); +igt_info ("Using (pipe %s + %s) to run the subtest.\n" , +kmstest_pipe_name (pipe),igt_output_name (output)); + +igt_display_reset (dpy); + +set_fb_on_crtc (dpy, pipe, output, &fb[0 ]);igt_display_commit2 (dpy,COMMIT_ATOMIC ); primary =igt_output_get_plane_type (output,DRM_PLANE_TYPE_PRIMARY );
@@ -265,16 +270,22 @@ static void test_hang(igt_display_t *dpy,igt_remove_fb (dpy->drm_fd, &fb[0 ]); } -static void test_pageflip_modeset_hang (igt_display_t *dpy,enum pipe pipe) +static void +test_pageflip_modeset_hang (igt_display_t *dpy, +igt_output_t *output,enum pipe pipe) {struct igt_fb fb;struct drm_event_vblank ev; -igt_output_t *output;igt_plane_t *primary;igt_spin_t *t;uint64_t ahnd =get_reloc_ahnd (dpy->drm_fd,0 ); - output =set_fb_on_crtc (dpy, pipe, &fb); +igt_info ("Using (pipe %s + %s) to run the subtest.\n" , +kmstest_pipe_name (pipe),igt_output_name (output)); + +igt_display_reset (dpy); + +set_fb_on_crtc (dpy, pipe, output, &fb); primary =igt_output_get_plane_type (output,DRM_PLANE_TYPE_PRIMARY );igt_display_commit2 (dpy, dpy->is_atomic ?COMMIT_ATOMIC :COMMIT_LEGACY );
@@ -299,6 +310,22 @@ static void test_pageflip_modeset_hang(igt_display_t *dpy, enum pipe pipe)igt_remove_fb (dpy->drm_fd, &fb); } +static bool +pipe_output_combo_valid (igt_display_t *dpy, +igt_output_t *output,enum pipe pipe) +{ +bool ret = true; + +igt_display_reset (dpy); + +igt_output_set_pipe (output, pipe); +if (!i915_pipe_output_combo_valid (dpy)) + ret = false; +igt_output_set_pipe (output,PIPE_NONE ); + +return ret; +} +static int opt_handler (int opt,int opt_index,void *data) {switch (opt) {
@@ -319,7 +346,8 @@ igt_main_args("e", NULL, help_str, opt_handler, NULL) {igt_display_t display = { .drm_fd =-1 , .n_pipes =IGT_MAX_PIPES }; -enum pipe active_pipes[IGT_MAX_PIPES ]; +enum pipe pipe, active_pipes[IGT_MAX_PIPES ]; +igt_output_t *output;uint32_t last_pipe =0 ;int i;struct {
@@ -338,7 +366,6 @@ igt_main_args("e", NULL, help_str, opt_handler, NULL) igt_fixture {int fd =drm_open_driver_master (DRIVER_INTEL ); -enum pipe pipe;igt_require_gem (fd);gem_require_mmap_device_coherent (fd);
@@ -358,63 +385,72 @@ igt_main_args("e", NULL, help_str, opt_handler, NULL)igt_describe ("Test for basic check of KMS ABI with busy framebuffers." ); igt_subtest_with_dynamic("basic") { /* just run on the first pipe */ -enum pipe pipe; +for_each_pipe_with_single_output (&display, pipe, output) { +if (!pipe_output_combo_valid (&display, output, pipe)) +continue ; -for_each_pipe (&display, pipe) { igt_dynamic("flip") -test_flip (&display, pipe, false); +test_flip (&display, pipe, output, false); igt_dynamic("modeset") -test_flip (&display, pipe, true); +test_flip (&display, pipe, output, true);break ; } } igt_subtest_with_dynamic("basic-hang") { -enum pipe pipe;igt_hang_t hang =igt_allow_hang (display.drm_fd,0 ,0 ); errno =0 ; -for_each_pipe (&display, pipe) { +for_each_pipe_with_single_output (&display, pipe, output) { +if (!pipe_output_combo_valid (&display, output, pipe)) +continue ; +if (!all_pipes && pipe != active_pipes[0 ] && pipe != active_pipes[last_pipe])continue ; igt_dynamic_f("flip-pipe-%s", kmstest_pipe_name(pipe)) -test_flip (&display, pipe, false); +test_flip (&display, pipe, output, false); igt_dynamic_f("modeset-pipe-%s", kmstest_pipe_name(pipe)) -test_flip (&display, pipe, true); +test_flip (&display, pipe, output, true); }igt_disallow_hang (display.drm_fd, hang); } igt_subtest_with_dynamic("extended-pageflip-modeset-hang-oldfb") { -enum pipe pipe;igt_hang_t hang =igt_allow_hang (display.drm_fd,0 ,0 ); errno =0 ; -for_each_pipe (&display, pipe) { +for_each_pipe_with_single_output (&display, pipe, output) { +if (!pipe_output_combo_valid (&display, output, pipe)) +continue ; +if (!all_pipes && pipe != active_pipes[0 ] && pipe != active_pipes[last_pipe])continue ; igt_dynamic_f("pipe-%s", kmstest_pipe_name(pipe)) -test_pageflip_modeset_hang (&display, pipe); +test_pageflip_modeset_hang (&display, output, pipe); }igt_disallow_hang (display.drm_fd, hang); }for (i =0 ; i <sizeof (tests) /sizeof (tests[0 ]); i++) { +igt_fixture + igt_require(display.is_atomic); + igt_subtest_with_dynamic(tests[i].name) { -enum pipe pipe;igt_hang_t hang; errno =0 ; -igt_require (display.is_atomic); hang =igt_allow_hang (display.drm_fd,0 ,0 ); -for_each_pipe (&display, pipe) { +for_each_pipe_with_single_output (&display, pipe, output) { +if (!pipe_output_combo_valid (&display, output, pipe)) +continue ; +if (!all_pipes && pipe != active_pipes[0 ] && pipe != active_pipes[last_pipe])continue ;
@@ -423,7 +459,8 @@ igt_main_args("e", NULL, help_str, opt_handler, NULL)if (tests[i].reset)igt_set_module_param_int (display.drm_fd,"force_reset_modeset_test" ,1 ); -test_hang (&display, pipe, tests[i].modeset, tests[i].hang_newfb); +test_hang (&display, pipe, output, + tests[i].modeset, tests[i].hang_newfb);if (tests[i].reset)igt_set_module_param_int (display.drm_fd,"force_reset_modeset_test" ,0 );
Signature · 1 line
2.35.1
PATCH v3 40/52 tests/i915/kms_ccs: Add support for Bigjoiner
In reply to Bhanuprakash ModemThis patch will add a check to Skip the subtest if a selected pipe/output combo won't support Bigjoiner or 8K mode.
Example:
* Pipe-D wont support a mode > 5K
* To use 8K mode on a pipe then consecutive pipe must be available & free.
V2: - Use updated helper name
--- tests/i915/kms_ccs.c | 18 +++++++++++++----- 1 file changed, 13 insertions(+), 5 deletions(-)
tests/i915/kms_ccs.c +13 -5
@@ -589,12 +589,21 @@ static int test_ccs(data_t *data)static void test_output (data_t *data,const int testnum) { igt_fixture { +bool found = false; + data->flags = tests[testnum].flags; - data->output =igt_get_single_output_for_pipe (&data->display, - data->pipe); -igt_require (data->output); -igt_output_set_pipe (data->output, data->pipe); +for_each_valid_output_on_pipe (&data->display, data->pipe, data->output) { +igt_display_reset (&data->display); + +igt_output_set_pipe (data->output, data->pipe); +if (i915_pipe_output_combo_valid (&data->display)) { + found = true; +break ; + } + + } +igt_require_f (found,"No valid pipe/output combo found.\n" ); }for (int i =0 ; i <ARRAY_SIZE (ccs_modifiers); i++) {
@@ -610,7 +619,6 @@ static void test_output(data_t *data, const int testnum)igt_subtest_f ("pipe-%s-%s-%s" ,kmstest_pipe_name (data->pipe), tests[testnum].testname, ccs_modifiers[i].str) {int valid_tests =0 ; -igt_require (data->output);if (data->flags ==TEST_RANDOM )igt_info ("Testing with seed %d\n" , data->seed);
Signature · 1 line
2.35.1
PATCH v3 41/52 tests/i915/kms_cdclk: Add support for Bigjoiner
In reply to Bhanuprakash ModemAs many 2x tests are currently running on Pipe-A & B only, those tests will always SKIP if there is any 8K supported panel in the config. Instead of Skipping the test, add some intelligence to the subtest to identify the valid pipe/output combo to execute the subtest.
V2: - Use updated helper name
--- tests/i915/kms_cdclk.c | 93 +++++++++++++++++++++++------------------- 1 file changed, 51 insertions(+), 42 deletions(-)
tests/i915/kms_cdclk.c +51 -42
@@ -243,20 +243,17 @@ static void test_mode_transition_on_all_outputs(data_t *data)int debugfs_fd = data->debugfs_fd;drmModeModeInfo *mode, *mode_hi, *mode_lo;igt_output_t *output; -int valid_outputs =0 ;int cdclk_ref, cdclk_new;uint16_t width =0 , height =0 ;struct igt_fb fb;igt_pipe_t *pipe;igt_plane_t *plane; -int i =0 , j =0 ; +enum pipe p, active_pipes[IGT_MAX_PIPES ]; +int i =0 , active_pipe_count =0 ;do_cleanup_display (display);igt_display_reset (display); -for_each_connected_output (&data->display, output) - valid_outputs++; -for_each_connected_output (display, output) { mode =igt_output_get_mode (output);igt_assert (mode);
@@ -269,52 +266,59 @@ static void test_mode_transition_on_all_outputs(data_t *data)igt_create_pattern_fb (data->drm_fd, width, height,DRM_FORMAT_XRGB8888 ,DRM_FORMAT_MOD_LINEAR , &fb); - i =0 ; +for_each_connected_output (display, output) { - pipe = &display->pipes[i]; - plane =igt_pipe_get_plane_type (pipe,DRM_PLANE_TYPE_PRIMARY ); +for_each_pipe (display, p) { + mode =NULL ; - mode =NULL ; +igt_output_set_pipe (output, p); + mode =igt_output_get_mode (output); +igt_assert (mode); -igt_output_set_pipe (output, i); - mode =igt_output_get_mode (output); -igt_assert (mode); + mode_hi =get_highres_mode (output); +igt_require (mode_hi !=NULL ); + +igt_output_override_mode (output, mode_hi); +if (!i915_pipe_output_combo_valid (display)) { +igt_output_set_pipe (output,PIPE_NONE ); +continue ; + } - mode_lo =get_lowres_mode (output); + active_pipes[active_pipe_count++] = p; + pipe = &display->pipes[p]; + plane =igt_pipe_get_plane_type (pipe,DRM_PLANE_TYPE_PRIMARY ); +igt_plane_set_fb (plane, &fb); +igt_fb_set_size (&fb, plane, mode_hi->hdisplay, mode_hi->vdisplay); +igt_plane_set_size (plane, mode_hi->hdisplay, mode_hi->vdisplay); -igt_output_override_mode (output, mode_lo); -igt_plane_set_fb (plane, &fb); -igt_fb_set_size (&fb, plane, mode_lo->hdisplay, mode_lo->vdisplay); -igt_plane_set_size (plane, mode_lo->hdisplay, mode_lo->vdisplay); - i++; +break ; + } }igt_display_commit2 (display,COMMIT_ATOMIC ); - cdclk_ref =get_current_cdclk_freq (debugfs_fd); + cdclk_new =get_current_cdclk_freq (debugfs_fd); - j =0 ;for_each_connected_output (display, output) { - pipe = &display->pipes[j]; - plane =igt_pipe_get_plane_type (pipe,DRM_PLANE_TYPE_PRIMARY ); +for (i =0 ; i < active_pipe_count; i++) { + pipe = &display->pipes[active_pipes[i]]; + plane =igt_pipe_get_plane_type (pipe,DRM_PLANE_TYPE_PRIMARY ); - mode =NULL ; + mode =NULL ; +igt_output_set_pipe (output, i); + mode =igt_output_get_mode (output); +igt_assert (mode); -igt_output_set_pipe (output, j); - mode =igt_output_get_mode (output); -igt_assert (mode); - - mode_hi =get_highres_mode (output); -igt_require (mode_hi !=NULL ); + mode_lo =get_lowres_mode (output); -igt_output_override_mode (output, mode_hi); -igt_plane_set_fb (plane, &fb); -igt_fb_set_size (&fb, plane, mode_hi->hdisplay, mode_hi->vdisplay); -igt_plane_set_size (plane, mode_hi->hdisplay, mode_hi->vdisplay); - j++; +igt_output_override_mode (output, mode_lo); +igt_plane_set_fb (plane, &fb); +igt_fb_set_size (&fb, plane, mode_lo->hdisplay, mode_lo->vdisplay); +igt_plane_set_size (plane, mode_lo->hdisplay, mode_lo->vdisplay); + } }igt_display_commit2 (display,COMMIT_ATOMIC ); - cdclk_new =get_current_cdclk_freq (debugfs_fd); + cdclk_ref =get_current_cdclk_freq (debugfs_fd);igt_info ("CD clock frequency %d -> %d\n" , cdclk_ref, cdclk_new);/* cdclk should bump */
@@ -332,13 +336,18 @@ static void run_cdclk_test(data_t *data, uint32_t flags)enum pipe pipe;for_each_pipe_with_valid_output (display, pipe, output) { - igt_dynamic_f("pipe-%s-%s", kmstest_pipe_name(pipe), output->name) -if (igt_pipe_connector_valid (pipe, output)) { -if (flags &TEST_PLANESCALING ) -test_plane_scaling (data, pipe, output); -if (flags &TEST_MODETRANSITION ) -test_mode_transition (data, pipe, output); - } +igt_output_set_pipe (output, pipe); +if (!i915_pipe_output_combo_valid (display)) { +igt_output_set_pipe (output,PIPE_NONE ); +continue ; + } + + igt_dynamic_f("pipe-%s-%s", kmstest_pipe_name(pipe), output->name) { +if (flags &TEST_PLANESCALING ) +test_plane_scaling (data, pipe, output); +if (flags &TEST_MODETRANSITION ) +test_mode_transition (data, pipe, output); + } } }
Signature · 1 line
2.35.1
PATCH v3 42/52 tests/i915/kms_draw_crc: Add support for Bigjoiner
In reply to Bhanuprakash ModemThis patch will add a check to Skip the subtest if a selected pipe/output combo won't support Bigjoiner or 8K mode.
Example:
* Pipe-D wont support a mode > 5K
* To use 8K mode on a pipe then consecutive pipe must be available & free.
V2: - Use updated helper name
--- tests/i915/kms_draw_crc.c | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-)
tests/i915/kms_draw_crc.c +5 -6
@@ -59,17 +59,16 @@ static void find_modeset_params(void) {enum pipe pipe; -igt_display_reset (&display); -igt_display_commit (&display); -for_each_pipe_with_valid_output (&display, pipe, output) { -igt_output_set_pipe (output, pipe); +igt_display_reset (&display); - mode =igt_output_get_mode (output); -if (!mode) +igt_output_set_pipe (output, pipe); +if (!i915_pipe_output_combo_valid (&display))continue ; + mode =igt_output_get_mode (output); pipe_crc =igt_pipe_crc_new (drm_fd, pipe,INTEL_PIPE_CRC_SOURCE_AUTO ); +/*Only one pipe/output is enough*/ break ; }
Signature · 1 line
2.35.1
PATCH v3 43/52 tests/i915/kms_fence_pin_leak: Add support for Bigjoiner
In reply to Bhanuprakash ModemThis patch will add a check to Skip the subtest if a selected pipe/output combo won't support Bigjoiner or 8K mode.
Example:
* Pipe-D wont support a mode > 5K
* To use 8K mode on a pipe then consecutive pipe must be available & free.
V2: - Use updated helper name
--- tests/i915/kms_fence_pin_leak.c | 9 +++++++++ 1 file changed, 9 insertions(+)
tests/i915/kms_fence_pin_leak.c +9 -0
@@ -124,6 +124,9 @@ static void run_single_test(data_t *data, enum pipe pipe, igt_output_t *output)struct igt_fb fb[2 ];int i; +igt_info ("Using (pipe %s + %s) to run the subtest.\n" , +kmstest_pipe_name (pipe),igt_output_name (output)); +igt_output_set_pipe (output, pipe); mode =igt_output_get_mode (output);
@@ -196,6 +199,12 @@ static void run_test(data_t *data)enum pipe p;for_each_pipe_with_valid_output (display, p, output) { +igt_display_reset (display); + +igt_output_set_pipe (output, p); +if (!i915_pipe_output_combo_valid (display)) +continue ; +run_single_test (data, p, output);return ;/* one time ought to be enough */
Signature · 1 line
2.35.1
PATCH v3 44/52 tests/i915/kms_flip_scaled_crc: Add support for Bigjoiner
In reply to Bhanuprakash ModemThis patch will add a check to Skip the subtest if a selected pipe/output combo won't support Bigjoiner or 8K mode.
Example:
* Pipe-D wont support a mode > 5K
* To use 8K mode on a pipe then consecutive pipe must be available & free.
V2: - Use updated helper name
--- tests/i915/kms_flip_scaled_crc.c | 13 ++++++++++++- 1 file changed, 12 insertions(+), 1 deletion(-)
tests/i915/kms_flip_scaled_crc.c +12 -1
@@ -648,8 +648,13 @@ igt_mainfor_each_pipe (&data.display, pipe) {bool found = false;for_each_valid_output_on_pipe (&data.display, pipe, output) { +igt_display_reset (&data.display); + modetoset =find_mode (&data, output); -if (modetoset) { +igt_output_set_pipe (output, pipe); +igt_output_override_mode (output, modetoset); + +if (modetoset &&i915_pipe_output_combo_valid (&data.display)) { found = true; igt_dynamic_f("pipe-%s-valid-mode", kmstest_pipe_name(pipe))run_tests (&data, index, pipe, output, modetoset);
@@ -658,6 +663,12 @@ igt_main }if (!found) {for_each_valid_output_on_pipe (&data.display, pipe, output) { +igt_display_reset (&data.display); + +igt_output_set_pipe (output, pipe); +if (!i915_pipe_output_combo_valid (&data.display)) +continue ; + igt_dynamic_f("pipe-%s-default-mode", kmstest_pipe_name(pipe))run_tests (&data, index, pipe, output, modetoset); }
Signature · 1 line
2.35.1
PATCH v3 45/52 tests/i915/kms_flip_tiling: Add support for Bigjoiner
In reply to Bhanuprakash ModemThis patch will add a check to Skip the subtest if a selected pipe/output combo won't support Bigjoiner or 8K mode.
Example:
* Pipe-D wont support a mode > 5K
* To use 8K mode on a pipe then consecutive pipe must be available & free.
V2: - Use updated helper name
--- tests/i915/kms_flip_tiling.c | 7 +++++++ 1 file changed, 7 insertions(+)
tests/i915/kms_flip_tiling.c +7 -0
@@ -78,6 +78,9 @@ test_flip_tiling(data_t *data, enum pipe pipe, igt_output_t *output, uint64_t moigt_crc_t reference_crc, crc;int fb_id, ret; +igt_info ("Using (pipe %s + %s) to run the subtest.\n" , +kmstest_pipe_name (pipe),igt_output_name (output)); +memcpy (&data->old_fb, &data->fb,sizeof (data->fb)); mode =igt_output_get_mode (output);
@@ -194,8 +197,12 @@ igt_mainfor_each_pipe_with_valid_output (&data.display, pipe, output) {igt_plane_t *plane; +igt_display_reset (&data.display);pipe_crc_free (&data); +igt_output_set_pipe (output, pipe); +if (!i915_pipe_output_combo_valid (&data.display)) +continue ; plane =igt_output_get_plane_type (output,DRM_PLANE_TYPE_PRIMARY );
Signature · 1 line
2.35.1
PATCH v3 46/52 tests/i915/kms_frontbuffer_tracking: Add support for Bigjoiner
In reply to Bhanuprakash ModemAs many 2x tests are currently running on Pipe-A & B only, those tests will always SKIP if there is any 8K supported panel in the config. Instead of Skipping the test, add some intelligence to the subtest to identify the valid pipe/output combo to execute the subtest.
V2: - Use updated helper name
--- tests/i915/kms_frontbuffer_tracking.c | 16 ++++++++++++---- 1 file changed, 12 insertions(+), 4 deletions(-)
tests/i915/kms_frontbuffer_tracking.c +12 -4
@@ -403,15 +403,23 @@ static bool find_connector(bool edp_only, bool pipe_a,if (pipe_a && pipe !=PIPE_A )continue ; -if (output == forbidden_output || pipe == forbidden_pipe) +if (output == forbidden_output || pipe == forbidden_pipe) { +igt_output_set_pipe (output, pipe); +igt_output_override_mode (output,connector_get_mode (output)); +continue ; + }if (c->connector_type == DRM_MODE_CONNECTOR_eDP && opt.no_edp)continue ; - *ret_output = output; - *ret_pipe = pipe; -return true; +igt_output_set_pipe (output, pipe); +igt_output_override_mode (output,connector_get_mode (output)); +if (i915_pipe_output_combo_valid (&drm.display)) { + *ret_output = output; + *ret_pipe = pipe; +return true; + } }return false;
Signature · 1 line
2.35.1
PATCH v3 47/52 tests/i915/kms_mmap_write_crc: Add support for Bigjoiner
In reply to Bhanuprakash ModemThis patch will add a check to Skip the subtest if a selected pipe/output combo won't support Bigjoiner or 8K mode.
Example:
* Pipe-D wont support a mode > 5K
* To use 8K mode on a pipe then consecutive pipe must be available & free.
V2: - Use updated helper name
--- tests/i915/kms_mmap_write_crc.c | 6 ++++++ 1 file changed, 6 insertions(+)
tests/i915/kms_mmap_write_crc.c +6 -0
@@ -276,6 +276,12 @@ igt_main_args("n", NULL, NULL, opt_handler, NULL) igt_subtest_with_dynamic("main") {for_each_pipe_with_valid_output (&data.display, pipe, output) { +igt_display_reset (&data.display); + +igt_output_set_pipe (output, pipe); +if (!i915_pipe_output_combo_valid (&data.display)) +continue ; +igt_dynamic_f ("pipe-%s-%s" ,kmstest_pipe_name (pipe), igt_output_name(output)) { data.output = output;
Signature · 1 line
2.35.1
PATCH v3 48/52 tests/i915/kms_psr2_sf: Add support for Bigjoiner
In reply to Bhanuprakash ModemThis patch will add a check to Skip the subtest if a selected pipe/output combo won't support Bigjoiner or 8K mode.
Example:
* Pipe-D wont support a mode > 5K
* To use 8K mode on a pipe then consecutive pipe must be available & free.
V2: - Use updated helper name
--- tests/i915/kms_psr2_sf.c | 7 +++++++ 1 file changed, 7 insertions(+)
tests/i915/kms_psr2_sf.c +7 -0
@@ -115,7 +115,11 @@ static void setup_output(data_t *data)if (c->connector_type != DRM_MODE_CONNECTOR_eDP)continue ; +igt_display_reset (display);igt_output_set_pipe (output, pipe); +if (!i915_pipe_output_combo_valid (display)) +continue ; + data->output = output; data->mode =igt_output_get_mode (output);
@@ -127,6 +131,9 @@ static void display_init(data_t *data) {igt_display_require (&data->display, data->drm_fd);setup_output (data); + +igt_require_f (data->output,"No available output found\n" ); +igt_require_f (data->mode,"No available mode found on %s\n" , data->output->name); }static void display_fini (data_t *data)
Signature · 1 line
2.35.1
PATCH v3 49/52 tests/i915/kms_psr2_su: Add support for Bigjoiner
In reply to Bhanuprakash ModemThis patch will add a check to Skip the subtest if a selected pipe/output combo won't support Bigjoiner or 8K mode.
Example:
* Pipe-D wont support a mode > 5K
* To use 8K mode on a pipe then consecutive pipe must be available & free.
V2: - Use updated helper name
--- tests/i915/kms_psr2_su.c | 7 +++++++ 1 file changed, 7 insertions(+)
tests/i915/kms_psr2_su.c +7 -0
@@ -104,7 +104,11 @@ static void setup_output(data_t *data)if (c->connector_type != DRM_MODE_CONNECTOR_eDP)continue ; +igt_display_reset (display);igt_output_set_pipe (output, pipe); +if (!i915_pipe_output_combo_valid (display)) +continue ; + data->output = output; data->mode =igt_output_get_mode (output);
@@ -116,6 +120,9 @@ static void display_init(data_t *data) {igt_display_require (&data->display, data->drm_fd);setup_output (data); + +igt_require_f (data->output,"No available output found\n" ); +igt_require_f (data->mode,"No available mode found on %s\n" , data->output->name); }static void display_fini (data_t *data)
Signature · 1 line
2.35.1
PATCH v3 50/52 tests/i915/kms_psr: Add support for Bigjoiner
In reply to Bhanuprakash ModemThis patch will add a check to Skip the subtest if a selected pipe/output combo won't support Bigjoiner or 8K mode.
Example:
* Pipe-D wont support a mode > 5K
* To use 8K mode on a pipe then consecutive pipe must be available & free.
V2: - Use updated helper name
--- tests/i915/kms_psr.c | 4 ++++ 1 file changed, 4 insertions(+)
tests/i915/kms_psr.c +4 -0
@@ -102,7 +102,11 @@ static void setup_output(data_t *data)if (c->connector_type != DRM_MODE_CONNECTOR_eDP)continue ; +igt_display_reset (display);igt_output_set_pipe (output, pipe); +if (!i915_pipe_output_combo_valid (display)) +continue ; + data->crtc_id = output->config.crtc->crtc_id; data->output = output; data->mode =igt_output_get_mode (output);
Signature · 1 line
2.35.1
PATCH v3 51/52 tests/i915/kms_psr_stress_test: Add support for Bigjoiner
In reply to Bhanuprakash ModemThis patch will add a check to Skip the subtest if a selected pipe/output combo won't support Bigjoiner or 8K mode.
Example:
* Pipe-D wont support a mode > 5K
* To use 8K mode on a pipe then consecutive pipe must be available & free.
V2: - Use updated helper name
--- tests/i915/kms_psr_stress_test.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-)
tests/i915/kms_psr_stress_test.c +7 -1
@@ -72,7 +72,13 @@ static void setup_output(data_t *data)if (c->connector_type != DRM_MODE_CONNECTOR_eDP)continue ; +igt_display_reset (display);igt_output_set_pipe (output, pipe); +if (!i915_pipe_output_combo_valid (display)) { +igt_output_set_pipe (output,PIPE_NONE ); +continue ; + } + data->output = output; data->mode =igt_output_get_mode (output);
@@ -374,4 +380,4 @@ igt_mainclose (data.debugfs_fd);close (data.drm_fd); } -} +}
Signature · 1 line
2.35.1
PATCH v3 52/52 tests/i915/kms_pwrite_crc: Add support for Bigjoiner
In reply to Bhanuprakash ModemThis patch will add a check to Skip the subtest if a selected pipe/output combo won't support Bigjoiner or 8K mode.
Example:
* Pipe-D wont support a mode > 5K
* To use 8K mode on a pipe then consecutive pipe must be available & free.
V2: - Use updated helper name
--- tests/i915/kms_pwrite_crc.c | 7 +++++++ 1 file changed, 7 insertions(+)
tests/i915/kms_pwrite_crc.c +7 -0
@@ -110,6 +110,7 @@ static void prepare_crtc(data_t *data)igt_output_t *output = data->output;drmModeModeInfo *mode; +igt_display_reset (display);/* select the pipe we want to use */ igt_output_set_pipe (output, data->pipe);
@@ -160,6 +161,12 @@ static void run_test(data_t *data)enum pipe pipe;for_each_pipe_with_valid_output (display, pipe, output) { +igt_display_reset (display); + +igt_output_set_pipe (output, data->pipe); +if (!i915_pipe_output_combo_valid (display)) +continue ; + data->output = output; data->pipe = pipe;
Signature · 1 line
2.35.1
Patchwork
CI[igt-dev] ✓ Fi.CI.BAT: success for Add IGT support for Bigjoiner (rev2)
In reply to Bhanuprakash Modem== Series Details ==
== Series Details ==
Series: Add IGT support for Bigjoiner (rev2)
URL : https://patchwork.freedesktop.org/series/108183/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_12107 -> IGTPW_7765
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7765/index.html
Participating hosts (40 -> 38)
------------------------------
Missing (2): fi-bdw-samus fi-pnv-d510
Known issues
------------
Here are the changes found in IGTPW_7765 that come from known issues:
### IGT changes ###
#### Possible fixes ####
* igt@i915_selftest@live@reset:
- {bat-rpls-1}: [DMESG-FAIL][1] ([i915#4983]) -> [PASS][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12107/bat-rpls-1/igt@i915_selftest@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7765/bat-rpls-1/igt@i915_selftest@[email protected]
* igt@kms_cursor_legacy@basic-busy-flip-before-cursor@atomic-transitions-varying-size:
- fi-bsw-kefka: [FAIL][3] ([i915#6298]) -> [PASS][4]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12107/fi-bsw-kefka/igt@kms_cursor_legacy@basic-busy-flip-before-cursor@atomic-transitions-varying-size.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7765/fi-bsw-kefka/igt@kms_cursor_legacy@basic-busy-flip-before-cursor@atomic-transitions-varying-size.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[i915#4983]: https://gitlab.freedesktop.org/drm/intel/issues/4983
[i915#6298]: https://gitlab.freedesktop.org/drm/intel/issues/6298
[i915#6367]: https://gitlab.freedesktop.org/drm/intel/issues/6367
Build changes
-------------
* CI: CI-20190529 -> None
* IGT: IGT_6649 -> IGTPW_7765
CI-20190529: 20190529
CI_DRM_12107: 4b7320d052f68c125269d775c916f62f24aad0ab @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_7765: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7765/index.html
IGT_6649: 7d91a6952dadaa9001b662ed60c08ccb8364929d @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7765/index.html
Patchwork
CI[igt-dev] ✗ Fi.CI.IGT: failure for Add IGT support for Bigjoiner (rev2)
In reply to Bhanuprakash Modem== Series Details ==
== Series Details ==
Series: Add IGT support for Bigjoiner (rev2)
URL : https://patchwork.freedesktop.org/series/108183/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_12107_full -> IGTPW_7765_full
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with IGTPW_7765_full absolutely need to be verified manually.
If you think the reported changes have nothing to do with the changes introduced in IGTPW_7765_full, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7765/index.html
Participating hosts (10 -> 8)
------------------------------
Additional (1): shard-rkl
Missing (3): pig-skl-6260u pig-kbl-iris pig-glk-j5005
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in IGTPW_7765_full:
### IGT changes ###
#### Possible regressions ####
* igt@kms_ccs@pipe-a-crc-sprite-planes-basic-4_tiled_dg2_rc_ccs:
- shard-iclb: NOTRUN -> [SKIP][1] +1 similar issue
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7765/shard-iclb8/igt@kms_ccs@pipe-a-crc-sprite-planes-basic-4_tiled_dg2_rc_ccs.html
#### Warnings ####
* igt@kms_ccs@pipe-a-crc-sprite-planes-basic-y_tiled_gen12_rc_ccs:
- shard-iclb: [SKIP][2] ([fdo#109278]) -> [SKIP][3] +74 similar issues
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12107/shard-iclb4/igt@kms_ccs@pipe-a-crc-sprite-planes-basic-y_tiled_gen12_rc_ccs.html
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7765/shard-iclb7/igt@kms_ccs@pipe-a-crc-sprite-planes-basic-y_tiled_gen12_rc_ccs.html
* igt@kms_display_modes@extended-mode-basic:
- shard-tglb: [SKIP][4] ([fdo#109274]) -> [SKIP][5]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12107/shard-tglb5/igt@[email protected]
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7765/shard-tglb2/igt@[email protected]
- shard-iclb: [SKIP][6] ([fdo#109274]) -> [SKIP][7]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12107/shard-iclb1/igt@[email protected]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7765/shard-iclb5/igt@[email protected]
#### Suppressed ####
The following results come from untrusted machines, tests, or statuses. They do not affect the overall result.
* igt@kms_ccs@pipe-d-ccs-on-another-bo-y_tiled_gen12_mc_ccs:
- {shard-rkl}: NOTRUN -> [SKIP][8] +8 similar issues
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7765/shard-rkl-6/igt@kms_ccs@pipe-d-ccs-on-another-bo-y_tiled_gen12_mc_ccs.html
New tests
---------
New tests have been introduced between CI_DRM_12107_full and IGTPW_7765_full:
### New IGT tests (12) ###
* igt@kms_display_modes@extended-mode-basic@pipe-a-hdmi-a-1-pipe-b-hdmi-a-2:
- Statuses : 1 pass(s)
- Exec time: [0.83] s
* igt@kms_display_modes@extended-mode-basic@pipe-a-hdmi-a-1-pipe-c-hdmi-a-2:
- Statuses : 1 pass(s)
- Exec time: [1.03] s
* igt@kms_display_modes@extended-mode-basic@pipe-a-hdmi-a-2-pipe-b-hdmi-a-1:
- Statuses : 1 pass(s)
- Exec time: [0.93] s
* igt@kms_display_modes@extended-mode-basic@pipe-a-hdmi-a-2-pipe-c-hdmi-a-1:
- Statuses : 1 pass(s)
- Exec time: [1.01] s
* igt@kms_display_modes@extended-mode-basic@pipe-b-hdmi-a-1-pipe-a-hdmi-a-2:
- Statuses : 1 pass(s)
- Exec time: [0.98] s
* igt@kms_display_modes@extended-mode-basic@pipe-b-hdmi-a-1-pipe-c-hdmi-a-2:
- Statuses : 1 pass(s)
- Exec time: [0.91] s
* igt@kms_display_modes@extended-mode-basic@pipe-b-hdmi-a-2-pipe-a-hdmi-a-1:
- Statuses : 1 pass(s)
- Exec time: [0.98] s
* igt@kms_display_modes@extended-mode-basic@pipe-b-hdmi-a-2-pipe-c-hdmi-a-1:
- Statuses : 1 pass(s)
- Exec time: [0.96] s
* igt@kms_display_modes@extended-mode-basic@pipe-c-hdmi-a-1-pipe-a-hdmi-a-2:
- Statuses : 1 pass(s)
- Exec time: [0.98] s
* igt@kms_display_modes@extended-mode-basic@pipe-c-hdmi-a-1-pipe-b-hdmi-a-2:
- Statuses : 1 pass(s)
- Exec time: [1.04] s
* igt@kms_display_modes@extended-mode-basic@pipe-c-hdmi-a-2-pipe-a-hdmi-a-1:
- Statuses : 1 pass(s)
- Exec time: [0.96] s
* igt@kms_display_modes@extended-mode-basic@pipe-c-hdmi-a-2-pipe-b-hdmi-a-1:
- Statuses : 1 pass(s)
- Exec time: [1.04] s
Known issues
------------
Here are the changes found in IGTPW_7765_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@feature_discovery@psr2:
- shard-iclb: [PASS][9] -> [SKIP][10] ([i915#658])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12107/shard-iclb2/igt@[email protected]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7765/shard-iclb4/igt@[email protected]
* igt@gem_create@create-massive:
- shard-apl: NOTRUN -> [DMESG-WARN][11] ([i915#4991]) +1 similar issue
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7765/shard-apl8/igt@[email protected]
* igt@gem_ctx_exec@basic-nohangcheck:
- shard-tglb: [PASS][12] -> [FAIL][13] ([i915#6268])
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12107/shard-tglb5/igt@[email protected]
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7765/shard-tglb2/igt@[email protected]
* igt@gem_eio@in-flight-10ms:
- shard-tglb: [PASS][14] -> [TIMEOUT][15] ([i915#3063])
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12107/shard-tglb5/igt@[email protected]
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7765/shard-tglb5/igt@[email protected]
* igt@gem_eio@reset-stress:
- shard-tglb: [PASS][16] -> [FAIL][17] ([i915#5784])
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12107/shard-tglb3/igt@[email protected]
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7765/shard-tglb5/igt@[email protected]
* igt@gem_exec_balancer@parallel-keep-in-fence:
- shard-iclb: [PASS][18] -> [SKIP][19] ([i915#4525]) +1 similar issue
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12107/shard-iclb1/igt@[email protected]
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7765/shard-iclb7/igt@[email protected]
* igt@gem_exec_fair@basic-none-rrul@rcs0:
- shard-glk: [PASS][20] -> [FAIL][21] ([i915#2842]) +6 similar issues
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12107/shard-glk5/igt@gem_exec_fair@[email protected]
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7765/shard-glk9/igt@gem_exec_fair@[email protected]
* igt@gem_exec_fair@basic-none-share@rcs0:
- shard-tglb: [PASS][22] -> [FAIL][23] ([i915#2842]) +1 similar issue
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12107/shard-tglb6/igt@gem_exec_fair@[email protected]
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7765/shard-tglb6/igt@gem_exec_fair@[email protected]
* igt@gem_exec_fair@basic-none-solo@rcs0:
- shard-apl: [PASS][24] -> [FAIL][25] ([i915#2842])
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12107/shard-apl1/igt@gem_exec_fair@[email protected]
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7765/shard-apl1/igt@gem_exec_fair@[email protected]
* igt@gem_exec_fair@basic-throttle@rcs0:
- shard-iclb: [PASS][26] -> [FAIL][27] ([i915#2842]) +2 similar issues
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12107/shard-iclb2/igt@gem_exec_fair@[email protected]
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7765/shard-iclb4/igt@gem_exec_fair@[email protected]
* igt@gem_lmem_swapping@verify-ccs:
- shard-apl: NOTRUN -> [SKIP][28] ([fdo#109271] / [i915#4613])
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7765/shard-apl2/igt@[email protected]
* igt@gem_mmap_gtt@fault-concurrent-y:
- shard-snb: [PASS][29] -> [INCOMPLETE][30] ([i915#5161])
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12107/shard-snb5/igt@[email protected]
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7765/shard-snb4/igt@[email protected]
* igt@gem_pread@exhaustion:
- shard-glk: NOTRUN -> [WARN][31] ([i915#2658])
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7765/shard-glk5/igt@[email protected]
* igt@gem_pxp@create-valid-protected-context:
- shard-iclb: NOTRUN -> [SKIP][32] ([i915#4270])
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7765/shard-iclb5/igt@[email protected]
- shard-tglb: NOTRUN -> [SKIP][33] ([i915#4270])
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7765/shard-tglb2/igt@[email protected]
* igt@gem_softpin@evict-single-offset:
- shard-tglb: [PASS][34] -> [FAIL][35] ([i915#4171])
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12107/shard-tglb3/igt@[email protected]
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7765/shard-tglb5/igt@[email protected]
* igt@gem_userptr_blits@dmabuf-unsync:
- shard-tglb: NOTRUN -> [SKIP][36] ([i915#3297])
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7765/shard-tglb5/igt@[email protected]
- shard-iclb: NOTRUN -> [SKIP][37] ([i915#3297])
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7765/shard-iclb4/igt@[email protected]
* igt@i915_pm_dc@dc3co-vpb-simulation:
- shard-apl: NOTRUN -> [SKIP][38] ([fdo#109271] / [i915#658])
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7765/shard-apl1/igt@[email protected]
* igt@i915_selftest@live@hangcheck:
- shard-snb: [PASS][39] -> [INCOMPLETE][40] ([i915#3921])
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12107/shard-snb7/igt@i915_selftest@[email protected]
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7765/shard-snb4/igt@i915_selftest@[email protected]
* igt@i915_suspend@fence-restore-tiled2untiled:
- shard-apl: [PASS][41] -> [DMESG-WARN][42] ([i915#180]) +2 similar issues
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12107/shard-apl1/igt@[email protected]
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7765/shard-apl8/igt@[email protected]
* igt@kms_big_fb@4-tiled-max-hw-stride-32bpp-rotate-180-hflip-async-flip:
- shard-tglb: NOTRUN -> [SKIP][43] ([i915#5286])
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7765/shard-tglb1/igt@kms_big_fb@4-tiled-max-hw-stride-32bpp-rotate-180-hflip-async-flip.html
- shard-iclb: NOTRUN -> [SKIP][44] ([i915#5286])
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7765/shard-iclb5/igt@kms_big_fb@4-tiled-max-hw-stride-32bpp-rotate-180-hflip-async-flip.html
* igt@kms_big_fb@x-tiled-32bpp-rotate-270:
- shard-tglb: NOTRUN -> [SKIP][45] ([fdo#111614])
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7765/shard-tglb2/igt@[email protected]
- shard-iclb: NOTRUN -> [SKIP][46] ([fdo#110725] / [fdo#111614])
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7765/shard-iclb5/igt@[email protected]
* igt@kms_big_fb@x-tiled-addfb:
- shard-apl: [PASS][47] -> [DMESG-WARN][48] ([i915#62]) +16 similar issues
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12107/shard-apl7/igt@[email protected]
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7765/shard-apl8/igt@[email protected]
* igt@kms_big_fb@y-tiled-64bpp-rotate-180:
- shard-glk: [PASS][49] -> [FAIL][50] ([i915#1888] / [i915#5138])
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12107/shard-glk9/igt@[email protected]
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7765/shard-glk3/igt@[email protected]
* igt@kms_big_fb@yf-tiled-16bpp-rotate-0:
- shard-glk: [PASS][51] -> [FAIL][52] ([i915#1888])
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12107/shard-glk6/igt@[email protected]
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7765/shard-glk3/igt@[email protected]
* igt@kms_ccs@pipe-a-crc-sprite-planes-basic-4_tiled_dg2_rc_ccs:
- shard-tglb: NOTRUN -> [SKIP][53] ([i915#3689] / [i915#6095])
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7765/shard-tglb7/igt@kms_ccs@pipe-a-crc-sprite-planes-basic-4_tiled_dg2_rc_ccs.html
* igt@kms_ccs@pipe-b-crc-primary-rotation-180-y_tiled_gen12_mc_ccs:
- shard-apl: NOTRUN -> [SKIP][54] ([fdo#109271] / [i915#3886])
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7765/shard-apl6/igt@kms_ccs@pipe-b-crc-primary-rotation-180-y_tiled_gen12_mc_ccs.html
* igt@kms_ccs@pipe-b-random-ccs-data-yf_tiled_ccs:
- shard-tglb: NOTRUN -> [SKIP][55] ([fdo#111615] / [i915#3689])
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7765/shard-tglb2/igt@kms_ccs@pipe-b-random-ccs-data-yf_tiled_ccs.html
* igt@kms_ccs@pipe-d-bad-rotation-90-y_tiled_gen12_mc_ccs:
- shard-tglb: NOTRUN -> [SKIP][56] ([i915#3689])
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7765/shard-tglb5/igt@kms_ccs@pipe-d-bad-rotation-90-y_tiled_gen12_mc_ccs.html
- shard-iclb: NOTRUN -> [SKIP][57] ([fdo#109278])
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7765/shard-iclb8/igt@kms_ccs@pipe-d-bad-rotation-90-y_tiled_gen12_mc_ccs.html
* igt@kms_chamelium@dp-crc-multiple:
- shard-tglb: NOTRUN -> [SKIP][58] ([fdo#109284] / [fdo#111827])
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7765/shard-tglb6/igt@[email protected]
- shard-glk: NOTRUN -> [SKIP][59] ([fdo#109271] / [fdo#111827])
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7765/shard-glk2/igt@[email protected]
- shard-iclb: NOTRUN -> [SKIP][60] ([fdo#109284] / [fdo#111827])
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7765/shard-iclb3/igt@[email protected]
- shard-snb: NOTRUN -> [SKIP][61] ([fdo#109271] / [fdo#111827])
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7765/shard-snb7/igt@[email protected]
* igt@kms_chamelium@hdmi-hpd-enable-disable-mode:
- shard-apl: NOTRUN -> [SKIP][62] ([fdo#109271] / [fdo#111827]) +2 similar issues
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7765/shard-apl1/igt@[email protected]
* igt@kms_flip@2x-flip-vs-fences:
- shard-tglb: NOTRUN -> [SKIP][63] ([fdo#109274] / [fdo#111825] / [i915#3637])
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7765/shard-tglb7/igt@[email protected]
- shard-iclb: NOTRUN -> [SKIP][64] ([fdo#109274])
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7765/shard-iclb5/igt@[email protected]
* igt@kms_flip_scaled_crc@flip-32bpp-4tile-to-32bpp-4tiledg2rcccs-downscaling@pipe-a-valid-mode:
- shard-iclb: NOTRUN -> [SKIP][65] ([i915#2672]) +9 similar issues
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7765/shard-iclb1/igt@kms_flip_scaled_crc@flip-32bpp-4tile-to-32bpp-4tiledg2rcccs-downscaling@pipe-a-valid-mode.html
* igt@kms_flip_scaled_crc@flip-32bpp-yftile-to-32bpp-yftileccs-downscaling@pipe-a-default-mode:
- shard-iclb: NOTRUN -> [SKIP][66] ([i915#6375])
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7765/shard-iclb2/igt@kms_flip_scaled_crc@flip-32bpp-yftile-to-32bpp-yftileccs-downscaling@pipe-a-default-mode.html
* igt@kms_flip_scaled_crc@flip-64bpp-4tile-to-32bpp-4tile-downscaling@pipe-a-valid-mode:
- shard-tglb: NOTRUN -> [SKIP][67] ([i915#2672])
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7765/shard-tglb7/igt@kms_flip_scaled_crc@flip-64bpp-4tile-to-32bpp-4tile-downscaling@pipe-a-valid-mode.html
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-pri-shrfb-draw-render:
- shard-apl: NOTRUN -> [DMESG-WARN][68] ([i915#62])
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7765/shard-apl8/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-pri-shrfb-draw-render.html
* igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-spr-indfb-move:
- shard-tglb: NOTRUN -> [SKIP][69] ([i915#6497]) +2 similar issues
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7765/shard-tglb7/igt@[email protected]
* igt@kms_frontbuffer_tracking@fbcpsr-2p-scndscrn-spr-indfb-draw-mmap-wc:
- shard-glk: NOTRUN -> [SKIP][70] ([fdo#109271]) +44 similar issues
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7765/shard-glk2/igt@kms_frontbuffer_tracking@fbcpsr-2p-scndscrn-spr-indfb-draw-mmap-wc.html
- shard-iclb: NOTRUN -> [SKIP][71] ([fdo#109280]) +1 similar issue
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7765/shard-iclb1/igt@kms_frontbuffer_tracking@fbcpsr-2p-scndscrn-spr-indfb-draw-mmap-wc.html
* igt@kms_frontbuffer_tracking@psr-2p-primscrn-cur-indfb-onoff:
- shard-tglb: NOTRUN -> [SKIP][72] ([fdo#109280] / [fdo#111825]) +1 similar issue
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7765/shard-tglb6/igt@[email protected]
* igt@kms_plane_alpha_blend@pipe-c-constant-alpha-max:
- shard-apl: NOTRUN -> [FAIL][73] ([fdo#108145] / [i915#265])
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7765/shard-apl8/igt@[email protected]
* igt@kms_plane_scaling@plane-scaler-with-clipping-clamping-pixel-formats@pipe-b-edp-1:
- shard-iclb: [PASS][74] -> [SKIP][75] ([i915#5176]) +1 similar issue
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12107/shard-iclb1/igt@kms_plane_scaling@plane-scaler-with-clipping-clamping-pixel-formats@pipe-b-edp-1.html
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7765/shard-iclb3/igt@kms_plane_scaling@plane-scaler-with-clipping-clamping-pixel-formats@pipe-b-edp-1.html
* igt@kms_plane_scaling@plane-scaler-with-clipping-clamping-rotation@pipe-a-vga-1:
- shard-snb: NOTRUN -> [SKIP][76] ([fdo#109271]) +37 similar issues
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7765/shard-snb5/igt@kms_plane_scaling@[email protected]
* igt@kms_plane_scaling@plane-scaler-with-clipping-clamping-rotation@pipe-c-edp-1:
- shard-iclb: NOTRUN -> [SKIP][77] ([i915#5176]) +2 similar issues
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7765/shard-iclb1/igt@kms_plane_scaling@[email protected]
* igt@kms_plane_scaling@plane-scaler-with-clipping-clamping-rotation@pipe-d-edp-1:
- shard-tglb: NOTRUN -> [SKIP][78] ([i915#5176]) +3 similar issues
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7765/shard-tglb5/igt@kms_plane_scaling@[email protected]
* igt@kms_plane_scaling@planes-upscale-factor-0-25-downscale-factor-0-5@pipe-a-edp-1:
- shard-iclb: [PASS][79] -> [SKIP][80] ([i915#5235]) +2 similar issues
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12107/shard-iclb4/igt@kms_plane_scaling@planes-upscale-factor-0-25-downscale-factor-0-5@pipe-a-edp-1.html
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7765/shard-iclb2/igt@kms_plane_scaling@planes-upscale-factor-0-25-downscale-factor-0-5@pipe-a-edp-1.html
* igt@kms_psr@psr2_no_drrs:
- shard-iclb: NOTRUN -> [SKIP][81] ([fdo#109441]) +1 similar issue
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7765/shard-iclb4/igt@kms_psr@psr2_no_drrs.html
* igt@kms_psr@psr2_sprite_mmap_gtt:
- shard-iclb: [PASS][82] -> [SKIP][83] ([fdo#109441]) +2 similar issues
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12107/shard-iclb2/igt@kms_psr@psr2_sprite_mmap_gtt.html
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7765/shard-iclb6/igt@kms_psr@psr2_sprite_mmap_gtt.html
* igt@kms_psr@psr2_sprite_plane_onoff:
- shard-apl: NOTRUN -> [SKIP][84] ([fdo#109271]) +64 similar issues
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7765/shard-apl2/igt@kms_psr@psr2_sprite_plane_onoff.html
- shard-tglb: NOTRUN -> [FAIL][85] ([i915#132] / [i915#3467]) +1 similar issue
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7765/shard-tglb2/igt@kms_psr@psr2_sprite_plane_onoff.html
* igt@kms_sysfs_edid_timing:
- shard-apl: [PASS][86] -> [DMESG-FAIL][87] ([i915#62])
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12107/shard-apl7/igt@kms_sysfs_edid_timing.html
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7765/shard-apl8/igt@kms_sysfs_edid_timing.html
* igt@kms_vblank@pipe-a-ts-continuation-dpms-suspend:
- shard-snb: [PASS][88] -> [INCOMPLETE][89] ([i915#4939] / [i915#6598])
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12107/shard-snb4/igt@[email protected]
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7765/shard-snb7/igt@[email protected]
* igt@kms_vblank@pipe-d-wait-idle:
- shard-apl: NOTRUN -> [SKIP][90] ([fdo#109271] / [i915#533])
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7765/shard-apl7/igt@[email protected]
* igt@perf_pmu@module-unload:
- shard-snb: [PASS][91] -> [DMESG-WARN][92] ([i915#4528])
[91]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12107/shard-snb2/igt@[email protected]
[92]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7765/shard-snb2/igt@[email protected]
* igt@prime_udl:
- shard-tglb: NOTRUN -> [SKIP][93] ([fdo#109291])
[93]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7765/shard-tglb5/igt@prime_udl.html
- shard-iclb: NOTRUN -> [SKIP][94] ([fdo#109291])
[94]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7765/shard-iclb1/igt@prime_udl.html
* igt@sysfs_clients@create:
- shard-apl: NOTRUN -> [SKIP][95] ([fdo#109271] / [i915#2994])
[95]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7765/shard-apl4/igt@[email protected]
#### Possible fixes ####
* igt@gem_exec_balancer@parallel-bb-first:
- shard-iclb: [SKIP][96] ([i915#4525]) -> [PASS][97]
[96]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12107/shard-iclb6/igt@[email protected]
[97]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7765/shard-iclb4/igt@[email protected]
* igt@gem_exec_fair@basic-flow@rcs0:
- shard-tglb: [FAIL][98] ([i915#2842]) -> [PASS][99]
[98]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12107/shard-tglb2/igt@gem_exec_fair@[email protected]
[99]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7765/shard-tglb3/igt@gem_exec_fair@[email protected]
* igt@gem_exec_fair@basic-none@vcs0:
- shard-glk: [FAIL][100] ([i915#2842]) -> [PASS][101]
[100]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12107/shard-glk9/igt@gem_exec_fair@[email protected]
[101]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7765/shard-glk3/igt@gem_exec_fair@[email protected]
* igt@gen9_exec_parse@allowed-single:
- shard-apl: [DMESG-WARN][102] ([i915#5566] / [i915#716]) -> [PASS][103]
[102]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12107/shard-apl3/igt@[email protected]
[103]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7765/shard-apl6/igt@[email protected]
* igt@i915_pm_dc@dc9-dpms:
- shard-iclb: [SKIP][104] ([i915#4281]) -> [PASS][105]
[104]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12107/shard-iclb3/igt@[email protected]
[105]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7765/shard-iclb8/igt@[email protected]
* igt@i915_pm_rpm@modeset-lpsp-stress:
- shard-iclb: [SKIP][106] -> [PASS][107] +1 similar issue
[106]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12107/shard-iclb1/igt@[email protected]
[107]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7765/shard-iclb6/igt@[email protected]
* igt@i915_selftest@live@hangcheck:
- shard-iclb: [DMESG-WARN][108] ([i915#2867]) -> [PASS][109] +6 similar issues
[108]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12107/shard-iclb1/igt@i915_selftest@[email protected]
[109]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7765/shard-iclb5/igt@i915_selftest@[email protected]
* igt@kms_big_fb@linear-8bpp-rotate-0:
- {shard-tglu}: [DMESG-WARN][110] ([i915#1982]) -> [PASS][111]
[110]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12107/shard-tglu-2/igt@[email protected]
[111]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7765/shard-tglu-3/igt@[email protected]
* igt@kms_cursor_legacy@cursor-vs-flip@atomic-transitions-varying-size:
- shard-iclb: [FAIL][112] ([i915#5072]) -> [PASS][113]
[112]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12107/shard-iclb7/igt@kms_cursor_legacy@[email protected]
[113]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7765/shard-iclb3/igt@kms_cursor_legacy@[email protected]
* igt@kms_cursor_legacy@flip-vs-cursor@atomic-transitions-varying-size:
- shard-glk: [FAIL][114] ([i915#2346]) -> [PASS][115]
[114]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12107/shard-glk2/igt@kms_cursor_legacy@[email protected]
[115]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7765/shard-glk6/igt@kms_cursor_legacy@[email protected]
* igt@kms_flip@flip-vs-suspend-interruptible@c-dp1:
- shard-apl: [DMESG-WARN][116] ([i915#180]) -> [PASS][117]
[116]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12107/shard-apl3/igt@kms_flip@[email protected]
[117]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7765/shard-apl3/igt@kms_flip@[email protected]
* igt@kms_plane_scaling@planes-upscale-20x20-downscale-factor-0-5@pipe-b-edp-1:
- shard-iclb: [SKIP][118] ([i915#5235]) -> [PASS][119] +2 similar issues
[118]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12107/shard-iclb2/igt@kms_plane_scaling@[email protected]
[119]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7765/shard-iclb7/igt@kms_plane_scaling@[email protected]
* igt@kms_psr2_su@page_flip-xrgb8888:
- shard-iclb: [SKIP][120] ([fdo#109642] / [fdo#111068] / [i915#658]) -> [PASS][121]
[120]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12107/shard-iclb6/igt@kms_psr2_su@page_flip-xrgb8888.html
[121]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7765/shard-iclb2/igt@kms_psr2_su@page_flip-xrgb8888.html
* igt@kms_psr@psr2_cursor_plane_move:
- shard-iclb: [SKIP][122] ([fdo#109441]) -> [PASS][123] +1 similar issue
[122]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12107/shard-iclb4/igt@kms_psr@psr2_cursor_plane_move.html
[123]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7765/shard-iclb2/igt@kms_psr@psr2_cursor_plane_move.html
* igt@perf@non-zero-reason:
- shard-iclb: [FAIL][124] ([i915#3089]) -> [PASS][125]
[124]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12107/shard-iclb5/igt@[email protected]
[125]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7765/shard-iclb4/igt@[email protected]
#### Warnings ####
* igt@kms_ccs@pipe-c-crc-primary-rotation-180-y_tiled_gen12_rc_ccs_cc:
- shard-iclb: [SKIP][126] ([fdo#109278] / [i915#3886]) -> [SKIP][127] ([i915#3886]) +51 similar issues
[126]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12107/shard-iclb1/igt@kms_ccs@pipe-c-crc-primary-rotation-180-y_tiled_gen12_rc_ccs_cc.html
[127]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7765/shard-iclb3/igt@kms_ccs@pipe-c-crc-primary-rotation-180-y_tiled_gen12_rc_ccs_cc.html
* igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area:
- shard-iclb: [SKIP][128] ([i915#2920]) -> [SKIP][129] ([fdo#111068] / [i915#658]) +1 similar issue
[128]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12107/shard-iclb2/igt@[email protected]
[129]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7765/shard-iclb4/igt@[email protected]
* igt@runner@aborted:
- shard-apl: ([FAIL][130], [FAIL][131]) ([fdo#109271] / [i915#180] / [i915#4312] / [i915#5257] / [i915#6599]) -> ([FAIL][132], [FAIL][133], [FAIL][134], [FAIL][135], [FAIL][136]) ([i915#180] / [i915#3002] / [i915#4312] / [i915#5257] / [i915#6599])
[130]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12107/shard-apl3/igt@[email protected]
[131]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12107/shard-apl3/igt@[email protected]
[132]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7765/shard-apl8/igt@[email protected]
[133]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7765/shard-apl8/igt@[email protected]
[134]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7765/shard-apl8/igt@[email protected]
[135]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7765/shard-apl1/igt@[email protected]
[136]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7765/shard-apl6/igt@[email protected]
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#103375]: https://bugs.freedesktop.org/show_bug.cgi?id=103375
[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109274]: https://bugs.freedesktop.org/show_bug.cgi?id=109274
[fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278
[fdo#109279]: https://bugs.freedesktop.org/show_bug.cgi?id=109279
[fdo#109280]: https://bugs.freedesktop.org/show_bug.cgi?id=109280
[fdo#109283]: https://bugs.freedesktop.org/show_bug.cgi?id=109283
[fdo#109284]: https://bugs.freedesktop.org/show_bug.cgi?id=109284
[fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285
[fdo#109289]: https://bugs.freedesktop.org/show_bug.cgi?id=109289
[fdo#109291]: https://bugs.freedesktop.org/show_bug.cgi?id=109291
[fdo#109295]: https://bugs.freedesktop.org/show_bug.cgi?id=109295
[fdo#109303]: https://bugs.freedesktop.org/show_bug.cgi?id=109303
[fdo#109308]: https://bugs.freedesktop.org/show_bug.cgi?id=109308
[fdo#109309]: https://bugs.freedesktop.org/show_bug.cgi?id=109309
[fdo#109312]: https://bugs.freedesktop.org/show_bug.cgi?id=109312
[fdo#109313]: https://bugs.freedesktop.org/show_bug.cgi?id=109313
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[fdo#109506]: https://bugs.freedesktop.org/show_bug.cgi?id=109506
[fdo#109642]: https://bugs.freedesktop.org/show_bug.cgi?id=109642
[fdo#110189]: https://bugs.freedesktop.org/show_bug.cgi?id=110189
[fdo#110254]: https://bugs.freedesktop.org/show_bug.cgi?id=110254
[fdo#110542]: https://bugs.freedesktop.org/show_bug.cgi?id=110542
[fdo#110723]: https://bugs.freedesktop.org/show_bug.cgi?id=110723
[fdo#110725]: https://bugs.freedesktop.org/show_bug.cgi?id=110725
[fdo#111068]: https://bugs.freedesktop.org/show_bug.cgi?id=111068
[fdo#111614]: https://bugs.freedesktop.org/show_bug.cgi?id=111614
[fdo#111615]: https://bugs.freedesktop.org/show_bug.cgi?id=111615
[fdo#111656]: https://bugs.freedesktop.org/show_bug.cgi?id=111656
[fdo#111825]: https://bugs.freedesktop.org/show_bug.cgi?id=111825
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[fdo#112283]: https://bugs.freedesktop.org/show_bug.cgi?id=112283
[i915#1063]: https://gitlab.freedesktop.org/drm/intel/issues/1063
[i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
[i915#1155]: https://gitlab.freedesktop.org/drm/intel/issues/1155
[i915#132]: https://gitlab.freedesktop.org/drm/intel/issues/132
[i915#1397]: https://gitlab.freedesktop.org/drm/intel/issues/1397
[i915#1722]: https://gitlab.freedesktop.org/drm/intel/issues/1722
[i915#1769]: https://gitlab.freedesktop.org/drm/intel/issues/1769
[i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180
[i915#1825]: https://gitlab.freedesktop.org/drm/intel/issues/1825
[i915#1839]: https://gitlab.freedesktop.org/drm/intel/issues/1839
[i915#1845]: https://gitlab.freedesktop.org/drm/intel/issues/1845
[i915#1849]: https://gitlab.freedesktop.org/drm/intel/issues/1849
[i915#1888]: https://gitlab.freedesktop.org/drm/intel/issues/1888
[i915#1902]: https://gitlab.freedesktop.org/drm/intel/issues/1902
[i915#1911]: https://gitlab.freedesktop.org/drm/intel/issues/1911
[i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982
[i915#2346]: https://gitlab.freedesktop.org/drm/intel/issues/2346
[i915#2434]: https://gitlab.freedesktop.org/drm/intel/issues/2434
[i915#2435]: https://gitlab.freedesktop.org/drm/intel/issues/2435
[i915#2437]: https://gitlab.freedesktop.org/drm/intel/issues/2437
[i915#2527]: https://gitlab.freedesktop.org/drm/intel/issues/2527
[i915#2530]: https://gitlab.freedesktop.org/drm/intel/issues/2530
[i915#2582]: https://gitlab.freedesktop.org/drm/intel/issues/2582
[i915#265]: https://gitlab.freedesktop.org/drm/intel/issues/265
[i915#2658]: https://gitlab.freedesktop.org/drm/intel/issues/2658
[i915#2672]: https://gitlab.freedesktop.org/drm/intel/issues/2672
[i915#2705]: https://gitlab.freedesktop.org/drm/intel/issues/2705
[i915#280]: https://gitlab.freedesktop.org/drm/intel/issues/280
[i915#2842]: https://gitlab.freedesktop.org/drm/intel/issues/2842
[i915#2856]: https://gitlab.freedesktop.org/drm/intel/issues/2856
[i915#2867]: https://gitlab.freedesktop.org/drm/intel/issues/2867
[i915#2920]: https://gitlab.freedesktop.org/drm/intel/issues/2920
[i915#2994]: https://gitlab.freedesktop.org/drm/intel/issues/2994
[i915#3002]: https://gitlab.freedesktop.org/drm/intel/issues/3002
[i915#3012]: https://gitlab.freedesktop.org/drm/intel/issues/3012
[i915#3063]: https://gitlab.freedesktop.org/drm/intel/issues/3063
[i915#3089]: https://gitlab.freedesktop.org/drm/intel/issues/3089
[i915#3116]: https://gitlab.freedesktop.org/drm/intel/issues/3116
[i915#3281]: https://gitlab.freedesktop.org/drm/intel/issues/3281
[i915#3282]: https://gitlab.freedesktop.org/drm/intel/issues/3282
[i915#3291]: https://gitlab.freedesktop.org/drm/intel/issues/3291
[i915#3297]: https://gitlab.freedesktop.org/drm/intel/issues/3297
[i915#3299]: https://gitlab.freedesktop.org/drm/intel/issues/3299
[i915#3318]: https://gitlab.freedesktop.org/drm/intel/issues/3318
[i915#3359]: https://gitlab.freedesktop.org/drm/intel/issues/3359
[i915#3376]: https://gitlab.freedesktop.org/drm/intel/issues/3376
[i915#3467]: https://gitlab.freedesktop.org/drm/intel/issues/3467
[i915#3528]: https://gitlab.freedesktop.org/drm/intel/issues/3528
[i915#3546]: https://gitlab.freedesktop.org/drm/intel/issues/3546
[i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
[i915#3637]: https://gitlab.freedesktop.org/drm/intel/issues/3637
[i915#3689]: https://gitlab.freedesktop.org/drm/intel/issues/3689
[i915#3708]: https://gitlab.freedesktop.org/drm/intel/issues/3708
[i915#3734]: https://gitlab.freedesktop.org/drm/intel/issues/3734
[i915#3742]: https://gitlab.freedesktop.org/drm/intel/issues/3742
[i915#3826]: https://gitlab.freedesktop.org/drm/intel/issues/3826
[i915#3828]: https://gitlab.freedesktop.org/drm/intel/issues/3828
[i915#3886]: https://gitlab.freedesktop.org/drm/intel/issues/3886
[i915#3921]: https://gitlab.freedesktop.org/drm/intel/issues/3921
[i915#3966]: https://gitlab.freedesktop.org/drm/intel/issues/3966
[i915#3989]: https://gitlab.freedesktop.org/drm/intel/issues/3989
[i915#4070]: https://gitlab.freedesktop.org/drm/intel/issues/4070
[i915#4098]: https://gitlab.freedesktop.org/drm/intel/issues/4098
[i915#4103]: https://gitlab.freedesktop.org/drm/intel/issues/4103
[i915#4171]: https://gitlab.freedesktop.org/drm/intel/issues/4171
[i915#426]: https://gitlab.freedesktop.org/drm/intel/issues/426
[i915#4270]: https://gitlab.freedesktop.org/drm/intel/issues/4270
[i915#4281]: https://gitlab.freedesktop.org/drm/intel/issues/4281
[i915#4312]: https://gitlab.freedesktop.org/drm/intel/issues/4312
[i915#4387]: https://gitlab.freedesktop.org/drm/intel/issues/4387
[i915#4525]: https://gitlab.freedesktop.org/drm/intel/issues/4525
[i915#4528]: https://gitlab.freedesktop.org/drm/intel/issues/4528
[i915#454]: https://gitlab.freedesktop.org/drm/intel/issues/454
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#4877]: https://gitlab.freedesktop.org/drm/intel/issues/4877
[i915#4939]: https://gitlab.freedesktop.org/drm/intel/issues/4939
[i915#4991]: https://gitlab.freedesktop.org/drm/intel/issues/4991
[i915#5072]: https://gitlab.freedesktop.org/drm/intel/issues/5072
[i915#5122]: https://gitlab.freedesktop.org/drm/intel/issues/5122
[i915#5138]: https://gitlab.freedesktop.org/drm/intel/issues/5138
[i915#5161]: https://gitlab.freedesktop.org/drm/intel/issues/5161
[i915#5176]: https://gitlab.freedesktop.org/drm/intel/issues/5176
[i915#5182]: https://gitlab.freedesktop.org/drm/intel/issues/5182
[i915#5235]: https://gitlab.freedesktop.org/drm/intel/issues/5235
[i915#5257]: https://gitlab.freedesktop.org/drm/intel/issues/5257
[i915#5286]: https://gitlab.freedesktop.org/drm/intel/issues/5286
[i915#5289]: https://gitlab.freedesktop.org/drm/intel/issues/5289
[i915#5325]: https://gitlab.freedesktop.org/drm/intel/issues/5325
[i915#5327]: https://gitlab.freedesktop.org/drm/intel/issues/5327
[i915#533]: https://gitlab.freedesktop.org/drm/intel/issues/533
[i915#5461]: https://gitlab.freedesktop.org/drm/intel/issues/5461
[i915#5566]: https://gitlab.freedesktop.org/drm/intel/issues/5566
[i915#5784]: https://gitlab.freedesktop.org/drm/intel/issues/5784
[i915#6095]: https://gitlab.freedesktop.org/drm/intel/issues/6095
[i915#62]: https://gitlab.freedesktop.org/drm/intel/issues/62
[i915#6227]: https://gitlab.freedesktop.org/drm/intel/issues/6227
[i915#6230]: https://gitlab.freedesktop.org/drm/intel/issues/6230
[i915#6245]: https://gitlab.freedesktop.org/drm/intel/issues/6245
[i915#6248]: https://gitlab.freedesktop.org/drm/intel/issues/6248
[i915#6251]: https://gitlab.freedesktop.org/drm/intel/issues/6251
[i915#6268]: https://gitlab.freedesktop.org/drm/intel/issues/6268
[i915#6301]: https://gitlab.freedesktop.org/drm/intel/issues/6301
[i915#6334]: https://gitlab.freedesktop.org/drm/intel/issues/6334
[i915#6344]: https://gitlab.freedesktop.org/drm/intel/issues/6344
[i915#6375]: https://gitlab.freedesktop.org/drm/intel/issues/6375
[i915#6497]: https://gitlab.freedesktop.org/drm/intel/issues/6497
[i915#6524]: https://gitlab.freedesktop.org/drm/intel/issues/6524
[i915#658]: https://gitlab.freedesktop.org/drm/intel/issues/658
[i915#6598]: https://gitlab.freedesktop.org/drm/intel/issues/6598
[i915#6599]: https://gitlab.freedesktop.org/drm/intel/issues/6599
[i915#716]: https://gitlab.freedesktop.org/drm/intel/issues/716
Build changes
-------------
* CI: CI-20190529 -> None
* IGT: IGT_6649 -> IGTPW_7765
* Piglit: piglit_4509 -> None
CI-20190529: 20190529
CI_DRM_12107: 4b7320d052f68c125269d775c916f62f24aad0ab @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_7765: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7765/index.html
IGT_6649: 7d91a6952dadaa9001b662ed60c08ccb8364929d @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7765/index.html
Patchwork
CI[igt-dev] ✗ Fi.CI.BUILD: failure for Add IGT support for Bigjoiner (rev3)
In reply to Bhanuprakash Modem== Series Details ==
== Series Details ==
Series: Add IGT support for Bigjoiner (rev3)
URL : https://patchwork.freedesktop.org/series/108183/
State : failure
== Summary ==
Applying: lib/igt_kms: Add a helper for valid pipe/output constraint
Applying: lib/igt_kms: Bigjoiner check in max_bpc constraint
Applying: tests/kms_async_flips: Add support for Bigjoiner
Applying: tests/kms_atomic: Add support for Bigjoiner
Applying: tests/kms_atomic_interruptible: Add support for Bigjoiner
Applying: tests/kms_atomic_transition: Add support for Bigjoiner
Applying: tests/kms_color_helper: Helper to check Bigjoiner constraint
Applying: tests/kms_color: Add support for Bigjoiner
Applying: tests/chamelium/kms_color_chamelium: Add support for Bigjoiner
Applying: tests/kms_concurrent: Add support for Bigjoiner
Applying: tests/kms_content_protection: Add support for Bigjoiner
Applying: tests/kms_cursor_crc: Add support for Bigjoiner
Applying: tests/kms_cursor_edge_walk: Add support for Bigjoiner
Applying: tests/kms_cursor_legacy: Add support for Bigjoiner
Applying: tests/kms_display_modes: Add support for Bigjoiner
Applying: tests/kms_dp_tiled_display: Add support for Bigjoiner
Applying: tests/kms_flip_event_leak: Add support for Bigjoiner Using index info to reconstruct a base tree...
M tests/kms_flip_event_leak.c
Falling back to patching base and 3-way merge...
Auto-merging tests/kms_flip_event_leak.c
CONFLICT (content): Merge conflict in tests/kms_flip_event_leak.c Patch failed at 0017 tests/kms_flip_event_leak: Add support for Bigjoiner When you have resolved this problem, run "git am --continue". If you prefer to skip this patch, run "git am --skip" instead. To restore the original branch and stop patching, run "git am --abort".