armv8: cache_v8: Fix pgtables setup when MMU is already enabled
PATCH 1/1 armv8: cache_v8: Fix pgtables setup when MMU is already enabled
When MMU is already enabled then dcache_enable() does not call mmu_setup() and so setup_all_pgtables() is also never called.
In this situation when some driver calls mmu_set_region_dcache_behaviour() function then U-Boot crashes with error message:
Emergency page table not setup.
Fix this issue by explicitly calling setup_all_pgtables() in dcache_enable() function near condition for mmu_setup().
This change fixes chainloading U-Boot from U-Boot on Turris Mox board which uses mvneta ethernet driver which calls mmu_set_region_dcache_behaviour().
--- arch/arm/cpu/armv8/cache_v8.c | 4 ++++ 1 file changed, 4 insertions(+)
arch/arm/cpu/armv8/cache_v8.c +4 -0
@@ -503,6 +503,10 @@ void dcache_enable(void)mmu_setup (); } +/* Set up page tables only once (it is done also by mmu_setup()) */ +if (!gd->arch.tlb_fillptr) +setup_all_pgtables (); +set_sctlr (get_sctlr () |CR_C ); }
Signature · 1 line
2.20.1
Quoted 8 lines · On Wed, 14 Sep 2022 13:37:46 +0200 Pali Rohár <[email protected]> wrote:
When MMU is already enabled then
dcache_enable()does not callmmu_setup()and sosetup_all_pgtables()is also never called.In this situation when some driver calls
mmu_set_region_dcache_behaviour()function then U-Boot crashes with error message:Emergency page table not setup.
Quoted 7 lines
Fix this issue by explicitly calling
setup_all_pgtables()indcache_enable()function near condition formmu_setup().This change fixes chainloading U-Boot from U-Boot on Turris Mox board which uses mvneta ethernet driver which calls
mmu_set_region_dcache_behaviour().Signed-off-by Pali Rohár <[email protected]>
Quoted 8 lines · Pali Rohár
When MMU is already enabled then
dcache_enable()does not callmmu_setup()and sosetup_all_pgtables()is also never called.In this situation when some driver calls
mmu_set_region_dcache_behaviour()function then U-Boot crashes with error message:Emergency page table not setup.
Quoted 7 lines
Fix this issue by explicitly calling
setup_all_pgtables()indcache_enable()function near condition formmu_setup().This change fixes chainloading U-Boot from U-Boot on Turris Mox board which uses mvneta ethernet driver which calls
mmu_set_region_dcache_behaviour().Signed-off-by Pali Rohár <[email protected]>
Thanks,
Stefan
Quoted 9 lines
--- arch/arm/cpu/armv8/cache_v8.c | 4 ++++ 1 file changed, 4 insertions(+)arch/arm/cpu/armv8/cache_v8.c +0
-0
arch/arm/cpu/armv8/cache_v8.c void dcache_enable(void) · line 512
Quoted 10 lines
arch/arm/cpu/armv8/cache_v8.c +4
-0@@ -503,6 +503,10 @@ void dcache_enable(void)mmu_setup (); } +/* Set up page tables only once (it is done also by mmu_setup()) */ +if (!gd->arch.tlb_fillptr) +setup_all_pgtables (); +set_sctlr (get_sctlr () |CR_C ); }
Viele Grüße,
Stefan Roese
Signature · 3 lines
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-51 Fax: (+49)-8142-66989-80 Email: [email protected]
Quoted 11 lines · Pali Rohár
When MMU is already enabled then
dcache_enable()does not callmmu_setup()and sosetup_all_pgtables()is also never called.In this situation when some driver calls
mmu_set_region_dcache_behaviour()function then U-Boot crashes with error message:Emergency page table not setup.
Fix this issue by explicitly calling
setup_all_pgtables()indcache_enable()function near condition formmu_setup().
Quoted 6 lines
This change fixes chainloading U-Boot from U-Boot on Turris Mox board which uses mvneta ethernet driver which calls
mmu_set_region_dcache_behaviour().Signed-off-by Pali Rohár <[email protected]>Reviewed-by Marek Behún <[email protected]>Reviewed-by Stefan Roese <[email protected]>
Applied to u-boot/master, thanks!
Signature · 1 line
Tom