Skip to contentSkip to conversation

rootfs.py: Drop FAKEROOT support in exec function

PATCH New Andrei Gherzan 1 participant 1 message Sep 14, 2022

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 rootfs.py: Drop FAKEROOT support in exec function

From: Andrei Gherzan <[email protected]>

The _exec_shell_cmd function is used by a couple of other functions that are ultimatelly called from the create_rootfs function. The latter is used in image bbclass' do_rootfs which is running using the fakeroot support in bitbake. This makes the fakeroot support in _exec_shell_cmd redundant and never actually used.

---
 meta/lib/oe/rootfs.py | 8 +-------
 1 file changed, 1 insertion(+), 7 deletions(-)
meta/lib/oe/rootfs.py +1 -7
index 8587c5db82..890ba5f039 100644
@@ -173,14 +173,8 @@ class Rootfs(object, metaclass=ABCMeta):
         bb.utils.rename(self.image_rootfs + '-orig', self.image_rootfs)
 
     def _exec_shell_cmd(self, cmd):
-        fakerootcmd = self.d.getVar('FAKEROOT')
-        if fakerootcmd is not None:
-            exec_cmd = [fakerootcmd, cmd]
-        else:
-            exec_cmd = cmd
-
         try:
-            subprocess.check_output(exec_cmd, stderr=subprocess.STDOUT)
+            subprocess.check_output(cmd, stderr=subprocess.STDOUT)
         except subprocess.CalledProcessError as e:
             return("Command '%s' returned %d:\n%s" % (e.cmd, e.returncode, e.output))
 
Signature · 1 line
2.25.1