mm/damon: simplify scheme create in lru_sort.c
Subsystems (2)
SeongJae Park
maintainerPATCH v4 1/1 mm/damon: simplify scheme create in lru_sort.c
From: Xin Hao <[email protected]>
In damon_lru_sort_new_hot_scheme() and damon_lru_sort_new_cold_scheme(), they have so much in common, so we can combine them into a single function, and we just need to distinguish their differences.
---
changes from v3
(https://lore.kernel.org/damon/[email protected]/)
- Cosmetic cleanups
Changes from v2
(https://lore.kernel.org/linux-mm/[email protected]/)
- Add static global 'struct damos_access_pattern' stub variable
mm/damon/lru_sort.c | 39 +++++++++++++++++---------------------- 1 file changed, 17 insertions(+), 22 deletions(-)
mm/damon/lru_sort.c +17 -22
@@ -132,6 +132,18 @@ DEFINE_DAMON_MODULES_DAMOS_STATS_PARAMS(damon_lru_sort_cold_stat, lru_sort_tried_cold_regions, lru_sorted_cold_regions, cold_quota_exceeds); +struct damos_access_pattern damon_lru_sort_stub_pattern = { +/* Find regions having PAGE_SIZE or larger size */ + .min_sz_region =PAGE_SIZE , + .max_sz_region =ULONG_MAX , +/* no matter its access frequency */ + .min_nr_accesses =0 , + .max_nr_accesses =UINT_MAX , +/* no matter its age */ + .min_age_region =0 , + .max_age_region =UINT_MAX , +}; +static struct damon_ctx *ctx;static struct damon_target *target;
@@ -157,36 +169,19 @@ static struct damos *damon_lru_sort_new_scheme(/* Create a DAMON-based operation scheme for hot memory regions */ static struct damos *damon_lru_sort_new_hot_scheme (unsigned int hot_thres) { -struct damos_access_pattern pattern = { -/* Find regions having PAGE_SIZE or larger size */ - .min_sz_region =PAGE_SIZE , - .max_sz_region =ULONG_MAX , -/* and accessed for more than the threshold */ - .min_nr_accesses = hot_thres, - .max_nr_accesses =UINT_MAX , -/* no matter its age */ - .min_age_region =0 , - .max_age_region =UINT_MAX , - }; +struct damos_access_pattern pattern = damon_lru_sort_stub_pattern; + pattern.min_nr_accesses = hot_thres;return damon_lru_sort_new_scheme (&pattern,DAMOS_LRU_PRIO ); }/* Create a DAMON-based operation scheme for cold memory regions */ static struct damos *damon_lru_sort_new_cold_scheme (unsigned int cold_thres) { -struct damos_access_pattern pattern = { -/* Find regions having PAGE_SIZE or larger size */ - .min_sz_region =PAGE_SIZE , - .max_sz_region =ULONG_MAX , -/* and not accessed at all */ - .min_nr_accesses =0 , - .max_nr_accesses =0 , -/* for min_age or more micro-seconds */ - .min_age_region = cold_thres, - .max_age_region =UINT_MAX , - }; +struct damos_access_pattern pattern = damon_lru_sort_stub_pattern; + pattern.max_nr_accesses =0 ; + pattern.min_age_region = cold_thres;return damon_lru_sort_new_scheme (&pattern,DAMOS_LRU_DEPRIO ); }
Signature · 1 line
2.25.1
Thanks.
Quoted 86 lines · SeongJae Park
From: Xin Hao <[email protected]>
In
damon_lru_sort_new_hot_scheme()anddamon_lru_sort_new_cold_scheme(), they have so much in common, so we can combine them into a single function, and we just need to distinguish their differences.Suggested-by SeongJae Park <[email protected]>Signed-off-by Xin Hao <[email protected]>Signed-off-by SeongJae Park <[email protected]>---
changes from v3
(https://lore.kernel.org/damon/[email protected]/)
- Cosmetic cleanupsChanges from v2
(https://lore.kernel.org/linux-mm/[email protected]/)
- Add static global 'structdamos_access_pattern' stub variablemm/damon/lru_sort.c | 39 +++++++++++++++++---------------------- 1 file changed, 17 insertions(+), 22 deletions(-)mm/damon/lru_sort.c +17
-22@@ -132,6 +132,18 @@ DEFINE_DAMON_MODULES_DAMOS_STATS_PARAMS(damon_lru_sort_cold_stat, lru_sort_tried_cold_regions, lru_sorted_cold_regions, cold_quota_exceeds); +struct damos_access_pattern damon_lru_sort_stub_pattern = { +/* Find regions having PAGE_SIZE or larger size */ + .min_sz_region =PAGE_SIZE , + .max_sz_region =ULONG_MAX , +/* no matter its access frequency */ + .min_nr_accesses =0 , + .max_nr_accesses =UINT_MAX , +/* no matter its age */ + .min_age_region =0 , + .max_age_region =UINT_MAX , +}; +static struct damon_ctx *ctx;static struct damon_target *target;@@ -157,36 +169,19 @@ static struct damos *damon_lru_sort_new_scheme(/* Create a DAMON-based operation scheme for hot memory regions */ static struct damos *damon_lru_sort_new_hot_scheme (unsigned int hot_thres) { -struct damos_access_pattern pattern = { -/* Find regions having PAGE_SIZE or larger size */ - .min_sz_region =PAGE_SIZE , - .max_sz_region =ULONG_MAX , -/* and accessed for more than the threshold */ - .min_nr_accesses = hot_thres, - .max_nr_accesses =UINT_MAX , -/* no matter its age */ - .min_age_region =0 , - .max_age_region =UINT_MAX , - }; +struct damos_access_pattern pattern = damon_lru_sort_stub_pattern; + pattern.min_nr_accesses = hot_thres;return damon_lru_sort_new_scheme (&pattern,DAMOS_LRU_PRIO ); }/* Create a DAMON-based operation scheme for cold memory regions */ static struct damos *damon_lru_sort_new_cold_scheme (unsigned int cold_thres) { -struct damos_access_pattern pattern = { -/* Find regions having PAGE_SIZE or larger size */ - .min_sz_region =PAGE_SIZE , - .max_sz_region =ULONG_MAX , -/* and not accessed at all */ - .min_nr_accesses =0 , - .max_nr_accesses =0 , -/* for min_age or more micro-seconds */ - .min_age_region = cold_thres, - .max_age_region =UINT_MAX , - }; +struct damos_access_pattern pattern = damon_lru_sort_stub_pattern; + pattern.max_nr_accesses =0 ; + pattern.min_age_region = cold_thres;return damon_lru_sort_new_scheme (&pattern,DAMOS_LRU_DEPRIO ); }