Skip to contentSkip to conversation

dt-bindings: mfd: dlg,da9063: add missing regulator patterns

PATCH Applied Conor Dooley 3 participants 4 messages Sep 16, 2022 – Sep 26, 2022

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 dt-bindings: mfd: dlg,da9063: add missing regulator patterns

From: Conor Dooley <[email protected]>

Commit 5621d3977e29 ("dt-bindings: mfd: Add missing (unevaluated| additional)Properties on child nodes") exposed a flaw in the original binding, where "merged" versions of some regulators were missing, leading to warnings on the HiFive Unmatched Devicetree.

Add the missing patterns (and merge some of the trivial ones).

---
I opted not to include a fixes tag for the conversion since it just converted what was already there. I figured the original text binding is just incomplete rather than "broken", but if you don't agree the fixes tag would be:

Fixes c7f15d43a5c5 ("mfd: devicetree: Add bindings for DA9063")
 Documentation/devicetree/bindings/mfd/dlg,da9063.yaml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Documentation/devicetree/bindings/mfd/dlg,da9063.yaml +1 -1
index 54b47bd4c6aa..e8e74e91070c 100644
@@ -73,7 +73,7 @@ properties:
     type: object
     additionalProperties: false
     patternProperties:
-      "^(ldo([1-9]|1[01])|bcore[1-2]|bpro|bmem|bio|bperi)$":
+      "^(ldo([1-9]|1[01])|bcore([1-2]|s-merged)|b(pro|mem|io|peri)|bmem-bio-merged)$":
         $ref: /schemas/regulator/regulator.yaml
         unevaluatedProperties: false
 
Signature · 1 line
2.37.3
Acked-by on v1 1/1
#1 lore raw
Quoted 10 lines · Conor Dooley

From: Conor Dooley <[email protected]>

Commit 5621d3977e29 ("dt-bindings: mfd: Add missing (unevaluated| additional)Properties on child nodes") exposed a flaw in the original binding, where "merged" versions of some regulators were missing, leading to warnings on the HiFive Unmatched Devicetree.

Add the missing patterns (and merge some of the trivial ones).

Quoted 8 lines

---
I opted not to include a fixes tag for the conversion since it just converted what was already there. I figured the original text binding is just incomplete rather than "broken", but if you don't agree the fixes tag would be:

Fixes c7f15d43a5c5 ("mfd: devicetree: Add bindings for DA9063")
 Documentation/devicetree/bindings/mfd/dlg,da9063.yaml | 2 +-

Best regards,
Krzysztof

#2 lore raw
Quoted 18 lines · Krzysztof Kozlowski
Quoted 17 lines · Conor Dooley

From: Conor Dooley <[email protected]>

Commit 5621d3977e29 ("dt-bindings: mfd: Add missing (unevaluated| additional)Properties on child nodes") exposed a flaw in the original binding, where "merged" versions of some regulators were missing, leading to warnings on the HiFive Unmatched Devicetree.

Add the missing patterns (and merge some of the trivial ones).

---
I opted not to include a fixes tag for the conversion since it just converted what was already there. I figured the original text binding is just incomplete rather than "broken", but if you don't agree the fixes tag would be:

Fixes c7f15d43a5c5 ("mfd: devicetree: Add bindings for DA9063")
Quoted 5 lines
Quoted 1 line
 Documentation/devicetree/bindings/mfd/dlg,da9063.yaml | 2 +-

Hey Lee,
Is it too late to pick this up for 6.1?
It's the last remaining dt warning in for riscv.
Thanks,
Conor

maintainer Applied
#3 lore raw
In reply to Conor Dooley
Quoted 15 lines · Conor Dooley

From: Conor Dooley <[email protected]>

Commit 5621d3977e29 ("dt-bindings: mfd: Add missing (unevaluated| additional)Properties on child nodes") exposed a flaw in the original binding, where "merged" versions of some regulators were missing, leading to warnings on the HiFive Unmatched Devicetree.

Add the missing patterns (and merge some of the trivial ones).

---
I opted not to include a fixes tag for the conversion since it just converted what was already there. I figured the original text binding is just incomplete rather than "broken", but if you don't agree the fixes tag would be:

Quoted 4 lines
Fixes c7f15d43a5c5 ("mfd: devicetree: Add bindings for DA9063")
 Documentation/devicetree/bindings/mfd/dlg,da9063.yaml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Applied, thanks.

Signature · 1 line
Lee Jones [李琼斯]