Skip to contentSkip to conversation

scsi: make SCSI_MOD depend on BLOCK for cleaner .config files

PATCH Applied Lukas Bulwahn 3 participants 3 messages Sep 19, 2022 – Sep 25, 2022

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 scsi: make SCSI_MOD depend on BLOCK for cleaner .config files

SCSI_MOD is a helper config symbol for configuring RAID_ATTRS properly, i.e., RAID_ATTRS needs to be m when SCSI=m.

This helper config symbol SCSI_MOD still shows up even in kernel configurations that do not select the block subsystem and where SCSI is not even a configuration option mentioned and selectable.

Make this SCSI_MOD depend on BLOCK, so that it only shows up when it is slightly relevant in the kernel configuration.

---
 drivers/scsi/Kconfig | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)
drivers/scsi/Kconfig +4 -3
index 955cb69a5418..03e71e3d5e5b 100644
@@ -2,9 +2,10 @@
 menu "SCSI device support"
 
 config SCSI_MOD
-       tristate
-       default y if SCSI=n || SCSI=y
-       default m if SCSI=m
+	tristate
+	default y if SCSI=n || SCSI=y
+	default m if SCSI=m
+	depends on BLOCK
 
 config RAID_ATTRS
 	tristate "RAID Transport Class"
Signature · 1 line
2.17.1
Reviewed-by on v1 1/1
#1 lore raw
Quoted 20 lines · Lukas Bulwahn

SCSI_MOD is a helper config symbol for configuring RAID_ATTRS properly, i.e., RAID_ATTRS needs to be m when SCSI=m.

This helper config symbol SCSI_MOD still shows up even in kernel configurations that do not select the block subsystem and where SCSI is not even a configuration option mentioned and selectable.

Make this SCSI_MOD depend on BLOCK, so that it only shows up when it is slightly relevant in the kernel configuration.

---
  drivers/scsi/Kconfig | 7 ++++---
  1 file changed, 4 insertions(+), 3 deletions(-)
drivers/scsi/Kconfig +0 -0
index 955cb69a5418..03e71e3d5e5b 100644

drivers/scsi/Kconfig line 8

Quoted 10 lines
drivers/scsi/Kconfig +4 -3
@@ -2,9 +2,10 @@
  menu "SCSI device support"
 
  config SCSI_MOD
-       tristate
-       default y if SCSI=n || SCSI=y
-       default m if SCSI=m
+	tristate
+	default y if SCSI=n || SCSI=y
+	default m if SCSI=m
+	depends on BLOCK
#2 lore raw
In reply to Lukas Bulwahn

Lukas,

Quoted 2 lines

SCSI_MOD is a helper config symbol for configuring RAID_ATTRS properly, i.e., RAID_ATTRS needs to be m when SCSI=m.

Applied to 6.1/scsi-staging, thanks!

Signature · 1 line
Martin K. Petersen	Oracle Linux Engineering