Skip to contentSkip to conversation

linux-next: Fixes tag needs some work in the crypto tree

DISCUSSION Stephen Rothwell 3 participants 3 messages Sep 18, 2022 – Sep 20, 2022

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

Hi all,

In commit

cf5bb835b7c8 ("crypto: qat - fix DMA transfer direction")

Fixes tag

Fixes d370cec ("crypto: qat - Intel(R) QAT crypto interface")

has these problem(s):

- SHA1 should be at least 12 digits long
This can be fixed for the future by setting core.abbrev to 12 (or more) or (for git v2.11 or later) just making sure it is not set (or set to "auto").

Signature · 2 lines
Cheers,
Stephen Rothwell
#1 lore raw

My bad. Apologies.

@Herbert, can this be replaced in your history? The correct tag is

    Fixes: d370cec32194 ("crypto: qat - Intel(R) QAT crypto interface")

Thanks,

Signature · 1 line
Giovanni

-----Original Message-----
From: Stephen Rothwell <[email protected]>
Sent: Sunday, September 18, 2022 11:13 PM
To: Herbert Xu <[email protected]>; Linux Crypto List <[email protected]>
Cc: Muszynski, Damian <[email protected]>; Cabiddu, Giovanni <[email protected]>; Linux Kernel Mailing List <[email protected]>; Linux Next Mailing List <[email protected]>
Subject: linux-next: Fixes tag needs some work in the crypto tree

Hi all,

In commit

cf5bb835b7c8 ("crypto: qat - fix DMA transfer direction")

Fixes tag

Fixes d370cec ("crypto: qat - Intel(R) QAT crypto interface")

has these problem(s):

- SHA1 should be at least 12 digits long
This can be fixed for the future by setting core.abbrev to 12 (or more) or (for git v2.11 or later) just making sure it is not set (or set to "auto").

Signature · 2 lines
Cheers,
Stephen Rothwell
maintainer
#2 lore raw
Quoted 4 lines · Giovanni

My bad. Apologies.

@Herbert, can this be replaced in your history? The correct tag is

    Fixes: d370cec32194 ("crypto: qat - Intel(R) QAT crypto interface")

Hi Giovanni:

Please take this into consideration for future submissions.

Thanks,

Signature · 3 lines
Email: Herbert Xu <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt