Skip to contentSkip to conversation

libtirpc: add missing extern

PATCH In review Rosen Penev 2 participants 5 messages Sep 20, 2022 – Oct 25, 2022

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 libtirpc: add missing extern

Fixes compilation warning.

---
 src/svc_auth.c | 3 +++
 1 file changed, 3 insertions(+)
src/svc_auth.c +3 -0
index ce8bbd8..789d6af 100644
@@ -66,6 +66,9 @@ static struct authsvc *Auths = NULL;
 
 extern SVCAUTH svc_auth_none;
 
+#ifdef AUTHDES_SUPPORT
+extern enum auth_stat _svcauth_des(struct svc_req *rqst, struct rpc_msg *msg);
+#endif
 /*
  * The call rpc message, msg has been obtained from the wire.  The msg contains
  * the raw form of credentials and verifiers.  authenticate returns AUTH_OK
Signature · 1 line
2.37.3
#1 lore raw
Quoted 1 line · Rosen Penev

Fixes compilation warning.

What was the warning? Plus AUTH_DES is no longer supported.

steved.

Quoted 20 lines
---
  src/svc_auth.c | 3 +++
  1 file changed, 3 insertions(+)
src/svc_auth.c +3 -0
index ce8bbd8..789d6af 100644
@@ -66,6 +66,9 @@ static struct authsvc *Auths = NULL;
 
  extern SVCAUTH svc_auth_none;
 
+#ifdef AUTHDES_SUPPORT
+extern enum auth_stat _svcauth_des(struct svc_req *rqst, struct rpc_msg *msg);
+#endif
  /*
   * The call rpc message, msg has been obtained from the wire.  The msg contains
   * the raw form of credentials and verifiers.  authenticate returns AUTH_OK
#2 lore raw
Quoted 6 lines · Steve Dickson
Quoted 1 line · Rosen Penev

Fixes compilation warning.

What was the warning? Plus AUTH_DES is no longer supported.

Implicit function declaration as it's not in a header file or anything.

I found the issue from doing a meson conversion for libtirpc:
https://github.com/mesonbuild/wrapdb/pull/644

I have no idea about AUTH_DES or what it's used for.

Quoted 23 lines

steved.

Quoted 20 lines
---
  src/svc_auth.c | 3 +++
  1 file changed, 3 insertions(+)
src/svc_auth.c +3 -0
index ce8bbd8..789d6af 100644
@@ -66,6 +66,9 @@ static struct authsvc *Auths = NULL;
 
  extern SVCAUTH svc_auth_none;
 
+#ifdef AUTHDES_SUPPORT
+extern enum auth_stat _svcauth_des(struct svc_req *rqst, struct rpc_msg *msg);
+#endif
  /*
   * The call rpc message, msg has been obtained from the wire.  The msg contains
   * the raw form of credentials and verifiers.  authenticate returns AUTH_OK
#3 lore raw
Quoted 6 lines · Rosen Penev
Quoted 4 lines · Steve Dickson

On 9/19/22 7:59 PM, Rosen Penev wrote:

Quoted 8 lines
Quoted 2 lines
Quoted 1 line

Fixes compilation warning.

What was the warning? Plus AUTH_DES is no longer supported.

Implicit function declaration as it's not in a header file or anything.

I found the issue from doing a meson conversion for libtirpc:
https://github.com/mesonbuild/wrapdb/pull/644

I have no idea about AUTH_DES or what it's used for.

ping.

Quoted 23 lines
Quoted 23 lines

steved.

Quoted 20 lines
---
  src/svc_auth.c | 3 +++
  1 file changed, 3 insertions(+)
src/svc_auth.c +3 -0
index ce8bbd8..789d6af 100644
@@ -66,6 +66,9 @@ static struct authsvc *Auths = NULL;
 
  extern SVCAUTH svc_auth_none;
 
+#ifdef AUTHDES_SUPPORT
+extern enum auth_stat _svcauth_des(struct svc_req *rqst, struct rpc_msg *msg);
+#endif
  /*
   * The call rpc message, msg has been obtained from the wire.  The msg contains
   * the raw form of credentials and verifiers.  authenticate returns AUTH_OK
#4 lore raw
In reply to Rosen Penev
Quoted 3 lines · Rosen Penev

Fixes compilation warning.

Committed...

steved.

Quoted 18 lines
---
  src/svc_auth.c | 3 +++
  1 file changed, 3 insertions(+)
src/svc_auth.c +3 -0
index ce8bbd8..789d6af 100644
@@ -66,6 +66,9 @@ static struct authsvc *Auths = NULL;
 
  extern SVCAUTH svc_auth_none;
 
+#ifdef AUTHDES_SUPPORT
+extern enum auth_stat _svcauth_des(struct svc_req *rqst, struct rpc_msg *msg);
+#endif
  /*
   * The call rpc message, msg has been obtained from the wire.  The msg contains
   * the raw form of credentials and verifiers.  authenticate returns AUTH_OK