Skip to contentSkip to conversation

mmc: rtsx_usb_sdmmc: Remove the unneeded result variable

PATCH In review [email protected] 2 participants 2 messages Sep 20, 2022 – Sep 21, 2022 MMC, SD and SDIO

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 mmc: rtsx_usb_sdmmc: Remove the unneeded result variable

From: ye xingchen <[email protected]>

Return the value rtsx_usb_send_cmd() directly instead of storing it in another redundant variable.

---
 drivers/mmc/host/rtsx_usb_sdmmc.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)
drivers/mmc/host/rtsx_usb_sdmmc.c +1 -4
index 5fe4528e296e..5798aee06653 100644
@@ -1042,7 +1042,6 @@ static int sd_set_timing(struct rtsx_usb_sdmmc *host,
 		unsigned char timing, bool *ddr_mode)
 {
 	struct rtsx_ucr *ucr = host->ucr;
-	int err;
 
 	*ddr_mode = false;
 
@@ -1097,9 +1096,7 @@ static int sd_set_timing(struct rtsx_usb_sdmmc *host,
 		break;
 	}
 
-	err = rtsx_usb_send_cmd(ucr, MODE_C, 100);
-
-	return err;
+	return rtsx_usb_send_cmd(ucr, MODE_C, 100);
 }
 
 static void sdmmc_set_ios(struct mmc_host *mmc, struct mmc_ios *ios)
Signature · 1 line
2.25.1
#1 lore raw
Quoted 8 lines · On Tue, 20 Sept 2022 at 08:46, <[email protected]> wrote:

From: ye xingchen <[email protected]>

Return the value rtsx_usb_send_cmd() directly instead of storing it in another redundant variable.

Applied for next, thanks!

Kind regards
Uffe

Quoted 29 lines
---
 drivers/mmc/host/rtsx_usb_sdmmc.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)
drivers/mmc/host/rtsx_usb_sdmmc.c +1 -5
index 5fe4528e296e..5798aee06653 100644
@@ -1042,7 +1042,6 @@ static int sd_set_timing(struct rtsx_usb_sdmmc *host,
                unsigned char timing, bool *ddr_mode)
 {
        struct rtsx_ucr *ucr = host->ucr;
-       int err;
 
        *ddr_mode = false;
 
@@ -1097,9 +1096,7 @@ static int sd_set_timing(struct rtsx_usb_sdmmc *host,
                break;
        }
 
-       err = rtsx_usb_send_cmd(ucr, MODE_C, 100);
-
-       return err;
+       return rtsx_usb_send_cmd(ucr, MODE_C, 100);
 }
 
 static void sdmmc_set_ios(struct mmc_host *mmc, struct mmc_ios *ios)
--

2.25.1