mlock.2, pivot_root.2, poll.2, select.2, fopen.3, capabilities.7: tfix
PATCH 1/1 mlock.2, pivot_root.2, poll.2, select.2, fopen.3, capabilities.7: tfix
Signed-off-by Štěpán Němec <[email protected]>
--- man2/mlock.2 | 2 +- man2/pivot_root.2 | 2 +- man2/poll.2 | 2 +- man2/select.2 | 2 +- man3/fopen.3 | 2 +- man7/capabilities.7 | 4 ++-- 6 files changed, 7 insertions(+), 7 deletions(-)
man2/mlock.2 +1 -1
@@ -36,7 +36,7 @@ and perform the converse operation, unlocking part or all of the calling process's virtual address space, so that pages in the specified virtual address range may -once more to be swapped out if required by the kernel memory manager. +once more be swapped out if required by the kernel memory manager. .PP Memory locking and unlocking are performed in units of whole pages. .SS mlock(), mlock2(), and munlock()
man2/pivot_root.2 +1 -1
@@ -60,7 +60,7 @@ must not be on the same mount as the current root. .IP \- \fIput_old\fP must be at or underneath \fInew_root\fP; that is, adding some nonnegative -number of "\fI/..\fP" prefixes to the pathname pointed to by +number of "\fI/..\fP" suffixes to the pathname pointed to by .I put_old must yield the same directory as \fInew_root\fP. .IP \-
man2/poll.2 +1 -1
@@ -577,7 +577,7 @@ main(int argc, char *argv[]) if (pfds == NULL) errExit("malloc"); - /* Open each file on command line, and add it \(aqpfds\(aq array. */ + /* Open each file on command line, and add it to \(aqpfds\(aq array. */ for (nfds_t j = 0; j < nfds; j++) { pfds[j].fd = open(argv[j + 1], O_RDONLY);
man2/select.2 +1 -1
@@ -547,7 +547,7 @@ On some UNIX systems, .BR select () unblocks and returns, with an indication that the file descriptor is ready (a subsequent I/O operation will likely fail with an error, -unless another process reopens file descriptor between the time +unless another process reopens the file descriptor between the time .BR select () returned and the I/O operation is performed). On Linux (and some other systems),
man3/fopen.3 +1 -1
@@ -123,7 +123,7 @@ called for its synchronizing side effect). Opening a file in append mode (\fBa\fP as the first character of .IR mode ) causes all subsequent write operations to this stream to occur -at end-of-file, as if preceded the call: +at end-of-file, as if preceded by the call: .PP .in +4n .EX
man7/capabilities.7 +2 -2
@@ -1040,7 +1040,7 @@ Therefore, when assigning capabilities to a file if we specify the effective flag as being enabled for any capability, then the effective flag must also be specified as enabled for all other capabilities for which the corresponding permitted or -inheritable flags is enabled. +inheritable flag is enabled. .\" .SS File capability extended attribute versioning To allow extensibility,
@@ -1271,7 +1271,7 @@ file permitted capabilities, then fails with the error .BR EPERM . This prevents possible security risks that could arise when -a capability-dumb application is executed with less privilege that it needs. +a capability-dumb application is executed with less privilege than it needs. Note that, by definition, the application could not itself recognize this problem, since it does not employ the
base-commit: bf8f5415a1dd3296d3741008936458aeaf8769fc
Signature · 1 line
2.37.3
Hi Štěpán,
Quoted 28 lines · Štěpán Němec
Signed-off-by Štěpán Němec <[email protected]>--- man2/mlock.2 | 2 +- man2/pivot_root.2 | 2 +- man2/poll.2 | 2 +- man2/select.2 | 2 +- man3/fopen.3 | 2 +- man7/capabilities.7 | 4 ++-- 6 files changed, 7 insertions(+), 7 deletions(-)man2/mlock.2 +1
-1@@ -36,7 +36,7 @@ and perform the converse operation, unlocking part or all of the calling process's virtual address space, so that pages in the specified virtual address range may -once more to be swapped out if required by the kernel memory manager. +once more be swapped out if required by the kernel memory manager. .PP Memory locking and unlocking are performed in units of whole pages. .SS mlock(), mlock2(), and munlock()man2/pivot_root.2 +0
-0
man2/pivot_root.2 must not be on the same mount as the current root. · line 63
Quoted 5 lines
man2/pivot_root.2 +1
-1@@ -60,7 +60,7 @@ must not be on the same mount as the current root. .IP \- \fIput_old\fP must be at or underneath \fInew_root\fP; that is, adding some nonnegative -number of "\fI/..\fP" prefixes to the pathname pointed to by +number of "\fI/..\fP" suffixes to the pathname pointed to by
I'd like this change to be separate from the rest, as it's not an obvious writing typo, but rather one that needs understanding the context.
Would you mind splitting into a separate patch?
Thanks,
Alex
Quoted 66 lines
man2/pivot_root.2 +0
-0.I put_old must yield the same directory as \fInew_root\fP. .IP \-man2/poll.2 +1
-1@@ -577,7 +577,7 @@ main(int argc, char *argv[]) if (pfds == NULL) errExit("malloc"); - /* Open each file on command line, and add it \(aqpfds\(aq array. */ + /* Open each file on command line, and add it to \(aqpfds\(aq array. */ for (nfds_t j = 0; j < nfds; j++) { pfds[j].fd = open(argv[j + 1], O_RDONLY);man2/select.2 +1
-1@@ -547,7 +547,7 @@ On some UNIX systems, .BR select () unblocks and returns, with an indication that the file descriptor is ready (a subsequent I/O operation will likely fail with an error, -unless another process reopens file descriptor between the time +unless another process reopens the file descriptor between the time .BR select () returned and the I/O operation is performed). On Linux (and some other systems),man3/fopen.3 +1
-1@@ -123,7 +123,7 @@ called for its synchronizing side effect). Opening a file in append mode (\fBa\fP as the first character of .IR mode ) causes all subsequent write operations to this stream to occur -at end-of-file, as if preceded the call: +at end-of-file, as if preceded by the call: .PP .in +4n .EXman7/capabilities.7 +2
-2@@ -1040,7 +1040,7 @@ Therefore, when assigning capabilities to a file if we specify the effective flag as being enabled for any capability, then the effective flag must also be specified as enabled for all other capabilities for which the corresponding permitted or -inheritable flags is enabled. +inheritable flag is enabled. .\" .SS File capability extended attribute versioning To allow extensibility,@@ -1271,7 +1271,7 @@ file permitted capabilities, then fails with the error .BR EPERM . This prevents possible security risks that could arise when -a capability-dumb application is executed with less privilege that it needs. +a capability-dumb application is executed with less privilege than it needs. Note that, by definition, the application could not itself recognize this problem, since it does not employ thebase-commit:
bf8f5415a1dd3296d3741008936458aeaf8769fc
Signature · 1 line
<http://www.alejandro-colomar.es/>
cover Fix typos
Quoted 12 lines · On Sat, 08 Oct 2022 02:17:56 +0200 Alejandro Colomar wrote:
man2/pivot_root.2 must not be on the same mount as the current root. · line 63
Quoted 8 lines
man2/pivot_root.2 +1
-1@@ -60,7 +60,7 @@ must not be on the same mount as the current root. .IP \- \fIput_old\fP must be at or underneath \fInew_root\fP; that is, adding some nonnegative -number of "\fI/..\fP" prefixes to the pathname pointed to by +number of "\fI/..\fP" suffixes to the pathname pointed to byI'd like this change to be separate from the rest, as it's not an obvious writing typo, but rather one that needs understanding the context.
Quoted 1 line
Would you mind splitting into a separate patch?
Here it is. (I wanted to test the waters of submitting accumulated trivial fixes as a single patch, as I think it saves both some electrons and the resources of everyone else involved.)
I took this opportunity to squash in another missing article to the trivial typo patch (1/2).
Thanks,
Štěpán
Štěpán Němec (2):
memfd_create.2, mlock.2, poll.2, select.2, fopen.3, capabilities.7: tfix pivot_root.2: Fix a typo/thinko
man2/memfd_create.2 | 2 +- man2/mlock.2 | 2 +- man2/pivot_root.2 | 2 +- man2/poll.2 | 2 +- man2/select.2 | 2 +- man3/fopen.3 | 2 +- man7/capabilities.7 | 4 ++-- 7 files changed, 8 insertions(+), 8 deletions(-)
base-commit: a4a073ae7737fb8f20c390a60b8555a7cfdace98
Signature · 1 line
2.38.0
PATCH 1/2 memfd_create.2, mlock.2, poll.2, select.2, fopen.3, capabilities.7: tfix
Signed-off-by Štěpán Němec <[email protected]>
---
v1: squashed in a missing article in memfd_create(2)
man2/memfd_create.2 | 2 +- man2/mlock.2 | 2 +- man2/poll.2 | 2 +- man2/select.2 | 2 +- man3/fopen.3 | 2 +- man7/capabilities.7 | 4 ++-- 6 files changed, 7 insertions(+), 7 deletions(-)
man2/memfd_create.2 +1 -1
@@ -360,7 +360,7 @@ of which the first two are required. The first argument is the name to associate with the file, the second argument is the size to be set for the file, and the optional third argument is a string of characters that specify -seals to be set on file. +seals to be set on the file. .PP The second program, .IR t_get_seals.c ,
man2/mlock.2 +1 -1
@@ -36,7 +36,7 @@ and perform the converse operation, unlocking part or all of the calling process's virtual address space, so that pages in the specified virtual address range may -once more to be swapped out if required by the kernel memory manager. +once more be swapped out if required by the kernel memory manager. .PP Memory locking and unlocking are performed in units of whole pages. .SS mlock(), mlock2(), and munlock()
man2/poll.2 +1 -1
@@ -577,7 +577,7 @@ main(int argc, char *argv[]) if (pfds == NULL) errExit("malloc"); - /* Open each file on command line, and add it \(aqpfds\(aq array. */ + /* Open each file on command line, and add it to \(aqpfds\(aq array. */ for (nfds_t j = 0; j < nfds; j++) { pfds[j].fd = open(argv[j + 1], O_RDONLY);
man2/select.2 +1 -1
@@ -547,7 +547,7 @@ On some UNIX systems, .BR select () unblocks and returns, with an indication that the file descriptor is ready (a subsequent I/O operation will likely fail with an error, -unless another process reopens file descriptor between the time +unless another process reopens the file descriptor between the time .BR select () returned and the I/O operation is performed). On Linux (and some other systems),
man3/fopen.3 +1 -1
@@ -123,7 +123,7 @@ called for its synchronizing side effect). Opening a file in append mode (\fBa\fP as the first character of .IR mode ) causes all subsequent write operations to this stream to occur -at end-of-file, as if preceded the call: +at end-of-file, as if preceded by the call: .PP .in +4n .EX
man7/capabilities.7 +2 -2
@@ -1040,7 +1040,7 @@ Therefore, when assigning capabilities to a file if we specify the effective flag as being enabled for any capability, then the effective flag must also be specified as enabled for all other capabilities for which the corresponding permitted or -inheritable flags is enabled. +inheritable flag is enabled. .\" .SS File capability extended attribute versioning To allow extensibility,
@@ -1271,7 +1271,7 @@ file permitted capabilities, then fails with the error .BR EPERM . This prevents possible security risks that could arise when -a capability-dumb application is executed with less privilege that it needs. +a capability-dumb application is executed with less privilege than it needs. Note that, by definition, the application could not itself recognize this problem, since it does not employ the
Signature · 1 line
2.38.0
PATCH 2/2 pivot_root.2: Fix a typo/thinko
In reply to Štěpán Němec(To obtain a prefix of a given pathname, we have to append (suffix) '/..' at its end.)
Signed-off-by Štěpán Němec <[email protected]>
---
v1: split out from <[email protected]> per
Alejandro's preference; added explanation to commit message; no diff changes
man2/pivot_root.2 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
man2/pivot_root.2 +1 -1
@@ -60,7 +60,7 @@ must not be on the same mount as the current root. .IP \- \fIput_old\fP must be at or underneath \fInew_root\fP; that is, adding some nonnegative -number of "\fI/..\fP" prefixes to the pathname pointed to by +number of "\fI/..\fP" suffixes to the pathname pointed to by .I put_old must yield the same directory as \fInew_root\fP. .IP \-
Signature · 1 line
2.38.0
Re: [PATCH v1 0/2] Fix typos
In reply to Štěpán NěmecQuoted 15 lines · Štěpán Němec
Quoted 12 lines · On Sat, 08 Oct 2022 02:17:56 +0200 Alejandro Colomar wrote:
man2/pivot_root.2 must not be on the same mount as the current root. · line 63
Quoted 8 lines
man2/pivot_root.2 +1
-1@@ -60,7 +60,7 @@ must not be on the same mount as the current root. .IP \- \fIput_old\fP must be at or underneath \fInew_root\fP; that is, adding some nonnegative -number of "\fI/..\fP" prefixes to the pathname pointed to by +number of "\fI/..\fP" suffixes to the pathname pointed to byI'd like this change to be separate from the rest, as it's not an obvious writing typo, but rather one that needs understanding the context.
Quoted 5 lines
Quoted 1 line
Would you mind splitting into a separate patch?
Here it is. (I wanted to test the waters of submitting accumulated trivial fixes as a single patch, as I think it saves both some electrons and the resources of everyone else involved.)
Except that I don't agree on that one being that trivial :)
But yes, if you find many trivial typos, you can file them as a single patch.
Quoted 4 lines
I took this opportunity to squash in another missing article to the trivial typo patch (1/2).
That's fine.
Patch set applied.
Cheers,
Alex
Quoted 19 lines
Thanks,
Štěpán
Štěpán Němec (2):
memfd_create.2, mlock.2, poll.2, select.2, fopen.3, capabilities.7: tfix pivot_root.2: Fix a typo/thinkoman2/memfd_create.2 | 2 +- man2/mlock.2 | 2 +- man2/pivot_root.2 | 2 +- man2/poll.2 | 2 +- man2/select.2 | 2 +- man3/fopen.3 | 2 +- man7/capabilities.7 | 4 ++-- 7 files changed, 8 insertions(+), 8 deletions(-)base-commit:
a4a073ae7737fb8f20c390a60b8555a7cfdace98
Signature · 1 line
<http://www.alejandro-colomar.es/>