SDM670 SDHCI support
Subsystems (4)
cover SDM670 SDHCI support
This adds the compatible string for SDHCI on the Qualcomm Snapdragon 670. As I noted before, I think it's fine to include something like this before the initial device tree because it is trivial.
Documentation/devicetree/bindings/mmc/sdhci-msm.yaml | 1 + drivers/mmc/host/sdhci-msm.c | 1 + 2 files changed, 2 insertions(+)
PATCH 1/2 dt-bindings: mmc: sdhci-msm: add sdm670 compatible
The Snapdragon 670 supports eMMC with an SDHCI controller. Add the appropriate compatible to the documentation.
--- Documentation/devicetree/bindings/mmc/sdhci-msm.yaml | 1 + 1 file changed, 1 insertion(+)
Documentation/devicetree/bindings/mmc/sdhci-msm.yaml +1 -0
@@ -38,6 +38,7 @@ properties: - qcom,sc7180-sdhci - qcom,sc7280-sdhci - qcom,sdm630-sdhci + - qcom,sdm670-sdhci - qcom,sdm845-sdhci - qcom,sdx55-sdhci - qcom,sdx65-sdhci
Signature · 1 line
2.37.3
Re: [PATCH 1/2] dt-bindings: mmc: sdhci-msm: add sdm670 compatible
Quoted 4 lines · Richard Acayan
The Snapdragon 670 supports eMMC with an SDHCI controller. Add the appropriate compatible to the documentation.
Signed-off-by Richard Acayan <[email protected]>
Best regards,
Krzysztof
PATCH 2/2 mmc: sdhci-msm: add compatible string check for sdm670
In reply to Richard AcayanThe Snapdragon 670 has the same quirk as Snapdragon 845 (needing to restore the dll config). Add a compatible string check to detect the need for this.
--- drivers/mmc/host/sdhci-msm.c | 1 + 1 file changed, 1 insertion(+)
drivers/mmc/host/sdhci-msm.c +1 -0
@@ -2441,6 +2441,7 @@ static const struct of_device_id sdhci_msm_dt_match[] = {*/ {.compatible = "qcom,sdhci-msm-v4", .data = &sdhci_msm_mci_var}, {.compatible = "qcom,sdhci-msm-v5", .data = &sdhci_msm_v5_var}, + {.compatible = "qcom,sdm670-sdhci", .data = &sdm845_sdhci_var}, {.compatible = "qcom,sdm845-sdhci", .data = &sdm845_sdhci_var}, {.compatible = "qcom,sc7180-sdhci", .data = &sdm845_sdhci_var}, {},
Signature · 1 line
2.37.3
Re: [PATCH 2/2] mmc: sdhci-msm: add compatible string check for sdm670
Quoted 14 lines · Richard Acayan
The Snapdragon 670 has the same quirk as Snapdragon 845 (needing to restore the dll config). Add a compatible string check to detect the need for this.
Signed-off-by Richard Acayan <[email protected]>--- drivers/mmc/host/sdhci-msm.c | 1 + 1 file changed, 1 insertion(+)drivers/mmc/host/sdhci-msm.c +0
-0
drivers/mmc/host/sdhci-msm.c static const struct of_device_id sdhci_msm_dt_match[] = { · line 2446
Quoted 6 lines
drivers/mmc/host/sdhci-msm.c +1
-0@@ -2441,6 +2441,7 @@ static const struct of_device_id sdhci_msm_dt_match[] = {*/ {.compatible = "qcom,sdhci-msm-v4", .data = &sdhci_msm_mci_var}, {.compatible = "qcom,sdhci-msm-v5", .data = &sdhci_msm_v5_var}, + {.compatible = "qcom,sdm670-sdhci", .data = &sdm845_sdhci_var}, {.compatible = "qcom,sdm845-sdhci", .data = &sdm845_sdhci_var}, {.compatible = "qcom,sc7180-sdhci", .data = &sdm845_sdhci_var},
Probably we should make them a family of compatible devices, because the list grows. For three items:
If you want to add fourth, I propose to make it a family.
Best regards,
Krzysztof
Quoted 8 lines · Richard Acayan
This adds the compatible string for SDHCI on the Qualcomm Snapdragon 670. As I noted before, I think it's fine to include something like this before the initial device tree because it is trivial.
Documentation/devicetree/bindings/mmc/sdhci-msm.yaml | 1 + drivers/mmc/host/sdhci-msm.c | 1 + 2 files changed, 2 insertions(+)
With the assumption that the initial dts would be available for upstream review soon (as we need to see actual user before integrating such driver changes) - for the series:
Thanks.
Quoted 10 lines · Richard Acayan
This adds the compatible string for SDHCI on the Qualcomm Snapdragon 670. As I noted before, I think it's fine to include something like this before the initial device tree because it is trivial.
Documentation/devicetree/bindings/mmc/sdhci-msm.yaml | 1 + drivers/mmc/host/sdhci-msm.c | 1 + 2 files changed, 2 insertions(+)
Applied for next, thanks!
Kind regards
Uffe