Skip to contentSkip to conversation

staging: fwserial: delete the driver.

PATCH New Greg Kroah-Hartman 1 participant 1 message Sep 24, 2022 Staging

lore
Share & tools
lore

Greg Kroah-Hartman

author maintainer
#0 lore raw

PATCH 1/1 staging: fwserial: delete the driver.

In the years since it was added (2012), no one has stepped up to maintain this properly and get it merged into the kernel tree. So remove it as it's obviously not being used.

If it is being used, we can easily revert this and take the time to get it out of the staging tree.

---
 drivers/staging/Kconfig             |    2 -
 drivers/staging/Makefile            |    1 -
 drivers/staging/fwserial/Kconfig    |   32 -
 drivers/staging/fwserial/Makefile   |    3 -
 drivers/staging/fwserial/TODO       |   14 -
 drivers/staging/fwserial/dma_fifo.c |  294 ---
 drivers/staging/fwserial/dma_fifo.h |  117 --
 drivers/staging/fwserial/fwserial.c | 2889 ---------------------------
 drivers/staging/fwserial/fwserial.h |  359 ----
 9 files changed, 3711 deletions(-)
 delete mode 100644 drivers/staging/fwserial/Kconfig
 delete mode 100644 drivers/staging/fwserial/Makefile
 delete mode 100644 drivers/staging/fwserial/TODO
 delete mode 100644 drivers/staging/fwserial/dma_fifo.c
 delete mode 100644 drivers/staging/fwserial/dma_fifo.h
 delete mode 100644 drivers/staging/fwserial/fwserial.c
 delete mode 100644 drivers/staging/fwserial/fwserial.h
drivers/staging/Kconfig +0 -2
index 3bd80f9695ac..64a531accd72 100644
@@ -60,8 +60,6 @@ source "drivers/staging/board/Kconfig"
 
 source "drivers/staging/gdm724x/Kconfig"
 
-source "drivers/staging/fwserial/Kconfig"
-
 source "drivers/staging/clocking-wizard/Kconfig"
 
 source "drivers/staging/fbtft/Kconfig"
drivers/staging/Makefile +0 -1
index 1d9ae39fea14..6af299b9045b 100644
@@ -20,7 +20,6 @@ obj-$(CONFIG_USB_EMXX)		+= emxx_udc/
 obj-$(CONFIG_MFD_NVEC)		+= nvec/
 obj-$(CONFIG_STAGING_BOARD)	+= board/
 obj-$(CONFIG_LTE_GDM724X)	+= gdm724x/
-obj-$(CONFIG_FIREWIRE_SERIAL)	+= fwserial/
 obj-$(CONFIG_COMMON_CLK_XLNX_CLKWZRD)	+= clocking-wizard/
 obj-$(CONFIG_FB_TFT)		+= fbtft/
 obj-$(CONFIG_MOST)		+= most/
drivers/staging/fwserial/Kconfig deleted +0 -32
deleted file mode 100644
index 6964aac2a7ed..000000000000
@@ -1,32 +0,0 @@
-# SPDX-License-Identifier: GPL-2.0
-config FIREWIRE_SERIAL
-	tristate "TTY over Firewire"
-	depends on FIREWIRE && TTY
-	help
-	  This enables TTY over IEEE 1394, providing high-speed serial
-	  connectivity to cabled peers. This driver implements a
-	  ad-hoc transport protocol and is currently limited to
-	  Linux-to-Linux communication.
-
-	  To compile this driver as a module, say M here:  the module will
-	  be called firewire-serial.
-
-if FIREWIRE_SERIAL
-
-config FWTTY_MAX_TOTAL_PORTS
-	int "Maximum number of serial ports supported"
-	default "64"
-	help
-	  Set this to the maximum number of serial ports you want the
-	  firewire-serial driver to support.
-
-config FWTTY_MAX_CARD_PORTS
-	int "Maximum number of serial ports supported per adapter"
-	range 0 FWTTY_MAX_TOTAL_PORTS
-	default "32"
-	help
-	  Set this to the maximum number of serial ports each firewire
-	  adapter supports. The actual number of serial ports registered
-	  is set with the module parameter "ttys".
-
-endif
drivers/staging/fwserial/Makefile deleted +0 -3
deleted file mode 100644
index 1cd5c5c7e805..000000000000
@@ -1,3 +0,0 @@
-# SPDX-License-Identifier: GPL-2.0
-obj-$(CONFIG_FIREWIRE_SERIAL) += firewire-serial.o
-firewire-serial-objs := fwserial.o dma_fifo.o
drivers/staging/fwserial/TODO deleted +0 -14
deleted file mode 100644
index 382a7959407c..000000000000
@@ -1,14 +0,0 @@
-TODOs prior to this driver moving out of staging
-------------------------------------------------
-1. Implement retries for RCODE_BUSY, RCODE_NO_ACK and RCODE_SEND_ERROR
-   - I/O is handled asynchronously which presents some issues when error
-     conditions occur.
-2. Implement _robust_ console on top of this. The existing prototype console
-   driver is not ready for the big leagues yet.
-3. Expose means of controlling attach/detach of peers via sysfs. Include
-   GUID-to-port matching/whitelist/blacklist.
-
--- Issues with firewire stack --
-1. This driver uses the same unregistered vendor id that the firewire core does
-     (0xd00d1e). Perhaps this could be exposed as a define in
-     firewire.h?
drivers/staging/fwserial/dma_fifo.c deleted +0 -294

294 lines not on this page · raw message

drivers/staging/fwserial/dma_fifo.h deleted +0 -117

117 lines not on this page · raw message

drivers/staging/fwserial/fwserial.c deleted +0 -2889

2,525 lines not on this page · raw message

drivers/staging/fwserial/fwserial.h deleted +0 -359

359 lines not on this page · raw message

The rest of this diff is not shown. View the raw message.

Signature · 1 line
2.37.3

Part of the diff is not shown here. View the raw message.