Skip to contentSkip to conversation

clk: bcm2835: Make peripheral PLLC critical

PATCH Applied Maxime Ripard 4 participants 4 messages Sep 26, 2022 – Sep 30, 2022

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 clk: bcm2835: Make peripheral PLLC critical

When testing for a series affecting the VEC, it was discovered that turning off and on the VEC clock is crashing the system.

It turns out that, when disabling the VEC clock, it's the only child of the PLLC-per clock which will also get disabled. The source of the crash is PLLC-per being disabled.

It's likely that some other device might not take a clock reference that it actually needs, but it's unclear which at this point. Let's make PLLC-per critical so that we don't have that crash.

---
 drivers/clk/bcm/clk-bcm2835.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/clk/bcm/clk-bcm2835.c +1 -1
index 48a1eb9f2d55..19de0e83b65d 100644
@@ -1784,7 +1784,7 @@ static const struct bcm2835_clk_desc clk_desc_array[] = {
 		.load_mask = CM_PLLC_LOADPER,
 		.hold_mask = CM_PLLC_HOLDPER,
 		.fixed_divider = 1,
-		.flags = CLK_SET_RATE_PARENT),
+		.flags = CLK_IS_CRITICAL | CLK_SET_RATE_PARENT),
 
 	/*
 	 * PLLD is the display PLL, used to drive DSI display panels.
Signature · 1 line
2.37.3
Reviewed-by on v1 1/1
#1 lore raw

Am 26.09.22 um 10:45 schrieb Maxime Ripard:

Quoted 7 lines

When testing for a series affecting the VEC, it was discovered that turning off and on the VEC clock is crashing the system.

It turns out that, when disabling the VEC clock, it's the only child of the PLLC-per clock which will also get disabled. The source of the crash is PLLC-per being disabled.

Quoted 6 lines

It's likely that some other device might not take a clock reference that it actually needs, but it's unclear which at this point. Let's make PLLC-per critical so that we don't have that crash.

Acked-by on v1 1/1
#2 lore raw
In reply to Maxime Ripard

Den 26.09.2022 10.45, skrev Maxime Ripard:

Quoted 7 lines

When testing for a series affecting the VEC, it was discovered that turning off and on the VEC clock is crashing the system.

It turns out that, when disabling the VEC clock, it's the only child of the PLLC-per clock which will also get disabled. The source of the crash is PLLC-per being disabled.

Quoted 7 lines

It's likely that some other device might not take a clock reference that it actually needs, but it's unclear which at this point. Let's make PLLC-per critical so that we don't have that crash.

---

maintainer Applied
#3 lore raw
In reply to Maxime Ripard

Quoting Maxime Ripard (2022-09-26 01:45:09)

Quoted 7 lines

When testing for a series affecting the VEC, it was discovered that turning off and on the VEC clock is crashing the system.

It turns out that, when disabling the VEC clock, it's the only child of the PLLC-per clock which will also get disabled. The source of the crash is PLLC-per being disabled.

Quoted 7 lines

It's likely that some other device might not take a clock reference that it actually needs, but it's unclear which at this point. Let's make PLLC-per critical so that we don't have that crash.

---

Applied to clk-next