Makefile: apply dynamic relocations for LLD
PATCH 1/1 Makefile: apply dynamic relocations for LLD
From: Nick Desaulniers <[email protected]>
It seems that for aarch64, unless we apply dynamic relocations to the location being relocated, we fail to boot.
As Fangrui notes:
For dynamic relocations using the RELA format (readelf -Wr), GNU ld sets the initial content to r_addend; ld.lld doesn't do that by default (needs --apply-dynamic-relocs).
Otherwise .rodata appears to be full of NUL-bytes before relocation, causing crashes when trying to invoke the function pointers in init_sequence_f from initcall_run_list().
--- Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Makefile +1 -1
@@ -1022,7 +1022,7 @@ LDFLAGS_u-boot += $(LDFLAGS_FINAL) LDFLAGS_u-boot += $(call ld-option, --no-dynamic-linker) # ld.lld support -LDFLAGS_u-boot += -z notext +LDFLAGS_u-boot += -z notext $(call ld-option,--apply-dynamic-relocs) LDFLAGS_u-boot += --build-id=none
Signature · 1 line
2.30.2
Quoted 14 lines · Alistair Delva
From: Nick Desaulniers <[email protected]>
It seems that for aarch64, unless we apply dynamic relocations to the location being relocated, we fail to boot.
As Fangrui notes:
For dynamic relocations using the RELA format (readelf -Wr), GNU ld sets the initial content tor_addend; ld.lld doesn't do that by default (needs --apply-dynamic-relocs).Otherwise .rodata appears to be full of NUL-bytes before relocation, causing crashes when trying to invoke the function pointers in
init_sequence_ffrominitcall_run_list().
Quoted 7 lines
Suggested-by Fangrui Song <[email protected]>Signed-off-by Nick Desaulniers <[email protected]>Signed-off-by Alistair Delva <[email protected]>Cc Simon Glass <[email protected]>Cc Tom Rini <[email protected]>Cc Nick Desaulniers <[email protected]>
Applied to u-boot/master, thanks!
Signature · 1 line
Tom