scsi: qla2xxx: Fix serialization of DCBX TLV data request
Subsystems (2)
PATCH 1/1 scsi: qla2xxx: Fix serialization of DCBX TLV data request
Commit b6faaaf796d7 ("scsi: qla2xxx: Serialize mailbox request") serialized mailbox requests from userspace using the 'optrom' mutex. However, in the case of DCBX TLV data, if the memory for it is already allocated, then the mailbox request ends up not being serialized because it is done without holding the 'optrom' mutex.
--- drivers/scsi/qla2xxx/qla_attr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/scsi/qla2xxx/qla_attr.c +1 -1
@@ -951,9 +951,9 @@ qla2x00_sysfs_read_dcbx_tlv(struct file *filp, struct kobject *kobj,if (!capable (CAP_SYS_ADMIN ) || off !=0 || count >DCBX_TLV_DATA_SIZE )return 0 ; +mutex_lock (&vha->hw->optrom_mutex);if (ha->dcbx_tlv) goto do_read; -mutex_lock (&vha->hw->optrom_mutex);if (qla2x00_chip_is_down (vha)) {mutex_unlock (&vha->hw->optrom_mutex);return 0 ;
Signature · 1 line
2.34.1
Quoted 34 lines · Rafael Mendonca
Commit
b6faaaf796d7("scsi: qla2xxx: Serialize mailbox request") serialized mailbox requests from userspace using the 'optrom' mutex. However, in the case of DCBX TLV data, if the memory for it is already allocated, then the mailbox request ends up not being serialized because it is done without holding the 'optrom' mutex.Fixes b6faaaf796d7 ("scsi: qla2xxx: Serialize mailbox request")Signed-off-by Rafael Mendonca <[email protected]>---
drivers/scsi/qla2xxx/qla_attr.c| 2 +-1 file changed, 1 insertion(+), 1 deletion(-)drivers/scsi/qla2xxx/qla_attr.c +1
-1@@ -951,9 +951,9 @@ qla2x00_sysfs_read_dcbx_tlv(struct file *filp, struct kobject *kobj,if (!capable (CAP_SYS_ADMIN ) || off !=0 || count >DCBX_TLV_DATA_SIZE )return 0 ; +mutex_lock (&vha->hw->optrom_mutex);if (ha->dcbx_tlv) goto do_read; -mutex_lock (&vha->hw->optrom_mutex);if (qla2x00_chip_is_down (vha)) {mutex_unlock (&vha->hw->optrom_mutex);return 0 ;Signature · 1 line
2.34.1
Looks Good.
Signature · 1 line
Himanshu Madhani Oracle Linux Engineering
Martin K. Petersen
AppliedRafael,
Quoted 5 lines
Commit
b6faaaf796d7("scsi: qla2xxx: Serialize mailbox request") serialized mailbox requests from userspace using the 'optrom' mutex. However, in the case of DCBX TLV data, if the memory for it is already allocated, then the mailbox request ends up not being serialized because it is done without holding the 'optrom' mutex.
Applied to 6.1/scsi-staging, thanks!
Signature · 1 line
Martin K. Petersen Oracle Linux Engineering