mm-gup-use-gup_can_follow_protnone-also-in-gup-fast.patch removed from -mm tree
The quilt patch titled
Subject: mm/gup: use gup_can_follow_protnone() also in GUP-fast
has been removed from the -mm tree. Its filename was
mm-gup-use-gup_can_follow_protnone-also-in-gup-fast.patch
This patch was dropped because it was merged into the mm-stable branch of git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm
------------------------------------------------------
From: David Hildenbrand <[email protected]>
Subject: mm/gup: use gup_can_follow_protnone() also in GUP-fast
Date: Thu, 25 Aug 2022 18:46:58 +0200
There seems to be no reason why FOLL_FORCE during GUP-fast would have to fallback to the slow path when stumbling over a PROT_NONE mapped page. We only have to trigger hinting faults in case FOLL_FORCE is not set, and any kind of fault handling naturally happens from the slow path -- where NUMA hinting accounting/handling would be performed.
Note that the comment regarding THP migration is outdated: commit 2b4847e73004 ("mm: numa: serialise parallel get_user_page against THP migration") described that this was required for THP due to lack of PMD migration entries. Nowadays, we do have proper PMD migration entries in place -- see set_pmd_migration_entry(), which does a proper pmdp_invalidate() when placing the migration entry.
So let's just reuse gup_can_follow_protnone() here to make it consistent and drop the somewhat outdated comments.
---
mm/gup.c | 14 +++----------- 1 file changed, 3 insertions(+), 11 deletions(-)
mm/gup.c renamed from mm/gup.c~mm-gup-use-gup_can_follow_protnone-also-in-gup-fast +3 -11
@@ -2432,11 +2432,7 @@ static int gup_pte_range(pmd_t pmd, pmd_struct page *page;struct folio *folio; -/* -* Similar to the PMD case below, NUMA hinting must take slow -* path using the pte_protnone check. -*/ -if (pte_protnone (pte)) +if (pte_protnone (pte) && !gup_can_follow_protnone (flags)) goto pte_unmap;if (!pte_access_permitted (pte, flags &FOLL_WRITE ))
@@ -2820,12 +2816,8 @@ static int gup_pmd_range(pud_t *pudp, pu if (unlikely(pmd_trans_huge(pmd) || pmd_huge(pmd) || pmd_devmap(pmd))) { - /* - * NUMA hinting faults need to be handled in the GUP - * slowpath for accounting purposes and so that they - * can be serialised against THP migration. - */ - if (pmd_protnone(pmd)) + if (pmd_protnone(pmd) && + !gup_can_follow_protnone(flags)) return 0; if (!gup_huge_pmd(pmd, pmdp, addr, next, flags,
_
Patches currently in -mm which might be from [email protected] are