Skip to contentSkip to conversation

tests/kms_plane_multiple: turn off pipe if all planes are off

PATCH Superseded Alex Hung 3 participants 5 messages Sep 27, 2022 – Sep 28, 2022

v2 of 4 Superseded Latest is v4 →

lore
Share & tools
lore

Alex Hung

author
#0 lore raw

PATCH v2 1/1 tests/kms_plane_multiple: turn off pipe if all planes are off

amdgpu rejects when crtc is on + all planes are off, and it is necessary to turn off crtc when all planes are off.

This is revised from https://patchwork.freedesktop.org/series/80904/

---
 tests/kms_plane_multiple.c | 3 +++
 1 file changed, 3 insertions(+)
tests/kms_plane_multiple.c +3 -0
index cbe8c189..e900dc7f 100644
@@ -311,6 +311,8 @@ test_plane_position_with_output(data_t *data, enum pipe pipe,
 		for_each_plane_on_pipe(&data->display, pipe, plane)
 			igt_plane_set_fb(plane, NULL);
 
+		if (is_amdgpu_device(data->drm_fd))
+			igt_output_set_pipe(output, PIPE_NONE);
 		igt_display_commit2(&data->display, COMMIT_ATOMIC);
 
 		for (int x = 0; x < c; x++)
@@ -344,6 +346,7 @@ test_plane_position_with_output(data_t *data, enum pipe pipe,
 		for_each_plane_on_pipe(&data->display, pipe, plane)
 			igt_plane_set_fb(plane, NULL);
 
+		igt_output_set_pipe(output, PIPE_NONE);
 		igt_display_commit2(&data->display, COMMIT_ATOMIC);
 
 		for (int x = 0; x < c; x++)
Signature · 1 line
2.34.1
#1 lore raw

[igt-dev] ✓ Fi.CI.BAT: success for tests/kms_plane_multiple: turn off pipe if all planes are off (rev2)

== Series Details ==

== Series Details ==

Series: tests/kms_plane_multiple: turn off pipe if all planes are off (rev2)
URL : https://patchwork.freedesktop.org/series/109086/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_12192 -> IGTPW_7853
====================================================

Summary
-------

**SUCCESS**

No regressions found.

External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7853/index.html

Participating hosts (46 -> 44)
------------------------------

Missing (2): fi-bdw-samus fi-tgl-dsi

Known issues
------------

Here are the changes found in IGTPW_7853 that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@i915_selftest@live@gt_engines:
- bat-dg1-5: [PASS][1] -> [INCOMPLETE][2] ([i915#4418])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12192/bat-dg1-5/igt@i915_selftest@live@gt_engines.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7853/bat-dg1-5/igt@i915_selftest@live@gt_engines.html

* igt@i915_selftest@live@hangcheck:
- fi-hsw-g3258: [PASS][3] -> [INCOMPLETE][4] ([i915#3303] / [i915#4785])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12192/fi-hsw-g3258/igt@i915_selftest@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7853/fi-hsw-g3258/igt@i915_selftest@[email protected]

* igt@runner@aborted:
- bat-dg1-5: NOTRUN -> [FAIL][5] ([i915#4312])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7853/bat-dg1-5/igt@[email protected]
- fi-hsw-g3258: NOTRUN -> [FAIL][6] ([fdo#109271] / [i915#4312])
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7853/fi-hsw-g3258/igt@[email protected]

#### Possible fixes ####

* igt@gem_exec_suspend@basic-s3@smem:
- {bat-rplp-1}: [DMESG-WARN][7] ([i915#2867]) -> [PASS][8]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12192/bat-rplp-1/igt@gem_exec_suspend@[email protected]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7853/bat-rplp-1/igt@gem_exec_suspend@[email protected]
- {bat-adlm-1}: [DMESG-WARN][9] ([i915#2867]) -> [PASS][10]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12192/bat-adlm-1/igt@gem_exec_suspend@[email protected]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7853/bat-adlm-1/igt@gem_exec_suspend@[email protected]

* igt@i915_pm_rpm@module-reload:
- fi-cfl-8109u: [DMESG-FAIL][11] ([i915#62]) -> [PASS][12]
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12192/fi-cfl-8109u/igt@[email protected]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7853/fi-cfl-8109u/igt@[email protected]

* igt@i915_selftest@live@hangcheck:
- {fi-ehl-2}: [INCOMPLETE][13] ([i915#5153]) -> [PASS][14]
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12192/fi-ehl-2/igt@i915_selftest@[email protected]
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7853/fi-ehl-2/igt@i915_selftest@[email protected]

* igt@i915_selftest@live@late_gt_pm:
- fi-cfl-8109u: [DMESG-WARN][15] ([i915#5904]) -> [PASS][16] +30 similar issues
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12192/fi-cfl-8109u/igt@i915_selftest@live@late_gt_pm.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7853/fi-cfl-8109u/igt@i915_selftest@live@late_gt_pm.html

* igt@i915_suspend@basic-s2idle-without-i915:
- fi-cfl-8109u: [DMESG-WARN][17] ([i915#5904] / [i915#62]) -> [PASS][18]
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12192/fi-cfl-8109u/igt@[email protected]
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7853/fi-cfl-8109u/igt@[email protected]

* igt@kms_cursor_legacy@basic-busy-flip-before-cursor@atomic-transitions:
- fi-bsw-kefka: [FAIL][19] ([i915#6298]) -> [PASS][20]
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12192/fi-bsw-kefka/igt@kms_cursor_legacy@[email protected]
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7853/fi-bsw-kefka/igt@kms_cursor_legacy@[email protected]

* igt@kms_frontbuffer_tracking@basic:
- fi-cfl-8109u: [DMESG-WARN][21] ([i915#62]) -> [PASS][22] +12 similar issues
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12192/fi-cfl-8109u/igt@[email protected]
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7853/fi-cfl-8109u/igt@[email protected]

{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).

[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[i915#2867]: https://gitlab.freedesktop.org/drm/intel/issues/2867
[i915#3303]: https://gitlab.freedesktop.org/drm/intel/issues/3303
[i915#4312]: https://gitlab.freedesktop.org/drm/intel/issues/4312
[i915#4418]: https://gitlab.freedesktop.org/drm/intel/issues/4418
[i915#4785]: https://gitlab.freedesktop.org/drm/intel/issues/4785
[i915#5153]: https://gitlab.freedesktop.org/drm/intel/issues/5153
[i915#5886]: https://gitlab.freedesktop.org/drm/intel/issues/5886
[i915#5904]: https://gitlab.freedesktop.org/drm/intel/issues/5904
[i915#62]: https://gitlab.freedesktop.org/drm/intel/issues/62
[i915#6257]: https://gitlab.freedesktop.org/drm/intel/issues/6257
[i915#6298]: https://gitlab.freedesktop.org/drm/intel/issues/6298

Build changes
-------------

* CI: CI-20190529 -> None
* IGT: IGT_6666 -> IGTPW_7853

CI-20190529: 20190529
CI_DRM_12192: 83f5b1665fc067c78ed2d46c585d8c49e57e6b06 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_7853: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7853/index.html
IGT_6666: 1e3ecbaa3c56f4c52c62047707eb4942d3a39c44 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7853/index.html

#2 lore raw

[igt-dev] ✗ Fi.CI.IGT: failure for tests/kms_plane_multiple: turn off pipe if all planes are off (rev2)

In reply to Alex Hung
== Series Details ==

== Series Details ==

Series: tests/kms_plane_multiple: turn off pipe if all planes are off (rev2)
URL : https://patchwork.freedesktop.org/series/109086/
State : failure

== Summary ==

CI Bug Log - changes from CI_DRM_12192_full -> IGTPW_7853_full
====================================================

Summary
-------

**FAILURE**

Serious unknown changes coming with IGTPW_7853_full absolutely need to be verified manually.

If you think the reported changes have nothing to do with the changes introduced in IGTPW_7853_full, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.

External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7853/index.html

Participating hosts (11 -> 6)
------------------------------

Missing (5): pig-kbl-iris shard-tglu pig-glk-j5005 pig-skl-6260u shard-rkl

Possible new issues
-------------------

Here are the unknown changes that may have been introduced in IGTPW_7853_full:

### IGT changes ###

#### Possible regressions ####

* igt@gem_exec_whisper@basic-queues-priority-all:
- shard-iclb: [PASS][1] -> [INCOMPLETE][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12192/shard-iclb4/igt@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7853/shard-iclb4/igt@[email protected]

* igt@nouveau_crc@pipe-b-source-outp-inactive:
- shard-tglb: NOTRUN -> [SKIP][3] +47 similar issues
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7853/shard-tglb2/igt@[email protected]

* igt@prime_nv_test@i915_blt_fill_nv_read:
- shard-iclb: NOTRUN -> [SKIP][4] +46 similar issues
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7853/shard-iclb7/igt@prime_nv_test@i915_blt_fill_nv_read.html

Known issues
------------

Here are the changes found in IGTPW_7853_full that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@gem_ccs@block-copy-compressed:
- shard-tglb: NOTRUN -> [SKIP][5] ([i915#3555] / [i915#5325])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7853/shard-tglb5/igt@[email protected]

* igt@gem_eio@reset-stress:
- shard-tglb: [PASS][6] -> [FAIL][7] ([i915#5784])
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12192/shard-tglb3/igt@[email protected]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7853/shard-tglb1/igt@[email protected]

* igt@gem_exec_balancer@parallel-out-fence:
- shard-iclb: [PASS][8] -> [SKIP][9] ([i915#4525])
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12192/shard-iclb4/igt@[email protected]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7853/shard-iclb5/igt@[email protected]

* igt@gem_exec_capture@capture-recoverable:
- shard-tglb: NOTRUN -> [SKIP][10] ([i915#6344])
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7853/shard-tglb5/igt@[email protected]
- shard-iclb: NOTRUN -> [SKIP][11] ([i915#6344])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7853/shard-iclb4/igt@[email protected]

* igt@gem_exec_fair@basic-none-solo@rcs0:
- shard-apl: [PASS][12] -> [FAIL][13] ([i915#2842])
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12192/shard-apl6/igt@gem_exec_fair@[email protected]
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7853/shard-apl7/igt@gem_exec_fair@[email protected]

* igt@gem_lmem_swapping@heavy-verify-random-ccs:
- shard-apl: NOTRUN -> [SKIP][14] ([fdo#109271] / [i915#4613]) +1 similar issue
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7853/shard-apl3/igt@[email protected]
- shard-tglb: NOTRUN -> [SKIP][15] ([i915#4613])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7853/shard-tglb8/igt@[email protected]
- shard-glk: NOTRUN -> [SKIP][16] ([fdo#109271] / [i915#4613])
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7853/shard-glk2/igt@[email protected]
- shard-iclb: NOTRUN -> [SKIP][17] ([i915#4613])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7853/shard-iclb1/igt@[email protected]

* igt@gem_pxp@dmabuf-shared-protected-dst-is-context-refcounted:
- shard-iclb: NOTRUN -> [SKIP][18] ([i915#4270])
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7853/shard-iclb8/igt@[email protected]
- shard-tglb: NOTRUN -> [SKIP][19] ([i915#4270]) +1 similar issue
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7853/shard-tglb1/igt@[email protected]

* igt@gem_render_copy@yf-tiled-to-vebox-y-tiled:
- shard-iclb: NOTRUN -> [SKIP][20] ([i915#768]) +1 similar issue
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7853/shard-iclb2/igt@[email protected]

* igt@gem_userptr_blits@input-checking:
- shard-glk: NOTRUN -> [DMESG-WARN][21] ([i915#4991])
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7853/shard-glk8/igt@[email protected]

* igt@gem_workarounds@suspend-resume-fd:
- shard-apl: [PASS][22] -> [DMESG-WARN][23] ([i915#180])
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12192/shard-apl2/igt@[email protected]
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7853/shard-apl1/igt@[email protected]

* igt@gen7_exec_parse@basic-allowed:
- shard-tglb: NOTRUN -> [SKIP][24] ([fdo#109289])
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7853/shard-tglb3/igt@[email protected]

* igt@i915_pm_dc@dc9-dpms:
- shard-apl: [PASS][25] -> [SKIP][26] ([fdo#109271])
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12192/shard-apl8/igt@[email protected]
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7853/shard-apl2/igt@[email protected]
- shard-tglb: NOTRUN -> [SKIP][27] ([i915#4281])
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7853/shard-tglb1/igt@[email protected]

* igt@kms_big_fb@4-tiled-max-hw-stride-64bpp-rotate-0-hflip:
- shard-tglb: NOTRUN -> [SKIP][28] ([i915#5286])
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7853/shard-tglb2/igt@[email protected]

* igt@kms_ccs@pipe-a-bad-rotation-90-4_tiled_dg2_rc_ccs_cc:
- shard-iclb: NOTRUN -> [SKIP][29] ([fdo#109278]) +3 similar issues
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7853/shard-iclb5/igt@kms_ccs@pipe-a-bad-rotation-90-4_tiled_dg2_rc_ccs_cc.html
- shard-tglb: NOTRUN -> [SKIP][30] ([i915#6095])
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7853/shard-tglb2/igt@kms_ccs@pipe-a-bad-rotation-90-4_tiled_dg2_rc_ccs_cc.html

* igt@kms_ccs@pipe-a-crc-primary-rotation-180-4_tiled_dg2_rc_ccs:
- shard-apl: NOTRUN -> [SKIP][31] ([fdo#109271]) +181 similar issues
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7853/shard-apl7/igt@kms_ccs@pipe-a-crc-primary-rotation-180-4_tiled_dg2_rc_ccs.html

* igt@kms_ccs@pipe-a-crc-primary-rotation-180-yf_tiled_ccs:
- shard-tglb: NOTRUN -> [SKIP][32] ([fdo#111615] / [i915#3689]) +1 similar issue
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7853/shard-tglb3/igt@kms_ccs@pipe-a-crc-primary-rotation-180-yf_tiled_ccs.html

* igt@kms_ccs@pipe-a-missing-ccs-buffer-y_tiled_gen12_rc_ccs_cc:
- shard-glk: NOTRUN -> [SKIP][33] ([fdo#109271] / [i915#3886])
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7853/shard-glk5/igt@kms_ccs@pipe-a-missing-ccs-buffer-y_tiled_gen12_rc_ccs_cc.html
- shard-iclb: NOTRUN -> [SKIP][34] ([fdo#109278] / [i915#3886])
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7853/shard-iclb1/igt@kms_ccs@pipe-a-missing-ccs-buffer-y_tiled_gen12_rc_ccs_cc.html

* igt@kms_ccs@pipe-a-random-ccs-data-4_tiled_dg2_rc_ccs_cc:
- shard-tglb: NOTRUN -> [SKIP][35] ([i915#3689] / [i915#6095])
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7853/shard-tglb1/igt@kms_ccs@pipe-a-random-ccs-data-4_tiled_dg2_rc_ccs_cc.html

* igt@kms_ccs@pipe-b-bad-rotation-90-y_tiled_ccs:
- shard-tglb: NOTRUN -> [SKIP][36] ([i915#3689]) +2 similar issues
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7853/shard-tglb8/igt@kms_ccs@pipe-b-bad-rotation-90-y_tiled_ccs.html

* igt@kms_ccs@pipe-c-crc-primary-basic-y_tiled_gen12_mc_ccs:
- shard-apl: NOTRUN -> [SKIP][37] ([fdo#109271] / [i915#3886]) +6 similar issues
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7853/shard-apl7/igt@kms_ccs@pipe-c-crc-primary-basic-y_tiled_gen12_mc_ccs.html

* igt@kms_chamelium@vga-frame-dump:
- shard-apl: NOTRUN -> [SKIP][38] ([fdo#109271] / [fdo#111827]) +8 similar issues
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7853/shard-apl3/igt@[email protected]

* igt@kms_chamelium@vga-hpd:
- shard-tglb: NOTRUN -> [SKIP][39] ([fdo#109284] / [fdo#111827]) +4 similar issues
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7853/shard-tglb5/igt@[email protected]

* igt@kms_chamelium@vga-hpd-without-ddc:
- shard-snb: NOTRUN -> [SKIP][40] ([fdo#109271] / [fdo#111827]) +2 similar issues
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7853/shard-snb2/igt@[email protected]
- shard-glk: NOTRUN -> [SKIP][41] ([fdo#109271] / [fdo#111827]) +3 similar issues
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7853/shard-glk8/igt@[email protected]
- shard-iclb: NOTRUN -> [SKIP][42] ([fdo#109284] / [fdo#111827]) +2 similar issues
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7853/shard-iclb7/igt@[email protected]

* igt@kms_content_protection@atomic:
- shard-apl: NOTRUN -> [TIMEOUT][43] ([i915#1319])
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7853/shard-apl3/igt@[email protected]

* igt@kms_cursor_crc@cursor-offscreen-512x170:
- shard-tglb: NOTRUN -> [SKIP][44] ([fdo#109279] / [i915#3359])
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7853/shard-tglb1/igt@[email protected]

* igt@kms_cursor_crc@cursor-onscreen-512x512:
- shard-tglb: NOTRUN -> [SKIP][45] ([i915#3359])
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7853/shard-tglb1/igt@[email protected]

* igt@kms_cursor_legacy@flip-vs-cursor@atomic-transitions:
- shard-glk: NOTRUN -> [FAIL][46] ([i915#2346])
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7853/shard-glk8/igt@kms_cursor_legacy@[email protected]

* igt@kms_cursor_legacy@flip-vs-cursor@varying-size:
- shard-iclb: NOTRUN -> [FAIL][47] ([i915#2346]) +2 similar issues
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7853/shard-iclb7/igt@kms_cursor_legacy@[email protected]

* igt@kms_cursor_legacy@short-busy-flip-before-cursor:
- shard-tglb: NOTRUN -> [SKIP][48] ([i915#4103])
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7853/shard-tglb7/igt@[email protected]

* igt@kms_flip@2x-absolute-wf_vblank-interruptible:
- shard-iclb: NOTRUN -> [SKIP][49] ([fdo#109274])
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7853/shard-iclb7/igt@kms_flip@2x-absolute-wf_vblank-interruptible.html

* igt@kms_flip@2x-flip-vs-panning-vs-hang:
- shard-tglb: NOTRUN -> [SKIP][50] ([fdo#109274] / [fdo#111825] / [i915#3637]) +1 similar issue
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7853/shard-tglb1/igt@[email protected]

* igt@kms_flip@flip-vs-expired-vblank-interruptible@c-dp1:
- shard-apl: [PASS][51] -> [FAIL][52] ([i915#79])
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12192/shard-apl6/igt@kms_flip@[email protected]
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7853/shard-apl3/igt@kms_flip@[email protected]

* igt@kms_flip_scaled_crc@flip-64bpp-4tile-to-32bpp-4tiledg2rcccs-upscaling@pipe-a-default-mode:
- shard-iclb: NOTRUN -> [SKIP][53] ([i915#2672]) +3 similar issues
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7853/shard-iclb3/igt@kms_flip_scaled_crc@flip-64bpp-4tile-to-32bpp-4tiledg2rcccs-upscaling@pipe-a-default-mode.html

* igt@kms_flip_scaled_crc@flip-64bpp-linear-to-16bpp-linear-downscaling@pipe-a-default-mode:
- shard-iclb: NOTRUN -> [SKIP][54] ([i915#3555]) +2 similar issues
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7853/shard-iclb2/igt@kms_flip_scaled_crc@flip-64bpp-linear-to-16bpp-linear-downscaling@pipe-a-default-mode.html

* igt@kms_flip_scaled_crc@flip-64bpp-yftile-to-32bpp-yftile-upscaling@pipe-a-valid-mode:
- shard-iclb: NOTRUN -> [SKIP][55] ([i915#2587] / [i915#2672])
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7853/shard-iclb5/igt@kms_flip_scaled_crc@flip-64bpp-yftile-to-32bpp-yftile-upscaling@pipe-a-valid-mode.html

* igt@kms_frontbuffer_tracking@fbc-2p-primscrn-cur-indfb-draw-mmap-gtt:
- shard-iclb: NOTRUN -> [SKIP][56] ([fdo#109280]) +3 similar issues
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7853/shard-iclb3/igt@kms_frontbuffer_tracking@fbc-2p-primscrn-cur-indfb-draw-mmap-gtt.html

* igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-spr-indfb-draw-mmap-wc:
- shard-tglb: NOTRUN -> [SKIP][57] ([fdo#109280] / [fdo#111825]) +10 similar issues
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7853/shard-tglb1/igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-spr-indfb-draw-mmap-wc.html

* igt@kms_frontbuffer_tracking@fbcpsr-1p-offscren-pri-indfb-draw-blt:
- shard-tglb: NOTRUN -> [SKIP][58] ([i915#6497])
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7853/shard-tglb2/igt@kms_frontbuffer_tracking@fbcpsr-1p-offscren-pri-indfb-draw-blt.html

* igt@kms_plane_alpha_blend@pipe-b-alpha-transparent-fb:
- shard-glk: NOTRUN -> [FAIL][59] ([i915#265])
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7853/shard-glk1/igt@[email protected]
- shard-apl: NOTRUN -> [FAIL][60] ([i915#265])
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7853/shard-apl1/igt@[email protected]

* igt@kms_plane_scaling@planes-upscale-20x20-downscale-factor-0-5@pipe-b-edp-1:
- shard-iclb: [PASS][61] -> [SKIP][62] ([i915#5235]) +2 similar issues
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12192/shard-iclb7/igt@kms_plane_scaling@[email protected]
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7853/shard-iclb2/igt@kms_plane_scaling@[email protected]

* igt@kms_prime@d3hot:
- shard-tglb: NOTRUN -> [SKIP][63] ([i915#6524])
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7853/shard-tglb1/igt@[email protected]

* igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area:
- shard-apl: NOTRUN -> [SKIP][64] ([fdo#109271] / [i915#658])
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7853/shard-apl2/igt@[email protected]

* igt@kms_psr2_su@page_flip-nv12:
- shard-tglb: NOTRUN -> [SKIP][65] ([i915#1911])
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7853/shard-tglb3/igt@kms_psr2_su@page_flip-nv12.html

* igt@kms_psr@psr2_sprite_blt:
- shard-iclb: NOTRUN -> [SKIP][66] ([fdo#109441])
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7853/shard-iclb3/igt@kms_psr@psr2_sprite_blt.html
- shard-tglb: NOTRUN -> [FAIL][67] ([i915#132] / [i915#3467])
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7853/shard-tglb3/igt@kms_psr@psr2_sprite_blt.html

* igt@kms_setmode@basic@pipe-a-vga-1:
- shard-snb: NOTRUN -> [FAIL][68] ([i915#5465]) +1 similar issue
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7853/shard-snb6/igt@kms_setmode@[email protected]

* igt@kms_setmode@invalid-clone-single-crtc:
- shard-tglb: NOTRUN -> [SKIP][69] ([i915#3555]) +1 similar issue
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7853/shard-tglb7/igt@[email protected]

* igt@nouveau_crc@pipe-d-ctx-flip-detection:
- shard-glk: NOTRUN -> [SKIP][70] ([fdo#109271]) +67 similar issues
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7853/shard-glk2/igt@[email protected]

* igt@prime_nv_pcopy@test3_5:
- shard-snb: NOTRUN -> [SKIP][71] ([fdo#109271]) +81 similar issues
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7853/shard-snb4/igt@prime_nv_pcopy@test3_5.html

* igt@sysfs_clients@busy:
- shard-tglb: NOTRUN -> [SKIP][72] ([i915#2994]) +2 similar issues
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7853/shard-tglb7/igt@[email protected]

* igt@sysfs_clients@sema-10:
- shard-glk: NOTRUN -> [SKIP][73] ([fdo#109271] / [i915#2994]) +1 similar issue
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7853/shard-glk3/igt@[email protected]

* igt@sysfs_clients@split-25:
- shard-iclb: NOTRUN -> [SKIP][74] ([i915#2994]) +1 similar issue
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7853/shard-iclb5/igt@[email protected]
- shard-apl: NOTRUN -> [SKIP][75] ([fdo#109271] / [i915#2994]) +1 similar issue
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7853/shard-apl8/igt@[email protected]

#### Possible fixes ####

* igt@gem_exec_balancer@parallel:
- shard-iclb: [SKIP][76] ([i915#4525]) -> [PASS][77]
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12192/shard-iclb7/igt@[email protected]
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7853/shard-iclb4/igt@[email protected]

* igt@gem_exec_fair@basic-flow@rcs0:
- shard-tglb: [FAIL][78] ([i915#2842]) -> [PASS][79]
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12192/shard-tglb5/igt@gem_exec_fair@[email protected]
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7853/shard-tglb7/igt@gem_exec_fair@[email protected]

* igt@gem_exec_fair@basic-pace@vcs0:
- shard-glk: [FAIL][80] ([i915#2842]) -> [PASS][81] +1 similar issue
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12192/shard-glk3/igt@gem_exec_fair@[email protected]
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7853/shard-glk8/igt@gem_exec_fair@[email protected]
- shard-iclb: [FAIL][82] ([i915#2842]) -> [PASS][83]
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12192/shard-iclb2/igt@gem_exec_fair@[email protected]
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7853/shard-iclb7/igt@gem_exec_fair@[email protected]

* igt@gen9_exec_parse@allowed-single:
- shard-apl: [DMESG-WARN][84] ([i915#5566] / [i915#716]) -> [PASS][85]
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12192/shard-apl1/igt@[email protected]
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7853/shard-apl6/igt@[email protected]

* igt@kms_cursor_legacy@forked-bo@pipe-b:
- shard-glk: [DMESG-WARN][86] ([i915#118]) -> [PASS][87]
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12192/shard-glk3/igt@kms_cursor_legacy@[email protected]
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7853/shard-glk7/igt@kms_cursor_legacy@[email protected]

* igt@kms_flip@flip-vs-suspend@c-dp1:
- shard-apl: [DMESG-WARN][88] ([i915#180]) -> [PASS][89] +2 similar issues
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12192/shard-apl6/igt@kms_flip@[email protected]
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7853/shard-apl6/igt@kms_flip@[email protected]

* igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytileccs-downscaling@pipe-a-default-mode:
- shard-iclb: [SKIP][90] ([i915#3555]) -> [PASS][91]
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12192/shard-iclb2/igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytileccs-downscaling@pipe-a-default-mode.html
[91]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7853/shard-iclb3/igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytileccs-downscaling@pipe-a-default-mode.html

* igt@kms_plane_scaling@planes-unity-scaling-downscale-factor-0-5@pipe-c-edp-1:
- shard-iclb: [SKIP][92] ([i915#5235]) -> [PASS][93] +2 similar issues
[92]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12192/shard-iclb2/igt@kms_plane_scaling@[email protected]
[93]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7853/shard-iclb6/igt@kms_plane_scaling@[email protected]

* igt@kms_psr@psr2_primary_mmap_cpu:
- shard-iclb: [SKIP][94] ([fdo#109441]) -> [PASS][95] +3 similar issues
[94]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12192/shard-iclb4/igt@kms_psr@psr2_primary_mmap_cpu.html
[95]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7853/shard-iclb2/igt@kms_psr@psr2_primary_mmap_cpu.html

* igt@kms_psr_stress_test@flip-primary-invalidate-overlay:
- shard-iclb: [SKIP][96] ([i915#5519]) -> [PASS][97]
[96]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12192/shard-iclb1/igt@[email protected]
[97]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7853/shard-iclb6/igt@[email protected]

#### Warnings ####

* igt@gem_exec_balancer@parallel-ordering:
- shard-iclb: [FAIL][98] ([i915#6117]) -> [SKIP][99] ([i915#4525])
[98]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12192/shard-iclb2/igt@[email protected]
[99]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7853/shard-iclb5/igt@[email protected]

* igt@i915_pm_rc6_residency@rc6-idle@vcs0:
- shard-iclb: [FAIL][100] ([i915#2684]) -> [WARN][101] ([i915#2684])
[100]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12192/shard-iclb7/igt@i915_pm_rc6_residency@[email protected]
[101]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7853/shard-iclb4/igt@i915_pm_rc6_residency@[email protected]

* igt@kms_content_protection@mei_interface:
- shard-tglb: [SKIP][102] ([fdo#109300]) -> [SKIP][103] ([i915#1063])
[102]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12192/shard-tglb3/igt@kms_content_protection@mei_interface.html
[103]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7853/shard-tglb3/igt@kms_content_protection@mei_interface.html
- shard-iclb: [SKIP][104] ([fdo#109300]) -> [SKIP][105] ([fdo#109300] / [fdo#111066])
[104]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12192/shard-iclb7/igt@kms_content_protection@mei_interface.html
[105]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7853/shard-iclb3/igt@kms_content_protection@mei_interface.html

* igt@kms_psr2_sf@cursor-plane-move-continuous-exceed-sf:
- shard-iclb: [SKIP][106] ([i915#658]) -> [SKIP][107] ([i915#2920]) +1 similar issue
[106]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12192/shard-iclb5/igt@[email protected]
[107]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7853/shard-iclb2/igt@[email protected]

* igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area:
- shard-iclb: [SKIP][108] ([i915#2920]) -> [SKIP][109] ([fdo#111068] / [i915#658])
[108]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12192/shard-iclb2/igt@[email protected]
[109]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7853/shard-iclb8/igt@[email protected]

[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109274]: https://bugs.freedesktop.org/show_bug.cgi?id=109274
[fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278
[fdo#109279]: https://bugs.freedesktop.org/show_bug.cgi?id=109279
[fdo#109280]: https://bugs.freedesktop.org/show_bug.cgi?id=109280
[fdo#109284]: https://bugs.freedesktop.org/show_bug.cgi?id=109284
[fdo#109289]: https://bugs.freedesktop.org/show_bug.cgi?id=109289
[fdo#109300]: https://bugs.freedesktop.org/show_bug.cgi?id=109300
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[fdo#111066]: https://bugs.freedesktop.org/show_bug.cgi?id=111066
[fdo#111068]: https://bugs.freedesktop.org/show_bug.cgi?id=111068
[fdo#111615]: https://bugs.freedesktop.org/show_bug.cgi?id=111615
[fdo#111825]: https://bugs.freedesktop.org/show_bug.cgi?id=111825
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[i915#1063]: https://gitlab.freedesktop.org/drm/intel/issues/1063
[i915#118]: https://gitlab.freedesktop.org/drm/intel/issues/118
[i915#1319]: https://gitlab.freedesktop.org/drm/intel/issues/1319
[i915#132]: https://gitlab.freedesktop.org/drm/intel/issues/132
[i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180
[i915#1911]: https://gitlab.freedesktop.org/drm/intel/issues/1911
[i915#2346]: https://gitlab.freedesktop.org/drm/intel/issues/2346
[i915#2587]: https://gitlab.freedesktop.org/drm/intel/issues/2587
[i915#265]: https://gitlab.freedesktop.org/drm/intel/issues/265
[i915#2672]: https://gitlab.freedesktop.org/drm/intel/issues/2672
[i915#2684]: https://gitlab.freedesktop.org/drm/intel/issues/2684
[i915#2842]: https://gitlab.freedesktop.org/drm/intel/issues/2842
[i915#2920]: https://gitlab.freedesktop.org/drm/intel/issues/2920
[i915#2994]: https://gitlab.freedesktop.org/drm/intel/issues/2994
[i915#3359]: https://gitlab.freedesktop.org/drm/intel/issues/3359
[i915#3467]: https://gitlab.freedesktop.org/drm/intel/issues/3467
[i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
[i915#3637]: https://gitlab.freedesktop.org/drm/intel/issues/3637
[i915#3689]: https://gitlab.freedesktop.org/drm/intel/issues/3689
[i915#3886]: https://gitlab.freedesktop.org/drm/intel/issues/3886
[i915#4103]: https://gitlab.freedesktop.org/drm/intel/issues/4103
[i915#4270]: https://gitlab.freedesktop.org/drm/intel/issues/4270
[i915#4281]: https://gitlab.freedesktop.org/drm/intel/issues/4281
[i915#4525]: https://gitlab.freedesktop.org/drm/intel/issues/4525
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#4991]: https://gitlab.freedesktop.org/drm/intel/issues/4991
[i915#5235]: https://gitlab.freedesktop.org/drm/intel/issues/5235
[i915#5286]: https://gitlab.freedesktop.org/drm/intel/issues/5286
[i915#5325]: https://gitlab.freedesktop.org/drm/intel/issues/5325
[i915#5465]: https://gitlab.freedesktop.org/drm/intel/issues/5465
[i915#5519]: https://gitlab.freedesktop.org/drm/intel/issues/5519
[i915#5566]: https://gitlab.freedesktop.org/drm/intel/issues/5566
[i915#5784]: https://gitlab.freedesktop.org/drm/intel/issues/5784
[i915#6095]: https://gitlab.freedesktop.org/drm/intel/issues/6095
[i915#6117]: https://gitlab.freedesktop.org/drm/intel/issues/6117
[i915#6344]: https://gitlab.freedesktop.org/drm/intel/issues/6344
[i915#6497]: https://gitlab.freedesktop.org/drm/intel/issues/6497
[i915#6524]: https://gitlab.freedesktop.org/drm/intel/issues/6524
[i915#658]: https://gitlab.freedesktop.org/drm/intel/issues/658
[i915#716]: https://gitlab.freedesktop.org/drm/intel/issues/716
[i915#768]: https://gitlab.freedesktop.org/drm/intel/issues/768
[i915#79]: https://gitlab.freedesktop.org/drm/intel/issues/79

Build changes
-------------

* CI: CI-20190529 -> None
* IGT: IGT_6666 -> IGTPW_7853
* Piglit: piglit_4509 -> None

CI-20190529: 20190529
CI_DRM_12192: 83f5b1665fc067c78ed2d46c585d8c49e57e6b06 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_7853: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7853/index.html
IGT_6666: 1e3ecbaa3c56f4c52c62047707eb4942d3a39c44 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7853/index.html

#3 lore raw
In reply to Alex Hung

is the second fix not necessary anymore?

Quoted 16 lines · Alex Hung

amdgpu rejects when crtc is on + all planes are off, and it is necessary to turn off crtc when all planes are off.

This is revised from https://patchwork.freedesktop.org/series/80904/

---
 tests/kms_plane_multiple.c | 3 +++
 1 file changed, 3 insertions(+)
tests/kms_plane_multiple.c +0 -0
index cbe8c189..e900dc7f 100644

tests/kms_plane_multiple.c test_plane_position_with_output(data_t *data, enum pipe pipe, · line 315

Quoted 5 lines
tests/kms_plane_multiple.c +2 -0
@@ -311,6 +311,8 @@ test_plane_position_with_output(data_t *data, enum pipe pipe,
                for_each_plane_on_pipe(&data->display, pipe, plane)
                        igt_plane_set_fb(plane, NULL);
 
+               if (is_amdgpu_device(data->drm_fd))
+                       igt_output_set_pipe(output, PIPE_NONE);

I'm still confused why do you need this just for AMD. If AMD has some requirements, I think it's gonna work for everyone else. If it breaks in the CI (testing on intel devices), then I think something is off here, and maybe it's a kernel thing.
If it's the crtc/plan workaround that's in amdgpu, an IGT fix has always worked for everyone and didn't need an (is amd only) check.

Quoted 14 lines
tests/kms_plane_multiple.c +1 -1
                igt_display_commit2(&data->display, COMMIT_ATOMIC);
 
                for (int x = 0; x < c; x++)
@@ -344,6 +346,7 @@ test_plane_position_with_output(data_t *data, enum pipe pipe,
                for_each_plane_on_pipe(&data->display, pipe, plane)
                        igt_plane_set_fb(plane, NULL);
 
+               igt_output_set_pipe(output, PIPE_NONE);
                igt_display_commit2(&data->display, COMMIT_ATOMIC);
 
                for (int x = 0; x < c; x++)
--

2.34.1

author
#4 lore raw
Quoted 2 lines · Mark Yacoub

is the second fix not necessary anymore?

The second fix is still needed but it does not need to be guarded by is_amdgpu_device().

From IGT's CI test this seems to work fine.

Quoted 20 lines · Alex Hung
Quoted 19 lines

amdgpu rejects when crtc is on + all planes are off, and it is necessary to turn off crtc when all planes are off.

This is revised from https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpatchwork.freedesktop.org%2Fseries%2F80904%2F&amp;data=05%7C01%7Calex.hung%40amd.com%7C9618c44c52534176fa7608daa15c3b0e%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637999714757526450%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&amp;sdata=F%2FJ0xvZA1mpVrmuEimtMYUIXolalP9GG9NUGjfRepR0%3D&amp;reserved=0

---
  tests/kms_plane_multiple.c | 3 +++
  1 file changed, 3 insertions(+)
tests/kms_plane_multiple.c +0 -0
index cbe8c189..e900dc7f 100644
@@ -311,6 +311,8 @@ test_plane_position_with_output(data_t *data, enum pipe pipe,
                 for_each_plane_on_pipe(&data->display, pipe, plane)
                         igt_plane_set_fb(plane, NULL);
 
Quoted 8 lines

tests/kms_plane_multiple.c test_plane_position_with_output(data_t *data, enum pipe pipe, · line 315

Quoted 2 lines
tests/kms_plane_multiple.c +2 -0
+               if (is_amdgpu_device(data->drm_fd))
+                       igt_output_set_pipe(output, PIPE_NONE);

I'm still confused why do you need this just for AMD. If AMD has some requirements, I think it's gonna work for everyone else. If it breaks in the CI (testing on intel devices), then I think something is off here, and maybe it's a kernel thing.
If it's the crtc/plan workaround that's in amdgpu, an IGT fix has always worked for everyone and didn't need an (is amd only) check.

It may not be for AMD only and can also work for other GPUs. See discussion https://lore.kernel.org/all/[email protected]/T/#m03b3196cbebcd85013b04f8e9bca3b130e4557d1

Without is_amdgpu_device() it breaks at least one i915 device. In theory "is_amdgpu_device()" can be replaced by "!is_i915_device()" but this patch was not tested on other GPUs so I did not assume that it works on all other GPUs.

Quoted 14 lines
Quoted 14 lines
tests/kms_plane_multiple.c +1 -1
                 igt_display_commit2(&data->display, COMMIT_ATOMIC);
 
                 for (int x = 0; x < c; x++)
@@ -344,6 +346,7 @@ test_plane_position_with_output(data_t *data, enum pipe pipe,
                 for_each_plane_on_pipe(&data->display, pipe, plane)
                         igt_plane_set_fb(plane, NULL);
 
+               igt_output_set_pipe(output, PIPE_NONE);
                 igt_display_commit2(&data->display, COMMIT_ATOMIC);
 
                 for (int x = 0; x < c; x++)
--

2.34.1