Skip to contentSkip to conversation

arm64: dts: qcom: cp01-c1: remove bootargs-append

PATCH Applied Robert Marko 4 participants 7 messages Sep 27, 2022 – Oct 18, 2022

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/2 arm64: dts: qcom: cp01-c1: remove bootargs-append

bootargs-append is a leftover from the vendor SDK, and does not exist in the mainline kernel at all, so remove it.

---
 arch/arm64/boot/dts/qcom/ipq6018-cp01-c1.dts | 1 -
 1 file changed, 1 deletion(-)
arch/arm64/boot/dts/qcom/ipq6018-cp01-c1.dts +0 -1
index ff4c46645104..eaaaaa72234f 100644
@@ -20,7 +20,6 @@ aliases {
 
 	chosen {
 		stdout-path = "serial0:115200n8";
-		bootargs-append = " swiotlb=1";
 	};
 };
 
Signature · 1 line
2.37.3
#1 lore raw

PATCH 2/2 arm64: dts: qcom: cp01-c1: use "okay" instead of "ok"

Use "okay" instead of "ok" in USB nodes as "ok" is deprecated.

---
 arch/arm64/boot/dts/qcom/ipq6018-cp01-c1.dts | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
arch/arm64/boot/dts/qcom/ipq6018-cp01-c1.dts +2 -2
index eaaaaa72234f..c424b8390c78 100644
@@ -106,9 +106,9 @@ &sdhci {
 };
 
 &qusb_phy_1 {
-	status = "ok";
+	status = "okay";
 };
 
 &usb2 {
-	status = "ok";
+	status = "okay";
 };
Signature · 1 line
2.37.3
Reviewed-by on v1 2/2
#2 lore raw

Re: [PATCH 2/2] arm64: dts: qcom: cp01-c1: use "okay" instead of "ok"

Quoted 13 lines · Robert Marko

Use "okay" instead of "ok" in USB nodes as "ok" is deprecated.

---
  arch/arm64/boot/dts/qcom/ipq6018-cp01-c1.dts | 4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)
arch/arm64/boot/dts/qcom/ipq6018-cp01-c1.dts +0 -0
index eaaaaa72234f..c424b8390c78 100644
@@ -106,9 +106,9 @@ &sdhci {
  };

arch/arm64/boot/dts/qcom/ipq6018-cp01-c1.dts &sdhci { · line 114

Quoted 10 lines
arch/arm64/boot/dts/qcom/ipq6018-cp01-c1.dts +2 -2
 
  &qusb_phy_1 {
-	status = "ok";
+	status = "okay";
  };
 
  &usb2 {
-	status = "ok";
+	status = "okay";
  };
Reviewed-by on v1 1/2
#4 lore raw
In reply to Robert Marko
Quoted 13 lines · Robert Marko

bootargs-append is a leftover from the vendor SDK, and does not exist in the mainline kernel at all, so remove it.

---
  arch/arm64/boot/dts/qcom/ipq6018-cp01-c1.dts | 1 -
  1 file changed, 1 deletion(-)
arch/arm64/boot/dts/qcom/ipq6018-cp01-c1.dts +0 -0
index ff4c46645104..eaaaaa72234f 100644

arch/arm64/boot/dts/qcom/ipq6018-cp01-c1.dts aliases { · line 25

Quoted 7 lines
arch/arm64/boot/dts/qcom/ipq6018-cp01-c1.dts +0 -1
@@ -20,7 +20,6 @@ aliases {
 
  	chosen {
  		stdout-path = "serial0:115200n8";
-		bootargs-append = " swiotlb=1";
  	};
  };
 
maintainer Applied
#6 lore raw

Re: (subset) [PATCH 1/2] arm64: dts: qcom: cp01-c1: remove bootargs-append

In reply to Robert Marko
Quoted 4 lines · Robert Marko

bootargs-append is a leftover from the vendor SDK, and does not exist in the mainline kernel at all, so remove it.

Applied, thanks!

[1/2] arm64: dts: qcom: cp01-c1: remove bootargs-append

      commit: f493bf2e70c6540f79fda3b28d636f1dd486d17a
[2/2] arm64: dts: qcom: cp01-c1: use "okay" instead of "ok"
      commit: 4d29e016eb72d14fa4fb4e5c90c880d260b8b281

Best regards,

Signature · 1 line
Bjorn Andersson <[email protected]>