Skip to contentSkip to conversation

binutils: another way to clear GPROFNG_ALTS for clang and musl

PATCH In review [email protected] 2 participants 2 messages Sep 29, 2022

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 binutils: another way to clear GPROFNG_ALTS for clang and musl

From: Kai Kang <[email protected]>

It disables gprofng for toolchain clang and libc musl, so GPROFNG_ALTS should be cleared for them. But override 'toolchain-clang' is applied before overrides 'TRANSLATED_TARGET_ARCH' such as x86-64, then GPROFNG_ALTS is still set and not cleared.

Apply overrides 'toolchain-clang' and 'libc-musl' for GPROFNGS rather than GPROFNG_ALTS to make it work as expected.

---
 meta/recipes-devtools/binutils/binutils.inc | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)
meta/recipes-devtools/binutils/binutils.inc +5 -4
index 4dde387a8a..98acf0a222 100644
@@ -44,15 +44,16 @@ GPROFNGS = " \
 	gp-display-text \
 	gprofng \
 "
+
+# it disables gprofng for clang and musl in the bb file
+GPROFNGS:toolchain-clang = ""
+GPROFNGS:libc-musl = ""
+
 GPROFNG_ALTS ?= ""
 GPROFNG_ALTS:x86 = "${GPROFNGS}"
 GPROFNG_ALTS:x86-64 = "${GPROFNGS}"
 GPROFNG_ALTS:aarch64 = "${GPROFNGS}"
 
-# it disables gprofng for clang and musl in the bb file
-GPROFNG_ALTS:toolchain-clang = ""
-GPROFNG_ALTS:libc-musl = ""
-
 LDGOLD_ALTS ?= "ld.gold dwp"
 LDGOLD_ALTS:riscv64 = ""
 LDGOLD_ALTS:riscv32 = ""
Signature · 1 line
2.17.1
#1 lore raw

Fixes my builds, thanks Kai.

Ross

Quoted 54 lines · kai via lists.openembedded.org

From: Kai Kang <[email protected]>

It disables gprofng for toolchain clang and libc musl, so GPROFNG_ALTS should be cleared for them. But override 'toolchain-clang' is applied before overrides 'TRANSLATED_TARGET_ARCH' such as x86-64, then GPROFNG_ALTS is still set and not cleared.

Apply overrides 'toolchain-clang' and 'libc-musl' for GPROFNGS rather than GPROFNG_ALTS to make it work as expected.

---
meta/recipes-devtools/binutils/binutils.inc | 9 +++++----

1 file changed, 5 insertions(+), 4 deletions(-)
meta/recipes-devtools/binutils/binutils.inc +0 -0
index 4dde387a8a..98acf0a222 100644
@@ -44,15 +44,16 @@ GPROFNGS = " \
 	gp-display-text \
 	gprofng \

"

meta/recipes-devtools/binutils/binutils.inc +5 -0
+
+# it disables gprofng for clang and musl in the bb file
+GPROFNGS:toolchain-clang = ""
+GPROFNGS:libc-musl = ""
+

GPROFNG_ALTS ?= ""
GPROFNG_ALTS:x86 = "${GPROFNGS}"
GPROFNG_ALTS:x86-64 = "${GPROFNGS}"
GPROFNG_ALTS:aarch64 = "${GPROFNGS}"

meta/recipes-devtools/binutils/binutils.inc +0 -4
-# it disables gprofng for clang and musl in the bb file
-GPROFNG_ALTS:toolchain-clang = ""
-GPROFNG_ALTS:libc-musl = ""
-

LDGOLD_ALTS ?= "ld.gold dwp"
LDGOLD_ALTS:riscv64 = ""
LDGOLD_ALTS:riscv32 = ""

Signature · 10 lines
2.17.1


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#171173): https://lists.openembedded.org/g/openembedded-core/message/171173
Mute This Topic: https://lists.openembedded.org/mt/93990044/6875888
Group Owner: [email protected]
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-