Skip to contentSkip to conversation

loongarch: update config files

PATCH In review Lukas Bulwahn 4 participants 8 messages Sep 29, 2022 – Sep 30, 2022

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 loongarch: update config files

Clean up config files by:
- removing configs that were deleted in the past
- removing configs not in tree and without recently pending patches
- adding new configs that are replacements for old configs in the file

For some detailed information, see Link.

---
 arch/loongarch/configs/loongson3_defconfig | 7 -------
 1 file changed, 7 deletions(-)
arch/loongarch/configs/loongson3_defconfig +0 -7
index 3712552e18d3..2b4220778b66 100644
@@ -108,14 +108,12 @@ CONFIG_NETFILTER=y
 CONFIG_BRIDGE_NETFILTER=m
 CONFIG_NETFILTER_NETLINK_LOG=m
 CONFIG_NF_CONNTRACK=m
-CONFIG_NF_LOG_NETDEV=m
 CONFIG_NF_CONNTRACK_AMANDA=m
 CONFIG_NF_CONNTRACK_FTP=m
 CONFIG_NF_CONNTRACK_NETBIOS_NS=m
 CONFIG_NF_CONNTRACK_TFTP=m
 CONFIG_NF_CT_NETLINK=m
 CONFIG_NF_TABLES=m
-CONFIG_NFT_COUNTER=m
 CONFIG_NFT_CONNLIMIT=m
 CONFIG_NFT_LOG=m
 CONFIG_NFT_LIMIT=m
@@ -329,7 +327,6 @@ CONFIG_PARPORT_PC_FIFO=y
 CONFIG_ZRAM=m
 CONFIG_ZRAM_DEF_COMP_ZSTD=y
 CONFIG_BLK_DEV_LOOP=y
-CONFIG_BLK_DEV_CRYPTOLOOP=y
 CONFIG_BLK_DEV_NBD=m
 CONFIG_BLK_DEV_RAM=y
 CONFIG_BLK_DEV_RAM_SIZE=8192
@@ -505,7 +502,6 @@ CONFIG_ATH9K_HTC=m
 CONFIG_IWLWIFI=m
 CONFIG_IWLDVM=m
 CONFIG_IWLMVM=m
-CONFIG_IWLWIFI_BCAST_FILTERING=y
 CONFIG_HOSTAP=m
 CONFIG_MT7601U=m
 CONFIG_RT2X00=m
@@ -688,7 +684,6 @@ CONFIG_COMEDI_NI_PCIDIO=m
 CONFIG_COMEDI_NI_PCIMIO=m
 CONFIG_STAGING=y
 CONFIG_R8188EU=m
-# CONFIG_88EU_AP_MODE is not set
 CONFIG_PM_DEVFREQ=y
 CONFIG_DEVFREQ_GOV_SIMPLE_ONDEMAND=y
 CONFIG_DEVFREQ_GOV_PERFORMANCE=y
@@ -772,14 +767,12 @@ CONFIG_CRYPTO_CRYPTD=m
 CONFIG_CRYPTO_CHACHA20POLY1305=m
 CONFIG_CRYPTO_HMAC=y
 CONFIG_CRYPTO_VMAC=m
-CONFIG_CRYPTO_TGR192=m
 CONFIG_CRYPTO_WP512=m
 CONFIG_CRYPTO_ANUBIS=m
 CONFIG_CRYPTO_BLOWFISH=m
 CONFIG_CRYPTO_CAST5=m
 CONFIG_CRYPTO_CAST6=m
 CONFIG_CRYPTO_KHAZAD=m
-CONFIG_CRYPTO_SALSA20=m
 CONFIG_CRYPTO_SEED=m
 CONFIG_CRYPTO_SERPENT=m
 CONFIG_CRYPTO_TEA=m
Signature · 1 line
2.17.1
maintainer
#1 lore raw

Hi, Lukas,

Thank you for your patch, it is queued for loongarch-next, and may be squashed to another patch with your S-o-B if you have no objections.

Huacai

Quoted 77 lines · Lukas Bulwahn

Clean up config files by:
- removing configs that were deleted in the past
- removing configs not in tree and without recently pending patches
- adding new configs that are replacements for old configs in the file

For some detailed information, see Link.

---
 arch/loongarch/configs/loongson3_defconfig | 7 -------
 1 file changed, 7 deletions(-)
arch/loongarch/configs/loongson3_defconfig +0 -8
index 3712552e18d3..2b4220778b66 100644
@@ -108,14 +108,12 @@ CONFIG_NETFILTER=y
 CONFIG_BRIDGE_NETFILTER=m
 CONFIG_NETFILTER_NETLINK_LOG=m
 CONFIG_NF_CONNTRACK=m
-CONFIG_NF_LOG_NETDEV=m
 CONFIG_NF_CONNTRACK_AMANDA=m
 CONFIG_NF_CONNTRACK_FTP=m
 CONFIG_NF_CONNTRACK_NETBIOS_NS=m
 CONFIG_NF_CONNTRACK_TFTP=m
 CONFIG_NF_CT_NETLINK=m
 CONFIG_NF_TABLES=m
-CONFIG_NFT_COUNTER=m
 CONFIG_NFT_CONNLIMIT=m
 CONFIG_NFT_LOG=m
 CONFIG_NFT_LIMIT=m
@@ -329,7 +327,6 @@ CONFIG_PARPORT_PC_FIFO=y
 CONFIG_ZRAM=m
 CONFIG_ZRAM_DEF_COMP_ZSTD=y
 CONFIG_BLK_DEV_LOOP=y
-CONFIG_BLK_DEV_CRYPTOLOOP=y
 CONFIG_BLK_DEV_NBD=m
 CONFIG_BLK_DEV_RAM=y
 CONFIG_BLK_DEV_RAM_SIZE=8192
@@ -505,7 +502,6 @@ CONFIG_ATH9K_HTC=m
 CONFIG_IWLWIFI=m
 CONFIG_IWLDVM=m
 CONFIG_IWLMVM=m
-CONFIG_IWLWIFI_BCAST_FILTERING=y
 CONFIG_HOSTAP=m
 CONFIG_MT7601U=m
 CONFIG_RT2X00=m
@@ -688,7 +684,6 @@ CONFIG_COMEDI_NI_PCIDIO=m
 CONFIG_COMEDI_NI_PCIMIO=m
 CONFIG_STAGING=y
 CONFIG_R8188EU=m
-# CONFIG_88EU_AP_MODE is not set
 CONFIG_PM_DEVFREQ=y
 CONFIG_DEVFREQ_GOV_SIMPLE_ONDEMAND=y
 CONFIG_DEVFREQ_GOV_PERFORMANCE=y
@@ -772,14 +767,12 @@ CONFIG_CRYPTO_CRYPTD=m
 CONFIG_CRYPTO_CHACHA20POLY1305=m
 CONFIG_CRYPTO_HMAC=y
 CONFIG_CRYPTO_VMAC=m
-CONFIG_CRYPTO_TGR192=m
 CONFIG_CRYPTO_WP512=m
 CONFIG_CRYPTO_ANUBIS=m
 CONFIG_CRYPTO_BLOWFISH=m
 CONFIG_CRYPTO_CAST5=m
 CONFIG_CRYPTO_CAST6=m
 CONFIG_CRYPTO_KHAZAD=m
-CONFIG_CRYPTO_SALSA20=m
 CONFIG_CRYPTO_SEED=m
 CONFIG_CRYPTO_SERPENT=m
 CONFIG_CRYPTO_TEA=m
--

2.17.1

#2 lore raw
Quoted 8 lines · Huacai Chen

Hi, Lukas,

Thank you for your patch, it is queued for loongarch-next, and may be squashed to another patch with your S-o-B if you have no objections.

Huacai

Feel free to squash as you see fit. I cannot recall sending something specific for loongarch-next, though.

Lukas

Quoted 78 lines · Lukas Bulwahn
Quoted 77 lines

Clean up config files by:
- removing configs that were deleted in the past
- removing configs not in tree and without recently pending patches
- adding new configs that are replacements for old configs in the file

For some detailed information, see Link.

---
 arch/loongarch/configs/loongson3_defconfig | 7 -------
 1 file changed, 7 deletions(-)
arch/loongarch/configs/loongson3_defconfig +0 -8
index 3712552e18d3..2b4220778b66 100644
@@ -108,14 +108,12 @@ CONFIG_NETFILTER=y
 CONFIG_BRIDGE_NETFILTER=m
 CONFIG_NETFILTER_NETLINK_LOG=m
 CONFIG_NF_CONNTRACK=m
-CONFIG_NF_LOG_NETDEV=m
 CONFIG_NF_CONNTRACK_AMANDA=m
 CONFIG_NF_CONNTRACK_FTP=m
 CONFIG_NF_CONNTRACK_NETBIOS_NS=m
 CONFIG_NF_CONNTRACK_TFTP=m
 CONFIG_NF_CT_NETLINK=m
 CONFIG_NF_TABLES=m
-CONFIG_NFT_COUNTER=m
 CONFIG_NFT_CONNLIMIT=m
 CONFIG_NFT_LOG=m
 CONFIG_NFT_LIMIT=m
@@ -329,7 +327,6 @@ CONFIG_PARPORT_PC_FIFO=y
 CONFIG_ZRAM=m
 CONFIG_ZRAM_DEF_COMP_ZSTD=y
 CONFIG_BLK_DEV_LOOP=y
-CONFIG_BLK_DEV_CRYPTOLOOP=y
 CONFIG_BLK_DEV_NBD=m
 CONFIG_BLK_DEV_RAM=y
 CONFIG_BLK_DEV_RAM_SIZE=8192
@@ -505,7 +502,6 @@ CONFIG_ATH9K_HTC=m
 CONFIG_IWLWIFI=m
 CONFIG_IWLDVM=m
 CONFIG_IWLMVM=m
-CONFIG_IWLWIFI_BCAST_FILTERING=y
 CONFIG_HOSTAP=m
 CONFIG_MT7601U=m
 CONFIG_RT2X00=m
@@ -688,7 +684,6 @@ CONFIG_COMEDI_NI_PCIDIO=m
 CONFIG_COMEDI_NI_PCIMIO=m
 CONFIG_STAGING=y
 CONFIG_R8188EU=m
-# CONFIG_88EU_AP_MODE is not set
 CONFIG_PM_DEVFREQ=y
 CONFIG_DEVFREQ_GOV_SIMPLE_ONDEMAND=y
 CONFIG_DEVFREQ_GOV_PERFORMANCE=y
@@ -772,14 +767,12 @@ CONFIG_CRYPTO_CRYPTD=m
 CONFIG_CRYPTO_CHACHA20POLY1305=m
 CONFIG_CRYPTO_HMAC=y
 CONFIG_CRYPTO_VMAC=m
-CONFIG_CRYPTO_TGR192=m
 CONFIG_CRYPTO_WP512=m
 CONFIG_CRYPTO_ANUBIS=m
 CONFIG_CRYPTO_BLOWFISH=m
 CONFIG_CRYPTO_CAST5=m
 CONFIG_CRYPTO_CAST6=m
 CONFIG_CRYPTO_KHAZAD=m
-CONFIG_CRYPTO_SALSA20=m
 CONFIG_CRYPTO_SEED=m
 CONFIG_CRYPTO_SERPENT=m
 CONFIG_CRYPTO_TEA=m
--

2.17.1

maintainer
#3 lore raw
Quoted 5 lines · Lukas Bulwahn
Quoted 3 lines · Huacai Chen

Hi, Lukas,

Quoted 8 lines
Quoted 5 lines

Thank you for your patch, it is queued for loongarch-next, and may be squashed to another patch with your S-o-B if you have no objections.

Huacai

Feel free to squash as you see fit. I cannot recall sending something specific for loongarch-next, though.

Emmm, my meaning is squash your patch to mine and keep a S-o-B in that patch [1]. :)

[1] https://git.kernel.org/pub/scm/linux/kernel/git/chenhuacai/linux-loongson.git/commit/?h=loongarch-next

Huacai

Quoted 81 lines

Lukas

Quoted 78 lines · Lukas Bulwahn
Quoted 77 lines

Clean up config files by:
- removing configs that were deleted in the past
- removing configs not in tree and without recently pending patches
- adding new configs that are replacements for old configs in the file

For some detailed information, see Link.

---
 arch/loongarch/configs/loongson3_defconfig | 7 -------
 1 file changed, 7 deletions(-)
arch/loongarch/configs/loongson3_defconfig +0 -8
index 3712552e18d3..2b4220778b66 100644
@@ -108,14 +108,12 @@ CONFIG_NETFILTER=y
 CONFIG_BRIDGE_NETFILTER=m
 CONFIG_NETFILTER_NETLINK_LOG=m
 CONFIG_NF_CONNTRACK=m
-CONFIG_NF_LOG_NETDEV=m
 CONFIG_NF_CONNTRACK_AMANDA=m
 CONFIG_NF_CONNTRACK_FTP=m
 CONFIG_NF_CONNTRACK_NETBIOS_NS=m
 CONFIG_NF_CONNTRACK_TFTP=m
 CONFIG_NF_CT_NETLINK=m
 CONFIG_NF_TABLES=m
-CONFIG_NFT_COUNTER=m
 CONFIG_NFT_CONNLIMIT=m
 CONFIG_NFT_LOG=m
 CONFIG_NFT_LIMIT=m
@@ -329,7 +327,6 @@ CONFIG_PARPORT_PC_FIFO=y
 CONFIG_ZRAM=m
 CONFIG_ZRAM_DEF_COMP_ZSTD=y
 CONFIG_BLK_DEV_LOOP=y
-CONFIG_BLK_DEV_CRYPTOLOOP=y
 CONFIG_BLK_DEV_NBD=m
 CONFIG_BLK_DEV_RAM=y
 CONFIG_BLK_DEV_RAM_SIZE=8192
@@ -505,7 +502,6 @@ CONFIG_ATH9K_HTC=m
 CONFIG_IWLWIFI=m
 CONFIG_IWLDVM=m
 CONFIG_IWLMVM=m
-CONFIG_IWLWIFI_BCAST_FILTERING=y
 CONFIG_HOSTAP=m
 CONFIG_MT7601U=m
 CONFIG_RT2X00=m
@@ -688,7 +684,6 @@ CONFIG_COMEDI_NI_PCIDIO=m
 CONFIG_COMEDI_NI_PCIMIO=m
 CONFIG_STAGING=y
 CONFIG_R8188EU=m
-# CONFIG_88EU_AP_MODE is not set
 CONFIG_PM_DEVFREQ=y
 CONFIG_DEVFREQ_GOV_SIMPLE_ONDEMAND=y
 CONFIG_DEVFREQ_GOV_PERFORMANCE=y
@@ -772,14 +767,12 @@ CONFIG_CRYPTO_CRYPTD=m
 CONFIG_CRYPTO_CHACHA20POLY1305=m
 CONFIG_CRYPTO_HMAC=y
 CONFIG_CRYPTO_VMAC=m
-CONFIG_CRYPTO_TGR192=m
 CONFIG_CRYPTO_WP512=m
 CONFIG_CRYPTO_ANUBIS=m
 CONFIG_CRYPTO_BLOWFISH=m
 CONFIG_CRYPTO_CAST5=m
 CONFIG_CRYPTO_CAST6=m
 CONFIG_CRYPTO_KHAZAD=m
-CONFIG_CRYPTO_SALSA20=m
 CONFIG_CRYPTO_SEED=m
 CONFIG_CRYPTO_SERPENT=m
 CONFIG_CRYPTO_TEA=m
--

2.17.1

#4 lore raw
Quoted 13 lines · Huacai Chen
Quoted 11 lines · Lukas Bulwahn
Quoted 8 lines · Huacai Chen

Hi, Lukas,

Thank you for your patch, it is queued for loongarch-next, and may be squashed to another patch with your S-o-B if you have no objections.

Huacai

Quoted 7 lines
Quoted 2 lines

Feel free to squash as you see fit. I cannot recall sending something specific for loongarch-next, though.

Emmm, my meaning is squash your patch to mine and keep a S-o-B in that patch [1]. :)

[1] https://git.kernel.org/pub/scm/linux/kernel/git/chenhuacai/linux-loongson.git/commit/?h=loongarch-next

Process-wise that seems a bit strange (i.e., just mixing S-o-B by multiple people, how do you bisect which individual change broke something [you would need a second manual step of investigation], etc.), but sure go ahead.

No objections.

Lukas

#5 lore raw
Quoted 21 lines · Lukas Bulwahn

EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe

Quoted 18 lines · Huacai Chen
Quoted 5 lines · Lukas Bulwahn
Quoted 3 lines · Huacai Chen

Hi, Lukas,

Quoted 8 lines
Quoted 5 lines

Thank you for your patch, it is queued for loongarch-next, and may be squashed to another patch with your S-o-B if you have no objections.

Huacai

Feel free to squash as you see fit. I cannot recall sending something specific for loongarch-next, though.

Emmm, my meaning is squash your patch to mine and keep a S-o-B in that patch [1]. :)

Quoted 7 lines
Quoted 2 lines

[1] https://git.kernel.org/pub/scm/linux/kernel/git/chenhuacai/linux-loongson.git/commit/?h=loongarch-next

Process-wise that seems a bit strange (i.e., just mixing S-o-B by multiple people, how do you bisect which individual change broke something [you would need a second manual step of investigation], etc.), but sure go ahead.

Looks like each of yourself, Youling and Tiezhu should also have Co-developed-by tags, no?

maintainer
#6 lore raw
Quoted 26 lines · On Fri, Sep 30, 2022 at 3:39 PM <[email protected]> wrote:
Quoted 24 lines · Lukas Bulwahn

EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe

Quoted 20 lines · Huacai Chen
Quoted 5 lines · Lukas Bulwahn
Quoted 3 lines · Huacai Chen

Hi, Lukas,

Quoted 8 lines
Quoted 5 lines

Thank you for your patch, it is queued for loongarch-next, and may be squashed to another patch with your S-o-B if you have no objections.

Huacai

Feel free to squash as you see fit. I cannot recall sending something specific for loongarch-next, though.

Emmm, my meaning is squash your patch to mine and keep a S-o-B in that patch [1]. :)

[1] https://git.kernel.org/pub/scm/linux/kernel/git/chenhuacai/linux-loongson.git/commit/?h=loongarch-next

Quoted 7 lines
Quoted 4 lines

Process-wise that seems a bit strange (i.e., just mixing S-o-B by multiple people, how do you bisect which individual change broke something [you would need a second manual step of investigation], etc.), but sure go ahead.

Looks like each of yourself, Youling and Tiezhu should also have Co-developed-by tags, no?

Yes, that is needed.

Huacai

Quoted 1 line
reviewer
#7 lore raw
In reply to Huacai Chen
Quoted 7 lines · Huacai Chen
Quoted 6 lines · Lukas Bulwahn
Quoted 5 lines · Huacai Chen

Hi, Lukas,

Thank you for your patch, it is queued for loongarch-next, and may be squashed to another patch with your S-o-B if you have no objections.

Quoted 9 lines
Quoted 4 lines
Quoted 2 lines

Huacai

Feel free to squash as you see fit. I cannot recall sending something specific for loongarch-next, though.

Emmm, my meaning is squash your patch to mine and keep a S-o-B in that patch [1]. :)

[1] https://git.kernel.org/pub/scm/linux/kernel/git/chenhuacai/linux-loongson.git/commit/?h=loongarch-next

Hi, I have to disagree with you in this case, you are mixing multiple logical changes into one commit. Although all the commits are touching the same Kconfig defaults file it doesn't mean they can be unconditionally squashed. Especially when you have apparently dropped Lukas' detailed explanation regarding the cleanups with one single "Remove obsolete config options" sentence...

As you haven't created the tag and PR'd yet, I'd suggest you fix the branch and just make the commits separate. At the very least please don't delete Lukas' link reference regarding this round of overall Kconfig cleanup effort.

Signature · 3 lines
WANG "xen0n" Xuerui

Linux/LoongArch mailing list: https://lore.kernel.org/loongarch/