openrisc: update config files
Subsystems (2)
PATCH 1/1 openrisc: update config files
Clean up config files by:
- removing configs that were deleted in the past
- removing configs not in tree and without recently pending patches
- adding new configs that are replacements for old configs in the file
For some detailed information, see Link.
--- arch/openrisc/configs/or1ksim_defconfig | 5 ----- arch/openrisc/configs/simple_smp_defconfig | 4 ---- 2 files changed, 9 deletions(-)
arch/openrisc/configs/or1ksim_defconfig +0 -5
@@ -19,9 +19,6 @@ CONFIG_NET=y CONFIG_PACKET=y CONFIG_UNIX=y CONFIG_INET=y -# CONFIG_INET_XFRM_MODE_TRANSPORT is not set -# CONFIG_INET_XFRM_MODE_TUNNEL is not set -# CONFIG_INET_XFRM_MODE_BEET is not set # CONFIG_INET_DIAG is not set CONFIG_TCP_CONG_ADVANCED=y # CONFIG_TCP_CONG_BIC is not set
@@ -34,7 +31,6 @@ CONFIG_DEVTMPFS=y CONFIG_DEVTMPFS_MOUNT=y # CONFIG_PREVENT_FIRMWARE_BUILD is not set # CONFIG_FW_LOADER is not set -CONFIG_PROC_DEVICETREE=y CONFIG_NETDEVICES=y CONFIG_ETHOC=y CONFIG_MICREL_PHY=y
@@ -52,4 +48,3 @@ CONFIG_SERIAL_OF_PLATFORM=y # CONFIG_DNOTIFY is not set CONFIG_TMPFS=y CONFIG_NFS_FS=y -# CONFIG_ENABLE_MUST_CHECK is not set
arch/openrisc/configs/simple_smp_defconfig +0 -4
@@ -27,9 +27,6 @@ CONFIG_NET=y CONFIG_PACKET=y CONFIG_UNIX=y CONFIG_INET=y -# CONFIG_INET_XFRM_MODE_TRANSPORT is not set -# CONFIG_INET_XFRM_MODE_TUNNEL is not set -# CONFIG_INET_XFRM_MODE_BEET is not set # CONFIG_INET_DIAG is not set CONFIG_TCP_CONG_ADVANCED=y # CONFIG_TCP_CONG_BIC is not set
@@ -60,5 +57,4 @@ CONFIG_SERIAL_OF_PLATFORM=y CONFIG_TMPFS=y CONFIG_NFS_FS=y CONFIG_XZ_DEC=y -# CONFIG_ENABLE_MUST_CHECK is not set # CONFIG_RCU_TRACE is not set
Signature · 1 line
2.17.1
Stafford Horne
maintainerQuoted 10 lines · Lukas Bulwahn
Clean up config files by:
- removing configs that were deleted in the past
- removing configs not in tree and without recently pending patches
- adding new configs that are replacements for old configs in the fileFor some detailed information, see Link.
Signed-off-by Lukas Bulwahn <[email protected]>
Hello,
Thanks for the patch this looks fine to me. Usually I just generate this defcnfigs using make savedefconfig. If there is some better way which doesn't generate the file with the # comment's I haven't found it.
I will queue this.
-Stafford
Quoted 55 lines
--- arch/openrisc/configs/or1ksim_defconfig | 5 ----- arch/openrisc/configs/simple_smp_defconfig | 4 ---- 2 files changed, 9 deletions(-)arch/openrisc/configs/or1ksim_defconfig +0
-5@@ -19,9 +19,6 @@ CONFIG_NET=y CONFIG_PACKET=y CONFIG_UNIX=y CONFIG_INET=y -# CONFIG_INET_XFRM_MODE_TRANSPORT is not set -# CONFIG_INET_XFRM_MODE_TUNNEL is not set -# CONFIG_INET_XFRM_MODE_BEET is not set # CONFIG_INET_DIAG is not set CONFIG_TCP_CONG_ADVANCED=y # CONFIG_TCP_CONG_BIC is not set@@ -34,7 +31,6 @@ CONFIG_DEVTMPFS=y CONFIG_DEVTMPFS_MOUNT=y # CONFIG_PREVENT_FIRMWARE_BUILD is not set # CONFIG_FW_LOADER is not set -CONFIG_PROC_DEVICETREE=y CONFIG_NETDEVICES=y CONFIG_ETHOC=y CONFIG_MICREL_PHY=y@@ -52,4 +48,3 @@ CONFIG_SERIAL_OF_PLATFORM=y # CONFIG_DNOTIFY is not set CONFIG_TMPFS=y CONFIG_NFS_FS=y -# CONFIG_ENABLE_MUST_CHECK is not setarch/openrisc/configs/simple_smp_defconfig +0
-4@@ -27,9 +27,6 @@ CONFIG_NET=y CONFIG_PACKET=y CONFIG_UNIX=y CONFIG_INET=y -# CONFIG_INET_XFRM_MODE_TRANSPORT is not set -# CONFIG_INET_XFRM_MODE_TUNNEL is not set -# CONFIG_INET_XFRM_MODE_BEET is not set # CONFIG_INET_DIAG is not set CONFIG_TCP_CONG_ADVANCED=y # CONFIG_TCP_CONG_BIC is not set@@ -60,5 +57,4 @@ CONFIG_SERIAL_OF_PLATFORM=y CONFIG_TMPFS=y CONFIG_NFS_FS=y CONFIG_XZ_DEC=y -# CONFIG_ENABLE_MUST_CHECK is not set # CONFIG_RCU_TRACE is not setSignature · 1 line
2.17.1
Stafford Horne
maintainerHello,
Quoted 5 lines · Stafford Horne
Quoted 4 lines · Lukas Bulwahn
Clean up config files by:
- removing configs that were deleted in the past
- removing configs not in tree and without recently pending patches
- adding new configs that are replacements for old configs in the file
Not all of these apply to this patch. Can you on mention what you changes you are doing here?
Quoted 4 lines
Quoted 4 lines
For some detailed information, see Link.
This extra newline is not need.
Quoted 9 lines
Quoted 1 line
Signed-off-by Lukas Bulwahn <[email protected]>Hello,
Thanks for the patch this looks fine to me. Usually I just generate this defcnfigs using make savedefconfig. If there is some better way which doesn't generate the file with the # comment's I haven't found it.
I will queue this.
Actually..
About the subject 'openrisc: update config files' and description. Can you be more specific about what updates you are making for this patch?
For example: remove comments from config files.
-Stafford
Quoted 55 lines
Quoted 55 lines
--- arch/openrisc/configs/or1ksim_defconfig | 5 ----- arch/openrisc/configs/simple_smp_defconfig | 4 ---- 2 files changed, 9 deletions(-)arch/openrisc/configs/or1ksim_defconfig +0
-5@@ -19,9 +19,6 @@ CONFIG_NET=y CONFIG_PACKET=y CONFIG_UNIX=y CONFIG_INET=y -# CONFIG_INET_XFRM_MODE_TRANSPORT is not set -# CONFIG_INET_XFRM_MODE_TUNNEL is not set -# CONFIG_INET_XFRM_MODE_BEET is not set # CONFIG_INET_DIAG is not set CONFIG_TCP_CONG_ADVANCED=y # CONFIG_TCP_CONG_BIC is not set@@ -34,7 +31,6 @@ CONFIG_DEVTMPFS=y CONFIG_DEVTMPFS_MOUNT=y # CONFIG_PREVENT_FIRMWARE_BUILD is not set # CONFIG_FW_LOADER is not set -CONFIG_PROC_DEVICETREE=y CONFIG_NETDEVICES=y CONFIG_ETHOC=y CONFIG_MICREL_PHY=y@@ -52,4 +48,3 @@ CONFIG_SERIAL_OF_PLATFORM=y # CONFIG_DNOTIFY is not set CONFIG_TMPFS=y CONFIG_NFS_FS=y -# CONFIG_ENABLE_MUST_CHECK is not setarch/openrisc/configs/simple_smp_defconfig +0
-4@@ -27,9 +27,6 @@ CONFIG_NET=y CONFIG_PACKET=y CONFIG_UNIX=y CONFIG_INET=y -# CONFIG_INET_XFRM_MODE_TRANSPORT is not set -# CONFIG_INET_XFRM_MODE_TUNNEL is not set -# CONFIG_INET_XFRM_MODE_BEET is not set # CONFIG_INET_DIAG is not set CONFIG_TCP_CONG_ADVANCED=y # CONFIG_TCP_CONG_BIC is not set@@ -60,5 +57,4 @@ CONFIG_SERIAL_OF_PLATFORM=y CONFIG_TMPFS=y CONFIG_NFS_FS=y CONFIG_XZ_DEC=y -# CONFIG_ENABLE_MUST_CHECK is not set # CONFIG_RCU_TRACE is not setSignature · 1 line
2.17.1
Hi Stafford,
Quoted 13 lines · Stafford Horne
Quoted 12 lines · Stafford Horne
Quoted 6 lines · Lukas Bulwahn
Clean up config files by:
- removing configs that were deleted in the past
- removing configs not in tree and without recently pending patches
- adding new configs that are replacements for old configs in the fileSigned-off-by Lukas Bulwahn <[email protected]>Thanks for the patch this looks fine to me. Usually I just generate this defcnfigs using make savedefconfig. If there is some better way which doesn't generate the file with the # comment's I haven't found it.
Quoted 8 lines
Quoted 1 line
I will queue this.
Actually..
About the subject 'openrisc: update config files' and description. Can you be more specific about what updates you are making for this patch?
For example: remove comments from config files.
These are not comments, but options that default to y or m, and are overriden to n by "commenting them out".
This syntax dates back to the days Kconfig was a collection of shell scripts. Nowadays, switching to "CONFIG_<FOO>=n" would perhaps make sense, as Kconfig already recognizes that syntax.
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
arch/openrisc/configs/or1ksim_defconfig +0
-0@@ -19,9 +19,6 @@ CONFIG_NET=y CONFIG_PACKET=y
Quoted 8 lines
Quoted 8 lines
arch/openrisc/configs/or1ksim_defconfig CONFIG_NET=y · line 24
Quoted 8 lines
arch/openrisc/configs/or1ksim_defconfig +0
-3CONFIG_UNIX=y CONFIG_INET=y -# CONFIG_INET_XFRM_MODE_TRANSPORT is not set -# CONFIG_INET_XFRM_MODE_TUNNEL is not set -# CONFIG_INET_XFRM_MODE_BEET is not set # CONFIG_INET_DIAG is not set CONFIG_TCP_CONG_ADVANCED=y # CONFIG_TCP_CONG_BIC is not set
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]
In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
Stafford Horne
maintainerHi Geert,
Quoted 23 lines · Geert Uytterhoeven
Hi Stafford,
Quoted 20 lines · Stafford Horne
Quoted 6 lines · Stafford Horne
Quoted 4 lines · Lukas Bulwahn
Clean up config files by:
- removing configs that were deleted in the past
- removing configs not in tree and without recently pending patches
- adding new configs that are replacements for old configs in the fileQuoted 7 lines
Quoted 1 line
Signed-off-by Lukas Bulwahn <[email protected]>Thanks for the patch this looks fine to me. Usually I just generate this defcnfigs using make savedefconfig. If there is some better way which doesn't generate the file with the # comment's I haven't found it.
I will queue this.
Actually..
About the subject 'openrisc: update config files' and description. Can you be more specific about what updates you are making for this patch?
Quoted 8 lines
Quoted 1 line
For example: remove comments from config files.
These are not comments, but options that default to y or m, and are overriden to n by "commenting them out".
This syntax dates back to the days
Kconfigwas a collection of shell scripts. Nowadays, switching to "CONFIG_<FOO>=n" would perhaps make sense, asKconfigalready recognizes that syntax.
Right, I remember the *comment's* do actually are material to the config files. In this patch not everything is removed, just old non-existent configs.
I sill prefer having a more descriptive subject.
-Stafford
Quoted 23 lines
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
arch/openrisc/configs/or1ksim_defconfig +0
-0@@ -19,9 +19,6 @@ CONFIG_NET=y CONFIG_PACKET=yQuoted 8 lines
Quoted 8 lines
arch/openrisc/configs/or1ksim_defconfig CONFIG_NET=y · line 24
Quoted 8 lines
arch/openrisc/configs/or1ksim_defconfig +0
-3CONFIG_UNIX=y CONFIG_INET=y -# CONFIG_INET_XFRM_MODE_TRANSPORT is not set -# CONFIG_INET_XFRM_MODE_TUNNEL is not set -# CONFIG_INET_XFRM_MODE_BEET is not set # CONFIG_INET_DIAG is not set CONFIG_TCP_CONG_ADVANCED=y # CONFIG_TCP_CONG_BIC is not setGr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds