fix possible memleak on damon_sysfs_add_target
Subsystems (3)
PATCH 1/1 fix possible memleak on damon_sysfs_add_target
commit 1c8e2349f2d0 ("damon/sysfs: fix possible memleak on damon_sysfs_add_target") upstream.
When damon_sysfs_add_target couldn't find proper task,
New allocated damon_target structure isn't registered yet,
So, it's impossible to free new allocated one by damon_sysfs_destroy_targets.
By calling damon_add_target as soon as allocating new target, Fix this possible memory leak.
Fixes a61ea561c871 ("mm/damon/sysfs: link DAMON for virtual address spaces monitoring")
Signed-off-by Levi Yun <[email protected]>
Signed-off-by SeongJae Park <[email protected]>
Reviewed-by SeongJae Park <[email protected]>
Cc <[email protected]> # 5.19.x
Signed-off-by Andrew Morton <[email protected]>
--- mm/damon/sysfs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
mm/damon/sysfs.c +1 -1
@@ -2181,13 +2181,13 @@ static int damon_sysfs_add_target(struct damon_sysfs_target *sys_target,if (!t)return -ENOMEM ; +damon_add_target (ctx, t);if (ctx->ops.id ==DAMON_OPS_VADDR || ctx->ops.id ==DAMON_OPS_FVADDR ) { t->pid =find_get_pid (sys_target->pid);if (!t->pid) goto destroy_targets_out; } -damon_add_target (ctx, t); err =damon_sysfs_set_regions (t, sys_target->regions);if (err) goto destroy_targets_out;
--
2.35.1
Greg KH
maintainerQuoted 1 line · Levi Yun
commit
1c8e2349f2d0("damon/sysfs: fix possible memleak ondamon_sysfs_add_target") upstream.
Now queued up, thanks,
greg k-h