mm-damon-core-copy-struct-to-struct-instead-of-field-to-field-in-damon_new_scheme.patch removed from -mm tree
The quilt patch titled
Subject: mm/damon/core: copy struct-to-struct instead of field-to-field in damon_new_scheme()
has been removed from the -mm tree. Its filename was
mm-damon-core-copy-struct-to-struct-instead-of-field-to-field-in-damon_new_scheme.patch
This patch was dropped because it was merged into the mm-stable branch of git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm
------------------------------------------------------
From: SeongJae Park <[email protected]>
Subject: mm/damon/core: copy struct-to-struct instead of field-to-field in damon_new_scheme()
Date: Tue, 13 Sep 2022 17:44:30 +0000
The function for new 'struct damos' creation, 'damon_new_scheme()', copies each field of the struct one by one, though it could simply copied via struct to struct. This commit replaces the unnecessarily verbose field-to-field copies with struct-to-struct copies to make code simple and short.
---
mm/damon/core.c | 21 ++++----------------- 1 file changed, 4 insertions(+), 17 deletions(-)
mm/damon/core.c renamed from mm/damon/core.c~mm-damon-core-copy-struct-to-struct-instead-of-field-to-field-in-damon_new_scheme +4 -17
@@ -272,22 +272,13 @@ struct damos *damon_new_scheme(struct da scheme =kmalloc (sizeof (*scheme),GFP_KERNEL );if (!scheme)return NULL ; - scheme->pattern.min_sz_region = pattern->min_sz_region; - scheme->pattern.max_sz_region = pattern->max_sz_region; - scheme->pattern.min_nr_accesses = pattern->min_nr_accesses; - scheme->pattern.max_nr_accesses = pattern->max_nr_accesses; - scheme->pattern.min_age_region = pattern->min_age_region; - scheme->pattern.max_age_region = pattern->max_age_region; + scheme->pattern = *pattern; scheme->action = action; scheme->stat = (struct damos_stat ){};INIT_LIST_HEAD (&scheme->list); - scheme->quota.ms = quota->ms; - scheme->quota.sz = quota->sz; - scheme->quota.reset_interval = quota->reset_interval; - scheme->quota.weight_sz = quota->weight_sz; - scheme->quota.weight_nr_accesses = quota->weight_nr_accesses; - scheme->quota.weight_age = quota->weight_age; + scheme->quota = *quota; +/* caller might not zero-initialized the private fileds */ scheme->quota.total_charged_sz =0 ; scheme->quota.total_charged_ns =0 ; scheme->quota.esz =0 ;
@@ -296,11 +287,7 @@ struct damos *damon_new_scheme(struct da scheme->quota.charge_target_from =NULL ; scheme->quota.charge_addr_from =0 ; - scheme->wmarks.metric = wmarks->metric; - scheme->wmarks.interval = wmarks->interval; - scheme->wmarks.high = wmarks->high; - scheme->wmarks.mid = wmarks->mid; - scheme->wmarks.low = wmarks->low; + scheme->wmarks = *wmarks; scheme->wmarks.activated = true;return scheme;
_
Patches currently in -mm which might be from [email protected] are
mm-damon-core-initialize-damon_target-list-in-damon_new_target.patch